Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix (and suppress) some static code analysis warnings in blueprint
[controller.git]
/
opendaylight
/
blueprint
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
blueprint
/
ext
/
SpecificReferenceListMetadata.java
diff --git
a/opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/SpecificReferenceListMetadata.java
b/opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/SpecificReferenceListMetadata.java
index c9aab3ba9847b87b72551fbb425f70e6b9d38c22..9a0bd29a09d6ba552e0778a82381a72cbbfcd46b 100644
(file)
--- a/
opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/SpecificReferenceListMetadata.java
+++ b/
opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/SpecificReferenceListMetadata.java
@@
-141,7
+141,7
@@
class SpecificReferenceListMetadata extends AbstractDependentComponentFactoryMet
private Object serviceAdded(ServiceReference<Object> reference) {
Object service = container().getBundleContext().getService(reference);
private Object serviceAdded(ServiceReference<Object> reference) {
Object service = container().getBundleContext().getService(reference);
-
Object serviceType =
reference.getProperty(OpendaylightNamespaceHandler.TYPE_ATTR);
+
String serviceType = (String)
reference.getProperty(OpendaylightNamespaceHandler.TYPE_ATTR);
LOG.debug("{}: Service type {} added from bundle {}", logName(), serviceType,
reference.getBundle().getSymbolicName());
LOG.debug("{}: Service type {} added from bundle {}", logName(), serviceType,
reference.getBundle().getSymbolicName());
@@
-166,7
+166,7
@@
class SpecificReferenceListMetadata extends AbstractDependentComponentFactoryMet
if (isSatisfied()) {
restartContainer();
} else {
if (isSatisfied()) {
restartContainer();
} else {
- retrievedServiceTypes.add(serviceType
.toString()
);
+ retrievedServiceTypes.add(serviceType);
retrievedServices.add(service);
if (retrievedServiceTypes.equals(expectedServiceTypes)) {
retrievedServices.add(service);
if (retrievedServiceTypes.equals(expectedServiceTypes)) {