Fixed few sonar warnings.

[controller.git] / opendaylight / config / config-manager / src / main / java / org / opendaylight / controller / config / manager / impl / jmx / ServiceReferenceRegistrator.java

diff --git a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ServiceReferenceRegistrator.java b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ServiceReferenceRegistrator.java
index eafe760ddc1f029d3e9ea471282efd0693a62225..fa0c52699a7b1242a13caec363c43af2483c34d7 100644 (file)
--- a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ServiceReferenceRegistrator.java
+++ b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ServiceReferenceRegistrator.java
@@ -47,22 +47,24 @@ public interface ServiceReferenceRegistrator extends AutoCloseable {
             this.nullableTransactionName = nullableTransactionName;
         }
 
+        @Override
         public String getNullableTransactionName() {
             return nullableTransactionName;
         }
 
 
+        @Override
         public ServiceReferenceJMXRegistration registerMBean(ServiceReferenceMXBeanImpl object,
                                                              ObjectName on) throws InstanceAlreadyExistsException {
             String actualTransactionName = ObjectNameUtil.getTransactionName(on);
             boolean broken = false;
             broken |= (nullableTransactionName == null) != (actualTransactionName == null);
-            broken |= (nullableTransactionName != null) && nullableTransactionName.equals(actualTransactionName) == false;
+            broken |= (nullableTransactionName != null) && !nullableTransactionName.equals(actualTransactionName);
             if (broken) {
                 throw new IllegalArgumentException("Transaction name mismatch between expected "
                         + nullableTransactionName + ", got " + actualTransactionName + " in " + on);
             }
-            if (ObjectNameUtil.isServiceReference(on) == false) {
+            if (!ObjectNameUtil.isServiceReference(on)) {
                 throw new IllegalArgumentException("Invalid type of " + on);
             }
             return new ServiceReferenceJMXRegistration(currentJMXRegistrator.registerMBean(object, on));
@@ -94,6 +96,7 @@ public interface ServiceReferenceRegistrator extends AutoCloseable {
             this.nullableTransactionName = null;
         }
 
+        @Override
         public ServiceReferenceRegistrator create() {
             return new ServiceReferenceRegistratorImpl(parentRegistrator, nullableTransactionName);
         }