Fix Eclipse warnings in config-manager

[controller.git] / opendaylight / config / config-manager / src / test / java / org / opendaylight / controller / config / manager / testingservices / scheduledthreadpool / test / RuntimeBeanTest.java

diff --git a/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/testingservices/scheduledthreadpool/test/RuntimeBeanTest.java b/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/testingservices/scheduledthreadpool/test/RuntimeBeanTest.java
index 19e6ef3b78baed4f3a55af2ad1ba650d96053337..451980c3ef9bafdd6c57e51dc2100f6b0a7c0b45 100644 (file)
--- a/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/testingservices/scheduledthreadpool/test/RuntimeBeanTest.java
+++ b/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/testingservices/scheduledthreadpool/test/RuntimeBeanTest.java
@@ -72,21 +72,21 @@ public class RuntimeBeanTest extends AbstractScheduledTest {
 
     private void checkRuntimeBeans() throws Exception {
         // check runtime bean - on 2 places
-        for (ObjectName on : allObjectNames)
+        for (ObjectName on : allObjectNames) {
             checkRuntimeBean(on);
+        }
     }
 
-    private void checkRuntimeBean(ObjectName on) throws Exception {
-        assertEquals(0,
-                platformMBeanServer.getAttribute(on, "ActualNumberOfThreads"));
+    private static void checkRuntimeBean(final ObjectName on) throws Exception {
+        assertEquals(0, platformMBeanServer.getAttribute(on, "ActualNumberOfThreads"));
     }
 
-    private void checkRuntimeBeanDoesNotExist(ObjectName on) throws Exception {
+    private static void checkRuntimeBeanDoesNotExist(final ObjectName on) throws Exception {
         try {
             checkRuntimeBean(on);
             fail();
         } catch (InstanceNotFoundException e) {
-
+            // No-op
         }
     }
 
@@ -149,8 +149,9 @@ public class RuntimeBeanTest extends AbstractScheduledTest {
         configTransaction.destroyModule(ObjectNameUtil
                 .createTransactionModuleON(configTransaction.getTransactionName(), createdConfigBean));
         configTransaction.commit();
-        for (ObjectName on : allObjectNames)
+        for (ObjectName on : allObjectNames) {
             checkRuntimeBeanDoesNotExist(on);
+        }
     }
 
 }