* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
-
package org.opendaylight.controller.cluster.datastore.modification;
-import com.google.common.base.Preconditions;
+import static com.google.common.base.Preconditions.checkArgument;
+import static java.util.Objects.requireNonNull;
+
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
import org.opendaylight.controller.cluster.datastore.DataStoreVersions;
import org.opendaylight.controller.cluster.datastore.messages.VersionedExternalizableMessage;
+import org.opendaylight.controller.cluster.datastore.node.utils.stream.NormalizedNodeDataInput;
+import org.opendaylight.controller.cluster.datastore.node.utils.stream.NormalizedNodeDataOutput;
import org.opendaylight.controller.cluster.datastore.node.utils.stream.NormalizedNodeInputOutput;
-import org.opendaylight.controller.cluster.datastore.node.utils.stream.NormalizedNodeInputStreamReader;
-import org.opendaylight.controller.cluster.datastore.utils.SerializationUtils;
-import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction;
+import org.opendaylight.mdsal.dom.spi.store.DOMStoreWriteTransaction;
import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeModification;
+import org.opendaylight.yangtools.yang.data.impl.schema.ReusableImmutableNormalizedNodeStreamWriter;
/**
- * MutableCompositeModification is just a mutable version of a
- * CompositeModification {@link org.opendaylight.controller.cluster.datastore.modification.MutableCompositeModification#addModification(Modification)}
+ * MutableCompositeModification is just a mutable version of a CompositeModification.
*/
public class MutableCompositeModification extends VersionedExternalizableMessage implements CompositeModification {
private static final long serialVersionUID = 1L;
private final List<Modification> modifications = new ArrayList<>();
+ private List<Modification> immutableModifications = null;
public MutableCompositeModification() {
this(DataStoreVersions.CURRENT_VERSION);
}
- public MutableCompositeModification(short version) {
+ public MutableCompositeModification(final short version) {
super(version);
}
@Override
- public void apply(DOMStoreWriteTransaction transaction) {
+ public void apply(final DOMStoreWriteTransaction transaction) {
for (Modification modification : modifications) {
modification.apply(transaction);
}
}
@Override
- public void apply(DataTreeModification transaction) {
+ public void apply(final DataTreeModification transaction) {
for (Modification modification : modifications) {
modification.apply(transaction);
}
}
/**
- * Add a new Modification to the list of Modifications represented by this
- * composite
+ * Add a new Modification to the list of Modifications represented by this composite.
*
- * @param modification
+ * @param modification the modification to add.
*/
- public void addModification(Modification modification) {
- modifications.add(modification);
+ public void addModification(final Modification modification) {
+ modifications.add(requireNonNull(modification));
+ }
+
+ public void addModifications(final Iterable<Modification> newMods) {
+ for (Modification mod : newMods) {
+ addModification(mod);
+ }
}
@Override
public List<Modification> getModifications() {
- return modifications;
+ if (immutableModifications == null) {
+ immutableModifications = Collections.unmodifiableList(modifications);
+ }
+
+ return immutableModifications;
}
@Override
- public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
+ public void readExternal(final ObjectInput in) throws IOException, ClassNotFoundException {
super.readExternal(in);
int size = in.readInt();
+ if (size > 0) {
+ final NormalizedNodeDataInput input = NormalizedNodeInputOutput.newDataInputWithoutValidation(in);
+ final ReusableImmutableNormalizedNodeStreamWriter writer =
+ ReusableImmutableNormalizedNodeStreamWriter.create();
- if(size > 1) {
- SerializationUtils.REUSABLE_READER_TL.set(new NormalizedNodeInputStreamReader(in));
- }
-
- try {
- for(int i = 0; i < size; i++) {
+ for (int i = 0; i < size; i++) {
byte type = in.readByte();
- switch(type) {
- case Modification.WRITE:
- modifications.add(WriteModification.fromStream(in, getVersion()));
- break;
-
- case Modification.MERGE:
- modifications.add(MergeModification.fromStream(in, getVersion()));
- break;
-
- case Modification.DELETE:
- modifications.add(DeleteModification.fromStream(in, getVersion()));
- break;
+ switch (type) {
+ case Modification.WRITE:
+ modifications.add(WriteModification.fromStream(input, getVersion(), writer));
+ break;
+
+ case Modification.MERGE:
+ modifications.add(MergeModification.fromStream(input, getVersion(), writer));
+ break;
+
+ case Modification.DELETE:
+ modifications.add(DeleteModification.fromStream(input, getVersion()));
+ break;
+ default:
+ break;
}
}
- } finally {
- SerializationUtils.REUSABLE_READER_TL.remove();
}
}
@Override
- public void writeExternal(ObjectOutput out) throws IOException {
+ public void writeExternal(final ObjectOutput out) throws IOException {
super.writeExternal(out);
- out.writeInt(modifications.size());
-
- if(modifications.size() > 1) {
- SerializationUtils.REUSABLE_WRITER_TL.set(NormalizedNodeInputOutput.newDataOutput(out));
- }
-
- try {
- for(Modification mod: modifications) {
- out.writeByte(mod.getType());
- mod.writeExternal(out);
+ final int size = modifications.size();
+ out.writeInt(size);
+ if (size > 0) {
+ try (NormalizedNodeDataOutput stream = NormalizedNodeInputOutput.newDataOutput(out, getStreamVersion())) {
+ for (Modification mod : modifications) {
+ out.writeByte(mod.getType());
+ mod.writeTo(stream);
+ }
}
- } finally {
- SerializationUtils.REUSABLE_WRITER_TL.remove();
}
}
- public static MutableCompositeModification fromSerializable(Object serializable) {
- Preconditions.checkArgument(serializable instanceof MutableCompositeModification);
+ public static MutableCompositeModification fromSerializable(final Object serializable) {
+ checkArgument(serializable instanceof MutableCompositeModification);
return (MutableCompositeModification)serializable;
}
+
+ @Override
+ public void writeTo(final NormalizedNodeDataOutput out) throws IOException {
+ throw new UnsupportedOperationException();
+ }
}
Code Review / controller.git / blobdiff