BUG-5280: eliminate ShardTransactionIdentifier
[controller.git] / opendaylight / md-sal / sal-distributed-datastore / src / test / java / org / opendaylight / controller / cluster / datastore / ShardTransactionFailureTest.java
index 3700c57d303f8b4ed3c6a88753888a7a58eb08e3..cc15e1a0e2b1e439324b8856b2079da22a69580a 100644 (file)
@@ -10,20 +10,18 @@ package org.opendaylight.controller.cluster.datastore;
 
 import akka.actor.ActorRef;
 import akka.actor.Props;
-import akka.pattern.AskTimeoutException;
 import akka.testkit.TestActorRef;
 import java.util.concurrent.TimeUnit;
 import org.junit.Test;
+import org.opendaylight.controller.cluster.access.concepts.MemberName;
 import org.opendaylight.controller.cluster.datastore.identifiers.ShardIdentifier;
 import org.opendaylight.controller.cluster.datastore.jmx.mbeans.shard.ShardStats;
-import org.opendaylight.controller.cluster.datastore.node.utils.serialization.NormalizedNodeSerializer;
+import org.opendaylight.controller.cluster.datastore.messages.DataExists;
+import org.opendaylight.controller.cluster.datastore.messages.ReadData;
 import org.opendaylight.controller.md.cluster.datastore.model.TestModel;
 import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException;
-import org.opendaylight.controller.protobuff.messages.common.NormalizedNodeMessages;
-import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
 import org.opendaylight.yangtools.yang.data.api.schema.tree.TreeType;
-import org.opendaylight.yangtools.yang.data.impl.schema.Builders;
 import org.opendaylight.yangtools.yang.model.api.SchemaContext;
 import scala.concurrent.Await;
 import scala.concurrent.Future;
@@ -44,8 +42,7 @@ public class ShardTransactionFailureTest extends AbstractActorTest {
     private static final ShardDataTree store = new ShardDataTree(testSchemaContext, TreeType.OPERATIONAL);
 
     private static final ShardIdentifier SHARD_IDENTIFIER =
-        ShardIdentifier.builder().memberName("member-1")
-            .shardName("inventory").type("operational").build();
+        ShardIdentifier.create("inventory", MemberName.forName("member-1"), "operational");
 
     private final DatastoreContext datastoreContext = DatastoreContext.newBuilder().build();
 
@@ -59,219 +56,66 @@ public class ShardTransactionFailureTest extends AbstractActorTest {
     }
 
     @Test(expected = ReadFailedException.class)
-    public void testNegativeReadWithReadOnlyTransactionClosed()
-        throws Throwable {
+    public void testNegativeReadWithReadOnlyTransactionClosed() throws Throwable {
 
         final ActorRef shard = createShard();
         final Props props = ShardTransaction.props(RO, store.newReadOnlyTransaction("test-txn", null), shard,
-                datastoreContext, shardStats, "txn", DataStoreVersions.CURRENT_VERSION);
+                datastoreContext, shardStats);
 
-        final TestActorRef<ShardTransaction> subject = TestActorRef
-            .create(getSystem(), props,
+        final TestActorRef<ShardTransaction> subject = TestActorRef.create(getSystem(), props,
                 "testNegativeReadWithReadOnlyTransactionClosed");
 
-        ShardTransactionMessages.ReadData readData =
-            ShardTransactionMessages.ReadData.newBuilder()
-                .setInstanceIdentifierPathArguments(
-                    NormalizedNodeMessages.InstanceIdentifier.newBuilder()
-                        .build()
-                ).build();
-        Future<Object> future =
-            akka.pattern.Patterns.ask(subject, readData, 3000);
+        Future<Object> future = akka.pattern.Patterns.ask(subject,
+                new ReadData(YangInstanceIdentifier.EMPTY, DataStoreVersions.CURRENT_VERSION), 3000);
         Await.result(future, Duration.create(3, TimeUnit.SECONDS));
 
         subject.underlyingActor().getDOMStoreTransaction().abort();
 
-        future = akka.pattern.Patterns.ask(subject, readData, 3000);
+        future = akka.pattern.Patterns.ask(subject, new ReadData(YangInstanceIdentifier.EMPTY,
+                DataStoreVersions.CURRENT_VERSION), 3000);
         Await.result(future, Duration.create(3, TimeUnit.SECONDS));
     }
 
 
     @Test(expected = ReadFailedException.class)
-    public void testNegativeReadWithReadWriteTransactionClosed()
-        throws Throwable {
+    public void testNegativeReadWithReadWriteTransactionClosed() throws Throwable {
 
         final ActorRef shard = createShard();
         final Props props = ShardTransaction.props(RW, store.newReadWriteTransaction("test-txn", null), shard,
-                datastoreContext, shardStats, "txn", DataStoreVersions.CURRENT_VERSION);
+                datastoreContext, shardStats);
 
-        final TestActorRef<ShardTransaction> subject = TestActorRef
-            .create(getSystem(), props,
+        final TestActorRef<ShardTransaction> subject = TestActorRef.create(getSystem(), props,
                 "testNegativeReadWithReadWriteTransactionClosed");
 
-        ShardTransactionMessages.ReadData readData =
-            ShardTransactionMessages.ReadData.newBuilder()
-                .setInstanceIdentifierPathArguments(
-                    NormalizedNodeMessages.InstanceIdentifier.newBuilder()
-                        .build()
-                ).build();
-
-        Future<Object> future =
-            akka.pattern.Patterns.ask(subject, readData, 3000);
+        Future<Object> future = akka.pattern.Patterns.ask(subject,
+                new ReadData(YangInstanceIdentifier.EMPTY, DataStoreVersions.CURRENT_VERSION), 3000);
         Await.result(future, Duration.create(3, TimeUnit.SECONDS));
 
         subject.underlyingActor().getDOMStoreTransaction().abort();
 
-        future = akka.pattern.Patterns.ask(subject, readData, 3000);
+        future = akka.pattern.Patterns.ask(subject, new ReadData(YangInstanceIdentifier.EMPTY,
+                DataStoreVersions.CURRENT_VERSION), 3000);
         Await.result(future, Duration.create(3, TimeUnit.SECONDS));
     }
 
     @Test(expected = ReadFailedException.class)
-    public void testNegativeExistsWithReadWriteTransactionClosed()
-        throws Throwable {
+    public void testNegativeExistsWithReadWriteTransactionClosed() throws Throwable {
 
         final ActorRef shard = createShard();
         final Props props = ShardTransaction.props(RW, store.newReadWriteTransaction("test-txn", null), shard,
-                datastoreContext, shardStats, "txn", DataStoreVersions.CURRENT_VERSION);
+                datastoreContext, shardStats);
 
-        final TestActorRef<ShardTransaction> subject = TestActorRef
-            .create(getSystem(), props,
+        final TestActorRef<ShardTransaction> subject = TestActorRef.create(getSystem(), props,
                 "testNegativeExistsWithReadWriteTransactionClosed");
 
-        ShardTransactionMessages.DataExists dataExists =
-            ShardTransactionMessages.DataExists.newBuilder()
-                .setInstanceIdentifierPathArguments(
-                    NormalizedNodeMessages.InstanceIdentifier.newBuilder()
-                        .build()
-                ).build();
-
-        Future<Object> future =
-            akka.pattern.Patterns.ask(subject, dataExists, 3000);
+        Future<Object> future = akka.pattern.Patterns.ask(subject,
+                new DataExists(YangInstanceIdentifier.EMPTY, DataStoreVersions.CURRENT_VERSION), 3000);
         Await.result(future, Duration.create(3, TimeUnit.SECONDS));
 
         subject.underlyingActor().getDOMStoreTransaction().abort();
 
-        future = akka.pattern.Patterns.ask(subject, dataExists, 3000);
-        Await.result(future, Duration.create(3, TimeUnit.SECONDS));
-    }
-
-    @Test(expected = AskTimeoutException.class)
-    public void testNegativeWriteWithTransactionReady() throws Exception {
-
-
-        final ActorRef shard = createShard();
-        final Props props = ShardTransaction.props(WO, store.newReadWriteTransaction("test-txn", null), shard,
-                datastoreContext, shardStats, "txn", DataStoreVersions.CURRENT_VERSION);
-
-        final TestActorRef<ShardTransaction> subject = TestActorRef
-            .create(getSystem(), props,
-                "testNegativeWriteWithTransactionReady");
-
-        ShardTransactionMessages.ReadyTransaction readyTransaction =
-            ShardTransactionMessages.ReadyTransaction.newBuilder().build();
-
-        Future<Object> future =
-            akka.pattern.Patterns.ask(subject, readyTransaction, 3000);
-        Await.result(future, Duration.create(3, TimeUnit.SECONDS));
-
-        ShardTransactionMessages.WriteData writeData =
-            ShardTransactionMessages.WriteData.newBuilder()
-                .setInstanceIdentifierPathArguments(
-                    NormalizedNodeMessages.InstanceIdentifier.newBuilder()
-                        .build()).setNormalizedNode(
-                buildNormalizedNode()
-
-            ).build();
-
-        future = akka.pattern.Patterns.ask(subject, writeData, 3000);
-        Await.result(future, Duration.create(3, TimeUnit.SECONDS));
-    }
-
-    @Test(expected = AskTimeoutException.class)
-    public void testNegativeReadWriteWithTransactionReady() throws Exception {
-
-
-        final ActorRef shard = createShard();
-        final Props props = ShardTransaction.props(RW, store.newReadWriteTransaction("test-txn", null), shard,
-                datastoreContext, shardStats, "txn", DataStoreVersions.CURRENT_VERSION);
-
-        final TestActorRef<ShardTransaction> subject = TestActorRef
-            .create(getSystem(), props,
-                "testNegativeReadWriteWithTransactionReady");
-
-        ShardTransactionMessages.ReadyTransaction readyTransaction =
-            ShardTransactionMessages.ReadyTransaction.newBuilder().build();
-
-        Future<Object> future =
-            akka.pattern.Patterns.ask(subject, readyTransaction, 3000);
-        Await.result(future, Duration.create(3, TimeUnit.SECONDS));
-
-        ShardTransactionMessages.WriteData writeData =
-            ShardTransactionMessages.WriteData.newBuilder()
-                .setInstanceIdentifierPathArguments(
-                    NormalizedNodeMessages.InstanceIdentifier.newBuilder()
-                        .build()
-                )
-                .setNormalizedNode(buildNormalizedNode())
-                .build();
-
-        future = akka.pattern.Patterns.ask(subject, writeData, 3000);
-        Await.result(future, Duration.create(3, TimeUnit.SECONDS));
-    }
-
-    private static NormalizedNodeMessages.Node buildNormalizedNode() {
-        return NormalizedNodeSerializer
-            .serialize(Builders.containerBuilder().withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)).build());
-    }
-
-    @Test(expected = AskTimeoutException.class)
-    public void testNegativeMergeTransactionReady() throws Exception {
-
-
-        final ActorRef shard = createShard();
-        final Props props = ShardTransaction.props(RW, store.newReadWriteTransaction("test-txn", null), shard,
-                datastoreContext, shardStats, "txn", DataStoreVersions.CURRENT_VERSION);
-
-        final TestActorRef<ShardTransaction> subject = TestActorRef
-            .create(getSystem(), props, "testNegativeMergeTransactionReady");
-
-        ShardTransactionMessages.ReadyTransaction readyTransaction =
-            ShardTransactionMessages.ReadyTransaction.newBuilder().build();
-
-        Future<Object> future =
-            akka.pattern.Patterns.ask(subject, readyTransaction, 3000);
-        Await.result(future, Duration.create(3, TimeUnit.SECONDS));
-
-        ShardTransactionMessages.MergeData mergeData =
-            ShardTransactionMessages.MergeData.newBuilder()
-                .setInstanceIdentifierPathArguments(
-                    NormalizedNodeMessages.InstanceIdentifier.newBuilder()
-                        .build()).setNormalizedNode(
-                buildNormalizedNode()
-
-            ).build();
-
-        future = akka.pattern.Patterns.ask(subject, mergeData, 3000);
-        Await.result(future, Duration.create(3, TimeUnit.SECONDS));
-    }
-
-
-    @Test(expected = AskTimeoutException.class)
-    public void testNegativeDeleteDataWhenTransactionReady() throws Exception {
-
-
-        final ActorRef shard = createShard();
-        final Props props = ShardTransaction.props(RW, store.newReadWriteTransaction("test-txn", null), shard,
-                datastoreContext, shardStats, "txn", DataStoreVersions.CURRENT_VERSION);
-
-        final TestActorRef<ShardTransaction> subject = TestActorRef
-            .create(getSystem(), props,
-                "testNegativeDeleteDataWhenTransactionReady");
-
-        ShardTransactionMessages.ReadyTransaction readyTransaction =
-            ShardTransactionMessages.ReadyTransaction.newBuilder().build();
-
-        Future<Object> future =
-            akka.pattern.Patterns.ask(subject, readyTransaction, 3000);
-        Await.result(future, Duration.create(3, TimeUnit.SECONDS));
-
-        ShardTransactionMessages.DeleteData deleteData =
-            ShardTransactionMessages.DeleteData.newBuilder()
-                .setInstanceIdentifierPathArguments(
-                    NormalizedNodeMessages.InstanceIdentifier.newBuilder()
-                        .build()).build();
-
-        future = akka.pattern.Patterns.ask(subject, deleteData, 3000);
+        future = akka.pattern.Patterns.ask(subject,
+                new DataExists(YangInstanceIdentifier.EMPTY, DataStoreVersions.CURRENT_VERSION), 3000);
         Await.result(future, Duration.create(3, TimeUnit.SECONDS));
     }
 }