Cleanup TestKit use

[controller.git] / opendaylight / md-sal / sal-distributed-datastore / src / test / java / org / opendaylight / controller / cluster / datastore / actors / DataTreeNotificationListenerRegistrationActorTest.java

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/actors/DataTreeNotificationListenerRegistrationActorTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/actors/DataTreeNotificationListenerRegistrationActorTest.java
index f5d096bff8f56b20d286aa557345e78a96646f5a..397724b79317ac51367dd74016ef52a99f5749ad 100644 (file)
--- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/actors/DataTreeNotificationListenerRegistrationActorTest.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/actors/DataTreeNotificationListenerRegistrationActorTest.java
@@ -7,14 +7,15 @@
  */
 package org.opendaylight.controller.cluster.datastore.actors;
 
+import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.timeout;
+import static org.mockito.Mockito.verify;
 
 import akka.actor.ActorRef;
 import akka.testkit.javadsl.TestKit;
 import org.junit.Before;
 import org.junit.Test;
 import org.mockito.Mock;
-import org.mockito.Mockito;
 import org.mockito.MockitoAnnotations;
 import org.opendaylight.controller.cluster.datastore.AbstractActorTest;
 import org.opendaylight.controller.cluster.datastore.messages.CloseDataTreeNotificationListenerRegistration;
@@ -28,81 +29,72 @@ public class DataTreeNotificationListenerRegistrationActorTest extends AbstractA
     @Mock
     private Runnable mockOnClose;
 
+    private TestKit kit;
+
     @Before
     public void setup() {
         MockitoAnnotations.initMocks(this);
         DataTreeNotificationListenerRegistrationActor.killDelay = 100;
+        kit = new TestKit(getSystem());
     }
 
     @Test
     public void testOnReceiveCloseListenerRegistrationAfterSetRegistration() {
-        new TestKit(getSystem()) {
-            {
-                final ActorRef subject = getSystem().actorOf(DataTreeNotificationListenerRegistrationActor.props(),
-                        "testOnReceiveCloseListenerRegistrationAfterSetRegistration");
-                watch(subject);
+        final ActorRef subject = getSystem().actorOf(DataTreeNotificationListenerRegistrationActor.props(),
+                "testOnReceiveCloseListenerRegistrationAfterSetRegistration");
+        kit.watch(subject);
 
-                subject.tell(new DataTreeNotificationListenerRegistrationActor.SetRegistration(mockListenerReg,
-                        mockOnClose), ActorRef.noSender());
-                subject.tell(CloseDataTreeNotificationListenerRegistration.getInstance(), getRef());
+        subject.tell(new DataTreeNotificationListenerRegistrationActor.SetRegistration(mockListenerReg,
+            mockOnClose), ActorRef.noSender());
+        subject.tell(CloseDataTreeNotificationListenerRegistration.getInstance(), kit.getRef());
 
-                expectMsgClass(duration("5 second"), CloseDataTreeNotificationListenerRegistrationReply.class);
+        kit.expectMsgClass(kit.duration("5 second"), CloseDataTreeNotificationListenerRegistrationReply.class);
 
-                Mockito.verify(mockListenerReg, timeout(5000)).close();
-                Mockito.verify(mockOnClose, timeout(5000)).run();
+        verify(mockListenerReg, timeout(5000)).close();
+        verify(mockOnClose, timeout(5000)).run();
 
-                expectTerminated(duration("5 second"), subject);
-            }
-        };
+        kit.expectTerminated(kit.duration("5 second"), subject);
     }
 
     @Test
     public void testOnReceiveCloseListenerRegistrationBeforeSetRegistration() {
-        new TestKit(getSystem()) {
-            {
-                final ActorRef subject = getSystem().actorOf(DataTreeNotificationListenerRegistrationActor.props(),
-                        "testOnReceiveSetRegistrationAfterPriorClose");
-                watch(subject);
+        final ActorRef subject = getSystem().actorOf(DataTreeNotificationListenerRegistrationActor.props(),
+                "testOnReceiveSetRegistrationAfterPriorClose");
+        kit.watch(subject);
 
-                subject.tell(CloseDataTreeNotificationListenerRegistration.getInstance(), getRef());
-                expectMsgClass(duration("5 second"), CloseDataTreeNotificationListenerRegistrationReply.class);
+        subject.tell(CloseDataTreeNotificationListenerRegistration.getInstance(), kit.getRef());
+        kit.expectMsgClass(kit.duration("5 second"), CloseDataTreeNotificationListenerRegistrationReply.class);
 
-                subject.tell(new DataTreeNotificationListenerRegistrationActor.SetRegistration(mockListenerReg,
-                        mockOnClose), ActorRef.noSender());
+        subject.tell(new DataTreeNotificationListenerRegistrationActor.SetRegistration(mockListenerReg,
+            mockOnClose), ActorRef.noSender());
 
-                Mockito.verify(mockListenerReg, timeout(5000)).close();
-                Mockito.verify(mockOnClose, timeout(5000)).run();
+        verify(mockListenerReg, timeout(5000)).close();
+        verify(mockOnClose, timeout(5000)).run();
 
-                expectTerminated(duration("5 second"), subject);
-            }
-        };
+        kit.expectTerminated(kit.duration("5 second"), subject);
     }
 
     @Test
     public void testOnReceiveSetRegistrationAfterPriorClose() {
-        new TestKit(getSystem()) {
-            {
-                DataTreeNotificationListenerRegistrationActor.killDelay = 1000;
-                final ListenerRegistration<?> mockListenerReg2 = Mockito.mock(ListenerRegistration.class);
-                final Runnable mockOnClose2 = Mockito.mock(Runnable.class);
-
-                final ActorRef subject = getSystem().actorOf(DataTreeNotificationListenerRegistrationActor.props(),
-                        "testOnReceiveSetRegistrationAfterPriorClose");
-                watch(subject);
-
-                subject.tell(new DataTreeNotificationListenerRegistrationActor.SetRegistration(mockListenerReg,
-                        mockOnClose), ActorRef.noSender());
-                subject.tell(CloseDataTreeNotificationListenerRegistration.getInstance(), ActorRef.noSender());
-                subject.tell(new DataTreeNotificationListenerRegistrationActor.SetRegistration(mockListenerReg2,
-                        mockOnClose2), ActorRef.noSender());
-
-                Mockito.verify(mockListenerReg, timeout(5000)).close();
-                Mockito.verify(mockOnClose, timeout(5000)).run();
-                Mockito.verify(mockListenerReg2, timeout(5000)).close();
-                Mockito.verify(mockOnClose2, timeout(5000)).run();
-
-                expectTerminated(duration("5 second"), subject);
-            }
-        };
+        DataTreeNotificationListenerRegistrationActor.killDelay = 1000;
+        final ListenerRegistration<?> mockListenerReg2 = mock(ListenerRegistration.class);
+        final Runnable mockOnClose2 = mock(Runnable.class);
+
+        final ActorRef subject = getSystem().actorOf(DataTreeNotificationListenerRegistrationActor.props(),
+            "testOnReceiveSetRegistrationAfterPriorClose");
+        kit.watch(subject);
+
+        subject.tell(new DataTreeNotificationListenerRegistrationActor.SetRegistration(mockListenerReg,
+            mockOnClose), ActorRef.noSender());
+        subject.tell(CloseDataTreeNotificationListenerRegistration.getInstance(), ActorRef.noSender());
+        subject.tell(new DataTreeNotificationListenerRegistrationActor.SetRegistration(mockListenerReg2,
+            mockOnClose2), ActorRef.noSender());
+
+        verify(mockListenerReg, timeout(5000)).close();
+        verify(mockOnClose, timeout(5000)).run();
+        verify(mockListenerReg2, timeout(5000)).close();
+        verify(mockOnClose2, timeout(5000)).run();
+
+        kit.expectTerminated(kit.duration("5 second"), subject);
     }
 }