Code Review / controller.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | inline | side by side
Simplify code using Java 8 features
[controller.git] / opendaylight / md-sal / sal-distributed-datastore / src / test / java / org / opendaylight / controller / cluster / datastore / shardmanager / ShardManagerTest.java
diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/shardmanager/ShardManagerTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/shardmanager/ShardManagerTest.java
index 2f98ec6916d23ce7ca9a62a90610f38ad74c99c2..41413d9c62b752787f289ffab69f50d3774261f4 100644 (file)
--- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/shardmanager/ShardManagerTest.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/shardmanager/ShardManagerTest.java
@@ -35,8 +35,8 @@ import akka.japi.Creator;
 import akka.pattern.Patterns;
 import akka.persistence.RecoveryCompleted;
 import akka.serialization.Serialization;
-import akka.testkit.JavaTestKit;
 import akka.testkit.TestActorRef;
+import akka.testkit.javadsl.TestKit;
 import akka.util.Timeout;
 import com.google.common.base.Function;
 import com.google.common.base.Stopwatch;
@@ -192,7 +192,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
     }
 
     private static void waitForShardInitialized(final ActorRef shardManager, final String shardName,
-            final JavaTestKit kit) {
+            final TestKit kit) {
         AssertionError last = null;
         Stopwatch sw = Stopwatch.createStarted();
         while (sw.elapsed(TimeUnit.SECONDS) <= 5) {
@@ -211,8 +211,8 @@ public class ShardManagerTest extends AbstractShardManagerTest {
     }
 
     @SuppressWarnings("unchecked")
-    private static <T> T expectMsgClassOrFailure(final Class<T> msgClass, final JavaTestKit kit, final String msg) {
-        Object reply = kit.expectMsgAnyClassOf(JavaTestKit.duration("5 sec"), msgClass, Failure.class);
+    private static <T> T expectMsgClassOrFailure(final Class<T> msgClass, final TestKit kit, final String msg) {
+        Object reply = kit.expectMsgAnyClassOf(kit.duration("5 sec"), msgClass, Failure.class);
         if (reply instanceof Failure) {
             throw new AssertionError(msg + " failed", ((Failure)reply).cause());
         }
@@ -220,7 +220,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         return (T)reply;
     }
 
-    //@Test
+    @Test
     public void testPerShardDatastoreContext() throws Exception {
         LOG.info("testPerShardDatastoreContext starting");
         final DatastoreContextFactory mockFactory = newDatastoreContextFactory(
@@ -280,14 +280,14 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         final Creator<ShardManager> creator = new Creator<ShardManager>() {
             private static final long serialVersionUID = 1L;
             @Override
-            public ShardManager create() throws Exception {
+            public ShardManager create() {
                 return new LocalShardManager(
                         new GenericCreator<>(LocalShardManager.class).datastoreContextFactory(mockFactory)
                                 .primaryShardInfoCache(primaryShardInfoCache).configuration(mockConfig));
             }
         };
 
-        JavaTestKit kit = new JavaTestKit(getSystem());
+        TestKit kit = new TestKit(getSystem());
 
         final ActorRef shardManager = actorFactory.createActor(Props.create(
                 new DelegatingShardManagerCreator(creator)).withDispatcher(Dispatchers.DefaultDispatcherId()));
@@ -322,9 +322,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testPerShardDatastoreContext ending");
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryForNonExistentShard() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testOnReceiveFindPrimaryForNonExistentShard() {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -337,10 +337,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryForLocalLeaderShard() throws Exception {
+    @Test
+    public void testOnReceiveFindPrimaryForLocalLeaderShard() {
         LOG.info("testOnReceiveFindPrimaryForLocalLeaderShard starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
 
@@ -371,10 +371,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnReceiveFindPrimaryForLocalLeaderShard ending");
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp() throws Exception {
+    @Test
+    public void testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp() {
         LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -398,10 +398,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp ending");
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryForNonLocalLeaderShard() throws Exception {
+    @Test
+    public void testOnReceiveFindPrimaryForNonLocalLeaderShard() {
         LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShard starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -431,9 +431,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShard ending");
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryForUninitializedShard() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testOnReceiveFindPrimaryForUninitializedShard() {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -444,9 +444,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryForInitializedShardWithNoRole() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testOnReceiveFindPrimaryForInitializedShardWithNoRole() {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -460,10 +460,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId() throws Exception {
+    @Test
+    public void testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId() {
         LOG.info("testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -496,11 +496,11 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId starting");
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryWaitForShardLeader() throws Exception {
+    @Test
+    public void testOnReceiveFindPrimaryWaitForShardLeader() {
         LOG.info("testOnReceiveFindPrimaryWaitForShardLeader starting");
         datastoreContextBuilder.shardInitializationTimeout(10, TimeUnit.SECONDS);
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -542,10 +542,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnReceiveFindPrimaryWaitForShardLeader ending");
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard() throws Exception {
+    @Test
+    public void testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard() {
         LOG.info("testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -564,10 +564,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard ending");
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryWaitForReadyWithCandidateShard() throws Exception {
+    @Test
+    public void testOnReceiveFindPrimaryWaitForReadyWithCandidateShard() {
         LOG.info("testOnReceiveFindPrimaryWaitForReadyWithCandidateShard starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -585,10 +585,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnReceiveFindPrimaryWaitForReadyWithCandidateShard ending");
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard() throws Exception {
+    @Test
+    public void testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard() {
         LOG.info("testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -606,10 +606,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard ending");
     }
 
-    //@Test
-    public void testOnReceiveFindPrimaryWaitForReadyWithNoRoleShard() throws Exception {
+    @Test
+    public void testOnReceiveFindPrimaryWaitForReadyWithNoRoleShard() {
         LOG.info("testOnReceiveFindPrimaryWaitForReadyWithNoRoleShard starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -626,7 +626,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
     }
 
     @Test
-    public void testOnReceiveFindPrimaryForRemoteShard() throws Exception {
+    public void testOnReceiveFindPrimaryForRemoteShard() {
         LOG.info("testOnReceiveFindPrimaryForRemoteShard starting");
         String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
 
@@ -657,7 +657,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
                         new ClusterWrapperImpl(system2)).props().withDispatcher(
                                 Dispatchers.DefaultDispatcherId()), shardManagerID);
 
-        new JavaTestKit(system1) {
+        new TestKit(system1) {
             {
                 shardManager1.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
                 shardManager2.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
@@ -698,8 +698,8 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnReceiveFindPrimaryForRemoteShard ending");
     }
 
-    //@Test
-    public void testShardAvailabilityOnChangeOfMemberReachability() throws Exception {
+    @Test
+    public void testShardAvailabilityOnChangeOfMemberReachability() {
         LOG.info("testShardAvailabilityOnChangeOfMemberReachability starting");
         String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
 
@@ -731,7 +731,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
                         new ClusterWrapperImpl(system2)).props().withDispatcher(
                                 Dispatchers.DefaultDispatcherId()), shardManagerID);
 
-        new JavaTestKit(system1) {
+        new TestKit(system1) {
             {
                 shardManager1.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
                 shardManager2.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
@@ -820,8 +820,8 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testShardAvailabilityOnChangeOfMemberReachability ending");
     }
 
-    //@Test
-    public void testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange() throws Exception {
+    @Test
+    public void testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange() {
         LOG.info("testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange starting");
         String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
 
@@ -855,7 +855,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
                         new ClusterWrapperImpl(system2)).props().withDispatcher(
                                 Dispatchers.DefaultDispatcherId()), shardManagerID);
 
-        new JavaTestKit(system1) {
+        new TestKit(system1) {
             {
                 shardManager1.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
                 shardManager2.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
@@ -915,8 +915,8 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange ending");
     }
 
-    //@Test
-    public void testShardAvailabilityChangeOnMemberWithNameContainedInLeaderIdUnreachable() throws Exception {
+    @Test
+    public void testShardAvailabilityChangeOnMemberWithNameContainedInLeaderIdUnreachable() {
         LOG.info("testShardAvailabilityChangeOnMemberWithNameContainedInLeaderIdUnreachable starting");
         String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
 
@@ -955,7 +955,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
                         new ClusterWrapperImpl(system2)).props().withDispatcher(
                                 Dispatchers.DefaultDispatcherId()), shardManagerID);
 
-        new JavaTestKit(system256) {
+        new TestKit(system256) {
             {
                 shardManager256.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
                 shardManager2.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
@@ -1016,9 +1016,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testShardAvailabilityChangeOnMemberWithNameContainedInLeaderIdUnreachable ending");
     }
 
-    //@Test
-    public void testOnReceiveFindLocalShardForNonExistentShard() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testOnReceiveFindLocalShardForNonExistentShard() {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -1033,9 +1033,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
-    public void testOnReceiveFindLocalShardForExistentShard() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testOnReceiveFindLocalShardForExistentShard() {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -1052,9 +1052,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
-    public void testOnReceiveFindLocalShardForNotInitializedShard() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testOnReceiveFindLocalShardForNotInitializedShard() {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -1065,10 +1065,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
+    @Test
     public void testOnReceiveFindLocalShardWaitForShardInitialized() throws Exception {
         LOG.info("testOnReceiveFindLocalShardWaitForShardInitialized starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -1090,7 +1090,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnReceiveFindLocalShardWaitForShardInitialized starting");
     }
 
-    //@Test
+    @Test
     public void testRoleChangeNotificationAndShardLeaderStateChangedReleaseReady() throws Exception {
         TestShardManager shardManager = newTestShardManager();
 
@@ -1106,9 +1106,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         verify(ready, times(1)).countDown();
     }
 
-    //@Test
+    @Test
     public void testRoleChangeNotificationToFollowerWithShardLeaderStateChangedReleaseReady() throws Exception {
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 TestShardManager shardManager = newTestShardManager();
 
@@ -1129,9 +1129,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
+    @Test
     public void testReadyCountDownForMemberUpAfterLeaderStateChanged() throws Exception {
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 TestShardManager shardManager = newTestShardManager();
 
@@ -1152,7 +1152,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
+    @Test
     public void testRoleChangeNotificationDoNothingForUnknownShard() throws Exception {
         TestShardManager shardManager = newTestShardManager();
 
@@ -1162,14 +1162,14 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         verify(ready, never()).countDown();
     }
 
-    //@Test
-    public void testByDefaultSyncStatusIsFalse() throws Exception {
+    @Test
+    public void testByDefaultSyncStatusIsFalse() {
         TestShardManager shardManager = newTestShardManager();
 
         assertEquals(false, shardManager.getMBean().getSyncStatus());
     }
 
-    //@Test
+    @Test
     public void testWhenShardIsLeaderSyncStatusIsTrue() throws Exception {
         TestShardManager shardManager = newTestShardManager();
 
@@ -1179,7 +1179,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         assertEquals(true, shardManager.getMBean().getSyncStatus());
     }
 
-    //@Test
+    @Test
     public void testWhenShardIsCandidateSyncStatusIsFalse() throws Exception {
         TestShardManager shardManager = newTestShardManager();
 
@@ -1196,7 +1196,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         assertEquals(false, shardManager.getMBean().getSyncStatus());
     }
 
-    //@Test
+    @Test
     public void testWhenShardIsFollowerSyncStatusDependsOnFollowerInitialSyncStatus() throws Exception {
         TestShardManager shardManager = newTestShardManager();
 
@@ -1219,7 +1219,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
 
     }
 
-    //@Test
+    @Test
     public void testWhenMultipleShardsPresentSyncStatusMustBeTrueForAllShards() throws Exception {
         LOG.info("testWhenMultipleShardsPresentSyncStatusMustBeTrueForAllShards starting");
         TestShardManager shardManager = newTestShardManager(newShardMgrProps(new MockConfiguration() {
@@ -1264,9 +1264,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testWhenMultipleShardsPresentSyncStatusMustBeTrueForAllShards ending");
     }
 
-    //@Test
-    public void testOnReceiveSwitchShardBehavior() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testOnReceiveSwitchShardBehavior() {
+        new TestKit(getSystem()) {
             {
                 final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
 
@@ -1288,10 +1288,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         return Arrays.asList(names).stream().map(MemberName::forName).collect(Collectors.toList());
     }
 
-    //@Test
+    @Test
     public void testOnCreateShard() {
         LOG.info("testOnCreateShard starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 datastoreContextBuilder.shardInitializationTimeout(1, TimeUnit.MINUTES).persistent(true);
 
@@ -1340,10 +1340,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnCreateShard ending");
     }
 
-    //@Test
+    @Test
     public void testOnCreateShardWithLocalMemberNotInShardConfig() {
         LOG.info("testOnCreateShardWithLocalMemberNotInShardConfig starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 datastoreContextBuilder.shardInitializationTimeout(1, TimeUnit.MINUTES).persistent(true);
 
@@ -1372,10 +1372,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnCreateShardWithLocalMemberNotInShardConfig ending");
     }
 
-    //@Test
+    @Test
     public void testOnCreateShardWithNoInitialSchemaContext() {
         LOG.info("testOnCreateShardWithNoInitialSchemaContext starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 ActorRef shardManager = actorFactory
                         .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
@@ -1404,10 +1404,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testOnCreateShardWithNoInitialSchemaContext ending");
     }
 
-    //@Test
-    public void testGetSnapshot() throws Exception {
+    @Test
+    public void testGetSnapshot() {
         LOG.info("testGetSnapshot starting");
-        JavaTestKit kit = new JavaTestKit(getSystem());
+        TestKit kit = new TestKit(getSystem());
 
         MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
                 .put("shard1", Arrays.asList("member-1")).put("shard2", Arrays.asList("member-1"))
@@ -1435,11 +1435,11 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         Function<ShardSnapshot, String> shardNameTransformer = ShardSnapshot::getName;
 
         assertEquals("Shard names", Sets.newHashSet("shard1", "shard2"), Sets.newHashSet(
-                Lists.transform(datastoreSnapshot.getShardSnapshots(), shardNameTransformer)));
+            datastoreSnapshot.getShardSnapshots().stream().map(shardNameTransformer).collect(Collectors.toSet())));
 
         // Add a new replica
 
-        JavaTestKit mockShardLeaderKit = new JavaTestKit(getSystem());
+        TestKit mockShardLeaderKit = new TestKit(getSystem());
 
         TestShardManager shardManagerInstance = shardManager.underlyingActor();
         shardManagerInstance.setMessageInterceptor(newFindPrimaryInterceptor(mockShardLeaderKit.getRef()));
@@ -1466,13 +1466,13 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testGetSnapshot ending");
     }
 
-    //@Test
-    public void testRestoreFromSnapshot() throws Exception {
+    @Test
+    public void testRestoreFromSnapshot() {
         LOG.info("testRestoreFromSnapshot starting");
 
         datastoreContextBuilder.shardInitializationTimeout(3, TimeUnit.SECONDS);
 
-        JavaTestKit kit = new JavaTestKit(getSystem());
+        TestKit kit = new TestKit(getSystem());
 
         MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
                 .put("shard1", Collections.<String>emptyList()).put("shard2", Collections.<String>emptyList())
@@ -1506,9 +1506,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testRestoreFromSnapshot ending");
     }
 
-    //@Test
-    public void testAddShardReplicaForNonExistentShardConfig() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testAddShardReplicaForNonExistentShardConfig() {
+        new TestKit(getSystem()) {
             {
                 ActorRef shardManager = actorFactory
                         .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
@@ -1522,8 +1522,8 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
-    public void testAddShardReplica() throws Exception {
+    @Test
+    public void testAddShardReplica() {
         LOG.info("testAddShardReplica starting");
         MockConfiguration mockConfig = new MockConfiguration(
                 ImmutableMap.<String, List<String>>builder().put("default", Arrays.asList("member-1", "member-2"))
@@ -1559,7 +1559,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
                         .withDispatcher(Dispatchers.DefaultDispatcherId()),
                 shardManagerID);
 
-        new JavaTestKit(system1) {
+        new TestKit(system1) {
             {
                 newReplicaShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
                 leaderShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
@@ -1609,10 +1609,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testAddShardReplica ending");
     }
 
-    //@Test
-    public void testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader() throws Exception {
+    @Test
+    public void testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader() {
         LOG.info("testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 TestActorRef<TestShardManager> shardManager = actorFactory
                         .createTestActor(newPropsShardMgrWithMockShardActor(), shardMgrID);
@@ -1671,10 +1671,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader ending");
     }
 
-    //@Test
-    public void testAddShardReplicaWithPreExistingLocalReplicaLeader() throws Exception {
+    @Test
+    public void testAddShardReplicaWithPreExistingLocalReplicaLeader() {
         LOG.info("testAddShardReplicaWithPreExistingLocalReplicaLeader starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
                 ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
@@ -1699,12 +1699,12 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testAddShardReplicaWithPreExistingLocalReplicaLeader ending");
     }
 
-    //@Test
-    public void testAddShardReplicaWithAddServerReplyFailure() throws Exception {
+    @Test
+    public void testAddShardReplicaWithAddServerReplyFailure() {
         LOG.info("testAddShardReplicaWithAddServerReplyFailure starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
-                JavaTestKit mockShardLeaderKit = new JavaTestKit(getSystem());
+                TestKit mockShardLeaderKit = new TestKit(getSystem());
 
                 MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
                         .put("astronauts", Arrays.asList("member-2")).build());
@@ -1718,7 +1718,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
 
                 shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
 
-                JavaTestKit terminateWatcher = new JavaTestKit(getSystem());
+                TestKit terminateWatcher = new TestKit(getSystem());
                 terminateWatcher.watch(mockNewReplicaShardActor);
 
                 shardManager.tell(new AddShardReplica("astronauts"), getRef());
@@ -1747,17 +1747,17 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testAddShardReplicaWithAddServerReplyFailure ending");
     }
 
-    //@Test
-    public void testAddShardReplicaWithAlreadyInProgress() throws Exception {
+    @Test
+    public void testAddShardReplicaWithAlreadyInProgress() {
         testServerChangeWhenAlreadyInProgress("astronauts", new AddShardReplica("astronauts"),
                 AddServer.class, new AddShardReplica("astronauts"));
     }
 
-    //@Test
-    public void testAddShardReplicaWithFindPrimaryTimeout() throws Exception {
+    @Test
+    public void testAddShardReplicaWithFindPrimaryTimeout() {
         LOG.info("testAddShardReplicaWithFindPrimaryTimeout starting");
         datastoreContextBuilder.shardInitializationTimeout(100, TimeUnit.MILLISECONDS);
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
                         .put("astronauts", Arrays.asList("member-2")).build());
@@ -1779,9 +1779,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testAddShardReplicaWithFindPrimaryTimeout ending");
     }
 
-    //@Test
-    public void testRemoveShardReplicaForNonExistentShard() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testRemoveShardReplicaForNonExistentShard() {
+        new TestKit(getSystem()) {
             {
                 ActorRef shardManager = actorFactory
                         .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
@@ -1794,12 +1794,12 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
+    @Test
     /**
      * Primary is Local.
      */
-    public void testRemoveShardReplicaLocal() throws Exception {
-        new JavaTestKit(getSystem()) {
+    public void testRemoveShardReplicaLocal() {
+        new TestKit(getSystem()) {
             {
                 String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
 
@@ -1826,8 +1826,8 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
-    public void testRemoveShardReplicaRemote() throws Exception {
+    @Test
+    public void testRemoveShardReplicaRemote() {
         MockConfiguration mockConfig = new MockConfiguration(
                 ImmutableMap.<String, List<String>>builder().put("default", Arrays.asList("member-1", "member-2"))
                         .put("astronauts", Arrays.asList("member-1")).build());
@@ -1879,7 +1879,7 @@ public class ShardManagerTest extends AbstractShardManagerTest {
 
         LOG.error("Forwarding actor : {}", actorRef);
 
-        new JavaTestKit(system1) {
+        new TestKit(system1) {
             {
                 newReplicaShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
                 leaderShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
@@ -1917,14 +1917,14 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
-    public void testRemoveShardReplicaWhenAnotherRemoveShardReplicaAlreadyInProgress() throws Exception {
+    @Test
+    public void testRemoveShardReplicaWhenAnotherRemoveShardReplicaAlreadyInProgress() {
         testServerChangeWhenAlreadyInProgress("astronauts", new RemoveShardReplica("astronauts", MEMBER_2),
                 RemoveServer.class, new RemoveShardReplica("astronauts", MEMBER_3));
     }
 
-    //@Test
-    public void testRemoveShardReplicaWhenAddShardReplicaAlreadyInProgress() throws Exception {
+    @Test
+    public void testRemoveShardReplicaWhenAddShardReplicaAlreadyInProgress() {
         testServerChangeWhenAlreadyInProgress("astronauts", new AddShardReplica("astronauts"),
                 AddServer.class, new RemoveShardReplica("astronauts", MEMBER_2));
     }
@@ -1932,11 +1932,11 @@ public class ShardManagerTest extends AbstractShardManagerTest {
 
     public void testServerChangeWhenAlreadyInProgress(final String shardName, final Object firstServerChange,
                                                       final Class<?> firstForwardedServerChangeClass,
-                                                      final Object secondServerChange) throws Exception {
-        new JavaTestKit(getSystem()) {
+                                                      final Object secondServerChange) {
+        new TestKit(getSystem()) {
             {
-                JavaTestKit mockShardLeaderKit = new JavaTestKit(getSystem());
-                final JavaTestKit secondRequestKit = new JavaTestKit(getSystem());
+                TestKit mockShardLeaderKit = new TestKit(getSystem());
+                final TestKit secondRequestKit = new TestKit(getSystem());
 
                 MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
                         .put(shardName, Arrays.asList("member-2")).build());
@@ -1963,10 +1963,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
-    public void testServerRemovedShardActorNotRunning() throws Exception {
+    @Test
+    public void testServerRemovedShardActorNotRunning() {
         LOG.info("testServerRemovedShardActorNotRunning starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
                         .put("default", Arrays.asList("member-1", "member-2"))
@@ -1996,10 +1996,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testServerRemovedShardActorNotRunning ending");
     }
 
-    //@Test
-    public void testServerRemovedShardActorRunning() throws Exception {
+    @Test
+    public void testServerRemovedShardActorRunning() {
         LOG.info("testServerRemovedShardActorRunning starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
                         .put("default", Arrays.asList("member-1", "member-2"))
@@ -2033,10 +2033,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testServerRemovedShardActorRunning ending");
     }
 
-    //@Test
-    public void testShardPersistenceWithRestoredData() throws Exception {
+    @Test
+    public void testShardPersistenceWithRestoredData() {
         LOG.info("testShardPersistenceWithRestoredData starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 MockConfiguration mockConfig =
                     new MockConfiguration(ImmutableMap.<String, List<String>>builder()
@@ -2073,10 +2073,10 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testShardPersistenceWithRestoredData ending");
     }
 
-    //@Test
+    @Test
     public void testShutDown() throws Exception {
         LOG.info("testShutDown starting");
-        new JavaTestKit(getSystem()) {
+        new TestKit(getSystem()) {
             {
                 MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
                         .put("shard1", Arrays.asList("member-1")).put("shard2", Arrays.asList("member-1")).build());
@@ -2118,9 +2118,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         LOG.info("testShutDown ending");
     }
 
-    //@Test
-    public void testChangeServersVotingStatus() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testChangeServersVotingStatus() {
+        new TestKit(getSystem()) {
             {
                 String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
 
@@ -2154,9 +2154,9 @@ public class ShardManagerTest extends AbstractShardManagerTest {
         };
     }
 
-    //@Test
-    public void testChangeServersVotingStatusWithNoLeader() throws Exception {
-        new JavaTestKit(getSystem()) {
+    @Test
+    public void testChangeServersVotingStatusWithNoLeader() {
+        new TestKit(getSystem()) {
             {
                 String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
 
OpenDaylight controller