* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
-
package org.opendaylight.controller.cluster.datastore.shardmanager;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.reset;
+import static org.mockito.Mockito.timeout;
import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoMoreInteractions;
import akka.actor.ActorRef;
import akka.actor.ActorSystem;
import akka.testkit.TestActorRef;
import akka.testkit.javadsl.TestKit;
import akka.util.Timeout;
-import com.google.common.base.Function;
import com.google.common.base.Stopwatch;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Lists;
import com.google.common.collect.Sets;
import com.google.common.util.concurrent.Uninterruptibles;
-import java.net.URI;
+import java.time.Duration;
import java.util.AbstractMap;
import java.util.Arrays;
import java.util.Collection;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
+import java.util.function.Consumer;
+import java.util.function.Function;
import java.util.stream.Collectors;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
import org.junit.Test;
-import org.mockito.Mockito;
import org.opendaylight.controller.cluster.access.concepts.MemberName;
import org.opendaylight.controller.cluster.datastore.AbstractShardManagerTest;
import org.opendaylight.controller.cluster.datastore.ClusterWrapperImpl;
import org.opendaylight.controller.cluster.datastore.messages.LocalPrimaryShardFound;
import org.opendaylight.controller.cluster.datastore.messages.LocalShardFound;
import org.opendaylight.controller.cluster.datastore.messages.LocalShardNotFound;
-import org.opendaylight.controller.cluster.datastore.messages.PeerDown;
-import org.opendaylight.controller.cluster.datastore.messages.PeerUp;
import org.opendaylight.controller.cluster.datastore.messages.PrimaryShardInfo;
import org.opendaylight.controller.cluster.datastore.messages.RemotePrimaryShardFound;
import org.opendaylight.controller.cluster.datastore.messages.RemoveShardReplica;
import org.opendaylight.controller.cluster.raft.utils.InMemorySnapshotStore;
import org.opendaylight.controller.cluster.raft.utils.MessageCollectorActor;
import org.opendaylight.controller.md.cluster.datastore.model.TestModel;
+import org.opendaylight.yangtools.concepts.Registration;
+import org.opendaylight.yangtools.yang.common.XMLNamespace;
import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTree;
-import org.opendaylight.yangtools.yang.model.api.SchemaContext;
+import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import scala.concurrent.Await;
private static final MemberName MEMBER_2 = MemberName.forName("member-2");
private static final MemberName MEMBER_3 = MemberName.forName("member-3");
+ private static EffectiveModelContext TEST_SCHEMA_CONTEXT;
+
private final String shardMgrID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
+ @BeforeClass
+ public static void beforeClass() {
+ TEST_SCHEMA_CONTEXT = TestModel.createTestContext();
+ }
+
+ @AfterClass
+ public static void afterClass() {
+ TEST_SCHEMA_CONTEXT = null;
+ }
+
private ActorSystem newActorSystem(final String config) {
return newActorSystem("cluster-test", config);
}
private static DatastoreContextFactory newDatastoreContextFactory(final DatastoreContext datastoreContext) {
DatastoreContextFactory mockFactory = mock(DatastoreContextFactory.class);
- Mockito.doReturn(datastoreContext).when(mockFactory).getBaseDatastoreContext();
- Mockito.doReturn(datastoreContext).when(mockFactory).getShardDatastoreContext(Mockito.anyString());
+ doReturn(datastoreContext).when(mockFactory).getBaseDatastoreContext();
+ doReturn(datastoreContext).when(mockFactory).getShardDatastoreContext(anyString());
return mockFactory;
}
final DatastoreContextFactory mockFactory = newDatastoreContextFactory(
datastoreContextBuilder.shardElectionTimeoutFactor(5).build());
- Mockito.doReturn(
+ doReturn(
DatastoreContext.newBuilderFrom(datastoreContextBuilder.build()).shardElectionTimeoutFactor(6).build())
.when(mockFactory).getShardDatastoreContext("default");
- Mockito.doReturn(
+ doReturn(
DatastoreContext.newBuilderFrom(datastoreContextBuilder.build()).shardElectionTimeoutFactor(7).build())
.when(mockFactory).getShardDatastoreContext("topology");
}
}
- final Creator<ShardManager> creator = new Creator<ShardManager>() {
+ final Creator<ShardManager> creator = new Creator<>() {
private static final long serialVersionUID = 1L;
@Override
- public ShardManager create() throws Exception {
+ public ShardManager create() {
return new LocalShardManager(
new GenericCreator<>(LocalShardManager.class).datastoreContextFactory(mockFactory)
.primaryShardInfoCache(primaryShardInfoCache).configuration(mockConfig));
}
};
- TestKit kit = new TestKit(getSystem());
+ final TestKit kit = new TestKit(getSystem());
- final ActorRef shardManager = actorFactory.createActor(Props.create(
+ final ActorRef shardManager = actorFactory.createActor(Props.create(ShardManager.class,
new DelegatingShardManagerCreator(creator)).withDispatcher(Dispatchers.DefaultDispatcherId()));
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), kit.getRef());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
- assertEquals("Shard actors created", true, newShardActorLatch.await(5, TimeUnit.SECONDS));
+ assertTrue("Shard actors created", newShardActorLatch.await(5, TimeUnit.SECONDS));
assertEquals("getShardElectionTimeoutFactor", 6,
shardInfoMap.get("default").getValue().getShardElectionTimeoutFactor());
assertEquals("getShardElectionTimeoutFactor", 7,
DatastoreContextFactory newMockFactory = newDatastoreContextFactory(
datastoreContextBuilder.shardElectionTimeoutFactor(5).build());
- Mockito.doReturn(
+ doReturn(
DatastoreContext.newBuilderFrom(datastoreContextBuilder.build()).shardElectionTimeoutFactor(66).build())
.when(newMockFactory).getShardDatastoreContext("default");
- Mockito.doReturn(
+ doReturn(
DatastoreContext.newBuilderFrom(datastoreContextBuilder.build()).shardElectionTimeoutFactor(77).build())
.when(newMockFactory).getShardDatastoreContext("topology");
}
@Test
- public void testOnReceiveFindPrimaryForNonExistentShard() throws Exception {
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ public void testOnReceiveFindPrimaryForNonExistentShard() {
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
- shardManager.tell(new FindPrimary("non-existent", false), getRef());
+ shardManager.tell(new FindPrimary("non-existent", false), kit.getRef());
- expectMsgClass(duration("5 seconds"), PrimaryNotFoundException.class);
- }
- };
+ kit.expectMsgClass(Duration.ofSeconds(5), PrimaryNotFoundException.class);
}
@Test
- public void testOnReceiveFindPrimaryForLocalLeaderShard() throws Exception {
+ public void testOnReceiveFindPrimaryForLocalLeaderShard() {
LOG.info("testOnReceiveFindPrimaryForLocalLeaderShard starting");
- new TestKit(getSystem()) {
- {
- String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
+ final TestKit kit = new TestKit(getSystem());
+ String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- DataTree mockDataTree = mock(DataTree.class);
- shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mockDataTree,
- DataStoreVersions.CURRENT_VERSION), getRef());
+ DataTree mockDataTree = mock(DataTree.class);
+ shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mockDataTree,
+ DataStoreVersions.CURRENT_VERSION), kit.getRef());
- MessageCollectorActor.expectFirstMatching(mockShardActor, RegisterRoleChangeListener.class);
- shardManager.tell(
- new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Leader.name()),
- mockShardActor);
+ MessageCollectorActor.expectFirstMatching(mockShardActor, RegisterRoleChangeListener.class);
+ shardManager.tell(
+ new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Leader.name()),
+ mockShardActor);
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), getRef());
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), kit.getRef());
- LocalPrimaryShardFound primaryFound = expectMsgClass(duration("5 seconds"),
- LocalPrimaryShardFound.class);
- assertTrue("Unexpected primary path " + primaryFound.getPrimaryPath(),
- primaryFound.getPrimaryPath().contains("member-1-shard-default"));
- assertSame("getLocalShardDataTree", mockDataTree, primaryFound.getLocalShardDataTree());
- }
- };
+ LocalPrimaryShardFound primaryFound = kit.expectMsgClass(Duration.ofSeconds(5),
+ LocalPrimaryShardFound.class);
+ assertTrue("Unexpected primary path " + primaryFound.getPrimaryPath(),
+ primaryFound.getPrimaryPath().contains("member-1-shard-default"));
+ assertSame("getLocalShardDataTree", mockDataTree, primaryFound.getLocalShardDataTree());
LOG.info("testOnReceiveFindPrimaryForLocalLeaderShard ending");
}
@Test
- public void testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp() throws Exception {
+ public void testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp() {
LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp starting");
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
- String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.tell(
- new RoleChangeNotification(memberId1, RaftState.Candidate.name(), RaftState.Follower.name()),
- mockShardActor);
- shardManager.tell(new LeaderStateChanged(memberId1, memberId2, DataStoreVersions.CURRENT_VERSION),
- mockShardActor);
+ String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
+ String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
+ shardManager.tell(
+ new RoleChangeNotification(memberId1, RaftState.Candidate.name(), RaftState.Follower.name()),
+ mockShardActor);
+ shardManager.tell(new LeaderStateChanged(memberId1, memberId2, DataStoreVersions.CURRENT_VERSION),
+ mockShardActor);
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), getRef());
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), kit.getRef());
- expectMsgClass(duration("5 seconds"), NoShardLeaderException.class);
- }
- };
+ kit.expectMsgClass(Duration.ofSeconds(5), NoShardLeaderException.class);
LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp ending");
}
@Test
- public void testOnReceiveFindPrimaryForNonLocalLeaderShard() throws Exception {
+ public void testOnReceiveFindPrimaryForNonLocalLeaderShard() {
LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShard starting");
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
-
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
-
- String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
- MockClusterWrapper.sendMemberUp(shardManager, "member-2", getRef().path().toString());
-
- String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.tell(
- new RoleChangeNotification(memberId1, RaftState.Candidate.name(), RaftState.Follower.name()),
- mockShardActor);
- short leaderVersion = DataStoreVersions.CURRENT_VERSION - 1;
- shardManager.tell(new ShardLeaderStateChanged(memberId1, memberId2, leaderVersion), mockShardActor);
-
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), getRef());
-
- RemotePrimaryShardFound primaryFound = expectMsgClass(duration("5 seconds"),
- RemotePrimaryShardFound.class);
- assertTrue("Unexpected primary path " + primaryFound.getPrimaryPath(),
- primaryFound.getPrimaryPath().contains("member-2-shard-default"));
- assertEquals("getPrimaryVersion", leaderVersion, primaryFound.getPrimaryVersion());
- }
- };
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
+
+ String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
+ MockClusterWrapper.sendMemberUp(shardManager, "member-2", kit.getRef().path().toString());
+
+ String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
+ shardManager.tell(
+ new RoleChangeNotification(memberId1, RaftState.Candidate.name(), RaftState.Follower.name()),
+ mockShardActor);
+ short leaderVersion = DataStoreVersions.CURRENT_VERSION - 1;
+ shardManager.tell(new ShardLeaderStateChanged(memberId1, memberId2, leaderVersion), mockShardActor);
+
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), kit.getRef());
+
+ RemotePrimaryShardFound primaryFound = kit.expectMsgClass(Duration.ofSeconds(5), RemotePrimaryShardFound.class);
+ assertTrue("Unexpected primary path " + primaryFound.getPrimaryPath(),
+ primaryFound.getPrimaryPath().contains("member-2-shard-default"));
+ assertEquals("getPrimaryVersion", leaderVersion, primaryFound.getPrimaryVersion());
LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShard ending");
}
@Test
- public void testOnReceiveFindPrimaryForUninitializedShard() throws Exception {
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ public void testOnReceiveFindPrimaryForUninitializedShard() {
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), getRef());
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), kit.getRef());
- expectMsgClass(duration("5 seconds"), NotInitializedException.class);
- }
- };
+ kit.expectMsgClass(Duration.ofSeconds(5), NotInitializedException.class);
}
@Test
- public void testOnReceiveFindPrimaryForInitializedShardWithNoRole() throws Exception {
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ public void testOnReceiveFindPrimaryForInitializedShardWithNoRole() {
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), getRef());
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), kit.getRef());
- expectMsgClass(duration("5 seconds"), NoShardLeaderException.class);
- }
- };
+ kit.expectMsgClass(Duration.ofSeconds(5), NoShardLeaderException.class);
}
@Test
- public void testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId() throws Exception {
+ public void testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId() {
LOG.info("testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId starting");
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.tell(
- new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Follower.name()),
- mockShardActor);
+ String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
+ shardManager.tell(
+ new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Follower.name()),
+ mockShardActor);
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), getRef());
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), kit.getRef());
- expectMsgClass(duration("5 seconds"), NoShardLeaderException.class);
+ kit.expectMsgClass(Duration.ofSeconds(5), NoShardLeaderException.class);
- DataTree mockDataTree = mock(DataTree.class);
- shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mockDataTree,
- DataStoreVersions.CURRENT_VERSION), mockShardActor);
+ DataTree mockDataTree = mock(DataTree.class);
+ shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mockDataTree,
+ DataStoreVersions.CURRENT_VERSION), mockShardActor);
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), getRef());
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), kit.getRef());
- LocalPrimaryShardFound primaryFound = expectMsgClass(duration("5 seconds"),
- LocalPrimaryShardFound.class);
- assertTrue("Unexpected primary path " + primaryFound.getPrimaryPath(),
- primaryFound.getPrimaryPath().contains("member-1-shard-default"));
- assertSame("getLocalShardDataTree", mockDataTree, primaryFound.getLocalShardDataTree());
- }
- };
+ LocalPrimaryShardFound primaryFound = kit.expectMsgClass(Duration.ofSeconds(5),
+ LocalPrimaryShardFound.class);
+ assertTrue("Unexpected primary path " + primaryFound.getPrimaryPath(),
+ primaryFound.getPrimaryPath().contains("member-1-shard-default"));
+ assertSame("getLocalShardDataTree", mockDataTree, primaryFound.getLocalShardDataTree());
LOG.info("testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId starting");
}
@Test
- public void testOnReceiveFindPrimaryWaitForShardLeader() throws Exception {
+ public void testOnReceiveFindPrimaryWaitForShardLeader() {
LOG.info("testOnReceiveFindPrimaryWaitForShardLeader starting");
datastoreContextBuilder.shardInitializationTimeout(10, TimeUnit.SECONDS);
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
- // We're passing waitUntilInitialized = true to FindPrimary so
- // the response should be
- // delayed until we send ActorInitialized and
- // RoleChangeNotification.
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, true), getRef());
+ // We're passing waitUntilInitialized = true to FindPrimary so
+ // the response should be
+ // delayed until we send ActorInitialized and
+ // RoleChangeNotification.
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, true), kit.getRef());
- expectNoMsg(FiniteDuration.create(150, TimeUnit.MILLISECONDS));
+ kit.expectNoMessage(Duration.ofMillis(150));
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- expectNoMsg(FiniteDuration.create(150, TimeUnit.MILLISECONDS));
+ kit.expectNoMessage(Duration.ofMillis(150));
- String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.tell(
- new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Leader.name()),
- mockShardActor);
+ String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
+ shardManager.tell(
+ new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Leader.name()),
+ mockShardActor);
- expectNoMsg(FiniteDuration.create(150, TimeUnit.MILLISECONDS));
+ kit.expectNoMessage(Duration.ofMillis(150));
- DataTree mockDataTree = mock(DataTree.class);
- shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mockDataTree,
- DataStoreVersions.CURRENT_VERSION), mockShardActor);
+ DataTree mockDataTree = mock(DataTree.class);
+ shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mockDataTree,
+ DataStoreVersions.CURRENT_VERSION), mockShardActor);
- LocalPrimaryShardFound primaryFound = expectMsgClass(duration("5 seconds"),
- LocalPrimaryShardFound.class);
- assertTrue("Unexpected primary path " + primaryFound.getPrimaryPath(),
- primaryFound.getPrimaryPath().contains("member-1-shard-default"));
- assertSame("getLocalShardDataTree", mockDataTree, primaryFound.getLocalShardDataTree());
+ LocalPrimaryShardFound primaryFound = kit.expectMsgClass(Duration.ofSeconds(5), LocalPrimaryShardFound.class);
+ assertTrue("Unexpected primary path " + primaryFound.getPrimaryPath(),
+ primaryFound.getPrimaryPath().contains("member-1-shard-default"));
+ assertSame("getLocalShardDataTree", mockDataTree, primaryFound.getLocalShardDataTree());
- expectNoMsg(FiniteDuration.create(200, TimeUnit.MILLISECONDS));
- }
- };
+ kit.expectNoMessage(Duration.ofMillis(200));
LOG.info("testOnReceiveFindPrimaryWaitForShardLeader ending");
}
@Test
- public void testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard() throws Exception {
+ public void testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard() {
LOG.info("testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard starting");
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, true), getRef());
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, true), kit.getRef());
- expectMsgClass(duration("2 seconds"), NotInitializedException.class);
+ kit.expectMsgClass(Duration.ofSeconds(2), NotInitializedException.class);
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- expectNoMsg(FiniteDuration.create(200, TimeUnit.MILLISECONDS));
- }
- };
+ kit.expectNoMessage(Duration.ofMillis(200));
LOG.info("testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard ending");
}
@Test
- public void testOnReceiveFindPrimaryWaitForReadyWithCandidateShard() throws Exception {
+ public void testOnReceiveFindPrimaryWaitForReadyWithCandidateShard() {
LOG.info("testOnReceiveFindPrimaryWaitForReadyWithCandidateShard starting");
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
- shardManager.tell(new RoleChangeNotification("member-1-shard-default-" + shardMrgIDSuffix, null,
- RaftState.Candidate.name()), mockShardActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new RoleChangeNotification("member-1-shard-default-" + shardMrgIDSuffix, null,
+ RaftState.Candidate.name()), mockShardActor);
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, true), getRef());
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, true), kit.getRef());
- expectMsgClass(duration("2 seconds"), NoShardLeaderException.class);
- }
- };
+ kit.expectMsgClass(Duration.ofSeconds(2), NoShardLeaderException.class);
LOG.info("testOnReceiveFindPrimaryWaitForReadyWithCandidateShard ending");
}
@Test
- public void testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard() throws Exception {
+ public void testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard() {
LOG.info("testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard starting");
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
- shardManager.tell(new RoleChangeNotification("member-1-shard-default-" + shardMrgIDSuffix, null,
- RaftState.IsolatedLeader.name()), mockShardActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new RoleChangeNotification("member-1-shard-default-" + shardMrgIDSuffix, null,
+ RaftState.IsolatedLeader.name()), mockShardActor);
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, true), getRef());
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, true),kit. getRef());
- expectMsgClass(duration("2 seconds"), NoShardLeaderException.class);
- }
- };
+ kit.expectMsgClass(Duration.ofSeconds(2), NoShardLeaderException.class);
LOG.info("testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard ending");
}
@Test
- public void testOnReceiveFindPrimaryWaitForReadyWithNoRoleShard() throws Exception {
+ public void testOnReceiveFindPrimaryWaitForReadyWithNoRoleShard() {
LOG.info("testOnReceiveFindPrimaryWaitForReadyWithNoRoleShard starting");
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, true), getRef());
+ shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, true), kit.getRef());
- expectMsgClass(duration("2 seconds"), NoShardLeaderException.class);
- }
- };
+ kit.expectMsgClass(Duration.ofSeconds(2), NoShardLeaderException.class);
LOG.info("testOnReceiveFindPrimaryWaitForReadyWithNoRoleShard ending");
}
@Test
- public void testOnReceiveFindPrimaryForRemoteShard() throws Exception {
+ public void testOnReceiveFindPrimaryForRemoteShard() {
LOG.info("testOnReceiveFindPrimaryForRemoteShard starting");
String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
new ClusterWrapperImpl(system2)).props().withDispatcher(
Dispatchers.DefaultDispatcherId()), shardManagerID);
- new TestKit(system1) {
- {
- shardManager1.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager2.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ final TestKit kit = new TestKit(system1);
+ shardManager1.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager2.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
- shardManager2.tell(new ActorInitialized(), mockShardActor2);
+ shardManager2.tell(new ActorInitialized(), mockShardActor2);
- String memberId2 = "member-2-shard-astronauts-" + shardMrgIDSuffix;
- short leaderVersion = DataStoreVersions.CURRENT_VERSION - 1;
- shardManager2.tell(
- new ShardLeaderStateChanged(memberId2, memberId2, mock(DataTree.class), leaderVersion),
- mockShardActor2);
- shardManager2.tell(
- new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Leader.name()),
- mockShardActor2);
+ String memberId2 = "member-2-shard-astronauts-" + shardMrgIDSuffix;
+ short leaderVersion = DataStoreVersions.CURRENT_VERSION - 1;
+ shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId2, mock(DataTree.class), leaderVersion),
+ mockShardActor2);
+ shardManager2.tell(new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Leader.name()),
+ mockShardActor2);
- shardManager1.underlyingActor().waitForMemberUp();
- shardManager1.tell(new FindPrimary("astronauts", false), getRef());
+ shardManager1.underlyingActor().waitForMemberUp();
+ shardManager1.tell(new FindPrimary("astronauts", false), kit.getRef());
- RemotePrimaryShardFound found = expectMsgClass(duration("5 seconds"), RemotePrimaryShardFound.class);
- String path = found.getPrimaryPath();
- assertTrue("Unexpected primary path " + path, path.contains("member-2-shard-astronauts-config"));
- assertEquals("getPrimaryVersion", leaderVersion, found.getPrimaryVersion());
+ RemotePrimaryShardFound found = kit.expectMsgClass(Duration.ofSeconds(5), RemotePrimaryShardFound.class);
+ String path = found.getPrimaryPath();
+ assertTrue("Unexpected primary path " + path, path.contains("member-2-shard-astronauts-config"));
+ assertEquals("getPrimaryVersion", leaderVersion, found.getPrimaryVersion());
- shardManager2.underlyingActor().verifyFindPrimary();
+ shardManager2.underlyingActor().verifyFindPrimary();
- // This part times out quite a bit on jenkins for some reason
+ // This part times out quite a bit on jenkins for some reason
// Cluster.get(system2).down(AddressFromURIString.parse("akka://cluster-test@127.0.0.1:2558"));
//
//
// shardManager1.tell(new FindPrimary("astronauts", false), getRef());
//
-// expectMsgClass(duration("5 seconds"), PrimaryNotFoundException.class);
- }
- };
+// expectMsgClass(Duration.ofSeconds(5), PrimaryNotFoundException.class);
LOG.info("testOnReceiveFindPrimaryForRemoteShard ending");
}
@Test
- public void testShardAvailabilityOnChangeOfMemberReachability() throws Exception {
+ public void testShardAvailabilityOnChangeOfMemberReachability() {
LOG.info("testShardAvailabilityOnChangeOfMemberReachability starting");
String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
new ClusterWrapperImpl(system2)).props().withDispatcher(
Dispatchers.DefaultDispatcherId()), shardManagerID);
- new TestKit(system1) {
- {
- shardManager1.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager2.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager1.tell(new ActorInitialized(), mockShardActor1);
- shardManager2.tell(new ActorInitialized(), mockShardActor2);
-
- String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
- String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager1.tell(new ShardLeaderStateChanged(memberId1, memberId2, mock(DataTree.class),
- DataStoreVersions.CURRENT_VERSION), mockShardActor1);
- shardManager1.tell(
- new RoleChangeNotification(memberId1, RaftState.Candidate.name(), RaftState.Follower.name()),
- mockShardActor1);
- shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId2, mock(DataTree.class),
- DataStoreVersions.CURRENT_VERSION), mockShardActor2);
- shardManager2.tell(
- new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Leader.name()),
- mockShardActor2);
- shardManager1.underlyingActor().waitForMemberUp();
-
- shardManager1.tell(new FindPrimary("default", true), getRef());
+ final TestKit kit = new TestKit(system1);
+ shardManager1.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager2.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager1.tell(new ActorInitialized(), mockShardActor1);
+ shardManager2.tell(new ActorInitialized(), mockShardActor2);
- RemotePrimaryShardFound found = expectMsgClass(duration("5 seconds"), RemotePrimaryShardFound.class);
- String path = found.getPrimaryPath();
- assertTrue("Unexpected primary path " + path, path.contains("member-2-shard-default-config"));
-
- shardManager1.tell(MockClusterWrapper.createUnreachableMember("member-2",
- "akka://cluster-test@127.0.0.1:2558"), getRef());
+ String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
+ String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
+ shardManager1.tell(new ShardLeaderStateChanged(memberId1, memberId2, mock(DataTree.class),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor1);
+ shardManager1.tell(
+ new RoleChangeNotification(memberId1, RaftState.Candidate.name(), RaftState.Follower.name()),
+ mockShardActor1);
+ shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId2, mock(DataTree.class),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor2);
+ shardManager2.tell(
+ new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Leader.name()),
+ mockShardActor2);
+ shardManager1.underlyingActor().waitForMemberUp();
- shardManager1.underlyingActor().waitForUnreachableMember();
+ shardManager1.tell(new FindPrimary("default", true), kit.getRef());
- PeerDown peerDown = MessageCollectorActor.expectFirstMatching(mockShardActor1, PeerDown.class);
- assertEquals("getMemberName", MEMBER_2, peerDown.getMemberName());
- MessageCollectorActor.clearMessages(mockShardActor1);
+ RemotePrimaryShardFound found = kit.expectMsgClass(Duration.ofSeconds(5), RemotePrimaryShardFound.class);
+ String path = found.getPrimaryPath();
+ assertTrue("Unexpected primary path " + path, path.contains("member-2-shard-default-config"));
- shardManager1.tell(
- MockClusterWrapper.createMemberRemoved("member-2", "akka://cluster-test@127.0.0.1:2558"),
- getRef());
+ shardManager1.tell(MockClusterWrapper.createUnreachableMember("member-2", "akka://cluster-test@127.0.0.1:2558"),
+ kit.getRef());
- MessageCollectorActor.expectFirstMatching(mockShardActor1, PeerDown.class);
+ shardManager1.underlyingActor().waitForUnreachableMember();
+ MessageCollectorActor.clearMessages(mockShardActor1);
- shardManager1.tell(new FindPrimary("default", true), getRef());
+ shardManager1.tell(MockClusterWrapper.createMemberRemoved("member-2", "akka://cluster-test@127.0.0.1:2558"),
+ kit.getRef());
- expectMsgClass(duration("5 seconds"), NoShardLeaderException.class);
+ shardManager1.tell(new FindPrimary("default", true), kit.getRef());
- shardManager1.tell(
- MockClusterWrapper.createReachableMember("member-2", "akka://cluster-test@127.0.0.1:2558"),
- getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), NoShardLeaderException.class);
- shardManager1.underlyingActor().waitForReachableMember();
+ shardManager1.tell(MockClusterWrapper.createReachableMember("member-2", "akka://cluster-test@127.0.0.1:2558"),
+ kit.getRef());
- PeerUp peerUp = MessageCollectorActor.expectFirstMatching(mockShardActor1, PeerUp.class);
- assertEquals("getMemberName", MEMBER_2, peerUp.getMemberName());
- MessageCollectorActor.clearMessages(mockShardActor1);
+ shardManager1.underlyingActor().waitForReachableMember();
- shardManager1.tell(new FindPrimary("default", true), getRef());
+ shardManager1.tell(new FindPrimary("default", true), kit.getRef());
- RemotePrimaryShardFound found1 = expectMsgClass(duration("5 seconds"), RemotePrimaryShardFound.class);
- String path1 = found1.getPrimaryPath();
- assertTrue("Unexpected primary path " + path1, path1.contains("member-2-shard-default-config"));
+ RemotePrimaryShardFound found1 = kit.expectMsgClass(Duration.ofSeconds(5), RemotePrimaryShardFound.class);
+ String path1 = found1.getPrimaryPath();
+ assertTrue("Unexpected primary path " + path1, path1.contains("member-2-shard-default-config"));
- shardManager1.tell(
- MockClusterWrapper.createMemberUp("member-2", "akka://cluster-test@127.0.0.1:2558"),
- getRef());
+ shardManager1.tell(MockClusterWrapper.createMemberUp("member-2", "akka://cluster-test@127.0.0.1:2558"),
+ kit.getRef());
- MessageCollectorActor.expectFirstMatching(mockShardActor1, PeerUp.class);
+ // Test FindPrimary wait succeeds after reachable member event.
- // Test FindPrimary wait succeeds after reachable member event.
+ shardManager1.tell(MockClusterWrapper.createUnreachableMember("member-2",
+ "akka://cluster-test@127.0.0.1:2558"), kit.getRef());
+ shardManager1.underlyingActor().waitForUnreachableMember();
- shardManager1.tell(MockClusterWrapper.createUnreachableMember("member-2",
- "akka://cluster-test@127.0.0.1:2558"), getRef());
- shardManager1.underlyingActor().waitForUnreachableMember();
+ shardManager1.tell(new FindPrimary("default", true), kit.getRef());
- shardManager1.tell(new FindPrimary("default", true), getRef());
+ shardManager1.tell(
+ MockClusterWrapper.createReachableMember("member-2", "akka://cluster-test@127.0.0.1:2558"), kit.getRef());
- shardManager1.tell(
- MockClusterWrapper.createReachableMember("member-2", "akka://cluster-test@127.0.0.1:2558"),
- getRef());
-
- RemotePrimaryShardFound found2 = expectMsgClass(duration("5 seconds"), RemotePrimaryShardFound.class);
- String path2 = found2.getPrimaryPath();
- assertTrue("Unexpected primary path " + path2, path2.contains("member-2-shard-default-config"));
- }
- };
+ RemotePrimaryShardFound found2 = kit.expectMsgClass(Duration.ofSeconds(5), RemotePrimaryShardFound.class);
+ String path2 = found2.getPrimaryPath();
+ assertTrue("Unexpected primary path " + path2, path2.contains("member-2-shard-default-config"));
LOG.info("testShardAvailabilityOnChangeOfMemberReachability ending");
}
@Test
- public void testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange() throws Exception {
+ public void testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange() {
LOG.info("testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange starting");
String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
new ClusterWrapperImpl(system2)).props().withDispatcher(
Dispatchers.DefaultDispatcherId()), shardManagerID);
- new TestKit(system1) {
- {
- shardManager1.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager2.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager1.tell(new ActorInitialized(), mockShardActor1);
- shardManager2.tell(new ActorInitialized(), mockShardActor2);
-
- String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
- String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager1.tell(new ShardLeaderStateChanged(memberId1, memberId2, mock(DataTree.class),
- DataStoreVersions.CURRENT_VERSION), mockShardActor1);
- shardManager1.tell(
- new RoleChangeNotification(memberId1, RaftState.Candidate.name(), RaftState.Follower.name()),
- mockShardActor1);
- shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId2, mock(DataTree.class),
- DataStoreVersions.CURRENT_VERSION), mockShardActor2);
- shardManager2.tell(
- new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Leader.name()),
- mockShardActor2);
- shardManager1.underlyingActor().waitForMemberUp();
+ final TestKit kit = new TestKit(system1);
+ shardManager1.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager2.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager1.tell(new ActorInitialized(), mockShardActor1);
+ shardManager2.tell(new ActorInitialized(), mockShardActor2);
- shardManager1.tell(new FindPrimary("default", true), getRef());
+ String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
+ String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
+ shardManager1.tell(new ShardLeaderStateChanged(memberId1, memberId2, mock(DataTree.class),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor1);
+ shardManager1.tell(
+ new RoleChangeNotification(memberId1, RaftState.Candidate.name(), RaftState.Follower.name()),
+ mockShardActor1);
+ shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId2, mock(DataTree.class),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor2);
+ shardManager2.tell(
+ new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Leader.name()),
+ mockShardActor2);
+ shardManager1.underlyingActor().waitForMemberUp();
- RemotePrimaryShardFound found = expectMsgClass(duration("5 seconds"), RemotePrimaryShardFound.class);
- String path = found.getPrimaryPath();
- assertTrue("Unexpected primary path " + path, path.contains("member-2-shard-default-config"));
+ shardManager1.tell(new FindPrimary("default", true), kit.getRef());
- primaryShardInfoCache.putSuccessful("default", new PrimaryShardInfo(
- system1.actorSelection(mockShardActor1.path()), DataStoreVersions.CURRENT_VERSION));
+ RemotePrimaryShardFound found = kit.expectMsgClass(Duration.ofSeconds(5), RemotePrimaryShardFound.class);
+ String path = found.getPrimaryPath();
+ assertTrue("Unexpected primary path " + path, path.contains("member-2-shard-default-config"));
- shardManager1.tell(MockClusterWrapper.createUnreachableMember("member-2",
- "akka://cluster-test@127.0.0.1:2558"), getRef());
+ primaryShardInfoCache.putSuccessful("default", new PrimaryShardInfo(
+ system1.actorSelection(mockShardActor1.path()), DataStoreVersions.CURRENT_VERSION));
- shardManager1.underlyingActor().waitForUnreachableMember();
+ shardManager1.tell(MockClusterWrapper.createUnreachableMember("member-2",
+ "akka://cluster-test@127.0.0.1:2558"), kit.getRef());
- shardManager1.tell(new FindPrimary("default", true), getRef());
+ shardManager1.underlyingActor().waitForUnreachableMember();
- expectMsgClass(duration("5 seconds"), NoShardLeaderException.class);
+ shardManager1.tell(new FindPrimary("default", true), kit.getRef());
- assertNull("Expected primaryShardInfoCache entry removed",
- primaryShardInfoCache.getIfPresent("default"));
+ kit.expectMsgClass(Duration.ofSeconds(5), NoShardLeaderException.class);
- shardManager1.tell(new ShardLeaderStateChanged(memberId1, memberId1, mock(DataTree.class),
- DataStoreVersions.CURRENT_VERSION), mockShardActor1);
- shardManager1.tell(
- new RoleChangeNotification(memberId1, RaftState.Follower.name(), RaftState.Leader.name()),
- mockShardActor1);
+ assertNull("Expected primaryShardInfoCache entry removed",
+ primaryShardInfoCache.getIfPresent("default"));
- shardManager1.tell(new FindPrimary("default", true), getRef());
+ shardManager1.tell(new ShardLeaderStateChanged(memberId1, memberId1, mock(DataTree.class),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor1);
+ shardManager1.tell(
+ new RoleChangeNotification(memberId1, RaftState.Follower.name(), RaftState.Leader.name()),
+ mockShardActor1);
- LocalPrimaryShardFound found1 = expectMsgClass(duration("5 seconds"), LocalPrimaryShardFound.class);
- String path1 = found1.getPrimaryPath();
- assertTrue("Unexpected primary path " + path1, path1.contains("member-1-shard-default-config"));
+ shardManager1.tell(new FindPrimary("default", true), kit.getRef());
- }
- };
+ LocalPrimaryShardFound found1 = kit.expectMsgClass(Duration.ofSeconds(5), LocalPrimaryShardFound.class);
+ String path1 = found1.getPrimaryPath();
+ assertTrue("Unexpected primary path " + path1, path1.contains("member-1-shard-default-config"));
LOG.info("testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange ending");
}
@Test
- public void testShardAvailabilityChangeOnMemberWithNameContainedInLeaderIdUnreachable() throws Exception {
+ public void testShardAvailabilityChangeOnMemberWithNameContainedInLeaderIdUnreachable() {
LOG.info("testShardAvailabilityChangeOnMemberWithNameContainedInLeaderIdUnreachable starting");
String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
new ClusterWrapperImpl(system2)).props().withDispatcher(
Dispatchers.DefaultDispatcherId()), shardManagerID);
- new TestKit(system256) {
- {
- shardManager256.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager2.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager256.tell(new ActorInitialized(), mockShardActor256);
- shardManager2.tell(new ActorInitialized(), mockShardActor2);
-
- String memberId256 = "member-256-shard-default-" + shardMrgIDSuffix;
- String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
- shardManager256.tell(new ShardLeaderStateChanged(memberId256, memberId256, mock(DataTree.class),
- DataStoreVersions.CURRENT_VERSION), mockShardActor256);
- shardManager256.tell(
- new RoleChangeNotification(memberId256, RaftState.Candidate.name(), RaftState.Leader.name()),
- mockShardActor256);
- shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId256, mock(DataTree.class),
- DataStoreVersions.CURRENT_VERSION), mockShardActor2);
- shardManager2.tell(
- new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Follower.name()),
- mockShardActor2);
- shardManager256.underlyingActor().waitForMemberUp();
-
- shardManager256.tell(new FindPrimary("default", true), getRef());
-
- LocalPrimaryShardFound found = expectMsgClass(duration("5 seconds"), LocalPrimaryShardFound.class);
- String path = found.getPrimaryPath();
- assertTrue("Unexpected primary path " + path + " which must on member-256",
- path.contains("member-256-shard-default-config"));
-
- PrimaryShardInfo primaryShardInfo = new PrimaryShardInfo(
- system256.actorSelection(mockShardActor256.path()), DataStoreVersions.CURRENT_VERSION);
- primaryShardInfoCache.putSuccessful("default", primaryShardInfo);
-
- // Simulate member-2 become unreachable.
- shardManager256.tell(MockClusterWrapper.createUnreachableMember("member-2",
- "akka://cluster-test@127.0.0.1:2558"), getRef());
- shardManager256.underlyingActor().waitForUnreachableMember();
-
- // Make sure leader shard on member-256 is still leader and still in the cache.
- shardManager256.tell(new FindPrimary("default", true), getRef());
- found = expectMsgClass(duration("5 seconds"), LocalPrimaryShardFound.class);
- path = found.getPrimaryPath();
- assertTrue("Unexpected primary path " + path + " which must still not on member-256",
- path.contains("member-256-shard-default-config"));
- Future<PrimaryShardInfo> futurePrimaryShard = primaryShardInfoCache.getIfPresent("default");
- futurePrimaryShard.onComplete(new OnComplete<PrimaryShardInfo>() {
- @Override
- public void onComplete(final Throwable failure, final PrimaryShardInfo futurePrimaryShardInfo) {
- if (failure != null) {
- assertTrue("Primary shard info is unexpectedly removed from primaryShardInfoCache", false);
- } else {
- assertEquals("Expected primaryShardInfoCache entry",
- primaryShardInfo, futurePrimaryShardInfo);
- }
- }
- }, system256.dispatchers().defaultGlobalDispatcher());
+ final TestKit kit256 = new TestKit(system256);
+ shardManager256.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit256.getRef());
+ shardManager2.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit256.getRef());
+ shardManager256.tell(new ActorInitialized(), mockShardActor256);
+ shardManager2.tell(new ActorInitialized(), mockShardActor2);
+
+ String memberId256 = "member-256-shard-default-" + shardMrgIDSuffix;
+ String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
+ shardManager256.tell(new ShardLeaderStateChanged(memberId256, memberId256, mock(DataTree.class),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor256);
+ shardManager256.tell(
+ new RoleChangeNotification(memberId256, RaftState.Candidate.name(), RaftState.Leader.name()),
+ mockShardActor256);
+ shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId256, mock(DataTree.class),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor2);
+ shardManager2.tell(
+ new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Follower.name()),
+ mockShardActor2);
+ shardManager256.underlyingActor().waitForMemberUp();
+
+ shardManager256.tell(new FindPrimary("default", true), kit256.getRef());
+
+ LocalPrimaryShardFound found = kit256.expectMsgClass(Duration.ofSeconds(5), LocalPrimaryShardFound.class);
+ String path = found.getPrimaryPath();
+ assertTrue("Unexpected primary path " + path + " which must on member-256",
+ path.contains("member-256-shard-default-config"));
+
+ PrimaryShardInfo primaryShardInfo = new PrimaryShardInfo(
+ system256.actorSelection(mockShardActor256.path()), DataStoreVersions.CURRENT_VERSION);
+ primaryShardInfoCache.putSuccessful("default", primaryShardInfo);
+
+ // Simulate member-2 become unreachable.
+ shardManager256.tell(MockClusterWrapper.createUnreachableMember("member-2",
+ "akka://cluster-test@127.0.0.1:2558"), kit256.getRef());
+ shardManager256.underlyingActor().waitForUnreachableMember();
+
+ // Make sure leader shard on member-256 is still leader and still in the cache.
+ shardManager256.tell(new FindPrimary("default", true), kit256.getRef());
+ found = kit256.expectMsgClass(Duration.ofSeconds(5), LocalPrimaryShardFound.class);
+ path = found.getPrimaryPath();
+ assertTrue("Unexpected primary path " + path + " which must still not on member-256",
+ path.contains("member-256-shard-default-config"));
+ Future<PrimaryShardInfo> futurePrimaryShard = primaryShardInfoCache.getIfPresent("default");
+ futurePrimaryShard.onComplete(new OnComplete<PrimaryShardInfo>() {
+ @Override
+ public void onComplete(final Throwable failure, final PrimaryShardInfo futurePrimaryShardInfo) {
+ if (failure != null) {
+ assertTrue("Primary shard info is unexpectedly removed from primaryShardInfoCache", false);
+ } else {
+ assertEquals("Expected primaryShardInfoCache entry",
+ primaryShardInfo, futurePrimaryShardInfo);
+ }
}
- };
+ }, system256.dispatchers().defaultGlobalDispatcher());
LOG.info("testShardAvailabilityChangeOnMemberWithNameContainedInLeaderIdUnreachable ending");
}
@Test
- public void testOnReceiveFindLocalShardForNonExistentShard() throws Exception {
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ public void testOnReceiveFindLocalShardForNonExistentShard() {
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
- shardManager.tell(new FindLocalShard("non-existent", false), getRef());
+ shardManager.tell(new FindLocalShard("non-existent", false), kit.getRef());
- LocalShardNotFound notFound = expectMsgClass(duration("5 seconds"), LocalShardNotFound.class);
+ LocalShardNotFound notFound = kit.expectMsgClass(Duration.ofSeconds(5), LocalShardNotFound.class);
- assertEquals("getShardName", "non-existent", notFound.getShardName());
- }
- };
+ assertEquals("getShardName", "non-existent", notFound.getShardName());
}
@Test
- public void testOnReceiveFindLocalShardForExistentShard() throws Exception {
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ public void testOnReceiveFindLocalShardForExistentShard() {
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), getRef());
+ shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), kit.getRef());
- LocalShardFound found = expectMsgClass(duration("5 seconds"), LocalShardFound.class);
+ LocalShardFound found = kit.expectMsgClass(Duration.ofSeconds(5), LocalShardFound.class);
- assertTrue("Found path contains " + found.getPath().path().toString(),
- found.getPath().path().toString().contains("member-1-shard-default-config"));
- }
- };
+ assertTrue("Found path contains " + found.getPath().path().toString(),
+ found.getPath().path().toString().contains("member-1-shard-default-config"));
}
@Test
- public void testOnReceiveFindLocalShardForNotInitializedShard() throws Exception {
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ public void testOnReceiveFindLocalShardForNotInitializedShard() {
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), getRef());
+ shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), kit.getRef());
- expectMsgClass(duration("5 seconds"), NotInitializedException.class);
- }
- };
+ kit.expectMsgClass(Duration.ofSeconds(5), NotInitializedException.class);
}
@Test
public void testOnReceiveFindLocalShardWaitForShardInitialized() throws Exception {
LOG.info("testOnReceiveFindLocalShardWaitForShardInitialized starting");
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
- // We're passing waitUntilInitialized = true to FindLocalShard
- // so the response should be
- // delayed until we send ActorInitialized.
- Future<Object> future = Patterns.ask(shardManager, new FindLocalShard(Shard.DEFAULT_NAME, true),
- new Timeout(5, TimeUnit.SECONDS));
+ // We're passing waitUntilInitialized = true to FindLocalShard
+ // so the response should be
+ // delayed until we send ActorInitialized.
+ Future<Object> future = Patterns.ask(shardManager, new FindLocalShard(Shard.DEFAULT_NAME, true),
+ new Timeout(5, TimeUnit.SECONDS));
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- Object resp = Await.result(future, duration("5 seconds"));
- assertTrue("Expected: LocalShardFound, Actual: " + resp, resp instanceof LocalShardFound);
- }
- };
+ Object resp = Await.result(future, kit.duration("5 seconds"));
+ assertTrue("Expected: LocalShardFound, Actual: " + resp, resp instanceof LocalShardFound);
LOG.info("testOnReceiveFindLocalShardWaitForShardInitialized starting");
}
TestShardManager shardManager = newTestShardManager();
String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.onReceiveCommand(new RoleChangeNotification(
+ shardManager.handleCommand(new RoleChangeNotification(
memberId, RaftState.Candidate.name(), RaftState.Leader.name()));
+ assertFalse(ready.isDone());
- verify(ready, never()).countDown();
-
- shardManager.onReceiveCommand(new ShardLeaderStateChanged(memberId, memberId,
+ shardManager.handleCommand(new ShardLeaderStateChanged(memberId, memberId,
mock(DataTree.class), DataStoreVersions.CURRENT_VERSION));
-
- verify(ready, times(1)).countDown();
+ assertTrue(ready.isDone());
}
@Test
public void testRoleChangeNotificationToFollowerWithShardLeaderStateChangedReleaseReady() throws Exception {
- new TestKit(getSystem()) {
- {
- TestShardManager shardManager = newTestShardManager();
-
- String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.onReceiveCommand(new RoleChangeNotification(memberId, null, RaftState.Follower.name()));
-
- verify(ready, never()).countDown();
+ final TestKit kit = new TestKit(getSystem());
+ TestShardManager shardManager = newTestShardManager();
- shardManager
- .onReceiveCommand(MockClusterWrapper.createMemberUp("member-2", getRef().path().toString()));
+ String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
+ shardManager.handleCommand(new RoleChangeNotification(memberId, null, RaftState.Follower.name()));
+ assertFalse(ready.isDone());
- shardManager.onReceiveCommand(
- new ShardLeaderStateChanged(memberId, "member-2-shard-default-" + shardMrgIDSuffix,
- mock(DataTree.class), DataStoreVersions.CURRENT_VERSION));
+ shardManager.handleCommand(MockClusterWrapper.createMemberUp("member-2", kit.getRef().path().toString()));
- verify(ready, times(1)).countDown();
- }
- };
+ shardManager.handleCommand(
+ new ShardLeaderStateChanged(memberId, "member-2-shard-default-" + shardMrgIDSuffix,
+ mock(DataTree.class), DataStoreVersions.CURRENT_VERSION));
+ assertTrue(ready.isDone());
}
@Test
public void testReadyCountDownForMemberUpAfterLeaderStateChanged() throws Exception {
- new TestKit(getSystem()) {
- {
- TestShardManager shardManager = newTestShardManager();
-
- String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.onReceiveCommand(new RoleChangeNotification(memberId, null, RaftState.Follower.name()));
-
- verify(ready, never()).countDown();
+ final TestKit kit = new TestKit(getSystem());
+ TestShardManager shardManager = newTestShardManager();
- shardManager.onReceiveCommand(
- new ShardLeaderStateChanged(memberId, "member-2-shard-default-" + shardMrgIDSuffix,
- mock(DataTree.class), DataStoreVersions.CURRENT_VERSION));
+ String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
+ shardManager.handleCommand(new RoleChangeNotification(memberId, null, RaftState.Follower.name()));
+ assertFalse(ready.isDone());
- shardManager
- .onReceiveCommand(MockClusterWrapper.createMemberUp("member-2", getRef().path().toString()));
+ shardManager.handleCommand(
+ new ShardLeaderStateChanged(memberId, "member-2-shard-default-" + shardMrgIDSuffix,
+ mock(DataTree.class), DataStoreVersions.CURRENT_VERSION));
- verify(ready, times(1)).countDown();
- }
- };
+ shardManager.handleCommand(MockClusterWrapper.createMemberUp("member-2", kit.getRef().path().toString()));
+ assertTrue(ready.isDone());
}
@Test
public void testRoleChangeNotificationDoNothingForUnknownShard() throws Exception {
TestShardManager shardManager = newTestShardManager();
- shardManager.onReceiveCommand(new RoleChangeNotification(
- "unknown", RaftState.Candidate.name(), RaftState.Leader.name()));
-
- verify(ready, never()).countDown();
+ shardManager.handleCommand(new RoleChangeNotification("unknown", RaftState.Candidate.name(),
+ RaftState.Leader.name()));
+ assertFalse(ready.isDone());
}
@Test
- public void testByDefaultSyncStatusIsFalse() throws Exception {
+ public void testByDefaultSyncStatusIsFalse() {
TestShardManager shardManager = newTestShardManager();
- assertEquals(false, shardManager.getMBean().getSyncStatus());
+ assertFalse(shardManager.getMBean().getSyncStatus());
}
@Test
public void testWhenShardIsLeaderSyncStatusIsTrue() throws Exception {
TestShardManager shardManager = newTestShardManager();
- shardManager.onReceiveCommand(new RoleChangeNotification("member-1-shard-default-" + shardMrgIDSuffix,
+ shardManager.handleCommand(new RoleChangeNotification("member-1-shard-default-" + shardMrgIDSuffix,
RaftState.Follower.name(), RaftState.Leader.name()));
- assertEquals(true, shardManager.getMBean().getSyncStatus());
+ assertTrue(shardManager.getMBean().getSyncStatus());
}
@Test
TestShardManager shardManager = newTestShardManager();
String shardId = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.onReceiveCommand(new RoleChangeNotification(shardId,
+ shardManager.handleCommand(new RoleChangeNotification(shardId,
RaftState.Follower.name(), RaftState.Candidate.name()));
- assertEquals(false, shardManager.getMBean().getSyncStatus());
+ assertFalse(shardManager.getMBean().getSyncStatus());
// Send a FollowerInitialSyncStatus with status = true for the replica whose current state is candidate
- shardManager.onReceiveCommand(new FollowerInitialSyncUpStatus(
+ shardManager.handleCommand(new FollowerInitialSyncUpStatus(
true, shardId));
- assertEquals(false, shardManager.getMBean().getSyncStatus());
+ assertFalse(shardManager.getMBean().getSyncStatus());
}
@Test
TestShardManager shardManager = newTestShardManager();
String shardId = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.onReceiveCommand(new RoleChangeNotification(shardId,
+ shardManager.handleCommand(new RoleChangeNotification(shardId,
RaftState.Candidate.name(), RaftState.Follower.name()));
// Initially will be false
- assertEquals(false, shardManager.getMBean().getSyncStatus());
+ assertFalse(shardManager.getMBean().getSyncStatus());
// Send status true will make sync status true
- shardManager.onReceiveCommand(new FollowerInitialSyncUpStatus(true, shardId));
+ shardManager.handleCommand(new FollowerInitialSyncUpStatus(true, shardId));
- assertEquals(true, shardManager.getMBean().getSyncStatus());
+ assertTrue(shardManager.getMBean().getSyncStatus());
// Send status false will make sync status false
- shardManager.onReceiveCommand(new FollowerInitialSyncUpStatus(false, shardId));
-
- assertEquals(false, shardManager.getMBean().getSyncStatus());
+ shardManager.handleCommand(new FollowerInitialSyncUpStatus(false, shardId));
+ assertFalse(shardManager.getMBean().getSyncStatus());
}
@Test
}));
// Initially will be false
- assertEquals(false, shardManager.getMBean().getSyncStatus());
+ assertFalse(shardManager.getMBean().getSyncStatus());
// Make default shard leader
String defaultShardId = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.onReceiveCommand(new RoleChangeNotification(defaultShardId,
+ shardManager.handleCommand(new RoleChangeNotification(defaultShardId,
RaftState.Follower.name(), RaftState.Leader.name()));
// default = Leader, astronauts is unknown so sync status remains false
- assertEquals(false, shardManager.getMBean().getSyncStatus());
+ assertFalse(shardManager.getMBean().getSyncStatus());
// Make astronauts shard leader as well
String astronautsShardId = "member-1-shard-astronauts-" + shardMrgIDSuffix;
- shardManager.onReceiveCommand(new RoleChangeNotification(astronautsShardId,
+ shardManager.handleCommand(new RoleChangeNotification(astronautsShardId,
RaftState.Follower.name(), RaftState.Leader.name()));
// Now sync status should be true
- assertEquals(true, shardManager.getMBean().getSyncStatus());
+ assertTrue(shardManager.getMBean().getSyncStatus());
// Make astronauts a Follower
- shardManager.onReceiveCommand(new RoleChangeNotification(astronautsShardId,
+ shardManager.handleCommand(new RoleChangeNotification(astronautsShardId,
RaftState.Leader.name(), RaftState.Follower.name()));
// Sync status is not true
- assertEquals(false, shardManager.getMBean().getSyncStatus());
+ assertFalse(shardManager.getMBean().getSyncStatus());
// Make the astronauts follower sync status true
- shardManager.onReceiveCommand(new FollowerInitialSyncUpStatus(true, astronautsShardId));
+ shardManager.handleCommand(new FollowerInitialSyncUpStatus(true, astronautsShardId));
// Sync status is now true
- assertEquals(true, shardManager.getMBean().getSyncStatus());
+ assertTrue(shardManager.getMBean().getSyncStatus());
LOG.info("testWhenMultipleShardsPresentSyncStatusMustBeTrueForAllShards ending");
}
@Test
- public void testOnReceiveSwitchShardBehavior() throws Exception {
- new TestKit(getSystem()) {
- {
- final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+ public void testOnReceiveSwitchShardBehavior() {
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- shardManager.tell(new SwitchShardBehavior(mockShardName, RaftState.Leader, 1000), getRef());
+ shardManager.tell(new SwitchShardBehavior(mockShardName, RaftState.Leader, 1000), kit.getRef());
- SwitchBehavior switchBehavior = MessageCollectorActor.expectFirstMatching(mockShardActor,
- SwitchBehavior.class);
+ SwitchBehavior switchBehavior = MessageCollectorActor.expectFirstMatching(mockShardActor,
+ SwitchBehavior.class);
- assertEquals(RaftState.Leader, switchBehavior.getNewState());
- assertEquals(1000, switchBehavior.getNewTerm());
- }
- };
+ assertEquals(RaftState.Leader, switchBehavior.getNewState());
+ assertEquals(1000, switchBehavior.getNewTerm());
}
private static List<MemberName> members(final String... names) {
@Test
public void testOnCreateShard() {
LOG.info("testOnCreateShard starting");
- new TestKit(getSystem()) {
- {
- datastoreContextBuilder.shardInitializationTimeout(1, TimeUnit.MINUTES).persistent(true);
+ final TestKit kit = new TestKit(getSystem());
+ datastoreContextBuilder.shardInitializationTimeout(1, TimeUnit.MINUTES).persistent(true);
- ActorRef shardManager = actorFactory
- .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
- .withDispatcher(Dispatchers.DefaultDispatcherId()));
+ ActorRef shardManager = actorFactory
+ .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
+ .withDispatcher(Dispatchers.DefaultDispatcherId()));
- SchemaContext schemaContext = TestModel.createTestContext();
- shardManager.tell(new UpdateSchemaContext(schemaContext), ActorRef.noSender());
+ EffectiveModelContext schemaContext = TEST_SCHEMA_CONTEXT;
+ shardManager.tell(new UpdateSchemaContext(schemaContext), ActorRef.noSender());
- DatastoreContext datastoreContext = DatastoreContext.newBuilder().shardElectionTimeoutFactor(100)
- .persistent(false).build();
- Shard.Builder shardBuilder = Shard.builder();
+ DatastoreContext datastoreContext = DatastoreContext.newBuilder().shardElectionTimeoutFactor(100)
+ .persistent(false).build();
+ Shard.Builder shardBuilder = Shard.builder();
- ModuleShardConfiguration config = new ModuleShardConfiguration(URI.create("foo-ns"), "foo-module",
- "foo", null, members("member-1", "member-5", "member-6"));
- shardManager.tell(new CreateShard(config, shardBuilder, datastoreContext), getRef());
+ ModuleShardConfiguration config = new ModuleShardConfiguration(XMLNamespace.of("foo-ns"), "foo-module",
+ "foo", null, members("member-1", "member-5", "member-6"));
+ shardManager.tell(new CreateShard(config, shardBuilder, datastoreContext), kit.getRef());
- expectMsgClass(duration("5 seconds"), Success.class);
+ kit.expectMsgClass(Duration.ofSeconds(5), Success.class);
- shardManager.tell(new FindLocalShard("foo", true), getRef());
+ shardManager.tell(new FindLocalShard("foo", true), kit.getRef());
- expectMsgClass(duration("5 seconds"), LocalShardFound.class);
+ kit.expectMsgClass(Duration.ofSeconds(5), LocalShardFound.class);
- assertEquals("isRecoveryApplicable", false, shardBuilder.getDatastoreContext().isPersistent());
- assertTrue("Epxected ShardPeerAddressResolver", shardBuilder.getDatastoreContext().getShardRaftConfig()
- .getPeerAddressResolver() instanceof ShardPeerAddressResolver);
- assertEquals("peerMembers", Sets.newHashSet(
- ShardIdentifier.create("foo", MemberName.forName("member-5"), shardMrgIDSuffix).toString(),
- ShardIdentifier.create("foo", MemberName.forName("member-6"), shardMrgIDSuffix).toString()),
- shardBuilder.getPeerAddresses().keySet());
- assertEquals("ShardIdentifier", ShardIdentifier.create("foo", MEMBER_1, shardMrgIDSuffix),
- shardBuilder.getId());
- assertSame("schemaContext", schemaContext, shardBuilder.getSchemaContext());
+ assertFalse("isRecoveryApplicable", shardBuilder.getDatastoreContext().isPersistent());
+ assertTrue("Epxected ShardPeerAddressResolver", shardBuilder.getDatastoreContext().getShardRaftConfig()
+ .getPeerAddressResolver() instanceof ShardPeerAddressResolver);
+ assertEquals("peerMembers", Sets.newHashSet(
+ ShardIdentifier.create("foo", MemberName.forName("member-5"), shardMrgIDSuffix).toString(),
+ ShardIdentifier.create("foo", MemberName.forName("member-6"), shardMrgIDSuffix).toString()),
+ shardBuilder.getPeerAddresses().keySet());
+ assertEquals("ShardIdentifier", ShardIdentifier.create("foo", MEMBER_1, shardMrgIDSuffix),
+ shardBuilder.getId());
+ assertSame("schemaContext", schemaContext, shardBuilder.getSchemaContext());
- // Send CreateShard with same name - should return Success with
- // a message.
+ // Send CreateShard with same name - should return Success with
+ // a message.
- shardManager.tell(new CreateShard(config, shardBuilder, null), getRef());
+ shardManager.tell(new CreateShard(config, shardBuilder, null), kit.getRef());
- Success success = expectMsgClass(duration("5 seconds"), Success.class);
- assertNotNull("Success status is null", success.status());
- }
- };
+ Success success = kit.expectMsgClass(Duration.ofSeconds(5), Success.class);
+ assertNotNull("Success status is null", success.status());
LOG.info("testOnCreateShard ending");
}
@Test
public void testOnCreateShardWithLocalMemberNotInShardConfig() {
LOG.info("testOnCreateShardWithLocalMemberNotInShardConfig starting");
- new TestKit(getSystem()) {
- {
- datastoreContextBuilder.shardInitializationTimeout(1, TimeUnit.MINUTES).persistent(true);
+ final TestKit kit = new TestKit(getSystem());
+ datastoreContextBuilder.shardInitializationTimeout(1, TimeUnit.MINUTES).persistent(true);
- ActorRef shardManager = actorFactory
- .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
- .withDispatcher(Dispatchers.DefaultDispatcherId()));
+ ActorRef shardManager = actorFactory
+ .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
+ .withDispatcher(Dispatchers.DefaultDispatcherId()));
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), ActorRef.noSender());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), ActorRef.noSender());
- Shard.Builder shardBuilder = Shard.builder();
- ModuleShardConfiguration config = new ModuleShardConfiguration(URI.create("foo-ns"), "foo-module",
- "foo", null, members("member-5", "member-6"));
+ Shard.Builder shardBuilder = Shard.builder();
+ ModuleShardConfiguration config = new ModuleShardConfiguration(XMLNamespace.of("foo-ns"), "foo-module",
+ "foo", null, members("member-5", "member-6"));
- shardManager.tell(new CreateShard(config, shardBuilder, null), getRef());
- expectMsgClass(duration("5 seconds"), Success.class);
+ shardManager.tell(new CreateShard(config, shardBuilder, null), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), Success.class);
- shardManager.tell(new FindLocalShard("foo", true), getRef());
- expectMsgClass(duration("5 seconds"), LocalShardFound.class);
+ shardManager.tell(new FindLocalShard("foo", true), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), LocalShardFound.class);
- assertEquals("peerMembers size", 0, shardBuilder.getPeerAddresses().size());
- assertEquals("schemaContext", DisableElectionsRaftPolicy.class.getName(), shardBuilder
- .getDatastoreContext().getShardRaftConfig().getCustomRaftPolicyImplementationClass());
- }
- };
+ assertEquals("peerMembers size", 0, shardBuilder.getPeerAddresses().size());
+ assertEquals("schemaContext", DisableElectionsRaftPolicy.class.getName(), shardBuilder
+ .getDatastoreContext().getShardRaftConfig().getCustomRaftPolicyImplementationClass());
LOG.info("testOnCreateShardWithLocalMemberNotInShardConfig ending");
}
@Test
public void testOnCreateShardWithNoInitialSchemaContext() {
LOG.info("testOnCreateShardWithNoInitialSchemaContext starting");
- new TestKit(getSystem()) {
- {
- ActorRef shardManager = actorFactory
- .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
- .withDispatcher(Dispatchers.DefaultDispatcherId()));
+ final TestKit kit = new TestKit(getSystem());
+ ActorRef shardManager = actorFactory
+ .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
+ .withDispatcher(Dispatchers.DefaultDispatcherId()));
- Shard.Builder shardBuilder = Shard.builder();
+ Shard.Builder shardBuilder = Shard.builder();
- ModuleShardConfiguration config = new ModuleShardConfiguration(URI.create("foo-ns"), "foo-module",
- "foo", null, members("member-1"));
- shardManager.tell(new CreateShard(config, shardBuilder, null), getRef());
+ ModuleShardConfiguration config = new ModuleShardConfiguration(XMLNamespace.of("foo-ns"), "foo-module",
+ "foo", null, members("member-1"));
+ shardManager.tell(new CreateShard(config, shardBuilder, null), kit.getRef());
- expectMsgClass(duration("5 seconds"), Success.class);
+ kit.expectMsgClass(Duration.ofSeconds(5), Success.class);
- SchemaContext schemaContext = TestModel.createTestContext();
- shardManager.tell(new UpdateSchemaContext(schemaContext), ActorRef.noSender());
+ EffectiveModelContext schemaContext = TEST_SCHEMA_CONTEXT;
+ shardManager.tell(new UpdateSchemaContext(schemaContext), ActorRef.noSender());
- shardManager.tell(new FindLocalShard("foo", true), getRef());
+ shardManager.tell(new FindLocalShard("foo", true), kit.getRef());
- expectMsgClass(duration("5 seconds"), LocalShardFound.class);
+ kit.expectMsgClass(Duration.ofSeconds(5), LocalShardFound.class);
- assertSame("schemaContext", schemaContext, shardBuilder.getSchemaContext());
- assertNotNull("schemaContext is null", shardBuilder.getDatastoreContext());
- }
- };
+ assertSame("schemaContext", schemaContext, shardBuilder.getSchemaContext());
+ assertNotNull("schemaContext is null", shardBuilder.getDatastoreContext());
LOG.info("testOnCreateShardWithNoInitialSchemaContext ending");
}
@Test
- public void testGetSnapshot() throws Exception {
+ public void testGetSnapshot() {
LOG.info("testGetSnapshot starting");
TestKit kit = new TestKit(getSystem());
Failure failure = kit.expectMsgClass(Failure.class);
assertEquals("Failure cause type", IllegalStateException.class, failure.cause().getClass());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), ActorRef.noSender());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), ActorRef.noSender());
waitForShardInitialized(shardManager, "shard1", kit);
waitForShardInitialized(shardManager, "shard2", kit);
assertEquals("getType", shardMrgIDSuffix, datastoreSnapshot.getType());
assertNull("Expected null ShardManagerSnapshot", datastoreSnapshot.getShardManagerSnapshot());
- Function<ShardSnapshot, String> shardNameTransformer = ShardSnapshot::getName;
-
assertEquals("Shard names", Sets.newHashSet("shard1", "shard2"), Sets.newHashSet(
- Lists.transform(datastoreSnapshot.getShardSnapshots(), shardNameTransformer)));
+ datastoreSnapshot.getShardSnapshots().stream().map(ShardSnapshot::getName).collect(Collectors.toSet())));
// Add a new replica
datastoreSnapshot = expectMsgClassOrFailure(DatastoreSnapshot.class, kit, "GetSnapshot");
assertEquals("Shard names", Sets.newHashSet("shard1", "shard2", "astronauts"), Sets.newHashSet(
- Lists.transform(datastoreSnapshot.getShardSnapshots(), shardNameTransformer)));
+ Lists.transform(datastoreSnapshot.getShardSnapshots(), ShardSnapshot::getName)));
ShardManagerSnapshot snapshot = datastoreSnapshot.getShardManagerSnapshot();
assertNotNull("Expected ShardManagerSnapshot", snapshot);
}
@Test
- public void testRestoreFromSnapshot() throws Exception {
+ public void testRestoreFromSnapshot() {
LOG.info("testRestoreFromSnapshot starting");
datastoreContextBuilder.shardInitializationTimeout(3, TimeUnit.SECONDS);
.put("astronauts", Collections.<String>emptyList()).build());
ShardManagerSnapshot snapshot =
- new ShardManagerSnapshot(Arrays.asList("shard1", "shard2", "astronauts"), Collections.emptyMap());
+ new ShardManagerSnapshot(Arrays.asList("shard1", "shard2", "astronauts"));
DatastoreSnapshot restoreFromSnapshot = new DatastoreSnapshot(shardMrgIDSuffix, snapshot,
Collections.<ShardSnapshot>emptyList());
TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(newTestShardMgrBuilder(mockConfig)
shardManager.underlyingActor().waitForRecoveryComplete();
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), ActorRef.noSender());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), ActorRef.noSender());
waitForShardInitialized(shardManager, "shard1", kit);
waitForShardInitialized(shardManager, "shard2", kit);
}
@Test
- public void testAddShardReplicaForNonExistentShardConfig() throws Exception {
- new TestKit(getSystem()) {
- {
- ActorRef shardManager = actorFactory
- .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
- .withDispatcher(Dispatchers.DefaultDispatcherId()));
+ public void testAddShardReplicaForNonExistentShardConfig() {
+ final TestKit kit = new TestKit(getSystem());
+ ActorRef shardManager = actorFactory
+ .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
+ .withDispatcher(Dispatchers.DefaultDispatcherId()));
- shardManager.tell(new AddShardReplica("model-inventory"), getRef());
- Status.Failure resp = expectMsgClass(duration("2 seconds"), Status.Failure.class);
+ shardManager.tell(new AddShardReplica("model-inventory"), kit.getRef());
+ Status.Failure resp = kit.expectMsgClass(Duration.ofSeconds(2), Status.Failure.class);
- assertEquals("Failure obtained", true, resp.cause() instanceof IllegalArgumentException);
- }
- };
+ assertTrue("Failure obtained", resp.cause() instanceof IllegalArgumentException);
}
@Test
- public void testAddShardReplica() throws Exception {
+ public void testAddShardReplica() {
LOG.info("testAddShardReplica starting");
MockConfiguration mockConfig = new MockConfiguration(
ImmutableMap.<String, List<String>>builder().put("default", Arrays.asList("member-1", "member-2"))
.withDispatcher(Dispatchers.DefaultDispatcherId()),
shardManagerID);
- new TestKit(system1) {
- {
- newReplicaShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- leaderShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
-
- leaderShardManager.tell(new ActorInitialized(), mockShardLeaderActor);
-
- short leaderVersion = DataStoreVersions.CURRENT_VERSION - 1;
- leaderShardManager.tell(
- new ShardLeaderStateChanged(memberId2, memberId2, mock(DataTree.class), leaderVersion),
- mockShardLeaderActor);
- leaderShardManager.tell(
- new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Leader.name()),
- mockShardLeaderActor);
-
- newReplicaShardManager.underlyingActor().waitForMemberUp();
- leaderShardManager.underlyingActor().waitForMemberUp();
-
- // Have a dummy snapshot to be overwritten by the new data
- // persisted.
- String[] restoredShards = { "default", "people" };
- ShardManagerSnapshot snapshot =
- new ShardManagerSnapshot(Arrays.asList(restoredShards), Collections.emptyMap());
- InMemorySnapshotStore.addSnapshot(shardManagerID, snapshot);
- Uninterruptibles.sleepUninterruptibly(2, TimeUnit.MILLISECONDS);
-
- InMemorySnapshotStore.addSnapshotSavedLatch(shardManagerID);
- InMemorySnapshotStore.addSnapshotDeletedLatch(shardManagerID);
-
- // construct a mock response message
- newReplicaShardManager.tell(new AddShardReplica("astronauts"), getRef());
- AddServer addServerMsg = MessageCollectorActor.expectFirstMatching(mockShardLeaderActor,
- AddServer.class);
- String addServerId = "member-1-shard-astronauts-" + shardMrgIDSuffix;
- assertEquals("AddServer serverId", addServerId, addServerMsg.getNewServerId());
- expectMsgClass(duration("5 seconds"), Status.Success.class);
-
- InMemorySnapshotStore.waitForSavedSnapshot(shardManagerID, ShardManagerSnapshot.class);
- InMemorySnapshotStore.waitForDeletedSnapshot(shardManagerID);
- List<ShardManagerSnapshot> persistedSnapshots = InMemorySnapshotStore.getSnapshots(shardManagerID,
- ShardManagerSnapshot.class);
- assertEquals("Number of snapshots persisted", 1, persistedSnapshots.size());
- ShardManagerSnapshot shardManagerSnapshot = persistedSnapshots.get(0);
- assertEquals("Persisted local shards", Sets.newHashSet("default", "astronauts"),
- Sets.newHashSet(shardManagerSnapshot.getShardList()));
- }
- };
+ final TestKit kit = new TestKit(getSystem());
+ newReplicaShardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ leaderShardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+
+ leaderShardManager.tell(new ActorInitialized(), mockShardLeaderActor);
+
+ short leaderVersion = DataStoreVersions.CURRENT_VERSION - 1;
+ leaderShardManager.tell(
+ new ShardLeaderStateChanged(memberId2, memberId2, mock(DataTree.class), leaderVersion),
+ mockShardLeaderActor);
+ leaderShardManager.tell(
+ new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Leader.name()),
+ mockShardLeaderActor);
+
+ newReplicaShardManager.underlyingActor().waitForMemberUp();
+ leaderShardManager.underlyingActor().waitForMemberUp();
+
+ // Have a dummy snapshot to be overwritten by the new data
+ // persisted.
+ String[] restoredShards = { "default", "people" };
+ ShardManagerSnapshot snapshot =
+ new ShardManagerSnapshot(Arrays.asList(restoredShards));
+ InMemorySnapshotStore.addSnapshot(shardManagerID, snapshot);
+ Uninterruptibles.sleepUninterruptibly(2, TimeUnit.MILLISECONDS);
+
+ InMemorySnapshotStore.addSnapshotSavedLatch(shardManagerID);
+ InMemorySnapshotStore.addSnapshotDeletedLatch(shardManagerID);
+
+ // construct a mock response message
+ newReplicaShardManager.tell(new AddShardReplica("astronauts"), kit.getRef());
+ AddServer addServerMsg = MessageCollectorActor.expectFirstMatching(mockShardLeaderActor,
+ AddServer.class);
+ String addServerId = "member-1-shard-astronauts-" + shardMrgIDSuffix;
+ assertEquals("AddServer serverId", addServerId, addServerMsg.getNewServerId());
+ kit.expectMsgClass(Duration.ofSeconds(5), Status.Success.class);
+
+ InMemorySnapshotStore.waitForSavedSnapshot(shardManagerID, ShardManagerSnapshot.class);
+ InMemorySnapshotStore.waitForDeletedSnapshot(shardManagerID);
+ List<ShardManagerSnapshot> persistedSnapshots = InMemorySnapshotStore.getSnapshots(shardManagerID,
+ ShardManagerSnapshot.class);
+ assertEquals("Number of snapshots persisted", 1, persistedSnapshots.size());
+ ShardManagerSnapshot shardManagerSnapshot = persistedSnapshots.get(0);
+ assertEquals("Persisted local shards", Sets.newHashSet("default", "astronauts"),
+ Sets.newHashSet(shardManagerSnapshot.getShardList()));
LOG.info("testAddShardReplica ending");
}
@Test
- public void testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader() throws Exception {
+ public void testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader() {
LOG.info("testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader starting");
- new TestKit(getSystem()) {
- {
- TestActorRef<TestShardManager> shardManager = actorFactory
- .createTestActor(newPropsShardMgrWithMockShardActor(), shardMgrID);
+ final TestKit kit = new TestKit(getSystem());
+ TestActorRef<TestShardManager> shardManager = actorFactory
+ .createTestActor(newPropsShardMgrWithMockShardActor(), shardMgrID);
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
- String leaderId = "leader-member-shard-default-" + shardMrgIDSuffix;
- AddServerReply addServerReply = new AddServerReply(ServerChangeStatus.ALREADY_EXISTS, null);
- ActorRef leaderShardActor = shardManager.underlyingActor().getContext()
- .actorOf(Props.create(MockRespondActor.class, AddServer.class, addServerReply), leaderId);
+ String leaderId = "leader-member-shard-default-" + shardMrgIDSuffix;
+ AddServerReply addServerReply = new AddServerReply(ServerChangeStatus.ALREADY_EXISTS, null);
+ ActorRef leaderShardActor = shardManager.underlyingActor().getContext()
+ .actorOf(Props.create(MockRespondActor.class, AddServer.class, addServerReply), leaderId);
- MockClusterWrapper.sendMemberUp(shardManager, "leader-member", leaderShardActor.path().toString());
+ MockClusterWrapper.sendMemberUp(shardManager, "leader-member", leaderShardActor.path().toString());
- String newReplicaId = "member-1-shard-default-" + shardMrgIDSuffix;
- shardManager.tell(
- new RoleChangeNotification(newReplicaId, RaftState.Candidate.name(), RaftState.Follower.name()),
- mockShardActor);
- shardManager.tell(
- new ShardLeaderStateChanged(newReplicaId, leaderId, DataStoreVersions.CURRENT_VERSION),
- mockShardActor);
+ String newReplicaId = "member-1-shard-default-" + shardMrgIDSuffix;
+ shardManager.tell(
+ new RoleChangeNotification(newReplicaId, RaftState.Candidate.name(), RaftState.Follower.name()),
+ mockShardActor);
+ shardManager.tell(
+ new ShardLeaderStateChanged(newReplicaId, leaderId, DataStoreVersions.CURRENT_VERSION),
+ mockShardActor);
- shardManager.tell(new AddShardReplica(Shard.DEFAULT_NAME), getRef());
+ shardManager.tell(new AddShardReplica(Shard.DEFAULT_NAME), kit.getRef());
- MessageCollectorActor.expectFirstMatching(leaderShardActor, AddServer.class);
+ MessageCollectorActor.expectFirstMatching(leaderShardActor, AddServer.class);
- Failure resp = expectMsgClass(duration("5 seconds"), Failure.class);
- assertEquals("Failure cause", AlreadyExistsException.class, resp.cause().getClass());
+ Failure resp = kit.expectMsgClass(Duration.ofSeconds(5), Failure.class);
+ assertEquals("Failure cause", AlreadyExistsException.class, resp.cause().getClass());
- shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), getRef());
- expectMsgClass(duration("5 seconds"), LocalShardFound.class);
+ shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), LocalShardFound.class);
- // Send message again to verify previous in progress state is
- // cleared
+ // Send message again to verify previous in progress state is
+ // cleared
- shardManager.tell(new AddShardReplica(Shard.DEFAULT_NAME), getRef());
- resp = expectMsgClass(duration("5 seconds"), Failure.class);
- assertEquals("Failure cause", AlreadyExistsException.class, resp.cause().getClass());
+ shardManager.tell(new AddShardReplica(Shard.DEFAULT_NAME), kit.getRef());
+ resp = kit.expectMsgClass(Duration.ofSeconds(5), Failure.class);
+ assertEquals("Failure cause", AlreadyExistsException.class, resp.cause().getClass());
- // Send message again with an AddServer timeout to verify the
- // pre-existing shard actor isn't terminated.
+ // Send message again with an AddServer timeout to verify the
+ // pre-existing shard actor isn't terminated.
- shardManager.tell(
- newDatastoreContextFactory(
- datastoreContextBuilder.shardLeaderElectionTimeout(100, TimeUnit.MILLISECONDS).build()),
- getRef());
- leaderShardActor.tell(MockRespondActor.CLEAR_RESPONSE, ActorRef.noSender());
- shardManager.tell(new AddShardReplica(Shard.DEFAULT_NAME), getRef());
- expectMsgClass(duration("5 seconds"), Failure.class);
+ shardManager.tell(
+ newDatastoreContextFactory(
+ datastoreContextBuilder.shardLeaderElectionTimeout(100, TimeUnit.MILLISECONDS).build()), kit.getRef());
+ leaderShardActor.tell(MockRespondActor.CLEAR_RESPONSE, ActorRef.noSender());
+ shardManager.tell(new AddShardReplica(Shard.DEFAULT_NAME), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), Failure.class);
- shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), getRef());
- expectMsgClass(duration("5 seconds"), LocalShardFound.class);
- }
- };
+ shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), LocalShardFound.class);
LOG.info("testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader ending");
}
@Test
- public void testAddShardReplicaWithPreExistingLocalReplicaLeader() throws Exception {
+ public void testAddShardReplicaWithPreExistingLocalReplicaLeader() {
LOG.info("testAddShardReplicaWithPreExistingLocalReplicaLeader starting");
- new TestKit(getSystem()) {
- {
- String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
- ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
-
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), mockShardActor);
- shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mock(DataTree.class),
- DataStoreVersions.CURRENT_VERSION), getRef());
- shardManager.tell(
- new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Leader.name()),
- mockShardActor);
-
- shardManager.tell(new AddShardReplica(Shard.DEFAULT_NAME), getRef());
- Failure resp = expectMsgClass(duration("5 seconds"), Failure.class);
- assertEquals("Failure cause", AlreadyExistsException.class, resp.cause().getClass());
-
- shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), getRef());
- expectMsgClass(duration("5 seconds"), LocalShardFound.class);
- }
- };
+ final TestKit kit = new TestKit(getSystem());
+ String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
+ ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
+ shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mock(DataTree.class),
+ DataStoreVersions.CURRENT_VERSION), kit.getRef());
+ shardManager.tell(
+ new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Leader.name()),
+ mockShardActor);
+
+ shardManager.tell(new AddShardReplica(Shard.DEFAULT_NAME), kit.getRef());
+ Failure resp = kit.expectMsgClass(Duration.ofSeconds(5), Failure.class);
+ assertEquals("Failure cause", AlreadyExistsException.class, resp.cause().getClass());
+
+ shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), LocalShardFound.class);
LOG.info("testAddShardReplicaWithPreExistingLocalReplicaLeader ending");
}
@Test
- public void testAddShardReplicaWithAddServerReplyFailure() throws Exception {
+ public void testAddShardReplicaWithAddServerReplyFailure() {
LOG.info("testAddShardReplicaWithAddServerReplyFailure starting");
- new TestKit(getSystem()) {
- {
- TestKit mockShardLeaderKit = new TestKit(getSystem());
+ final TestKit kit = new TestKit(getSystem());
+ final TestKit mockShardLeaderKit = new TestKit(getSystem());
- MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
- .put("astronauts", Arrays.asList("member-2")).build());
+ MockConfiguration mockConfig = new MockConfiguration(
+ ImmutableMap.of("astronauts", Arrays.asList("member-2")));
- ActorRef mockNewReplicaShardActor = newMockShardActor(getSystem(), "astronauts", "member-1");
- final TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(
- newTestShardMgrBuilder(mockConfig).shardActor(mockNewReplicaShardActor).props()
- .withDispatcher(Dispatchers.DefaultDispatcherId()), shardMgrID);
- shardManager.underlyingActor()
- .setMessageInterceptor(newFindPrimaryInterceptor(mockShardLeaderKit.getRef()));
+ ActorRef mockNewReplicaShardActor = newMockShardActor(getSystem(), "astronauts", "member-1");
+ final TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(
+ newTestShardMgrBuilder(mockConfig).shardActor(mockNewReplicaShardActor).props()
+ .withDispatcher(Dispatchers.DefaultDispatcherId()), shardMgrID);
+ shardManager.underlyingActor().setMessageInterceptor(newFindPrimaryInterceptor(mockShardLeaderKit.getRef()));
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
- TestKit terminateWatcher = new TestKit(getSystem());
- terminateWatcher.watch(mockNewReplicaShardActor);
+ TestKit terminateWatcher = new TestKit(getSystem());
+ terminateWatcher.watch(mockNewReplicaShardActor);
- shardManager.tell(new AddShardReplica("astronauts"), getRef());
+ shardManager.tell(new AddShardReplica("astronauts"), kit.getRef());
- AddServer addServerMsg = mockShardLeaderKit.expectMsgClass(AddServer.class);
- assertEquals("AddServer serverId", "member-1-shard-astronauts-" + shardMrgIDSuffix,
- addServerMsg.getNewServerId());
- mockShardLeaderKit.reply(new AddServerReply(ServerChangeStatus.TIMEOUT, null));
+ AddServer addServerMsg = mockShardLeaderKit.expectMsgClass(AddServer.class);
+ assertEquals("AddServer serverId", "member-1-shard-astronauts-" + shardMrgIDSuffix,
+ addServerMsg.getNewServerId());
+ mockShardLeaderKit.reply(new AddServerReply(ServerChangeStatus.TIMEOUT, null));
- Failure failure = expectMsgClass(duration("5 seconds"), Failure.class);
- assertEquals("Failure cause", TimeoutException.class, failure.cause().getClass());
+ Failure failure = kit.expectMsgClass(Duration.ofSeconds(5), Failure.class);
+ assertEquals("Failure cause", TimeoutException.class, failure.cause().getClass());
- shardManager.tell(new FindLocalShard("astronauts", false), getRef());
- expectMsgClass(duration("5 seconds"), LocalShardNotFound.class);
+ shardManager.tell(new FindLocalShard("astronauts", false), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), LocalShardNotFound.class);
- terminateWatcher.expectTerminated(mockNewReplicaShardActor);
+ terminateWatcher.expectTerminated(mockNewReplicaShardActor);
- shardManager.tell(new AddShardReplica("astronauts"), getRef());
- mockShardLeaderKit.expectMsgClass(AddServer.class);
- mockShardLeaderKit.reply(new AddServerReply(ServerChangeStatus.NO_LEADER, null));
- failure = expectMsgClass(duration("5 seconds"), Failure.class);
- assertEquals("Failure cause", NoShardLeaderException.class, failure.cause().getClass());
- }
- };
+ shardManager.tell(new AddShardReplica("astronauts"), kit.getRef());
+ mockShardLeaderKit.expectMsgClass(AddServer.class);
+ mockShardLeaderKit.reply(new AddServerReply(ServerChangeStatus.NO_LEADER, null));
+ failure = kit.expectMsgClass(Duration.ofSeconds(5), Failure.class);
+ assertEquals("Failure cause", NoShardLeaderException.class, failure.cause().getClass());
LOG.info("testAddShardReplicaWithAddServerReplyFailure ending");
}
@Test
- public void testAddShardReplicaWithAlreadyInProgress() throws Exception {
+ public void testAddShardReplicaWithAlreadyInProgress() {
testServerChangeWhenAlreadyInProgress("astronauts", new AddShardReplica("astronauts"),
AddServer.class, new AddShardReplica("astronauts"));
}
@Test
- public void testAddShardReplicaWithFindPrimaryTimeout() throws Exception {
+ public void testAddShardReplicaWithFindPrimaryTimeout() {
LOG.info("testAddShardReplicaWithFindPrimaryTimeout starting");
datastoreContextBuilder.shardInitializationTimeout(100, TimeUnit.MILLISECONDS);
- new TestKit(getSystem()) {
- {
- MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
- .put("astronauts", Arrays.asList("member-2")).build());
+ final TestKit kit = new TestKit(getSystem());
+ MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.of("astronauts", Arrays.asList("member-2")));
- final ActorRef newReplicaShardManager = actorFactory
- .createActor(newTestShardMgrBuilder(mockConfig).shardActor(mockShardActor).props()
- .withDispatcher(Dispatchers.DefaultDispatcherId()), shardMgrID);
+ final ActorRef newReplicaShardManager = actorFactory
+ .createActor(newTestShardMgrBuilder(mockConfig).shardActor(mockShardActor).props()
+ .withDispatcher(Dispatchers.DefaultDispatcherId()), shardMgrID);
- newReplicaShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- MockClusterWrapper.sendMemberUp(newReplicaShardManager, "member-2",
- AddressFromURIString.parse("akka://non-existent@127.0.0.1:5").toString());
+ newReplicaShardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ MockClusterWrapper.sendMemberUp(newReplicaShardManager, "member-2",
+ AddressFromURIString.parse("akka://non-existent@127.0.0.1:5").toString());
- newReplicaShardManager.tell(new AddShardReplica("astronauts"), getRef());
- Status.Failure resp = expectMsgClass(duration("5 seconds"), Status.Failure.class);
- assertEquals("Failure obtained", true, resp.cause() instanceof RuntimeException);
- }
- };
+ newReplicaShardManager.tell(new AddShardReplica("astronauts"), kit.getRef());
+ Status.Failure resp = kit.expectMsgClass(Duration.ofSeconds(5), Status.Failure.class);
+ assertTrue("Failure obtained", resp.cause() instanceof RuntimeException);
LOG.info("testAddShardReplicaWithFindPrimaryTimeout ending");
}
@Test
- public void testRemoveShardReplicaForNonExistentShard() throws Exception {
- new TestKit(getSystem()) {
- {
- ActorRef shardManager = actorFactory
- .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
- .withDispatcher(Dispatchers.DefaultDispatcherId()));
-
- shardManager.tell(new RemoveShardReplica("model-inventory", MEMBER_1), getRef());
- Status.Failure resp = expectMsgClass(duration("10 seconds"), Status.Failure.class);
- assertEquals("Failure obtained", true, resp.cause() instanceof PrimaryNotFoundException);
- }
- };
+ public void testRemoveShardReplicaForNonExistentShard() {
+ final TestKit kit = new TestKit(getSystem());
+ ActorRef shardManager = actorFactory
+ .createActor(newShardMgrProps(new ConfigurationImpl(new EmptyModuleShardConfigProvider()))
+ .withDispatcher(Dispatchers.DefaultDispatcherId()));
+
+ shardManager.tell(new RemoveShardReplica("model-inventory", MEMBER_1), kit.getRef());
+ Status.Failure resp = kit.expectMsgClass(Duration.ofSeconds(10), Status.Failure.class);
+ assertTrue("Failure obtained", resp.cause() instanceof PrimaryNotFoundException);
}
@Test
/**
* Primary is Local.
*/
- public void testRemoveShardReplicaLocal() throws Exception {
- new TestKit(getSystem()) {
- {
- String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
-
- final ActorRef respondActor = actorFactory.createActor(Props.create(MockRespondActor.class,
- RemoveServer.class, new RemoveServerReply(ServerChangeStatus.OK, null)), memberId);
-
- ActorRef shardManager = getSystem().actorOf(newPropsShardMgrWithMockShardActor(respondActor));
-
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), respondActor);
- shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mock(DataTree.class),
- DataStoreVersions.CURRENT_VERSION), getRef());
- shardManager.tell(
- new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Leader.name()),
- respondActor);
-
- shardManager.tell(new RemoveShardReplica(Shard.DEFAULT_NAME, MEMBER_1), getRef());
- final RemoveServer removeServer = MessageCollectorActor.expectFirstMatching(respondActor,
- RemoveServer.class);
- assertEquals(ShardIdentifier.create("default", MEMBER_1, shardMrgIDSuffix).toString(),
- removeServer.getServerId());
- expectMsgClass(duration("5 seconds"), Success.class);
- }
- };
+ public void testRemoveShardReplicaLocal() {
+ final TestKit kit = new TestKit(getSystem());
+ String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
+
+ final ActorRef respondActor = actorFactory.createActor(Props.create(MockRespondActor.class,
+ RemoveServer.class, new RemoveServerReply(ServerChangeStatus.OK, null)), memberId);
+
+ ActorRef shardManager = getSystem().actorOf(newPropsShardMgrWithMockShardActor(respondActor));
+
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), respondActor);
+ shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mock(DataTree.class),
+ DataStoreVersions.CURRENT_VERSION), kit.getRef());
+ shardManager.tell(
+ new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Leader.name()),
+ respondActor);
+
+ shardManager.tell(new RemoveShardReplica(Shard.DEFAULT_NAME, MEMBER_1), kit.getRef());
+ final RemoveServer removeServer = MessageCollectorActor.expectFirstMatching(respondActor,
+ RemoveServer.class);
+ assertEquals(ShardIdentifier.create("default", MEMBER_1, shardMrgIDSuffix).toString(),
+ removeServer.getServerId());
+ kit.expectMsgClass(Duration.ofSeconds(5), Success.class);
}
@Test
- public void testRemoveShardReplicaRemote() throws Exception {
+ public void testRemoveShardReplicaRemote() {
MockConfiguration mockConfig = new MockConfiguration(
ImmutableMap.<String, List<String>>builder().put("default", Arrays.asList("member-1", "member-2"))
.put("astronauts", Arrays.asList("member-1")).build());
LOG.error("Forwarding actor : {}", actorRef);
- new TestKit(system1) {
- {
- newReplicaShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- leaderShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
-
- leaderShardManager.tell(new ActorInitialized(), mockShardLeaderActor);
- newReplicaShardManager.tell(new ActorInitialized(), mockShardLeaderActor);
-
- short leaderVersion = DataStoreVersions.CURRENT_VERSION - 1;
- leaderShardManager.tell(
- new ShardLeaderStateChanged(memberId2, memberId2, mock(DataTree.class), leaderVersion),
- mockShardLeaderActor);
- leaderShardManager.tell(
- new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Leader.name()),
- mockShardLeaderActor);
-
- String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
- newReplicaShardManager.tell(
- new ShardLeaderStateChanged(memberId1, memberId2, mock(DataTree.class), leaderVersion),
- mockShardActor);
- newReplicaShardManager.tell(
- new RoleChangeNotification(memberId1, RaftState.Candidate.name(), RaftState.Follower.name()),
- mockShardActor);
-
- newReplicaShardManager.underlyingActor().waitForMemberUp();
- leaderShardManager.underlyingActor().waitForMemberUp();
-
- // construct a mock response message
- newReplicaShardManager.tell(new RemoveShardReplica("default", MEMBER_1), getRef());
- RemoveServer removeServer = MessageCollectorActor.expectFirstMatching(mockShardLeaderActor,
- RemoveServer.class);
- String removeServerId = ShardIdentifier.create("default", MEMBER_1, shardMrgIDSuffix).toString();
- assertEquals("RemoveServer serverId", removeServerId, removeServer.getServerId());
- expectMsgClass(duration("5 seconds"), Status.Success.class);
- }
- };
+ final TestKit kit = new TestKit(getSystem());
+ newReplicaShardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ leaderShardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+
+ leaderShardManager.tell(new ActorInitialized(), mockShardLeaderActor);
+ newReplicaShardManager.tell(new ActorInitialized(), mockShardLeaderActor);
+
+ short leaderVersion = DataStoreVersions.CURRENT_VERSION - 1;
+ leaderShardManager.tell(
+ new ShardLeaderStateChanged(memberId2, memberId2, mock(DataTree.class), leaderVersion),
+ mockShardLeaderActor);
+ leaderShardManager.tell(
+ new RoleChangeNotification(memberId2, RaftState.Candidate.name(), RaftState.Leader.name()),
+ mockShardLeaderActor);
+
+ String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
+ newReplicaShardManager.tell(
+ new ShardLeaderStateChanged(memberId1, memberId2, mock(DataTree.class), leaderVersion),
+ mockShardActor);
+ newReplicaShardManager.tell(
+ new RoleChangeNotification(memberId1, RaftState.Candidate.name(), RaftState.Follower.name()),
+ mockShardActor);
+
+ newReplicaShardManager.underlyingActor().waitForMemberUp();
+ leaderShardManager.underlyingActor().waitForMemberUp();
+
+ // construct a mock response message
+ newReplicaShardManager.tell(new RemoveShardReplica("default", MEMBER_1), kit.getRef());
+ RemoveServer removeServer = MessageCollectorActor.expectFirstMatching(mockShardLeaderActor,
+ RemoveServer.class);
+ String removeServerId = ShardIdentifier.create("default", MEMBER_1, shardMrgIDSuffix).toString();
+ assertEquals("RemoveServer serverId", removeServerId, removeServer.getServerId());
+ kit.expectMsgClass(Duration.ofSeconds(5), Status.Success.class);
}
@Test
- public void testRemoveShardReplicaWhenAnotherRemoveShardReplicaAlreadyInProgress() throws Exception {
+ public void testRemoveShardReplicaWhenAnotherRemoveShardReplicaAlreadyInProgress() {
testServerChangeWhenAlreadyInProgress("astronauts", new RemoveShardReplica("astronauts", MEMBER_2),
RemoveServer.class, new RemoveShardReplica("astronauts", MEMBER_3));
}
@Test
- public void testRemoveShardReplicaWhenAddShardReplicaAlreadyInProgress() throws Exception {
+ public void testRemoveShardReplicaWhenAddShardReplicaAlreadyInProgress() {
testServerChangeWhenAlreadyInProgress("astronauts", new AddShardReplica("astronauts"),
AddServer.class, new RemoveShardReplica("astronauts", MEMBER_2));
}
public void testServerChangeWhenAlreadyInProgress(final String shardName, final Object firstServerChange,
final Class<?> firstForwardedServerChangeClass,
- final Object secondServerChange) throws Exception {
- new TestKit(getSystem()) {
- {
- TestKit mockShardLeaderKit = new TestKit(getSystem());
- final TestKit secondRequestKit = new TestKit(getSystem());
+ final Object secondServerChange) {
+ final TestKit kit = new TestKit(getSystem());
+ final TestKit mockShardLeaderKit = new TestKit(getSystem());
+ final TestKit secondRequestKit = new TestKit(getSystem());
- MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
- .put(shardName, Arrays.asList("member-2")).build());
+ MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
+ .put(shardName, Arrays.asList("member-2")).build());
- final TestActorRef<TestShardManager> shardManager = TestActorRef.create(getSystem(),
- newTestShardMgrBuilder().configuration(mockConfig).shardActor(mockShardActor)
- .cluster(new MockClusterWrapper()).props()
- .withDispatcher(Dispatchers.DefaultDispatcherId()),
- shardMgrID);
+ final TestActorRef<TestShardManager> shardManager = TestActorRef.create(getSystem(),
+ newTestShardMgrBuilder().configuration(mockConfig).shardActor(mockShardActor)
+ .cluster(new MockClusterWrapper()).props()
+ .withDispatcher(Dispatchers.DefaultDispatcherId()),
+ shardMgrID);
- shardManager.underlyingActor()
- .setMessageInterceptor(newFindPrimaryInterceptor(mockShardLeaderKit.getRef()));
+ shardManager.underlyingActor().setMessageInterceptor(newFindPrimaryInterceptor(mockShardLeaderKit.getRef()));
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
- shardManager.tell(firstServerChange, getRef());
+ shardManager.tell(firstServerChange, kit.getRef());
- mockShardLeaderKit.expectMsgClass(firstForwardedServerChangeClass);
+ mockShardLeaderKit.expectMsgClass(firstForwardedServerChangeClass);
- shardManager.tell(secondServerChange, secondRequestKit.getRef());
+ shardManager.tell(secondServerChange, secondRequestKit.getRef());
- secondRequestKit.expectMsgClass(duration("5 seconds"), Failure.class);
- }
- };
+ secondRequestKit.expectMsgClass(Duration.ofSeconds(5), Failure.class);
}
@Test
- public void testServerRemovedShardActorNotRunning() throws Exception {
+ public void testServerRemovedShardActorNotRunning() {
LOG.info("testServerRemovedShardActorNotRunning starting");
- new TestKit(getSystem()) {
- {
- MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
- .put("default", Arrays.asList("member-1", "member-2"))
- .put("astronauts", Arrays.asList("member-2"))
- .put("people", Arrays.asList("member-1", "member-2")).build());
-
- TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(
- newShardMgrProps(mockConfig).withDispatcher(Dispatchers.DefaultDispatcherId()));
-
- shardManager.underlyingActor().waitForRecoveryComplete();
- shardManager.tell(new FindLocalShard("people", false), getRef());
- expectMsgClass(duration("5 seconds"), NotInitializedException.class);
-
- shardManager.tell(new FindLocalShard("default", false), getRef());
- expectMsgClass(duration("5 seconds"), NotInitializedException.class);
-
- // Removed the default shard replica from member-1
- ShardIdentifier.Builder builder = new ShardIdentifier.Builder();
- ShardIdentifier shardId = builder.shardName("default").memberName(MEMBER_1).type(shardMrgIDSuffix)
- .build();
- shardManager.tell(new ServerRemoved(shardId.toString()), getRef());
-
- shardManager.underlyingActor().verifySnapshotPersisted(Sets.newHashSet("people"));
- }
- };
+ final TestKit kit = new TestKit(getSystem());
+ MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
+ .put("default", Arrays.asList("member-1", "member-2"))
+ .put("astronauts", Arrays.asList("member-2"))
+ .put("people", Arrays.asList("member-1", "member-2")).build());
+
+ TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(
+ newShardMgrProps(mockConfig).withDispatcher(Dispatchers.DefaultDispatcherId()));
+
+ shardManager.underlyingActor().waitForRecoveryComplete();
+ shardManager.tell(new FindLocalShard("people", false), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), NotInitializedException.class);
+
+ shardManager.tell(new FindLocalShard("default", false), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), NotInitializedException.class);
+
+ // Removed the default shard replica from member-1
+ ShardIdentifier.Builder builder = new ShardIdentifier.Builder();
+ ShardIdentifier shardId = builder.shardName("default").memberName(MEMBER_1).type(shardMrgIDSuffix)
+ .build();
+ shardManager.tell(new ServerRemoved(shardId.toString()), kit.getRef());
+
+ shardManager.underlyingActor().verifySnapshotPersisted(Sets.newHashSet("people"));
LOG.info("testServerRemovedShardActorNotRunning ending");
}
@Test
- public void testServerRemovedShardActorRunning() throws Exception {
+ public void testServerRemovedShardActorRunning() {
LOG.info("testServerRemovedShardActorRunning starting");
- new TestKit(getSystem()) {
- {
- MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
- .put("default", Arrays.asList("member-1", "member-2"))
- .put("astronauts", Arrays.asList("member-2"))
- .put("people", Arrays.asList("member-1", "member-2")).build());
+ final TestKit kit = new TestKit(getSystem());
+ MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
+ .put("default", Arrays.asList("member-1", "member-2"))
+ .put("astronauts", Arrays.asList("member-2"))
+ .put("people", Arrays.asList("member-1", "member-2")).build());
- String shardId = ShardIdentifier.create("default", MEMBER_1, shardMrgIDSuffix).toString();
- ActorRef shard = actorFactory.createActor(MessageCollectorActor.props(), shardId);
+ String shardId = ShardIdentifier.create("default", MEMBER_1, shardMrgIDSuffix).toString();
+ ActorRef shard = actorFactory.createActor(MessageCollectorActor.props(), shardId);
- TestActorRef<TestShardManager> shardManager = actorFactory
- .createTestActor(newTestShardMgrBuilder(mockConfig).addShardActor("default", shard).props()
- .withDispatcher(Dispatchers.DefaultDispatcherId()));
+ TestActorRef<TestShardManager> shardManager = actorFactory
+ .createTestActor(newTestShardMgrBuilder(mockConfig).addShardActor("default", shard).props()
+ .withDispatcher(Dispatchers.DefaultDispatcherId()));
- shardManager.underlyingActor().waitForRecoveryComplete();
+ shardManager.underlyingActor().waitForRecoveryComplete();
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), shard);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), shard);
- waitForShardInitialized(shardManager, "people", this);
- waitForShardInitialized(shardManager, "default", this);
+ waitForShardInitialized(shardManager, "people", kit);
+ waitForShardInitialized(shardManager, "default", kit);
- // Removed the default shard replica from member-1
- shardManager.tell(new ServerRemoved(shardId), getRef());
+ // Removed the default shard replica from member-1
+ shardManager.tell(new ServerRemoved(shardId), kit.getRef());
- shardManager.underlyingActor().verifySnapshotPersisted(Sets.newHashSet("people"));
+ shardManager.underlyingActor().verifySnapshotPersisted(Sets.newHashSet("people"));
- MessageCollectorActor.expectFirstMatching(shard, Shutdown.class);
- }
- };
+ MessageCollectorActor.expectFirstMatching(shard, Shutdown.class);
LOG.info("testServerRemovedShardActorRunning ending");
}
@Test
- public void testShardPersistenceWithRestoredData() throws Exception {
+ public void testShardPersistenceWithRestoredData() {
LOG.info("testShardPersistenceWithRestoredData starting");
- new TestKit(getSystem()) {
- {
- MockConfiguration mockConfig =
- new MockConfiguration(ImmutableMap.<String, List<String>>builder()
- .put("default", Arrays.asList("member-1", "member-2"))
- .put("astronauts", Arrays.asList("member-2"))
- .put("people", Arrays.asList("member-1", "member-2")).build());
- String[] restoredShards = {"default", "astronauts"};
- ShardManagerSnapshot snapshot =
- new ShardManagerSnapshot(Arrays.asList(restoredShards), Collections.emptyMap());
- InMemorySnapshotStore.addSnapshot("shard-manager-" + shardMrgIDSuffix, snapshot);
-
- // create shardManager to come up with restored data
- TestActorRef<TestShardManager> newRestoredShardManager = actorFactory.createTestActor(
- newShardMgrProps(mockConfig).withDispatcher(Dispatchers.DefaultDispatcherId()));
-
- newRestoredShardManager.underlyingActor().waitForRecoveryComplete();
-
- newRestoredShardManager.tell(new FindLocalShard("people", false), getRef());
- LocalShardNotFound notFound = expectMsgClass(duration("5 seconds"), LocalShardNotFound.class);
- assertEquals("for uninitialized shard", "people", notFound.getShardName());
-
- // Verify a local shard is created for the restored shards,
- // although we expect a NotInitializedException for the shards
- // as the actor initialization
- // message is not sent for them
- newRestoredShardManager.tell(new FindLocalShard("default", false), getRef());
- expectMsgClass(duration("5 seconds"), NotInitializedException.class);
-
- newRestoredShardManager.tell(new FindLocalShard("astronauts", false), getRef());
- expectMsgClass(duration("5 seconds"), NotInitializedException.class);
- }
- };
+ final TestKit kit = new TestKit(getSystem());
+ MockConfiguration mockConfig =
+ new MockConfiguration(ImmutableMap.<String, List<String>>builder()
+ .put("default", Arrays.asList("member-1", "member-2"))
+ .put("astronauts", Arrays.asList("member-2"))
+ .put("people", Arrays.asList("member-1", "member-2")).build());
+ String[] restoredShards = {"default", "astronauts"};
+ ShardManagerSnapshot snapshot =
+ new ShardManagerSnapshot(Arrays.asList(restoredShards));
+ InMemorySnapshotStore.addSnapshot("shard-manager-" + shardMrgIDSuffix, snapshot);
+
+ // create shardManager to come up with restored data
+ TestActorRef<TestShardManager> newRestoredShardManager = actorFactory.createTestActor(
+ newShardMgrProps(mockConfig).withDispatcher(Dispatchers.DefaultDispatcherId()));
+
+ newRestoredShardManager.underlyingActor().waitForRecoveryComplete();
+
+ newRestoredShardManager.tell(new FindLocalShard("people", false), kit.getRef());
+ LocalShardNotFound notFound = kit.expectMsgClass(Duration.ofSeconds(5), LocalShardNotFound.class);
+ assertEquals("for uninitialized shard", "people", notFound.getShardName());
+
+ // Verify a local shard is created for the restored shards,
+ // although we expect a NotInitializedException for the shards
+ // as the actor initialization
+ // message is not sent for them
+ newRestoredShardManager.tell(new FindLocalShard("default", false), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), NotInitializedException.class);
+
+ newRestoredShardManager.tell(new FindLocalShard("astronauts", false), kit.getRef());
+ kit.expectMsgClass(Duration.ofSeconds(5), NotInitializedException.class);
LOG.info("testShardPersistenceWithRestoredData ending");
}
@Test
public void testShutDown() throws Exception {
LOG.info("testShutDown starting");
- new TestKit(getSystem()) {
- {
- MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
- .put("shard1", Arrays.asList("member-1")).put("shard2", Arrays.asList("member-1")).build());
+ final TestKit kit = new TestKit(getSystem());
+ MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder()
+ .put("shard1", Arrays.asList("member-1")).put("shard2", Arrays.asList("member-1")).build());
- String shardId1 = ShardIdentifier.create("shard1", MEMBER_1, shardMrgIDSuffix).toString();
- ActorRef shard1 = actorFactory.createActor(MessageCollectorActor.props(), shardId1);
+ String shardId1 = ShardIdentifier.create("shard1", MEMBER_1, shardMrgIDSuffix).toString();
+ ActorRef shard1 = actorFactory.createActor(MessageCollectorActor.props(), shardId1);
- String shardId2 = ShardIdentifier.create("shard2", MEMBER_1, shardMrgIDSuffix).toString();
- ActorRef shard2 = actorFactory.createActor(MessageCollectorActor.props(), shardId2);
+ String shardId2 = ShardIdentifier.create("shard2", MEMBER_1, shardMrgIDSuffix).toString();
+ ActorRef shard2 = actorFactory.createActor(MessageCollectorActor.props(), shardId2);
- ActorRef shardManager = actorFactory.createActor(newTestShardMgrBuilder(mockConfig)
- .addShardActor("shard1", shard1).addShardActor("shard2", shard2).props());
+ ActorRef shardManager = actorFactory.createActor(newTestShardMgrBuilder(mockConfig)
+ .addShardActor("shard1", shard1).addShardActor("shard2", shard2).props());
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), shard1);
- shardManager.tell(new ActorInitialized(), shard2);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), shard1);
+ shardManager.tell(new ActorInitialized(), shard2);
- FiniteDuration duration = FiniteDuration.create(5, TimeUnit.SECONDS);
- Future<Boolean> stopFuture = Patterns.gracefulStop(shardManager, duration, Shutdown.INSTANCE);
+ FiniteDuration duration = FiniteDuration.create(5, TimeUnit.SECONDS);
+ Future<Boolean> stopFuture = Patterns.gracefulStop(shardManager, duration, Shutdown.INSTANCE);
- MessageCollectorActor.expectFirstMatching(shard1, Shutdown.class);
- MessageCollectorActor.expectFirstMatching(shard2, Shutdown.class);
+ MessageCollectorActor.expectFirstMatching(shard1, Shutdown.class);
+ MessageCollectorActor.expectFirstMatching(shard2, Shutdown.class);
- try {
- Await.ready(stopFuture, FiniteDuration.create(500, TimeUnit.MILLISECONDS));
- fail("ShardManager actor stopped without waiting for the Shards to be stopped");
- } catch (TimeoutException e) {
- // expected
- }
+ try {
+ Await.ready(stopFuture, FiniteDuration.create(500, TimeUnit.MILLISECONDS));
+ fail("ShardManager actor stopped without waiting for the Shards to be stopped");
+ } catch (TimeoutException e) {
+ // expected
+ }
- actorFactory.killActor(shard1, this);
- actorFactory.killActor(shard2, this);
+ actorFactory.killActor(shard1, kit);
+ actorFactory.killActor(shard2, kit);
- Boolean stopped = Await.result(stopFuture, duration);
- assertEquals("Stopped", Boolean.TRUE, stopped);
- }
- };
+ Boolean stopped = Await.result(stopFuture, duration);
+ assertEquals("Stopped", Boolean.TRUE, stopped);
LOG.info("testShutDown ending");
}
@Test
- public void testChangeServersVotingStatus() throws Exception {
- new TestKit(getSystem()) {
- {
- String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
-
- ActorRef respondActor = actorFactory
- .createActor(Props.create(MockRespondActor.class, ChangeServersVotingStatus.class,
- new ServerChangeReply(ServerChangeStatus.OK, null)), memberId);
-
- ActorRef shardManager = getSystem().actorOf(newPropsShardMgrWithMockShardActor(respondActor));
-
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), respondActor);
- shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mock(DataTree.class),
- DataStoreVersions.CURRENT_VERSION), getRef());
- shardManager.tell(
- new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Leader.name()),
- respondActor);
-
- shardManager.tell(
- new ChangeShardMembersVotingStatus("default", ImmutableMap.of("member-2", Boolean.TRUE)),
- getRef());
-
- ChangeServersVotingStatus actualChangeStatusMsg = MessageCollectorActor
- .expectFirstMatching(respondActor, ChangeServersVotingStatus.class);
- assertEquals("ChangeServersVotingStatus map", actualChangeStatusMsg.getServerVotingStatusMap(),
- ImmutableMap.of(ShardIdentifier
- .create("default", MemberName.forName("member-2"), shardMrgIDSuffix).toString(),
- Boolean.TRUE));
-
- expectMsgClass(duration("5 seconds"), Success.class);
- }
- };
+ public void testChangeServersVotingStatus() {
+ final TestKit kit = new TestKit(getSystem());
+ String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
+
+ ActorRef respondActor = actorFactory
+ .createActor(Props.create(MockRespondActor.class, ChangeServersVotingStatus.class,
+ new ServerChangeReply(ServerChangeStatus.OK, null)), memberId);
+
+ ActorRef shardManager = getSystem().actorOf(newPropsShardMgrWithMockShardActor(respondActor));
+
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), respondActor);
+ shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, mock(DataTree.class),
+ DataStoreVersions.CURRENT_VERSION), kit.getRef());
+ shardManager.tell(
+ new RoleChangeNotification(memberId, RaftState.Candidate.name(), RaftState.Leader.name()),
+ respondActor);
+
+ shardManager.tell(
+ new ChangeShardMembersVotingStatus("default", ImmutableMap.of("member-2", Boolean.TRUE)), kit.getRef());
+
+ ChangeServersVotingStatus actualChangeStatusMsg = MessageCollectorActor
+ .expectFirstMatching(respondActor, ChangeServersVotingStatus.class);
+ assertEquals("ChangeServersVotingStatus map", actualChangeStatusMsg.getServerVotingStatusMap(),
+ ImmutableMap.of(ShardIdentifier
+ .create("default", MemberName.forName("member-2"), shardMrgIDSuffix).toString(),
+ Boolean.TRUE));
+
+ kit.expectMsgClass(Duration.ofSeconds(5), Success.class);
}
@Test
- public void testChangeServersVotingStatusWithNoLeader() throws Exception {
- new TestKit(getSystem()) {
- {
- String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
+ public void testChangeServersVotingStatusWithNoLeader() {
+ final TestKit kit = new TestKit(getSystem());
+ String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
- ActorRef respondActor = actorFactory
- .createActor(Props.create(MockRespondActor.class, ChangeServersVotingStatus.class,
- new ServerChangeReply(ServerChangeStatus.NO_LEADER, null)), memberId);
+ ActorRef respondActor = actorFactory
+ .createActor(Props.create(MockRespondActor.class, ChangeServersVotingStatus.class,
+ new ServerChangeReply(ServerChangeStatus.NO_LEADER, null)), memberId);
- ActorRef shardManager = getSystem().actorOf(newPropsShardMgrWithMockShardActor(respondActor));
+ ActorRef shardManager = getSystem().actorOf(newPropsShardMgrWithMockShardActor(respondActor));
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
- shardManager.tell(new ActorInitialized(), respondActor);
- shardManager.tell(new RoleChangeNotification(memberId, null, RaftState.Follower.name()), respondActor);
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), respondActor);
+ shardManager.tell(new RoleChangeNotification(memberId, null, RaftState.Follower.name()), respondActor);
- shardManager.tell(
- new ChangeShardMembersVotingStatus("default", ImmutableMap.of("member-2", Boolean.TRUE)),
- getRef());
+ shardManager.tell(
+ new ChangeShardMembersVotingStatus("default", ImmutableMap.of("member-2", Boolean.TRUE)), kit.getRef());
- MessageCollectorActor.expectFirstMatching(respondActor, ChangeServersVotingStatus.class);
+ MessageCollectorActor.expectFirstMatching(respondActor, ChangeServersVotingStatus.class);
- Status.Failure resp = expectMsgClass(duration("5 seconds"), Status.Failure.class);
- assertEquals("Failure resposnse", true, resp.cause() instanceof NoShardLeaderException);
- }
- };
+ Status.Failure resp = kit.expectMsgClass(Duration.ofSeconds(5), Status.Failure.class);
+ assertTrue("Failure resposnse", resp.cause() instanceof NoShardLeaderException);
+ }
+
+ @SuppressWarnings("unchecked")
+ @Test
+ public void testRegisterForShardLeaderChanges() {
+ LOG.info("testRegisterForShardLeaderChanges starting");
+
+ final String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
+ final String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
+ final TestKit kit = new TestKit(getSystem());
+ final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
+
+ shardManager.tell(new UpdateSchemaContext(TEST_SCHEMA_CONTEXT), kit.getRef());
+ shardManager.tell(new ActorInitialized(), mockShardActor);
+
+ final Consumer<String> mockCallback = mock(Consumer.class);
+ shardManager.tell(new RegisterForShardAvailabilityChanges(mockCallback), kit.getRef());
+
+ final Success reply = kit.expectMsgClass(Duration.ofSeconds(5), Success.class);
+ final Registration reg = (Registration) reply.status();
+
+ final DataTree mockDataTree = mock(DataTree.class);
+ shardManager.tell(new ShardLeaderStateChanged(memberId1, memberId1, mockDataTree,
+ DataStoreVersions.CURRENT_VERSION), mockShardActor);
+
+ verify(mockCallback, timeout(5000)).accept("default");
+
+ reset(mockCallback);
+ shardManager.tell(new ShardLeaderStateChanged(memberId1, memberId1, mockDataTree,
+ DataStoreVersions.CURRENT_VERSION), mockShardActor);
+
+ Uninterruptibles.sleepUninterruptibly(500, TimeUnit.MILLISECONDS);
+ verifyNoMoreInteractions(mockCallback);
+
+ shardManager.tell(new ShardLeaderStateChanged(memberId1, null, mockDataTree,
+ DataStoreVersions.CURRENT_VERSION), mockShardActor);
+
+ verify(mockCallback, timeout(5000)).accept("default");
+
+ reset(mockCallback);
+ shardManager.tell(new ShardLeaderStateChanged(memberId1, memberId2, mockDataTree,
+ DataStoreVersions.CURRENT_VERSION), mockShardActor);
+
+ verify(mockCallback, timeout(5000)).accept("default");
+
+ reset(mockCallback);
+ reg.close();
+
+ shardManager.tell(new ShardLeaderStateChanged(memberId1, memberId1, mockDataTree,
+ DataStoreVersions.CURRENT_VERSION), mockShardActor);
+
+ Uninterruptibles.sleepUninterruptibly(500, TimeUnit.MILLISECONDS);
+ verifyNoMoreInteractions(mockCallback);
+
+ LOG.info("testRegisterForShardLeaderChanges ending");
}
public static class TestShardManager extends ShardManager {
}
void waitForRecoveryComplete() {
- assertEquals("Recovery complete", true,
+ assertTrue("Recovery complete",
Uninterruptibles.awaitUninterruptibly(recoveryComplete, 5, TimeUnit.SECONDS));
}
public void waitForMemberUp() {
- assertEquals("MemberUp received", true,
+ assertTrue("MemberUp received",
Uninterruptibles.awaitUninterruptibly(memberUpReceived, 5, TimeUnit.SECONDS));
memberUpReceived = new CountDownLatch(1);
}
void waitForMemberRemoved() {
- assertEquals("MemberRemoved received", true,
+ assertTrue("MemberRemoved received",
Uninterruptibles.awaitUninterruptibly(memberRemovedReceived, 5, TimeUnit.SECONDS));
memberRemovedReceived = new CountDownLatch(1);
}
void waitForUnreachableMember() {
- assertEquals("UnreachableMember received", true,
- Uninterruptibles.awaitUninterruptibly(memberUnreachableReceived, 5, TimeUnit.SECONDS
- ));
+ assertTrue("UnreachableMember received",
+ Uninterruptibles.awaitUninterruptibly(memberUnreachableReceived, 5, TimeUnit.SECONDS));
memberUnreachableReceived = new CountDownLatch(1);
}
void waitForReachableMember() {
- assertEquals("ReachableMember received", true,
+ assertTrue("ReachableMember received",
Uninterruptibles.awaitUninterruptibly(memberReachableReceived, 5, TimeUnit.SECONDS));
memberReachableReceived = new CountDownLatch(1);
}
void verifyFindPrimary() {
- assertEquals("FindPrimary received", true,
+ assertTrue("FindPrimary received",
Uninterruptibles.awaitUninterruptibly(findPrimaryMessageReceived, 5, TimeUnit.SECONDS));
findPrimaryMessageReceived = new CountDownLatch(1);
}
}
void verifySnapshotPersisted(final Set<String> shardList) {
- assertEquals("saveSnapshot invoked", true,
+ assertTrue("saveSnapshot invoked",
Uninterruptibles.awaitUninterruptibly(snapshotPersist, 5, TimeUnit.SECONDS));
assertEquals("Shard Persisted", shardList, Sets.newHashSet(snapshot.getShardList()));
}
AbstractGenericCreator(final Class<C> shardManagerClass) {
this.shardManagerClass = shardManagerClass;
- cluster(new MockClusterWrapper()).configuration(new MockConfiguration()).waitTillReadyCountDownLatch(ready)
+ cluster(new MockClusterWrapper()).configuration(new MockConfiguration()).readinessFuture(ready)
.primaryShardInfoCache(new PrimaryShardInfoFutureCache());
}
Code Review / controller.git / blobdiff