Fix findbugs violations in md-sal - part 1

[controller.git] / opendaylight / md-sal / sal-dom-spi / src / main / java / org / opendaylight / controller / md / sal / dom / spi / DefaultDOMRpcResult.java

diff --git a/opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/md/sal/dom/spi/DefaultDOMRpcResult.java b/opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/md/sal/dom/spi/DefaultDOMRpcResult.java
index 269fd3537cc794402a5a4557065bcb6897fc1eea..94cc510645a2bd4500ace771f33b407b2e1d92c0 100644 (file)
--- a/opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/md/sal/dom/spi/DefaultDOMRpcResult.java
+++ b/opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/md/sal/dom/spi/DefaultDOMRpcResult.java
@@ -9,6 +9,7 @@ package org.opendaylight.controller.md.sal.dom.spi;
 
 import com.google.common.annotations.Beta;
 import com.google.common.base.Preconditions;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.Serializable;
 import java.util.Arrays;
 import java.util.Collection;
@@ -26,7 +27,15 @@ import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
 @Beta
 public final class DefaultDOMRpcResult implements DOMRpcResult, Immutable, Serializable {
     private static final long serialVersionUID = 1L;
+
+    // Flagged as "Non-transient non-serializable instance field" - the Collection is Serializable but the RpcError
+    // interface isn't. In lieu of changing the interface, we assume the implementation is Serializable which is
+    // reasonable since the only implementation that is actually used is from the RpcResultBuilder.
+    @SuppressFBWarnings("SE_BAD_FIELD")
     private final Collection<RpcError> errors;
+
+    // Unfortunately the NormalizedNode interface isn't Serializable but we assume the implementations are.
+    @SuppressFBWarnings("SE_BAD_FIELD")
     private final NormalizedNode<?, ?> result;
 
     private static Collection<RpcError> asCollection(final RpcError... errors) {