Fix checkstyle violations in sal-inmemory-datastore

[controller.git] / opendaylight / md-sal / sal-inmemory-datastore / src / main / java / org / opendaylight / controller / md / sal / dom / store / impl / DOMImmutableDataChangeEvent.java

diff --git a/opendaylight/md-sal/sal-inmemory-datastore/src/main/java/org/opendaylight/controller/md/sal/dom/store/impl/DOMImmutableDataChangeEvent.java b/opendaylight/md-sal/sal-inmemory-datastore/src/main/java/org/opendaylight/controller/md/sal/dom/store/impl/DOMImmutableDataChangeEvent.java
index f457e3b9e9603bb2d409ac1d8b3d6fe8b1ea35eb..43b1c636e491f678e0550f25b3bef84e46f2206f 100644 (file)
--- a/opendaylight/md-sal/sal-inmemory-datastore/src/main/java/org/opendaylight/controller/md/sal/dom/store/impl/DOMImmutableDataChangeEvent.java
+++ b/opendaylight/md-sal/sal-inmemory-datastore/src/main/java/org/opendaylight/controller/md/sal/dom/store/impl/DOMImmutableDataChangeEvent.java
@@ -8,13 +8,11 @@
 package org.opendaylight.controller.md.sal.dom.store.impl;
 
 import com.google.common.base.Preconditions;
-
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Set;
-
 import org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker.DataChangeScope;
 import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeEvent;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
@@ -24,7 +22,6 @@ import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
 public final class DOMImmutableDataChangeEvent implements
         AsyncDataChangeEvent<YangInstanceIdentifier, NormalizedNode<?, ?>> {
 
-
     private static final RemoveEventFactory REMOVE_EVENT_FACTORY = new RemoveEventFactory();
     private static final CreateEventFactory CREATE_EVENT_FACTORY = new CreateEventFactory();
 
@@ -36,8 +33,6 @@ public final class DOMImmutableDataChangeEvent implements
     private final Set<YangInstanceIdentifier> removedPaths;
     private final DataChangeScope scope;
 
-
-
     private DOMImmutableDataChangeEvent(final Builder change) {
         original = change.before;
         updated = change.after;
@@ -48,7 +43,7 @@ public final class DOMImmutableDataChangeEvent implements
         scope = change.scope;
     }
 
-    public static final Builder builder(final DataChangeScope scope) {
+    public static Builder builder(final DataChangeScope scope) {
         return new Builder(scope);
     }
 
@@ -93,9 +88,7 @@ public final class DOMImmutableDataChangeEvent implements
     }
 
     /**
-     * Simple event factory which creates event based on path and data
-     *
-     *
+     * Simple event factory which creates event based on path and data.
      */
     public interface SimpleEventFactory {
         DOMImmutableDataChangeEvent create(YangInstanceIdentifier path, NormalizedNode<PathArgument,?> data);
@@ -104,30 +97,31 @@ public final class DOMImmutableDataChangeEvent implements
     /**
      * Event factory which takes after state and creates event for it.
      *
+     * <p>
      * Factory for events based on path and after state.
      * After state is set as {@link #getUpdatedSubtree()} and is path,
      * state mapping is also present in {@link #getUpdatedData()}.
-     *
-     * @return
      */
-    public static final SimpleEventFactory getCreateEventFactory() {
+    public static SimpleEventFactory getCreateEventFactory() {
         return CREATE_EVENT_FACTORY;
     }
 
     /**
      * Event factory which takes before state and creates event for it.
      *
+     * <p>
      * Factory for events based on path and after state.
      * After state is set as {@link #getOriginalSubtree()} and is path,
      * state mapping is also present in {@link #getOriginalSubtree()}.
      *
+     * <p>
      * Path is present in {@link #getRemovedPaths()}.
-     * @return
      */
-    public static final SimpleEventFactory getRemoveEventFactory() {
+    public static SimpleEventFactory getRemoveEventFactory() {
         return REMOVE_EVENT_FACTORY;
     }
-    public static class Builder {
+
+    public static final class Builder {
 
         public DataChangeScope scope;
         private NormalizedNode<?, ?> after;
@@ -178,10 +172,10 @@ public final class DOMImmutableDataChangeEvent implements
             return this;
         }
 
-        public Builder addUpdated(final YangInstanceIdentifier path, final NormalizedNode<?, ?> before,
-                final NormalizedNode<?, ?> after) {
-            original.put(path, before);
-            updated.put(path, after);
+        public Builder addUpdated(final YangInstanceIdentifier path, final NormalizedNode<?, ?> nodeBefore,
+                final NormalizedNode<?, ?> nodeAfter) {
+            original.put(path, nodeBefore);
+            updated.put(path, nodeAfter);
             return this;
         }
 
@@ -193,7 +187,8 @@ public final class DOMImmutableDataChangeEvent implements
     private static final class RemoveEventFactory implements SimpleEventFactory {
 
         @Override
-        public DOMImmutableDataChangeEvent create(final YangInstanceIdentifier path, final NormalizedNode<PathArgument, ?> data) {
+        public DOMImmutableDataChangeEvent create(final YangInstanceIdentifier path,
+                final NormalizedNode<PathArgument, ?> data) {
             return builder(DataChangeScope.BASE) //
                     .setBefore(data) //
                     .addRemoved(path, data) //
@@ -205,12 +200,12 @@ public final class DOMImmutableDataChangeEvent implements
     private static final class CreateEventFactory implements SimpleEventFactory {
 
         @Override
-        public DOMImmutableDataChangeEvent create(final YangInstanceIdentifier path, final NormalizedNode<PathArgument, ?> data) {
+        public DOMImmutableDataChangeEvent create(final YangInstanceIdentifier path,
+                final NormalizedNode<PathArgument, ?> data) {
             return builder(DataChangeScope.BASE) //
                     .setAfter(data) //
                     .addCreated(path, data) //
                     .build();
         }
     }
-
 }