BUG-1382: do not instantiate prefixed QNames

[controller.git] / opendaylight / md-sal / sal-rest-connector / src / test / java / org / opendaylight / controller / sal / restconf / impl / cnsn / to / xml / test / CnSnToXmlTest.java

diff --git a/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/xml/test/CnSnToXmlTest.java b/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/xml/test/CnSnToXmlTest.java
index 3d5fee3ab8aff5ef3adfde3dbbcdc91a9a13923e..4232c83d5b5bdd9280ce0ede41c62bac6f0501a3 100644 (file)
--- a/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/xml/test/CnSnToXmlTest.java
+++ b/opendaylight/md-sal/sal-rest-connector/src/test/java/org/opendaylight/controller/sal/restconf/impl/cnsn/to/xml/test/CnSnToXmlTest.java
@@ -70,7 +70,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
     @Test
     public void snAsYangIdentityrefWithQNamePrefixToXMLTest() {
         serializeToXml(prepareIdentityrefData("prefix", true),
-                "<lf11 xmlns:prefix=\"referenced:module\">prefix:iden</lf11>");
+                "<lf11 xmlns","=\"referenced:module\">",":iden</lf11>");
     }
 
     @Test
@@ -93,7 +93,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangInt8ToXmlTest() {
-        String elName = "lfInt8";
+        final String elName = "lfInt8";
         serializeToXml(
                 prepareCnStructForYangData(TypeDefinitionAwareCodec.from(Int8.getInstance()).deserialize("14"), elName),
                 "<" + elName + ">14</" + elName + ">");
@@ -101,7 +101,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangInt16ToXmlTest() {
-        String elName = "lfInt16";
+        final String elName = "lfInt16";
         serializeToXml(
                 prepareCnStructForYangData(TypeDefinitionAwareCodec.from(Int16.getInstance()).deserialize("3000"),
                         elName), "<" + elName + ">3000</" + elName + ">");
@@ -109,7 +109,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangInt32ToXmlTest() {
-        String elName = "lfInt32";
+        final String elName = "lfInt32";
         serializeToXml(
                 prepareCnStructForYangData(TypeDefinitionAwareCodec.from(Int32.getInstance()).deserialize("201234"),
                         elName), "<" + elName + ">201234</" + elName + ">");
@@ -117,7 +117,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangInt64ToXmlTest() {
-        String elName = "lfInt64";
+        final String elName = "lfInt64";
         serializeToXml(
                 prepareCnStructForYangData(
                         TypeDefinitionAwareCodec.from(Int64.getInstance()).deserialize("5123456789"), elName), "<"
@@ -126,7 +126,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangUint8ToXmlTest() {
-        String elName = "lfUint8";
+        final String elName = "lfUint8";
         serializeToXml(
                 prepareCnStructForYangData(TypeDefinitionAwareCodec.from(Uint8.getInstance()).deserialize("200"),
                         elName), "<" + elName + ">200</" + elName + ">");
@@ -134,7 +134,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangUint16ToXmlTest() {
-        String elName = "lfUint16";
+        final String elName = "lfUint16";
         serializeToXml(
                 prepareCnStructForYangData(TypeDefinitionAwareCodec.from(Uint16.getInstance()).deserialize("4000"),
                         elName), "<" + elName + ">4000</" + elName + ">");
@@ -142,7 +142,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangUint32ToXmlTest() {
-        String elName = "lfUint32";
+        final String elName = "lfUint32";
         serializeToXml(
                 prepareCnStructForYangData(TypeDefinitionAwareCodec.from(Uint32.getInstance())
                         .deserialize("4123456789"), elName), "<" + elName + ">4123456789</" + elName + ">");
@@ -150,7 +150,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangUint64ToXmlTest() {
-        String elName = "lfUint64";
+        final String elName = "lfUint64";
         serializeToXml(
                 prepareCnStructForYangData(TypeDefinitionAwareCodec.from(Uint64.getInstance())
                         .deserialize("5123456789"), elName), "<" + elName + ">5123456789</" + elName + ">");
@@ -158,7 +158,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangBinaryToXmlTest() {
-        String elName = "lfBinary";
+        final String elName = "lfBinary";
         serializeToXml(
                 prepareCnStructForYangData(
                         TypeDefinitionAwareCodec.from(BinaryType.getInstance()).deserialize(
@@ -168,13 +168,13 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangBitsToXmlTest() {
-        BitsTypeDefinition.Bit mockBit1 = mock(BitsTypeDefinition.Bit.class);
+        final BitsTypeDefinition.Bit mockBit1 = mock(BitsTypeDefinition.Bit.class);
         when(mockBit1.getName()).thenReturn("one");
-        BitsTypeDefinition.Bit mockBit2 = mock(BitsTypeDefinition.Bit.class);
+        final BitsTypeDefinition.Bit mockBit2 = mock(BitsTypeDefinition.Bit.class);
         when(mockBit2.getName()).thenReturn("two");
-        List<BitsTypeDefinition.Bit> bitList = Lists.newArrayList(mockBit1, mockBit2);
+        final List<BitsTypeDefinition.Bit> bitList = Lists.newArrayList(mockBit1, mockBit2);
 
-        String elName = "lfBits";
+        final String elName = "lfBits";
         serializeToXml(
                 prepareCnStructForYangData(
                         TypeDefinitionAwareCodec.from(BitsType.create(mock(SchemaPath.class), bitList)).deserialize(
@@ -184,11 +184,11 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangEnumerationToXmlTest() {
-        EnumTypeDefinition.EnumPair mockEnum = mock(EnumTypeDefinition.EnumPair.class);
+        final EnumTypeDefinition.EnumPair mockEnum = mock(EnumTypeDefinition.EnumPair.class);
         when(mockEnum.getName()).thenReturn("enum2");
-        List<EnumPair> enumList = Lists.newArrayList(mockEnum);
+        final List<EnumPair> enumList = Lists.newArrayList(mockEnum);
 
-        String elName = "lfEnumeration";
+        final String elName = "lfEnumeration";
         serializeToXml(
                 prepareCnStructForYangData(
                         TypeDefinitionAwareCodec.from(
@@ -199,7 +199,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangEmptyToXmlTest() {
-        String elName = "lfEmpty";
+        final String elName = "lfEmpty";
         serializeToXml(
                 prepareCnStructForYangData(TypeDefinitionAwareCodec.from(EmptyType.getInstance()).deserialize(null),
                         elName), "<" + elName + "/>");
@@ -207,7 +207,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
 
     @Test
     public void snAsYangBooleanToXmlTest() {
-        String elName = "lfBoolean";
+        final String elName = "lfBoolean";
         serializeToXml(
                 prepareCnStructForYangData(TypeDefinitionAwareCodec.from(BooleanType.getInstance()).deserialize("str"),
                         elName), "<" + elName + ">false</" + elName + ">");
@@ -220,26 +220,26 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
     @Test
     public void snAsYangUnionToXmlTest() {
 
-        BitsTypeDefinition.Bit mockBit1 = mock(BitsTypeDefinition.Bit.class);
+        final BitsTypeDefinition.Bit mockBit1 = mock(BitsTypeDefinition.Bit.class);
         when(mockBit1.getName()).thenReturn("first");
-        BitsTypeDefinition.Bit mockBit2 = mock(BitsTypeDefinition.Bit.class);
+        final BitsTypeDefinition.Bit mockBit2 = mock(BitsTypeDefinition.Bit.class);
         when(mockBit2.getName()).thenReturn("second");
-        List<BitsTypeDefinition.Bit> bitList = Lists.newArrayList(mockBit1, mockBit2);
+        final List<BitsTypeDefinition.Bit> bitList = Lists.newArrayList(mockBit1, mockBit2);
 
-        List<TypeDefinition<?>> types = Lists.<TypeDefinition<?>> newArrayList(Int8.getInstance(),
+        final List<TypeDefinition<?>> types = Lists.<TypeDefinition<?>> newArrayList(Int8.getInstance(),
                 BitsType.create(mock(SchemaPath.class), bitList), BooleanType.getInstance());
-        UnionType unionType = UnionType.create(types);
+        final UnionType unionType = UnionType.create(types);
 
-        String elName = "lfUnion";
-        String int8 = "15";
+        final String elName = "lfUnion";
+        final String int8 = "15";
         serializeToXml(prepareCnStructForYangData(TypeDefinitionAwareCodec.from(unionType).deserialize(int8), elName),
                 "<" + elName + ">15</" + elName + ">");
 
-        String bits = "first second";
+        final String bits = "first second";
         serializeToXml(prepareCnStructForYangData(TypeDefinitionAwareCodec.from(unionType).deserialize(bits), elName),
                 "<" + elName + ">first second</" + elName + ">");
 
-        String bool = "str";
+        final String bool = "str";
         serializeToXml(prepareCnStructForYangData(TypeDefinitionAwareCodec.from(unionType).deserialize(bool), elName),
                 "<" + elName + ">str</" + elName + ">");
     }
@@ -255,7 +255,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
         assertNotNull(xmlString);
         boolean containSearchedStr = false;
         String strRepresentation = "";
-        for (String searchedStr : xmlRepresentation) {
+        for (final String searchedStr : xmlRepresentation) {
             if (xmlString.contains(searchedStr)) {
                 containSearchedStr = true;
                 break;
@@ -267,9 +267,9 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
     }
 
     private CompositeNode prepareIdentityrefData(final String prefix, final boolean valueAsQName) {
-        MutableCompositeNode cont = NodeFactory.createMutableCompositeNode(
+        final MutableCompositeNode cont = NodeFactory.createMutableCompositeNode(
                 TestUtils.buildQName("cont", "basic:module", "2013-12-2"), null, null, ModifyAction.CREATE, null);
-        MutableCompositeNode cont1 = NodeFactory.createMutableCompositeNode(
+        final MutableCompositeNode cont1 = NodeFactory.createMutableCompositeNode(
                 TestUtils.buildQName("cont1", "basic:module", "2013-12-2"), cont, null, ModifyAction.CREATE, null);
         cont.getValue().add(cont1);
 
@@ -279,7 +279,7 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
         } else {
             value = "no qname value";
         }
-        MutableSimpleNode<Object> lf11 = NodeFactory.createMutableSimpleNode(
+        final MutableSimpleNode<Object> lf11 = NodeFactory.createMutableSimpleNode(
                 TestUtils.buildQName("lf11", "basic:module", "2013-12-2"), cont1, value, ModifyAction.CREATE, null);
         cont1.getValue().add(lf11);
         cont1.init();
@@ -289,10 +289,10 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
     }
 
     private CompositeNode prepareCnStructForYangData(final Object data, final String leafName) {
-        MutableCompositeNode cont = NodeFactory.createMutableCompositeNode(
+        final MutableCompositeNode cont = NodeFactory.createMutableCompositeNode(
                 TestUtils.buildQName("cont", "basic:module", "2013-12-2"), null, null, ModifyAction.CREATE, null);
 
-        MutableSimpleNode<Object> lf1 = NodeFactory.createMutableSimpleNode(
+        final MutableSimpleNode<Object> lf1 = NodeFactory.createMutableSimpleNode(
                 TestUtils.buildQName(leafName, "basic:module", "2013-12-2"), cont, data, ModifyAction.CREATE, null);
         cont.getValue().add(lf1);
         cont.init();
@@ -301,12 +301,12 @@ public class CnSnToXmlTest extends YangAndXmlAndDataSchemaLoader {
     }
 
     private CompositeNode prepareLeafrefData() {
-        MutableCompositeNode cont = NodeFactory.createMutableCompositeNode(TestUtils.buildQName("cont"), null, null,
+        final MutableCompositeNode cont = NodeFactory.createMutableCompositeNode(TestUtils.buildQName("cont"), null, null,
                 ModifyAction.CREATE, null);
 
-        MutableSimpleNode<Object> lfBoolean = NodeFactory.createMutableSimpleNode(TestUtils.buildQName("lfBoolean"),
+        final MutableSimpleNode<Object> lfBoolean = NodeFactory.createMutableSimpleNode(TestUtils.buildQName("lfBoolean"),
                 cont, Boolean.TRUE, ModifyAction.CREATE, null);
-        MutableSimpleNode<Object> lfLfref = NodeFactory.createMutableSimpleNode(TestUtils.buildQName("lfLfref"), cont,
+        final MutableSimpleNode<Object> lfLfref = NodeFactory.createMutableSimpleNode(TestUtils.buildQName("lfLfref"), cont,
                 "true", ModifyAction.CREATE, null);
         cont.getValue().add(lfBoolean);
         cont.getValue().add(lfLfref);