X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fconfig%2Fconfig-manager%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fconfig%2Fmanager%2Fimpl%2Fosgi%2Fmapping%2FModuleInfoBundleTracker.java;h=57740477a1f6c6ec643d94776e7e62ef6e961753;hp=7aa74ed18f146b18f02b9605aa59af657ca7e6d7;hb=refs%2Fchanges%2F73%2F46573%2F5;hpb=660c3e22ca97bc613ea6f6288503620bba6fb233 diff --git a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/osgi/mapping/ModuleInfoBundleTracker.java b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/osgi/mapping/ModuleInfoBundleTracker.java index 7aa74ed18f..57740477a1 100644 --- a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/osgi/mapping/ModuleInfoBundleTracker.java +++ b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/osgi/mapping/ModuleInfoBundleTracker.java @@ -7,14 +7,14 @@ */ package org.opendaylight.controller.config.manager.impl.osgi.mapping; -import static java.lang.String.format; import com.google.common.io.Resources; import java.io.IOException; import java.net.URL; +import java.nio.charset.StandardCharsets; import java.util.Collection; +import java.util.Collections; import java.util.LinkedList; import java.util.List; -import java.nio.charset.StandardCharsets; import org.opendaylight.yangtools.concepts.ObjectRegistration; import org.opendaylight.yangtools.yang.binding.YangModelBindingProvider; import org.opendaylight.yangtools.yang.binding.YangModuleInfo; @@ -73,8 +73,8 @@ public final class ModuleInfoBundleTracker implements AutoCloseable, public Collection> addingBundle(Bundle bundle, BundleEvent event) { URL resource = bundle.getEntry(MODULE_INFO_PROVIDER_PATH_PREFIX + YangModelBindingProvider.class.getName()); LOG.debug("Got addingBundle({}) with YangModelBindingProvider resource {}", bundle, resource); - if(resource==null) { - return null; + if(resource == null) { + return Collections.emptyList(); } List> registrations = new LinkedList<>(); @@ -121,7 +121,7 @@ public final class ModuleInfoBundleTracker implements AutoCloseable, String errorMessage; Class clazz = loadClass(moduleInfoClass, bundle); - if (YangModelBindingProvider.class.isAssignableFrom(clazz) == false) { + if (!YangModelBindingProvider.class.isAssignableFrom(clazz)) { errorMessage = logMessage("Class {} does not implement {} in bundle {}", clazz, YangModelBindingProvider.class, bundle); throw new IllegalStateException(errorMessage); } @@ -157,6 +157,6 @@ public final class ModuleInfoBundleTracker implements AutoCloseable, public static String logMessage(String slfMessage, Object... params) { LOG.info(slfMessage, params); String formatMessage = slfMessage.replaceAll("\\{\\}", "%s"); - return format(formatMessage, params); + return String.format(formatMessage, params); } }