X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fconfig%2Fconfig-persister-feature-adapter%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fconfigpusherfeature%2Finternal%2FChildAwareFeatureWrapper.java;h=a9d06853a27b9dfa4aa8bf4a6e04984e9d130b3f;hp=7da9b9f9a3663482c989e44cb9a8bab8da04c886;hb=8b1ea7f69a0183c988d3861a8b6c90e465d687ae;hpb=b6d6f433f22283fc5b078c1129bd24ff459fd799 diff --git a/opendaylight/config/config-persister-feature-adapter/src/main/java/org/opendaylight/controller/configpusherfeature/internal/ChildAwareFeatureWrapper.java b/opendaylight/config/config-persister-feature-adapter/src/main/java/org/opendaylight/controller/configpusherfeature/internal/ChildAwareFeatureWrapper.java index 7da9b9f9a3..a9d06853a2 100644 --- a/opendaylight/config/config-persister-feature-adapter/src/main/java/org/opendaylight/controller/configpusherfeature/internal/ChildAwareFeatureWrapper.java +++ b/opendaylight/config/config-persister-feature-adapter/src/main/java/org/opendaylight/controller/configpusherfeature/internal/ChildAwareFeatureWrapper.java @@ -11,6 +11,7 @@ import com.google.common.base.Optional; import com.google.common.base.Preconditions; import java.util.LinkedHashSet; import java.util.List; +import java.util.Set; import org.apache.felix.utils.version.VersionRange; import org.apache.felix.utils.version.VersionTable; import org.apache.karaf.features.Dependency; @@ -52,17 +53,17 @@ public class ChildAwareFeatureWrapper extends AbstractFeatureWrapper implements * Get FeatureConfigSnapshotHolders appropriate to feed to the config subsystem * from the underlying Feature Config files and those of its children recursively */ - public LinkedHashSet getChildFeatures() throws Exception { + public Set getChildFeatures() throws Exception { List dependencies = feature.getDependencies(); - LinkedHashSet childFeatures = new LinkedHashSet(); + Set childFeatures = new LinkedHashSet<>(); if(dependencies != null) { for(Dependency dependency: dependencies) { Feature fi = extractFeatureFromDependency(dependency); - if(fi != null) { - if(featuresService.getFeature(fi.getName(), fi.getVersion()) == null) { + if (fi != null) { + if (featuresService.getFeature(fi.getName(), fi.getVersion()) == null) { LOG.warn("Feature: {}, {} is missing from features service. Skipping", fi.getName(), fi.getVersion()); } else { - ChildAwareFeatureWrapper wrappedFeature = new ChildAwareFeatureWrapper(fi,featuresService); + ChildAwareFeatureWrapper wrappedFeature = new ChildAwareFeatureWrapper(fi, featuresService); childFeatures.add(wrappedFeature); } } @@ -72,8 +73,8 @@ public class ChildAwareFeatureWrapper extends AbstractFeatureWrapper implements } @Override - public LinkedHashSet getFeatureConfigSnapshotHolders() throws Exception { - LinkedHashSet snapShotHolders = new LinkedHashSet(); + public Set getFeatureConfigSnapshotHolders() throws Exception { + Set snapShotHolders = new LinkedHashSet<>(); for(ChildAwareFeatureWrapper c: getChildFeatures()) { for(FeatureConfigSnapshotHolder h: c.getFeatureConfigSnapshotHolders()) { final Optional featureConfigSnapshotHolder = getFeatureConfigSnapshotHolder(h.getFileInfo());