X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fconfig%2Fconfig-persister-file-xml-adapter%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fconfig%2Fpersist%2Fstorage%2Ffile%2Fxml%2Fmodel%2FConfig.java;h=e043e45feb94add6c36a0126f13a0b4ecf4b7690;hp=63755f9e62c69d56c37dfa6442c91447bf42b8f7;hb=de24c0e0c31714fb5a037d8dff72f4a285303b6a;hpb=dfc4bf9604f126da4ab2adbd3f782371ef18430f diff --git a/opendaylight/config/config-persister-file-xml-adapter/src/main/java/org/opendaylight/controller/config/persist/storage/file/xml/model/Config.java b/opendaylight/config/config-persister-file-xml-adapter/src/main/java/org/opendaylight/controller/config/persist/storage/file/xml/model/Config.java index 63755f9e62..e043e45feb 100644 --- a/opendaylight/config/config-persister-file-xml-adapter/src/main/java/org/opendaylight/controller/config/persist/storage/file/xml/model/Config.java +++ b/opendaylight/config/config-persister-file-xml-adapter/src/main/java/org/opendaylight/controller/config/persist/storage/file/xml/model/Config.java @@ -33,7 +33,7 @@ public final class Config { private List snapshots; - Config(List snapshots) { + Config(final List snapshots) { this.snapshots = snapshots; } @@ -47,11 +47,11 @@ public final class Config { return snapshots; } - public void setSnapshots(List snapshots) { + public void setSnapshots(final List snapshots) { this.snapshots = snapshots; } - public void toXml(File to) { + public void toXml(final File to) { try { // TODO Moxy has to be used instead of default jaxb impl due to a bug @@ -63,12 +63,12 @@ public final class Config { marshaller.setProperty(Marshaller.JAXB_FORMATTED_OUTPUT, Boolean.TRUE); marshaller.marshal(this, to); - } catch (JAXBException e) { + } catch (final JAXBException e) { throw new PersistException("Unable to persist configuration", e); } } - public static Config fromXml(File from) { + public static Config fromXml(final File from) { if(isEmpty(from)) { return new Config(); } @@ -86,14 +86,14 @@ public final class Config { } } - private static boolean isEmpty(File from) { + private static boolean isEmpty(final File from) { return from.length() == 0 || isBlank(from); } - private static boolean isBlank(File from) { + private static boolean isBlank(final File from) { try { return StringUtils.isBlank(Files.toString(from, StandardCharsets.UTF_8)); - } catch (IOException e) { + } catch (final IOException e) { throw new IllegalStateException("Unexpected error reading file" + from, e); } } @@ -103,14 +103,14 @@ public final class Config { return last == null ? Optional.absent() : Optional.of(last); } - public void addConfigSnapshot(ConfigSnapshot snap, int numberOfStoredBackups) { + public void addConfigSnapshot(final ConfigSnapshot snap, final int numberOfStoredBackups) { if (shouldReplaceLast(numberOfStoredBackups) && !snapshots.isEmpty()) { snapshots.remove(0); } snapshots.add(snap); } - private boolean shouldReplaceLast(int numberOfStoredBackups) { + private boolean shouldReplaceLast(final int numberOfStoredBackups) { return numberOfStoredBackups == snapshots.size(); } }