X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fconfig%2Fnetty-event-executor-config%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fconfig%2Fyang%2Fnetty%2Feventexecutor%2FGlobalEventExecutorModuleTest.java;h=e89d82a28fd6b3f8876e89724d254691bf90fad3;hp=6af508829be93eb6b64157562806753596b2ae64;hb=e159106bc148e76fc1e3e3c780bdd740d99e74ed;hpb=c742dea42922f3910cb178a1d8f50706e73c8aaa diff --git a/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleTest.java b/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleTest.java index 6af508829b..e89d82a28f 100644 --- a/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleTest.java +++ b/opendaylight/config/netty-event-executor-config/src/test/java/org/opendaylight/controller/config/yang/netty/eventexecutor/GlobalEventExecutorModuleTest.java @@ -1,7 +1,12 @@ -package org.opendaylight.controller.config.yang.netty.eventexecutor; +/* + * Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved. + * + * This program and the accompanying materials are made available under the + * terms of the Eclipse Public License v1.0 which accompanies this distribution, + * and is available at http://www.eclipse.org/legal/epl-v10.html + */ -import javax.management.InstanceAlreadyExistsException; -import javax.management.ObjectName; +package org.opendaylight.controller.config.yang.netty.eventexecutor; import org.junit.Before; import org.junit.Test; @@ -12,15 +17,21 @@ import org.opendaylight.controller.config.manager.impl.AbstractConfigTest; import org.opendaylight.controller.config.manager.impl.factoriesresolver.HardcodedModuleFactoriesResolver; import org.opendaylight.controller.config.util.ConfigTransactionJMXClient; +import javax.management.InstanceAlreadyExistsException; +import javax.management.ObjectName; + +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; + public class GlobalEventExecutorModuleTest extends AbstractConfigTest { private GlobalEventExecutorModuleFactory factory; - private final String instanceName = "netty1"; + private final String instanceName = GlobalEventExecutorModuleFactory.SINGLETON_NAME; @Before public void setUp() { factory = new GlobalEventExecutorModuleFactory(); - super.initConfigTransactionManagerImpl(new HardcodedModuleFactoriesResolver(factory)); + super.initConfigTransactionManagerImpl(new HardcodedModuleFactoriesResolver(mockedContext,factory)); } @Test @@ -29,12 +40,23 @@ public class GlobalEventExecutorModuleTest extends AbstractConfigTest { ConfigTransactionJMXClient transaction = configRegistryClient.createTransaction(); createInstance(transaction, instanceName); - createInstance(transaction, instanceName + 2); + transaction.validateConfig(); CommitStatus status = transaction.commit(); - assertBeanCount(2, factory.getImplementationName()); - assertStatus(status, 2, 0, 0); + assertBeanCount(1, factory.getImplementationName()); + assertStatus(status, 1, 0, 0); + } + + @Test + public void testConflictingName() throws Exception { + ConfigTransactionJMXClient transaction = configRegistryClient.createTransaction(); + try { + createInstance(transaction, instanceName + "x"); + fail(); + }catch(IllegalArgumentException e){ + assertTrue(e.getMessage() + " failure", e.getMessage().contains("only allowed name is singleton")); + } } @Test