X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fcds-access-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Faccess%2Fclient%2FAbstractClientConnection.java;h=9c290df13da3f61da22f0f728eaa3b5a150f255f;hp=0d45dd5c6918ca2d97b61898b4f291349e48a4f2;hb=b2aee9607bf989c1bcff3f931ee5238215ee3073;hpb=555663eec40d16fbc622bb5de1de37f2253c359b diff --git a/opendaylight/md-sal/cds-access-client/src/main/java/org/opendaylight/controller/cluster/access/client/AbstractClientConnection.java b/opendaylight/md-sal/cds-access-client/src/main/java/org/opendaylight/controller/cluster/access/client/AbstractClientConnection.java index 0d45dd5c69..9c290df13d 100644 --- a/opendaylight/md-sal/cds-access-client/src/main/java/org/opendaylight/controller/cluster/access/client/AbstractClientConnection.java +++ b/opendaylight/md-sal/cds-access-client/src/main/java/org/opendaylight/controller/cluster/access/client/AbstractClientConnection.java @@ -17,6 +17,7 @@ import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.util.Collection; import java.util.List; import java.util.Optional; +import java.util.OptionalLong; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; import java.util.concurrent.locks.Lock; @@ -334,7 +335,7 @@ public abstract class AbstractClientConnection { // Requests are always scheduled in sequence, hence checking for timeout is relatively straightforward. // Note we use also inquire about the delay, so we can re-schedule if needed, hence the unusual // tri-state return convention. - final Optional delay = lockedCheckTimeout(now); + final OptionalLong delay = lockedCheckTimeout(now); if (delay == null) { // We have timed out. There is no point in scheduling a timer LOG.debug("{}: connection {} timed out", context.persistenceId(), this); @@ -344,7 +345,7 @@ public abstract class AbstractClientConnection { if (delay.isPresent()) { // If there is new delay, schedule a timer - scheduleTimer(delay.get()); + scheduleTimer(delay.getAsLong()); } else { LOG.debug("{}: not scheduling timeout on {}", context.persistenceId(), this); } @@ -366,7 +367,7 @@ public abstract class AbstractClientConnection { } @VisibleForTesting - final Optional checkTimeout(final long now) { + final OptionalLong checkTimeout(final long now) { lock.lock(); try { return lockedCheckTimeout(now); @@ -388,10 +389,10 @@ public abstract class AbstractClientConnection { @SuppressFBWarnings(value = "NP_OPTIONAL_RETURN_NULL", justification = "Returning null Optional is documented in the API contract.") @GuardedBy("lock") - private Optional lockedCheckTimeout(final long now) { + private OptionalLong lockedCheckTimeout(final long now) { if (queue.isEmpty()) { LOG.debug("{}: connection {} is empty", context.persistenceId(), this); - return Optional.empty(); + return OptionalLong.empty(); } final long backendSilentTicks = backendSilentTicks(now); @@ -406,7 +407,7 @@ public abstract class AbstractClientConnection { final long beenOpen = now - head.getEnqueuedTicks(); final long requestTimeout = context.config().getRequestTimeout(); if (beenOpen < requestTimeout) { - return Optional.of(requestTimeout - beenOpen); + return OptionalLong.of(requestTimeout - beenOpen); } tasksTimedOut++; @@ -421,7 +422,7 @@ public abstract class AbstractClientConnection { queue.tryTransmit(now); } - return Optional.empty(); + return OptionalLong.empty(); } private void timeoutEntry(final ConnectionEntry entry, final long beenOpen) {