X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fmessagebus-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmessagebus%2Fapp%2Fimpl%2FEventSourceTopology.java;h=934056dcab81f2eeb81f387a6d6986c31ec5b629;hp=076d1b2fc7e9c1d42fee6e0ece1d7c9adc4a3228;hb=f9814cf027886294b74fb6c8748f4a3e0a545e86;hpb=95115ca49f3b16b936e0f6c88aedfc17cd0ee92c diff --git a/opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/app/impl/EventSourceTopology.java b/opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/app/impl/EventSourceTopology.java index 076d1b2fc7..934056dcab 100644 --- a/opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/app/impl/EventSourceTopology.java +++ b/opendaylight/md-sal/messagebus-impl/src/main/java/org/opendaylight/controller/messagebus/app/impl/EventSourceTopology.java @@ -8,26 +8,32 @@ package org.opendaylight.controller.messagebus.app.impl; -import java.util.List; +import com.google.common.annotations.VisibleForTesting; +import com.google.common.util.concurrent.FutureCallback; +import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.ListenableFuture; +import com.google.common.util.concurrent.MoreExecutors; import java.util.Map; import java.util.concurrent.ConcurrentHashMap; -import java.util.concurrent.Future; -import java.util.regex.Pattern; - import org.opendaylight.controller.md.sal.binding.api.DataBroker; -import org.opendaylight.controller.md.sal.binding.api.DataChangeListener; -import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; -import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; +import org.opendaylight.controller.messagebus.app.util.Util; +import org.opendaylight.controller.messagebus.spi.EventSource; +import org.opendaylight.controller.messagebus.spi.EventSourceRegistration; +import org.opendaylight.controller.messagebus.spi.EventSourceRegistry; +import org.opendaylight.controller.sal.binding.api.BindingAwareBroker.RoutedRpcRegistration; import org.opendaylight.controller.sal.binding.api.BindingAwareBroker.RpcRegistration; import org.opendaylight.controller.sal.binding.api.RpcProviderRegistry; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventaggregator.rev141202.CreateTopicInput; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventaggregator.rev141202.CreateTopicOutput; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventaggregator.rev141202.CreateTopicOutputBuilder; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventaggregator.rev141202.DestroyTopicInput; +import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventaggregator.rev141202.DestroyTopicOutput; +import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventaggregator.rev141202.DestroyTopicOutputBuilder; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventaggregator.rev141202.EventAggregatorService; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventaggregator.rev141202.NotificationPattern; +import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventaggregator.rev141202.TopicId; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventsource.rev141202.EventSourceService; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventsource.rev141202.Node1; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.messagebus.eventsource.rev141202.Node1Builder; @@ -44,7 +50,6 @@ import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology. import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.NodeKey; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.TopologyTypes; -import org.opendaylight.yangtools.concepts.ListenerRegistration; import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.opendaylight.yangtools.yang.binding.KeyedInstanceIdentifier; @@ -52,19 +57,14 @@ import org.opendaylight.yangtools.yang.common.RpcResult; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import com.google.common.base.Optional; -import com.google.common.util.concurrent.CheckedFuture; -import com.google.common.util.concurrent.FutureCallback; -import com.google.common.util.concurrent.Futures; - -public class EventSourceTopology implements EventAggregatorService, AutoCloseable { +public class EventSourceTopology implements EventAggregatorService, EventSourceRegistry { private static final Logger LOG = LoggerFactory.getLogger(EventSourceTopology.class); private static final String TOPOLOGY_ID = "EVENT-SOURCE-TOPOLOGY" ; private static final TopologyKey EVENT_SOURCE_TOPOLOGY_KEY = new TopologyKey(new TopologyId(TOPOLOGY_ID)); private static final LogicalDatastoreType OPERATIONAL = LogicalDatastoreType.OPERATIONAL; - private static final InstanceIdentifier EVENT_SOURCE_TOPOLOGY_PATH = + static final InstanceIdentifier EVENT_SOURCE_TOPOLOGY_PATH = InstanceIdentifier.create(NetworkTopology.class) .child(Topology.class, EVENT_SOURCE_TOPOLOGY_KEY); @@ -73,7 +73,8 @@ public class EventSourceTopology implements EventAggregatorService, AutoCloseabl .child(TopologyTypes.class) .augmentation(TopologyTypes1.class); - private final Map> registrations = + private final Map eventSourceTopicMap = new ConcurrentHashMap<>(); + private final Map> routedRpcRegistrations = new ConcurrentHashMap<>(); private final DataBroker dataBroker; @@ -89,106 +90,144 @@ public class EventSourceTopology implements EventAggregatorService, AutoCloseabl eventSourceService = rpcRegistry.getRpcService(EventSourceService.class); final TopologyEventSource topologySource = new TopologyEventSourceBuilder().build(); - final TopologyTypes1 topologyTypeAugment = new TopologyTypes1Builder().setTopologyEventSource(topologySource).build(); + final TopologyTypes1 topologyTypeAugment = + new TopologyTypes1Builder().setTopologyEventSource(topologySource).build(); putData(OPERATIONAL, TOPOLOGY_TYPE_PATH, topologyTypeAugment); - + LOG.info("EventSourceRegistry has been initialized"); } private void putData(final LogicalDatastoreType store, final InstanceIdentifier path, - final T data){ + final T data) { - final WriteTransaction tx = dataBroker.newWriteOnlyTransaction(); + final WriteTransaction tx = getDataBroker().newWriteOnlyTransaction(); tx.put(store, path, data, true); - tx.submit(); - - } + Futures.addCallback(tx.submit(), new FutureCallback() { + @Override + public void onSuccess(final Void result) { + LOG.trace("Data has put into datastore {} {}", store, path); + } - private void insert(final KeyedInstanceIdentifier sourcePath, final Node node) { - final NodeKey nodeKey = node.getKey(); - final InstanceIdentifier augmentPath = sourcePath.augmentation(Node1.class); - final Node1 nodeAgument = new Node1Builder().setEventSourceNode(new NodeId(nodeKey.getNodeId().getValue())).build(); - putData(OPERATIONAL, augmentPath, nodeAgument); + @Override + public void onFailure(final Throwable ex) { + LOG.error("Can not put data into datastore [store: {}] [path: {}] [exception: {}]",store,path, ex); + } + }, MoreExecutors.directExecutor()); } - private void notifyExistingNodes(final Pattern nodeIdPatternRegex, final EventSourceTopic eventSourceTopic){ - - final ReadOnlyTransaction tx = dataBroker.newReadOnlyTransaction(); - - final CheckedFuture, ReadFailedException> future = tx.read(OPERATIONAL, EVENT_SOURCE_TOPOLOGY_PATH); - - Futures.addCallback(future, new FutureCallback>(){ - + private void deleteData(final LogicalDatastoreType store, + final InstanceIdentifier path) { + final WriteTransaction tx = getDataBroker().newWriteOnlyTransaction(); + tx.delete(OPERATIONAL, path); + Futures.addCallback(tx.submit(), new FutureCallback() { @Override - public void onSuccess(Optional data) { - if(data.isPresent()) { - final List nodes = data.get().getNode(); - for (final Node node : nodes) { - if (nodeIdPatternRegex.matcher(node.getNodeId().getValue()).matches()) { - eventSourceTopic.notifyNode(EVENT_SOURCE_TOPOLOGY_PATH.child(Node.class, node.getKey())); - } - } - } - tx.close(); + public void onSuccess(final Void result) { + LOG.trace("Data has deleted from datastore {} {}", store, path); } @Override - public void onFailure(Throwable t) { - LOG.error("Can not notify existing nodes {}", t); - tx.close(); + public void onFailure(final Throwable ex) { + LOG.error("Can not delete data from datastore [store: {}] [path: {}] [exception: {}]",store,path, ex); } + }, MoreExecutors.directExecutor()); + } - }); + private void insert(final KeyedInstanceIdentifier sourcePath) { + final NodeKey nodeKey = sourcePath.getKey(); + final InstanceIdentifier augmentPath = sourcePath.augmentation(Node1.class); + final Node1 nodeAgument = new Node1Builder().setEventSourceNode( + new NodeId(nodeKey.getNodeId().getValue())).build(); + putData(OPERATIONAL, augmentPath, nodeAgument); + } + private void remove(final KeyedInstanceIdentifier sourcePath) { + final InstanceIdentifier augmentPath = sourcePath.augmentation(Node1.class); + deleteData(OPERATIONAL, augmentPath); } @Override - public Future> createTopic(final CreateTopicInput input) { - LOG.info("Received Topic creation request: NotificationPattern -> {}, NodeIdPattern -> {}", + public ListenableFuture> createTopic(final CreateTopicInput input) { + LOG.debug("Received Topic creation request: NotificationPattern -> {}, NodeIdPattern -> {}", input.getNotificationPattern(), input.getNodeIdPattern()); final NotificationPattern notificationPattern = new NotificationPattern(input.getNotificationPattern()); + //FIXME: do not use Util.wildcardToRegex - NodeIdPatter should be regex final String nodeIdPattern = input.getNodeIdPattern().getValue(); - final Pattern nodeIdPatternRegex = Pattern.compile(Util.wildcardToRegex(nodeIdPattern)); - final EventSourceTopic eventSourceTopic = new EventSourceTopic(notificationPattern, input.getNodeIdPattern().getValue(), eventSourceService); - - registerTopic(eventSourceTopic); + final EventSourceTopic eventSourceTopic = EventSourceTopic.create(notificationPattern, nodeIdPattern, this); - notifyExistingNodes(nodeIdPatternRegex, eventSourceTopic); + eventSourceTopicMap.put(eventSourceTopic.getTopicId(), eventSourceTopic); final CreateTopicOutput cto = new CreateTopicOutputBuilder() .setTopicId(eventSourceTopic.getTopicId()) .build(); - return Util.resultFor(cto); + LOG.info("Topic has been created: NotificationPattern -> {}, NodeIdPattern -> {}", + input.getNotificationPattern(), + input.getNodeIdPattern()); + + return Util.resultRpcSuccessFor(cto); } @Override - public Future> destroyTopic(final DestroyTopicInput input) { - return Futures.immediateFailedFuture(new UnsupportedOperationException("Not Implemented")); + public ListenableFuture> destroyTopic(final DestroyTopicInput input) { + final EventSourceTopic topicToDestroy = eventSourceTopicMap.remove(input.getTopicId()); + if (topicToDestroy != null) { + topicToDestroy.close(); + } + return Util.resultRpcSuccessFor(new DestroyTopicOutputBuilder().build()); } @Override public void close() { aggregatorRpcReg.close(); + eventSourceTopicMap.values().forEach(EventSourceTopic::close); } - public void registerTopic(final EventSourceTopic listener) { - final ListenerRegistration listenerRegistration = dataBroker.registerDataChangeListener(OPERATIONAL, - EVENT_SOURCE_TOPOLOGY_PATH, - listener, - DataBroker.DataChangeScope.SUBTREE); + public void register(final EventSource eventSource) { + + final NodeKey nodeKey = eventSource.getSourceNodeKey(); + final KeyedInstanceIdentifier sourcePath = EVENT_SOURCE_TOPOLOGY_PATH.child(Node.class, nodeKey); + final RoutedRpcRegistration reg = rpcRegistry.addRoutedRpcImplementation( + EventSourceService.class, eventSource); + reg.registerPath(NodeContext.class, sourcePath); + routedRpcRegistrations.put(nodeKey,reg); + insert(sourcePath); - registrations.put(listener, listenerRegistration); } - public void register(final Node node, final NetconfEventSource netconfEventSource) { - final KeyedInstanceIdentifier sourcePath = EVENT_SOURCE_TOPOLOGY_PATH.child(Node.class, node.getKey()); - rpcRegistry.addRoutedRpcImplementation(EventSourceService.class, netconfEventSource) - .registerPath(NodeContext.class, sourcePath); - insert(sourcePath,node); - // FIXME: Return registration object. + public void unRegister(final EventSource eventSource) { + final NodeKey nodeKey = eventSource.getSourceNodeKey(); + final KeyedInstanceIdentifier sourcePath = EVENT_SOURCE_TOPOLOGY_PATH.child(Node.class, nodeKey); + final RoutedRpcRegistration removeRegistration = routedRpcRegistrations.remove(nodeKey); + if (removeRegistration != null) { + removeRegistration.close(); + remove(sourcePath); + } } + @Override + public EventSourceRegistration registerEventSource(final T eventSource) { + final EventSourceRegistrationImpl esr = new EventSourceRegistrationImpl<>(eventSource, this); + register(eventSource); + return esr; + } + + DataBroker getDataBroker() { + return dataBroker; + } + + EventSourceService getEventSourceService() { + return eventSourceService; + } + + @VisibleForTesting + Map> getRoutedRpcRegistrations() { + return routedRpcRegistrations; + } + + @VisibleForTesting + Map getEventSourceTopicMap() { + return eventSourceTopicMap; + } }