X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2FRaftActorContextImpl.java;h=dfbffb726ab4f7a079d4efc3c770f8ab3dbd5bb9;hp=0bf71ab7991b3e87bb4c6afd02577f84d749a730;hb=000960f6451af770f5463e41e1fb6defb6f3ab27;hpb=8dabbaa07e7034a2f385f9b553eaf2dbde91525b diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContextImpl.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContextImpl.java index 0bf71ab799..dfbffb726a 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContextImpl.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActorContextImpl.java @@ -13,21 +13,33 @@ import akka.actor.ActorRef; import akka.actor.ActorSelection; import akka.actor.ActorSystem; import akka.actor.Props; +import akka.cluster.Cluster; import com.google.common.annotations.VisibleForTesting; -import com.google.common.base.Supplier; +import com.google.common.base.Preconditions; import java.util.ArrayList; import java.util.Collection; import java.util.HashMap; import java.util.HashSet; import java.util.List; import java.util.Map; +import java.util.Optional; import java.util.Set; +import java.util.function.LongSupplier; import org.opendaylight.controller.cluster.DataPersistenceProvider; -import org.opendaylight.controller.cluster.raft.ServerConfigurationPayload.ServerInfo; +import org.opendaylight.controller.cluster.raft.behaviors.RaftActorBehavior; +import org.opendaylight.controller.cluster.raft.persisted.ServerConfigurationPayload; +import org.opendaylight.controller.cluster.raft.persisted.ServerInfo; import org.opendaylight.controller.cluster.raft.policy.RaftPolicy; import org.slf4j.Logger; +/** + * Implementation of the RaftActorContext interface. + * + * @author Moiz Raja + * @author Thomas Pantelis + */ public class RaftActorContextImpl implements RaftActorContext { + private static final LongSupplier JVM_MEMORY_RETRIEVER = () -> Runtime.getRuntime().maxMemory(); private final ActorRef actor; @@ -45,14 +57,14 @@ public class RaftActorContextImpl implements RaftActorContext { private final Map peerInfoMap = new HashMap<>(); - private final Logger LOG; + private final Logger log; private ConfigParams configParams; private boolean dynamicServerConfiguration = false; @VisibleForTesting - private Supplier totalMemoryRetriever; + private LongSupplier totalMemoryRetriever = JVM_MEMORY_RETRIEVER; // Snapshot manager will need to be created on demand as it needs raft actor context which cannot // be passed to it in the constructor @@ -64,6 +76,12 @@ public class RaftActorContextImpl implements RaftActorContext { private boolean votingMember = true; + private RaftActorBehavior currentBehavior; + + private int numVotingPeers = -1; + + private Optional cluster; + public RaftActorContextImpl(ActorRef actor, ActorContext context, String id, ElectionTerm termInformation, long commitIndex, long lastApplied, Map peerAddresses, ConfigParams configParams, DataPersistenceProvider persistenceProvider, Logger logger) { @@ -75,13 +93,14 @@ public class RaftActorContextImpl implements RaftActorContext { this.lastApplied = lastApplied; this.configParams = configParams; this.persistenceProvider = persistenceProvider; - this.LOG = logger; + this.log = logger; - for(Map.Entry e: peerAddresses.entrySet()) { + for (Map.Entry e: peerAddresses.entrySet()) { peerInfoMap.put(e.getKey(), new PeerInfo(e.getKey(), e.getValue(), VotingState.VOTING)); } } + @VisibleForTesting public void setPayloadVersion(short payloadVersion) { this.payloadVersion = payloadVersion; } @@ -96,12 +115,12 @@ public class RaftActorContextImpl implements RaftActorContext { } @Override - public ActorRef actorOf(Props props){ + public ActorRef actorOf(Props props) { return context.actorOf(props); } @Override - public ActorSelection actorSelection(String path){ + public ActorSelection actorSelection(String path) { return context.actorSelection(path); } @@ -115,6 +134,22 @@ public class RaftActorContextImpl implements RaftActorContext { return actor; } + @Override + @SuppressWarnings("checkstyle:IllegalCatch") + public Optional getCluster() { + if (cluster == null) { + try { + cluster = Optional.of(Cluster.get(getActorSystem())); + } catch (Exception e) { + // An exception means there's no cluster configured. This will only happen in unit tests. + log.debug("{}: Could not obtain Cluster: {}", getId(), e); + cluster = Optional.empty(); + } + } + + return cluster; + } + @Override public ElectionTerm getTermInformation() { return termInformation; @@ -154,7 +189,7 @@ public class RaftActorContextImpl implements RaftActorContext { } @Override public Logger getLogger() { - return this.LOG; + return this.log; } @Override @@ -174,11 +209,11 @@ public class RaftActorContextImpl implements RaftActorContext { @Override public String getPeerAddress(String peerId) { - String peerAddress = null; + String peerAddress; PeerInfo peerInfo = peerInfoMap.get(peerId); - if(peerInfo != null) { + if (peerInfo != null) { peerAddress = peerInfo.getAddress(); - if(peerAddress == null) { + if (peerAddress == null) { peerAddress = configParams.getPeerAddressResolver().resolve(peerId); peerInfo.setAddress(peerAddress); } @@ -190,19 +225,19 @@ public class RaftActorContextImpl implements RaftActorContext { } @Override - public void updatePeerIds(ServerConfigurationPayload serverConfig){ + public void updatePeerIds(ServerConfigurationPayload serverConfig) { votingMember = true; boolean foundSelf = false; Set currentPeers = new HashSet<>(this.getPeerIds()); - for(ServerInfo server: serverConfig.getServerConfig()) { - if(getId().equals(server.getId())) { + for (ServerInfo server : serverConfig.getServerConfig()) { + if (getId().equals(server.getId())) { foundSelf = true; - if(!server.isVoting()) { + if (!server.isVoting()) { votingMember = false; } } else { - VotingState votingState = server.isVoting() ? VotingState.VOTING: VotingState.NON_VOTING; - if(!currentPeers.contains(server.getId())) { + VotingState votingState = server.isVoting() ? VotingState.VOTING : VotingState.NON_VOTING; + if (!currentPeers.contains(server.getId())) { this.addToPeers(server.getId(), null, votingState); } else { this.getPeerInfo(server.getId()).setVotingState(votingState); @@ -211,14 +246,16 @@ public class RaftActorContextImpl implements RaftActorContext { } } - for(String peerIdToRemove: currentPeers) { + for (String peerIdToRemove : currentPeers) { this.removePeer(peerIdToRemove); } - if(!foundSelf) { + if (!foundSelf) { votingMember = false; } + log.debug("{}: Updated server config: isVoting: {}, peers: {}", id, votingMember, peerInfoMap.values()); + setDynamicServerConfigurationInUse(); } @@ -227,22 +264,24 @@ public class RaftActorContextImpl implements RaftActorContext { } @Override - public void addToPeers(String id, String address, VotingState votingState) { - peerInfoMap.put(id, new PeerInfo(id, address, votingState)); + public void addToPeers(String peerId, String address, VotingState votingState) { + peerInfoMap.put(peerId, new PeerInfo(peerId, address, votingState)); + numVotingPeers = -1; } @Override public void removePeer(String name) { - if(getId().equals(name)) { + if (getId().equals(name)) { votingMember = false; } else { peerInfoMap.remove(name); + numVotingPeers = -1; } } @Override public ActorSelection getPeerActorSelection(String peerId) { String peerAddress = getPeerAddress(peerId); - if(peerAddress != null){ + if (peerAddress != null) { return actorSelection(peerAddress); } return null; @@ -251,33 +290,33 @@ public class RaftActorContextImpl implements RaftActorContext { @Override public void setPeerAddress(String peerId, String peerAddress) { PeerInfo peerInfo = peerInfoMap.get(peerId); - if(peerInfo != null) { - LOG.info("Peer address for peer {} set to {}", peerId, peerAddress); + if (peerInfo != null) { + log.info("Peer address for peer {} set to {}", peerId, peerAddress); peerInfo.setAddress(peerAddress); } } @Override public SnapshotManager getSnapshotManager() { - if(snapshotManager == null){ - snapshotManager = new SnapshotManager(this, LOG); + if (snapshotManager == null) { + snapshotManager = new SnapshotManager(this, log); } return snapshotManager; } @Override public long getTotalMemory() { - return totalMemoryRetriever != null ? totalMemoryRetriever.get() : Runtime.getRuntime().totalMemory(); + return totalMemoryRetriever.getAsLong(); } @Override - public void setTotalMemoryRetriever(Supplier retriever) { - totalMemoryRetriever = retriever; + public void setTotalMemoryRetriever(LongSupplier retriever) { + totalMemoryRetriever = retriever == null ? JVM_MEMORY_RETRIEVER : retriever; } @Override public boolean hasFollowers() { - return getPeerIds().size() > 0; + return !getPeerIds().isEmpty(); } @Override @@ -308,19 +347,53 @@ public class RaftActorContextImpl implements RaftActorContext { } Collection peers = getPeers(); List newConfig = new ArrayList<>(peers.size() + 1); - for(PeerInfo peer: peers) { + for (PeerInfo peer: peers) { newConfig.add(new ServerInfo(peer.getId(), peer.isVoting())); } - if(includeSelf) { + if (includeSelf) { newConfig.add(new ServerInfo(getId(), votingMember)); } - return (new ServerConfigurationPayload(newConfig)); + return new ServerConfigurationPayload(newConfig); } @Override public boolean isVotingMember() { return votingMember; } + + @Override + public boolean anyVotingPeers() { + if (numVotingPeers < 0) { + numVotingPeers = 0; + for (PeerInfo info: getPeers()) { + if (info.isVoting()) { + numVotingPeers++; + } + } + } + + return numVotingPeers > 0; + } + + @Override + public RaftActorBehavior getCurrentBehavior() { + return currentBehavior; + } + + void setCurrentBehavior(final RaftActorBehavior behavior) { + this.currentBehavior = Preconditions.checkNotNull(behavior); + } + + @SuppressWarnings("checkstyle:IllegalCatch") + void close() { + if (currentBehavior != null) { + try { + currentBehavior.close(); + } catch (Exception e) { + log.debug("{}: Error closing behavior {}", getId(), currentBehavior.state(), e); + } + } + } }