X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2Fmessages%2FAppendEntriesReply.java;fp=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2Fmessages%2FAppendEntriesReply.java;h=033a19a7b26e758a30430b902085649af4c886ef;hp=7cfe8b1c6d0c20d8a363f0d9709c30ddb5bdcbe0;hb=a4d01b62cc1e8d220355aa41632b1a425e8d9652;hpb=185b965d5450aeba211ec8afdaecc139c941a474 diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntriesReply.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntriesReply.java index 7cfe8b1c6d..033a19a7b2 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntriesReply.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntriesReply.java @@ -118,16 +118,14 @@ public final class AppendEntriesReply extends AbstractRaftRPC { @Override Object writeReplace() { - if (recipientRaftVersion <= RaftVersions.BORON_VERSION) { - return new Proxy(this); - } - return recipientRaftVersion == RaftVersions.FLUORINE_VERSION ? new Proxy2(this) : new AR(this); + return recipientRaftVersion <= RaftVersions.FLUORINE_VERSION ? new Proxy2(this) : new AR(this); } /** * Fluorine version that adds the needsLeaderAddress flag. */ private static class Proxy2 implements Externalizable { + @java.io.Serial private static final long serialVersionUID = 1L; private AppendEntriesReply appendEntriesReply; @@ -172,57 +170,7 @@ public final class AppendEntriesReply extends AbstractRaftRPC { RaftVersions.CURRENT_VERSION); } - private Object readResolve() { - return appendEntriesReply; - } - } - - /** - * Pre-Fluorine version. - */ - @Deprecated - private static class Proxy implements Externalizable { - private static final long serialVersionUID = 1L; - - private AppendEntriesReply appendEntriesReply; - - // checkstyle flags the public modifier as redundant which really doesn't make sense since it clearly isn't - // redundant. It is explicitly needed for Java serialization to be able to create instances via reflection. - @SuppressWarnings("checkstyle:RedundantModifier") - public Proxy() { - } - - Proxy(final AppendEntriesReply appendEntriesReply) { - this.appendEntriesReply = appendEntriesReply; - } - - @Override - public void writeExternal(final ObjectOutput out) throws IOException { - out.writeShort(appendEntriesReply.raftVersion); - out.writeLong(appendEntriesReply.getTerm()); - out.writeObject(appendEntriesReply.followerId); - out.writeBoolean(appendEntriesReply.success); - out.writeLong(appendEntriesReply.logLastIndex); - out.writeLong(appendEntriesReply.logLastTerm); - out.writeShort(appendEntriesReply.payloadVersion); - out.writeBoolean(appendEntriesReply.forceInstallSnapshot); - } - - @Override - public void readExternal(final ObjectInput in) throws IOException, ClassNotFoundException { - short raftVersion = in.readShort(); - long term = in.readLong(); - String followerId = (String) in.readObject(); - boolean success = in.readBoolean(); - long logLastIndex = in.readLong(); - long logLastTerm = in.readLong(); - short payloadVersion = in.readShort(); - boolean forceInstallSnapshot = in.readBoolean(); - - appendEntriesReply = new AppendEntriesReply(followerId, term, success, logLastIndex, logLastTerm, - payloadVersion, forceInstallSnapshot, false, raftVersion, RaftVersions.CURRENT_VERSION); - } - + @java.io.Serial private Object readResolve() { return appendEntriesReply; }