X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2FRaftActorDelegatingPersistentDataProviderTest.java;h=333e01f0c9368371996d5268aa02d9ce74c4fb95;hp=378c53cb18a9ee92b7085a27e429afafd225f584;hb=534bf6f83465cc8a575b097c1e28fbb1f34d110a;hpb=aa9c756831b5392e1dec18a93b86cf9c28b73e8f diff --git a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorDelegatingPersistentDataProviderTest.java b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorDelegatingPersistentDataProviderTest.java index 378c53cb18..333e01f0c9 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorDelegatingPersistentDataProviderTest.java +++ b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorDelegatingPersistentDataProviderTest.java @@ -7,25 +7,29 @@ */ package org.opendaylight.controller.cluster.raft; +import static org.mockito.ArgumentMatchers.eq; import static org.mockito.Mockito.doReturn; +import static org.mockito.Mockito.never; import static org.mockito.Mockito.verify; + import akka.japi.Procedure; -import com.google.protobuf.GeneratedMessage.GeneratedExtension; -import java.util.Map; import org.junit.Before; import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.ArgumentCaptor; import org.mockito.Mock; -import org.mockito.MockitoAnnotations; +import org.mockito.junit.MockitoJUnitRunner; import org.opendaylight.controller.cluster.DataPersistenceProvider; import org.opendaylight.controller.cluster.PersistentDataProvider; -import org.opendaylight.controller.cluster.raft.protobuff.client.messages.Payload; -import org.opendaylight.controller.cluster.raft.protobuff.client.messages.PersistentPayload; +import org.opendaylight.controller.cluster.raft.messages.Payload; +import org.opendaylight.controller.cluster.raft.messages.PersistentPayload; /** * Unit tests for RaftActorDelegatingPersistentDataProvider. * * @author Thomas Pantelis */ +@RunWith(MockitoJUnitRunner.StrictStubs.class) public class RaftActorDelegatingPersistentDataProviderTest { private static final Payload PERSISTENT_PAYLOAD = new TestPersistentPayload(); @@ -53,7 +57,6 @@ public class RaftActorDelegatingPersistentDataProviderTest { @Before public void setup() { - MockitoAnnotations.initMocks(this); doReturn(PERSISTENT_PAYLOAD).when(mockPersistentLogEntry).getData(); doReturn(NON_PERSISTENT_PAYLOAD).when(mockNonPersistentLogEntry).getData(); provider = new RaftActorDelegatingPersistentDataProvider(mockDelegateProvider, mockPersistentProvider); @@ -74,13 +77,18 @@ public class RaftActorDelegatingPersistentDataProviderTest { verify(mockDelegateProvider).persist(OTHER_DATA_OBJECT, mockProcedure); } - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) @Test - public void testPersistWithPersistenceDisabled() { + public void testPersistWithPersistenceDisabled() throws Exception { doReturn(false).when(mockDelegateProvider).isRecoveryApplicable(); provider.persist(mockPersistentLogEntry, mockProcedure); - verify(mockPersistentProvider).persist(mockPersistentLogEntry, mockProcedure); + + ArgumentCaptor procedureCaptor = ArgumentCaptor.forClass(Procedure.class); + verify(mockPersistentProvider).persist(eq(PERSISTENT_PAYLOAD), procedureCaptor.capture()); + verify(mockDelegateProvider, never()).persist(mockNonPersistentLogEntry, mockProcedure); + procedureCaptor.getValue().apply(PERSISTENT_PAYLOAD); + verify(mockProcedure).apply(mockPersistentLogEntry); provider.persist(mockNonPersistentLogEntry, mockProcedure); verify(mockDelegateProvider).persist(mockNonPersistentLogEntry, mockProcedure); @@ -90,18 +98,6 @@ public class RaftActorDelegatingPersistentDataProviderTest { } static class TestNonPersistentPayload extends Payload { - @SuppressWarnings("rawtypes") - @Override - public Map encode() { - return null; - } - - @Override - public Payload decode( - org.opendaylight.controller.protobuff.messages.cluster.raft.AppendEntriesMessages.AppendEntries.ReplicatedLogEntry.Payload payload) { - return null; - } - @Override public int size() { return 0;