X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2FRaftActorDelegatingPersistentDataProviderTest.java;h=9dedc67e68776215bf58acad376c07e35ab83137;hp=3b45e1184b644605927e84b192984b143bfa89dd;hb=86e8e4a06b682aa772c834a2cef56d0596540e1b;hpb=bde80dd9d3f7e9362a06d7f5e88cda501ed41387 diff --git a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorDelegatingPersistentDataProviderTest.java b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorDelegatingPersistentDataProviderTest.java index 3b45e1184b..9dedc67e68 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorDelegatingPersistentDataProviderTest.java +++ b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorDelegatingPersistentDataProviderTest.java @@ -7,23 +7,29 @@ */ package org.opendaylight.controller.cluster.raft; +import static org.mockito.ArgumentMatchers.eq; import static org.mockito.Mockito.doReturn; +import static org.mockito.Mockito.never; import static org.mockito.Mockito.verify; + import akka.japi.Procedure; import org.junit.Before; import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.ArgumentCaptor; import org.mockito.Mock; -import org.mockito.MockitoAnnotations; +import org.mockito.junit.MockitoJUnitRunner; import org.opendaylight.controller.cluster.DataPersistenceProvider; import org.opendaylight.controller.cluster.PersistentDataProvider; -import org.opendaylight.controller.cluster.raft.protobuff.client.messages.Payload; -import org.opendaylight.controller.cluster.raft.protobuff.client.messages.PersistentPayload; +import org.opendaylight.controller.cluster.raft.messages.Payload; +import org.opendaylight.controller.cluster.raft.messages.PersistentPayload; /** * Unit tests for RaftActorDelegatingPersistentDataProvider. * * @author Thomas Pantelis */ +@RunWith(MockitoJUnitRunner.StrictStubs.class) public class RaftActorDelegatingPersistentDataProviderTest { private static final Payload PERSISTENT_PAYLOAD = new TestPersistentPayload(); @@ -51,7 +57,6 @@ public class RaftActorDelegatingPersistentDataProviderTest { @Before public void setup() { - MockitoAnnotations.initMocks(this); doReturn(PERSISTENT_PAYLOAD).when(mockPersistentLogEntry).getData(); doReturn(NON_PERSISTENT_PAYLOAD).when(mockNonPersistentLogEntry).getData(); provider = new RaftActorDelegatingPersistentDataProvider(mockDelegateProvider, mockPersistentProvider); @@ -72,13 +77,18 @@ public class RaftActorDelegatingPersistentDataProviderTest { verify(mockDelegateProvider).persist(OTHER_DATA_OBJECT, mockProcedure); } - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) @Test - public void testPersistWithPersistenceDisabled() { + public void testPersistWithPersistenceDisabled() throws Exception { doReturn(false).when(mockDelegateProvider).isRecoveryApplicable(); provider.persist(mockPersistentLogEntry, mockProcedure); - verify(mockPersistentProvider).persist(mockPersistentLogEntry, mockProcedure); + + ArgumentCaptor procedureCaptor = ArgumentCaptor.forClass(Procedure.class); + verify(mockPersistentProvider).persist(eq(PERSISTENT_PAYLOAD), procedureCaptor.capture()); + verify(mockDelegateProvider, never()).persist(mockNonPersistentLogEntry, mockProcedure); + procedureCaptor.getValue().apply(PERSISTENT_PAYLOAD); + verify(mockProcedure).apply(mockPersistentLogEntry); provider.persist(mockNonPersistentLogEntry, mockProcedure); verify(mockDelegateProvider).persist(mockNonPersistentLogEntry, mockProcedure); @@ -88,12 +98,27 @@ public class RaftActorDelegatingPersistentDataProviderTest { } static class TestNonPersistentPayload extends Payload { + private static final long serialVersionUID = 1L; + @Override public int size() { return 0; } + + @Override + public int serializedSize() { + return 0; + } + + @Override + protected Object writeReplace() { + // Not needed + throw new UnsupportedOperationException(); + } } static class TestPersistentPayload extends TestNonPersistentPayload implements PersistentPayload { + private static final long serialVersionUID = 1L; + } }