X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2FRaftActorTestKit.java;h=ac9f8da34ee6365d5bdc66dcb67a512cf449dfae;hp=3d9214151f6302d26631d35d06f0f4d9266c77ef;hb=2ea38dabb91b086e91b74573e0ec4a2834b152ab;hpb=d617f1570fb165d02e18785b8b1704df7f830087 diff --git a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorTestKit.java b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorTestKit.java index 3d9214151f..ac9f8da34e 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorTestKit.java +++ b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/RaftActorTestKit.java @@ -13,17 +13,21 @@ import akka.pattern.Patterns; import akka.testkit.JavaTestKit; import akka.util.Timeout; import com.google.common.util.concurrent.Uninterruptibles; +import java.util.Optional; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; import org.junit.Assert; import org.opendaylight.controller.cluster.raft.client.messages.FindLeader; import org.opendaylight.controller.cluster.raft.client.messages.FindLeaderReply; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import scala.concurrent.Await; import scala.concurrent.Future; import scala.concurrent.duration.Duration; import scala.concurrent.duration.FiniteDuration; public class RaftActorTestKit extends JavaTestKit { + private static final Logger LOG = LoggerFactory.getLogger(RaftActorTestKit.class); private final ActorRef raftActor; public RaftActorTestKit(ActorSystem actorSystem, String actorName) { @@ -63,17 +67,15 @@ public class RaftActorTestKit extends JavaTestKit { for(int i = 0; i < 20 * 5; i++) { Future future = Patterns.ask(actorRef, FindLeader.INSTANCE, new Timeout(duration)); try { - FindLeaderReply resp = (FindLeaderReply) Await.result(future, duration); - if(resp.getLeaderActor() != null) { + final Optional maybeLeader = ((FindLeaderReply)Await.result(future, duration)).getLeaderActor(); + if (maybeLeader.isPresent()) { return; } } catch(TimeoutException e) { } catch(Exception e) { - System.err.println("FindLeader threw ex"); - e.printStackTrace(); + LOG.error("FindLeader failed", e); } - Uninterruptibles.sleepUninterruptibly(50, TimeUnit.MILLISECONDS); }