X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2FReplicatedLogImplTest.java;h=c6ee950d142afe1b0ff963aa9fef7b0fec6a2e0c;hp=fbe6fc4501f6b6b62b60490036e005e8ca065207;hb=b8c6400766f7324dd57d059bd48e435569fe1a27;hpb=228af4aa1ef1a802fd24e7e010f3bba959ee03dd diff --git a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImplTest.java b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImplTest.java index fbe6fc4501..c6ee950d14 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImplTest.java +++ b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/ReplicatedLogImplTest.java @@ -8,14 +8,12 @@ package org.opendaylight.controller.cluster.raft; import static org.junit.Assert.assertEquals; -import static org.mockito.Matchers.eq; import static org.mockito.Matchers.same; import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.reset; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verifyNoMoreInteractions; import akka.japi.Procedure; -import com.google.common.base.Supplier; import java.util.Collections; import org.hamcrest.BaseMatcher; import org.hamcrest.Description; @@ -50,9 +48,6 @@ public class ReplicatedLogImplTest { @Mock private RaftActorBehavior mockBehavior; - @Mock - private SnapshotManager mockSnapshotManager; - private RaftActorContext context; private final DefaultConfigParamsImpl configParams = new DefaultConfigParamsImpl(); @@ -62,12 +57,7 @@ public class ReplicatedLogImplTest { context = new RaftActorContextImpl(null, null, "test", new ElectionTermImpl(mockPersistence, "test", LOG), - -1, -1, Collections.emptyMap(), configParams, mockPersistence, LOG) { - @Override - public SnapshotManager getSnapshotManager() { - return mockSnapshotManager; - } - }; + -1, -1, Collections.emptyMap(), configParams, mockPersistence, LOG); } private void verifyPersist(Object message) throws Exception { @@ -85,7 +75,7 @@ public class ReplicatedLogImplTest { @SuppressWarnings("unchecked") @Test public void testAppendAndPersistExpectingNoCapture() throws Exception { - ReplicatedLog log = ReplicatedLogImpl.newInstance(context, mockBehavior); + ReplicatedLog log = ReplicatedLogImpl.newInstance(context); MockReplicatedLogEntry logEntry = new MockReplicatedLogEntry(1, 1, new MockPayload("1")); @@ -103,7 +93,6 @@ public class ReplicatedLogImplTest { verifyPersist(logEntry); verify(mockCallback).apply(same(logEntry)); - verifyNoMoreInteractions(mockSnapshotManager); assertEquals("size", 2, log.size()); } @@ -114,7 +103,7 @@ public class ReplicatedLogImplTest { doReturn(1L).when(mockBehavior).getReplicatedToAllIndex(); - ReplicatedLog log = ReplicatedLogImpl.newInstance(context, mockBehavior); + ReplicatedLog log = ReplicatedLogImpl.newInstance(context); MockReplicatedLogEntry logEntry1 = new MockReplicatedLogEntry(1, 2, new MockPayload("2")); MockReplicatedLogEntry logEntry2 = new MockReplicatedLogEntry(1, 3, new MockPayload("3")); @@ -122,13 +111,11 @@ public class ReplicatedLogImplTest { log.appendAndPersist(logEntry1); verifyPersist(logEntry1); - verifyNoMoreInteractions(mockSnapshotManager); reset(mockPersistence); log.appendAndPersist(logEntry2); verifyPersist(logEntry2); - verify(mockSnapshotManager).capture(same(logEntry2), eq(1L)); assertEquals("size", 2, log.size()); } @@ -137,41 +124,30 @@ public class ReplicatedLogImplTest { public void testAppendAndPersistExpectingCaptureDueToDataSize() throws Exception { doReturn(1L).when(mockBehavior).getReplicatedToAllIndex(); - context.setTotalMemoryRetriever(new Supplier() { - @Override - public Long get() { - return 100L; - } - }); + context.setTotalMemoryRetriever(() -> 100); - ReplicatedLog log = ReplicatedLogImpl.newInstance(context, mockBehavior); + ReplicatedLog log = ReplicatedLogImpl.newInstance(context); int dataSize = 600; MockReplicatedLogEntry logEntry = new MockReplicatedLogEntry(1, 2, new MockPayload("2", dataSize)); - doReturn(true).when(mockSnapshotManager).capture(same(logEntry), eq(1L)); - log.appendAndPersist(logEntry); verifyPersist(logEntry); - verify(mockSnapshotManager).capture(same(logEntry), eq(1L)); - - reset(mockPersistence, mockSnapshotManager); + reset(mockPersistence); logEntry = new MockReplicatedLogEntry(1, 3, new MockPayload("3", 5)); log.appendAndPersist(logEntry); verifyPersist(logEntry); - verifyNoMoreInteractions(mockSnapshotManager); - assertEquals("size", 2, log.size()); } @Test public void testRemoveFromAndPersist() throws Exception { - ReplicatedLog log = ReplicatedLogImpl.newInstance(context, mockBehavior); + ReplicatedLog log = ReplicatedLogImpl.newInstance(context); log.append(new MockReplicatedLogEntry(1, 0, new MockPayload("0"))); log.append(new MockReplicatedLogEntry(1, 1, new MockPayload("1")));