X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-akka-raft%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fraft%2Fbehaviors%2FAbstractLeaderElectionScenarioTest.java;h=36f5fd502e3c9cc3d0559dc2c22ab1fd04b0feea;hp=950180ca0a026a0e305df2df6ca88d9e829ee324;hb=f276ae33b951d173b51c467bb7bb1a5f5cf9a1e6;hpb=23049d1bb77b0eb8d115ad7c485c09a2367800df diff --git a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeaderElectionScenarioTest.java b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeaderElectionScenarioTest.java index 950180ca0a..36f5fd502e 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeaderElectionScenarioTest.java +++ b/opendaylight/md-sal/sal-akka-raft/src/test/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeaderElectionScenarioTest.java @@ -25,8 +25,8 @@ import org.junit.After; import org.junit.Before; import org.opendaylight.controller.cluster.raft.DefaultConfigParamsImpl; import org.opendaylight.controller.cluster.raft.MockRaftActorContext; -import org.opendaylight.controller.cluster.raft.RaftActorContext; import org.opendaylight.controller.cluster.raft.RaftState; +import org.opendaylight.controller.cluster.raft.TestActorFactory; import org.opendaylight.controller.cluster.raft.base.messages.SendHeartBeat; import org.opendaylight.controller.cluster.raft.messages.AppendEntriesReply; import org.opendaylight.controller.cluster.raft.utils.MessageCollectorActor; @@ -62,10 +62,13 @@ public class AbstractLeaderElectionScenarioTest { try { if(behavior != null && !dropMessagesToBehavior.containsKey(message.getClass())) { - RaftActorBehavior oldBehavior = behavior; - behavior = behavior.handleMessage(getSender(), message); - if(behavior != oldBehavior && behaviorStateChangeLatch != null) { - behaviorStateChangeLatch.countDown(); + final RaftActorBehavior nextBehavior = behavior.handleMessage(getSender(), message); + if (nextBehavior != null) { + RaftActorBehavior oldBehavior = behavior; + behavior = nextBehavior; + if(behavior != oldBehavior && behaviorStateChangeLatch != null) { + behaviorStateChangeLatch.countDown(); + } } } } finally { @@ -140,6 +143,7 @@ public class AbstractLeaderElectionScenarioTest { protected final Logger testLog = LoggerFactory.getLogger(MockRaftActorContext.class); protected final ActorSystem system = ActorSystem.create("test"); + protected final TestActorFactory factory = new TestActorFactory(system); protected TestActorRef member1ActorRef; protected TestActorRef member2ActorRef; protected TestActorRef member3ActorRef; @@ -197,13 +201,14 @@ public class AbstractLeaderElectionScenarioTest { assertEquals(name + " behavior state", expState, actor.behavior.state()); } - void initializeLeaderBehavior(MemberActor actor, RaftActorContext context, int numActiveFollowers) throws Exception { + void initializeLeaderBehavior(MemberActor actor, MockRaftActorContext context, int numActiveFollowers) throws Exception { // Leader sends immediate heartbeats - we don't care about it so ignore it. actor.expectMessageClass(AppendEntriesReply.class, numActiveFollowers); - @SuppressWarnings("resource") Leader leader = new Leader(context); + context.setCurrentBehavior(leader); + actor.waitForExpectedMessages(AppendEntriesReply.class); // Delay assignment here so the AppendEntriesReply isn't forwarded to the behavior. actor.behavior = leader; @@ -214,7 +219,8 @@ public class AbstractLeaderElectionScenarioTest { } TestActorRef newMemberActor(String name) throws Exception { - TestActorRef actor = TestActorRef.create(system, MemberActor.props(), name); + TestActorRef actor = factory.createTestActor(MemberActor.props(). + withDispatcher(Dispatchers.DefaultDispatcherId()), name); MessageCollectorActor.waitUntilReady(actor); return actor; }