X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-binding-broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fsal%2Fbinding%2Fimpl%2FBindingDOMMountPointServiceAdapter.java;h=f6df2c732621a314feb87c2c8dbefc773b052bb5;hp=3a63fba7301b78f891f0402dcdf07ab0f92c6c2e;hb=4ad8e1880cfee424eac9e4f12e461d98445a6e44;hpb=d7d67c58c7aacbb320f6d3d43918f80ccc2808d1 diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMMountPointServiceAdapter.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMMountPointServiceAdapter.java index 3a63fba730..f6df2c7326 100644 --- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMMountPointServiceAdapter.java +++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/BindingDOMMountPointServiceAdapter.java @@ -7,10 +7,12 @@ */ package org.opendaylight.controller.md.sal.binding.impl; +import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Optional; import com.google.common.cache.CacheBuilder; import com.google.common.cache.CacheLoader; import com.google.common.cache.LoadingCache; +import org.gaul.modernizer_maven_annotations.SuppressModernizer; import org.opendaylight.controller.md.sal.binding.api.MountPoint; import org.opendaylight.controller.md.sal.binding.api.MountPointService; import org.opendaylight.controller.md.sal.dom.api.DOMMountPoint; @@ -21,42 +23,42 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.slf4j.Logger; import org.slf4j.LoggerFactory; - +@Deprecated public class BindingDOMMountPointServiceAdapter implements MountPointService { - - public static final Logger LOG = LoggerFactory.getLogger(BindingDOMMountPointServiceAdapter.class); + private static final Logger LOG = LoggerFactory.getLogger(BindingDOMMountPointServiceAdapter.class); private final BindingToNormalizedNodeCodec codec; private final DOMMountPointService mountService; - private final LoadingCache bindingMountpoints = CacheBuilder.newBuilder() - .build(new CacheLoader() { - + @VisibleForTesting + final LoadingCache bindingMountpoints = CacheBuilder.newBuilder() + .weakKeys().weakValues().build(new CacheLoader() { @Override - public BindingMountPointAdapter load(DOMMountPoint key) throws Exception { - return new BindingMountPointAdapter(codec,key); + public BindingMountPointAdapter load(final DOMMountPoint key) { + return new BindingMountPointAdapter(codec, key); } }); - public BindingDOMMountPointServiceAdapter(DOMMountPointService mountService,BindingToNormalizedNodeCodec codec) { + public BindingDOMMountPointServiceAdapter(final DOMMountPointService mountService, + final BindingToNormalizedNodeCodec codec) { this.codec = codec; this.mountService = mountService; } @Override - public Optional getMountPoint(InstanceIdentifier mountPoint) { + @SuppressModernizer + public Optional getMountPoint(final InstanceIdentifier mountPoint) { - YangInstanceIdentifier domPath = codec.toNormalized(mountPoint); + YangInstanceIdentifier domPath = codec.toYangInstanceIdentifierBlocking(mountPoint); Optional domMount = mountService.getMountPoint(domPath); - if(domMount.isPresent()) { + if (domMount.isPresent()) { return Optional.fromNullable(bindingMountpoints.getUnchecked(domMount.get())); } return Optional.absent(); } @Override - public ListenerRegistration registerListener(InstanceIdentifier path, - T listener) { - return new BindingDOMMountPointListenerAdapter(listener,codec,mountService); + public ListenerRegistration registerListener(final InstanceIdentifier path, + final T listener) { + return new BindingDOMMountPointListenerAdapter<>(listener, codec, mountService); } - }