X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-binding-dom-it%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fsal%2Fbinding%2Ftest%2Fconnect%2Fdom%2FCrossBrokerRpcTest.java;h=a6b5cba145fb45dd3c0d435e28843223279b02fc;hp=63b04840334e5e1eb63d159d484faffcab99fbd7;hb=4f82c49691f091f0ba6b09a07525edb246f17321;hpb=fdb31721b3b17060158556f3e36be5800be18a07 diff --git a/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/CrossBrokerRpcTest.java b/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/CrossBrokerRpcTest.java index 63b0484033..a6b5cba145 100644 --- a/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/CrossBrokerRpcTest.java +++ b/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/sal/binding/test/connect/dom/CrossBrokerRpcTest.java @@ -12,16 +12,13 @@ import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNotSame; import static org.junit.Assert.assertTrue; -import com.google.common.util.concurrent.CheckedFuture; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.MoreExecutors; import java.util.concurrent.Future; import org.junit.After; import org.junit.Before; import org.junit.Test; -import org.opendaylight.controller.md.sal.dom.api.DOMRpcException; import org.opendaylight.controller.md.sal.dom.api.DOMRpcIdentifier; -import org.opendaylight.controller.md.sal.dom.api.DOMRpcImplementation; import org.opendaylight.controller.md.sal.dom.api.DOMRpcProviderService; import org.opendaylight.controller.md.sal.dom.api.DOMRpcResult; import org.opendaylight.controller.md.sal.dom.api.DOMRpcService; @@ -44,7 +41,6 @@ import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.common.RpcResult; import org.opendaylight.yangtools.yang.common.RpcResultBuilder; import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode; -import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.model.api.SchemaPath; public class CrossBrokerRpcTest { @@ -74,7 +70,7 @@ public class CrossBrokerRpcTest { @Before public void setup() { BindingBrokerTestFactory testFactory = new BindingBrokerTestFactory(); - testFactory.setExecutor(MoreExecutors.sameThreadExecutor()); + testFactory.setExecutor(MoreExecutors.newDirectExecutorService()); testFactory.setStartWithParsedSchema(true); testContext = testFactory.getTestContext(); @@ -119,13 +115,9 @@ public class CrossBrokerRpcTest { builder.setAnswer("open"); final KnockKnockOutput output = builder.build(); - provisionRegistry.registerRpcImplementation(new DOMRpcImplementation() { - - @Override - public CheckedFuture invokeRpc(DOMRpcIdentifier rpc, NormalizedNode input) { - ContainerNode result = testContext.getCodec().getCodecFactory().toNormalizedNodeRpcData(output); - return Futures.immediateCheckedFuture(new DefaultDOMRpcResult(result)); - } + provisionRegistry.registerRpcImplementation((rpc, input) -> { + ContainerNode result = testContext.getCodec().getCodecFactory().toNormalizedNodeRpcData(output); + return Futures.immediateCheckedFuture(new DefaultDOMRpcResult(result)); }, DOMRpcIdentifier.create(KNOCK_KNOCK_PATH, BI_NODE_C_ID)); OpendaylightOfMigrationTestModelService baKnockInvoker = @@ -135,7 +127,7 @@ public class CrossBrokerRpcTest { assertEquals(output, baResult.get().getResult()); } - private ContainerNode toDomRpcInput(DataObject addFlowA) { + private ContainerNode toDomRpcInput(final DataObject addFlowA) { return testContext.getCodec().getCodecFactory().toNormalizedNodeRpcData(addFlowA); } @@ -144,26 +136,26 @@ public class CrossBrokerRpcTest { testContext.close(); } - private static org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier createBINodeIdentifier(TopLevelListKey listKey) { + private static org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier createBINodeIdentifier(final TopLevelListKey listKey) { return org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.builder().node(Top.QNAME) .node(TopLevelList.QNAME) .nodeWithKey(TopLevelList.QNAME, NODE_ID_QNAME, listKey.getName()).build(); } - private Future> knockResult(boolean success, String answer) { + private Future> knockResult(final boolean success, final String answer) { KnockKnockOutput output = new KnockKnockOutputBuilder() // .setAnswer(answer).build(); RpcResult result = RpcResultBuilder.status(success).withResult(output).build(); return Futures.immediateFuture(result); } - private static KnockKnockInputBuilder knockKnock(InstanceIdentifier listId) { + private static KnockKnockInputBuilder knockKnock(final InstanceIdentifier listId) { KnockKnockInputBuilder builder = new KnockKnockInputBuilder(); builder.setKnockerId(listId); return builder; } - private ContainerNode toDomRpc(QName rpcName, KnockKnockInput knockInput) { + private ContainerNode toDomRpc(final QName rpcName, final KnockKnockInput knockInput) { return toDomRpcInput(knockInput); } }