X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-clustering-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fcommon%2Factor%2FMeteredBoundedMailbox.java;h=d234532751e94d871162a82b00d7d051e101ab6c;hp=258672114a9ac2ccce436b8623e4fd3f209796bb;hb=90f03193700920e656596d2a2257802cb22a90c7;hpb=6d03458bb71b7c0308746577d7e3035d33971c9b

diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java
index 258672114a..d234532751 100644
--- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java
+++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteredBoundedMailbox.java
@@ -30,7 +30,7 @@ public class MeteredBoundedMailbox implements MailboxType,
     private final Integer capacity;
     private final FiniteDuration pushTimeOut;
 
-    public MeteredBoundedMailbox(ActorSystem.Settings settings, Config config) {
+    public MeteredBoundedMailbox(final ActorSystem.Settings settings, final Config config) {
 
         CommonConfig commonConfig = new CommonConfig(settings.config());
         this.capacity = commonConfig.getMailBoxCapacity();
@@ -39,13 +39,13 @@ public class MeteredBoundedMailbox implements MailboxType,
 
 
     @Override
-    public MeteredMessageQueue create(final scala.Option<ActorRef> owner, scala.Option<ActorSystem> system) {
+    public MeteredMessageQueue create(final scala.Option<ActorRef> owner, final scala.Option<ActorSystem> system) {
         final MeteredMessageQueue queue = new MeteredMessageQueue(this.capacity, this.pushTimeOut);
         monitorQueueSize(owner, queue);
         return queue;
     }
 
-    private void monitorQueueSize(scala.Option<ActorRef> owner, final MeteredMessageQueue monitoredQueue) {
+    private static void monitorQueueSize(final scala.Option<ActorRef> owner, final MeteredMessageQueue monitoredQueue) {
         registerMetric(owner, QUEUE_SIZE, getQueueSizeGuage(monitoredQueue));
     }
 
@@ -53,7 +53,8 @@ public class MeteredBoundedMailbox implements MailboxType,
         return monitoredQueue::size;
     }
 
-    static <T extends Metric> void registerMetric(scala.Option<ActorRef> owner, String metricName, T metric) {
+    static <T extends Metric> void registerMetric(final scala.Option<ActorRef> owner, final String metricName,
+            final T metric) {
         if (owner.isEmpty()) {
            // there's no actor to monitor
             return;
@@ -73,14 +74,14 @@ public class MeteredBoundedMailbox implements MailboxType,
             registry.register(fullName, metric);
         } catch (IllegalArgumentException e) {
             // already registered - shouldn't happen here since we check above...
-            LOG.debug("Unable to register '{}' in metrics registry: {}", e);
+            LOG.debug("Unable to register '{}' in metrics registry", fullName);
         }
     }
 
     public static class MeteredMessageQueue extends BoundedDequeBasedMailbox.MessageQueue {
         private static final long serialVersionUID = 1L;
 
-        public MeteredMessageQueue(int capacity, FiniteDuration pushTimeOut) {
+        public MeteredMessageQueue(final int capacity, final FiniteDuration pushTimeOut) {
             super(capacity, pushTimeOut);
         }
     }