X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-clustering-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fmessaging%2FMessageSlicer.java;h=ca2441e438064b34af1bd28c41b8fd93827de738;hp=5f75e495af5b7db6f7f4ab4da2fab5cf3ee3d19a;hb=a6af137c30470b86d4bc624d4c48cb686495a182;hpb=12fcdfe39aa26dcba7fd3bb4d4c68e3d02e65c51 diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/messaging/MessageSlicer.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/messaging/MessageSlicer.java index 5f75e495af..ca2441e438 100644 --- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/messaging/MessageSlicer.java +++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/messaging/MessageSlicer.java @@ -16,7 +16,6 @@ import com.google.common.cache.RemovalNotification; import java.io.IOException; import java.io.ObjectOutputStream; import java.io.Serializable; -import java.util.Iterator; import java.util.Optional; import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicLong; @@ -55,7 +54,7 @@ public class MessageSlicer implements AutoCloseable { this.logContext = builder.logContext + "_slicer-id-" + id; CacheBuilder> cacheBuilder = - CacheBuilder.newBuilder().removalListener(notification -> stateRemoved(notification)); + CacheBuilder.newBuilder().removalListener(this::stateRemoved); if (builder.expireStateAfterInactivityDuration > 0) { cacheBuilder = cacheBuilder.expireAfterAccess(builder.expireStateAfterInactivityDuration, builder.expireStateAfterInactivityUnit); @@ -206,12 +205,8 @@ public class MessageSlicer implements AutoCloseable { * @param filter filters by Identifier */ public void cancelSlicing(@Nonnull final Predicate filter) { - final Iterator iter = stateCache.asMap().keySet().iterator(); - while (iter.hasNext()) { - if (filter.test(iter.next().getClientIdentifier())) { - iter.remove(); - } - } + stateCache.asMap().keySet().removeIf( + messageSliceIdentifier -> filter.test(messageSliceIdentifier.getClientIdentifier())); } private static MessageSlice getNextSliceMessage(final SlicedMessageState state) throws IOException {