X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FAbstractTransactionContextFactory.java;h=211ebec63c3074e9199d9c034290928495451b91;hp=1e085523fdc0599e21a320e4d721abdba9bd13a1;hb=3404a29b4ee3b146a5ff98889bcf1afdebb65c3f;hpb=380b9ee20a2032cd223e66dded8204519540803f diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/AbstractTransactionContextFactory.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/AbstractTransactionContextFactory.java index 1e085523fd..211ebec63c 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/AbstractTransactionContextFactory.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/AbstractTransactionContextFactory.java @@ -7,22 +7,24 @@ */ package org.opendaylight.controller.cluster.datastore; +import static java.util.Objects.requireNonNull; + import akka.actor.ActorSelection; -import akka.dispatch.OnComplete; -import com.google.common.base.Optional; -import com.google.common.base.Preconditions; import java.util.Collection; +import java.util.Optional; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; -import java.util.concurrent.atomic.AtomicLong; -import javax.annotation.Nonnull; -import org.opendaylight.controller.cluster.datastore.identifiers.TransactionIdentifier; +import java.util.concurrent.atomic.AtomicLongFieldUpdater; +import org.eclipse.jdt.annotation.NonNull; +import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier; +import org.opendaylight.controller.cluster.access.concepts.MemberName; +import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.controller.cluster.datastore.messages.PrimaryShardInfo; -import org.opendaylight.controller.cluster.datastore.utils.ActorContext; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadWriteTransaction; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; -import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTree; +import org.opendaylight.controller.cluster.datastore.utils.ActorUtils; +import org.opendaylight.mdsal.dom.spi.store.DOMStoreReadTransaction; +import org.opendaylight.mdsal.dom.spi.store.DOMStoreReadWriteTransaction; +import org.opendaylight.mdsal.dom.spi.store.DOMStoreWriteTransaction; +import org.opendaylight.yangtools.yang.data.api.schema.tree.ReadOnlyDataTree; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import scala.concurrent.Future; @@ -34,111 +36,155 @@ import scala.util.Try; */ abstract class AbstractTransactionContextFactory implements AutoCloseable { private static final Logger LOG = LoggerFactory.getLogger(AbstractTransactionContextFactory.class); - - protected static final AtomicLong TX_COUNTER = new AtomicLong(); + @SuppressWarnings("rawtypes") + private static final AtomicLongFieldUpdater TX_COUNTER_UPDATER = + AtomicLongFieldUpdater.newUpdater(AbstractTransactionContextFactory.class, "nextTx"); private final ConcurrentMap knownLocal = new ConcurrentHashMap<>(); - private final ActorContext actorContext; + private final LocalHistoryIdentifier historyId; + private final ActorUtils actorUtils; - protected AbstractTransactionContextFactory(final ActorContext actorContext) { - this.actorContext = Preconditions.checkNotNull(actorContext); + // Used via TX_COUNTER_UPDATER + @SuppressWarnings("unused") + private volatile long nextTx; + + protected AbstractTransactionContextFactory(final ActorUtils actorUtils, final LocalHistoryIdentifier historyId) { + this.actorUtils = requireNonNull(actorUtils); + this.historyId = requireNonNull(historyId); } - final ActorContext getActorContext() { - return actorContext; + final ActorUtils getActorUtils() { + return actorUtils; } - private TransactionContext maybeCreateLocalTransactionContext(final TransactionProxy parent, final String shardName) { + final LocalHistoryIdentifier getHistoryId() { + return historyId; + } + + @SuppressWarnings("checkstyle:IllegalCatch") + private TransactionContext maybeCreateLocalTransactionContext(final TransactionProxy parent, + final String shardName) { final LocalTransactionFactory local = knownLocal.get(shardName); if (local != null) { - if(LOG.isDebugEnabled()) { - LOG.debug("Tx {} - Creating local component for shard {} using factory {}", - parent.getIdentifier(), shardName, local); + LOG.debug("Tx {} - Creating local component for shard {} using factory {}", parent.getIdentifier(), + shardName, local); + + try { + return createLocalTransactionContext(local, parent); + } catch (Exception e) { + return new NoOpTransactionContext(e, parent.getIdentifier()); } - return createLocalTransactionContext(local, parent); } return null; } - private void onFindPrimaryShardSuccess(PrimaryShardInfo primaryShardInfo, TransactionProxy parent, - String shardName, TransactionContextWrapper transactionContextWrapper) { - if(LOG.isDebugEnabled()) { - LOG.debug("Tx {}: Found primary {} for shard {}", parent.getIdentifier(), - primaryShardInfo.getPrimaryShardActor(), shardName); + private AbstractTransactionContextWrapper maybeCreateDirectTransactionContextWrapper( + final PrimaryShardInfo primaryShardInfo, final TransactionProxy parent, + final String shardName, final DelayedTransactionContextWrapper transactionContextWrapper) { + LOG.debug("Tx {}: Found primary {} for shard {}, trying to use DirectTransactionContextWrapper", + parent.getIdentifier(), primaryShardInfo.getPrimaryShardActor(), shardName); + + updateShardInfo(shardName, primaryShardInfo); + + final TransactionContext localContext = maybeCreateLocalTransactionContext(parent, shardName); + try { + if (localContext != null) { + LOG.debug("Tx {}: Local transaction context created successfully, using DirectTransactionWrapper", + parent.getIdentifier()); + return new DirectTransactionContextWrapper(parent.getIdentifier(), actorUtils, shardName, + localContext); + } else { + LOG.debug("Tx {}: Local transaction context creation failed, using DelayedTransactionWrapper", + parent.getIdentifier()); + final RemoteTransactionContextSupport remote = new RemoteTransactionContextSupport( + transactionContextWrapper, parent, shardName); + remote.setPrimaryShard(primaryShardInfo); + return transactionContextWrapper; + } + } finally { + onTransactionContextCreated(parent.getIdentifier()); } + } + + private void onFindPrimaryShardSuccess(final PrimaryShardInfo primaryShardInfo, final TransactionProxy parent, + final String shardName, final DelayedTransactionContextWrapper transactionContextWrapper) { + LOG.debug("Tx {}: Found primary {} for shard {}", parent.getIdentifier(), + primaryShardInfo.getPrimaryShardActor(), shardName); updateShardInfo(shardName, primaryShardInfo); - TransactionContext localContext = maybeCreateLocalTransactionContext(parent, shardName); - if(localContext != null) { - transactionContextWrapper.executePriorTransactionOperations(localContext); - } else { - RemoteTransactionContextSupport remote = new RemoteTransactionContextSupport(transactionContextWrapper, - parent, shardName); - remote.setPrimaryShard(primaryShardInfo.getPrimaryShardActor(), primaryShardInfo.getPrimaryShardVersion()); + final TransactionContext localContext = maybeCreateLocalTransactionContext(parent, shardName); + try { + if (localContext != null) { + transactionContextWrapper.executePriorTransactionOperations(localContext); + } else { + final RemoteTransactionContextSupport remote = new RemoteTransactionContextSupport( + transactionContextWrapper, parent, shardName); + remote.setPrimaryShard(primaryShardInfo); + } + } finally { + onTransactionContextCreated(parent.getIdentifier()); } } - private void onFindPrimaryShardFailure(Throwable failure, TransactionProxy parent, - String shardName, TransactionContextWrapper transactionContextWrapper) { + private void onFindPrimaryShardFailure(final Throwable failure, final TransactionProxy parent, + final String shardName, final DelayedTransactionContextWrapper transactionContextWrapper) { LOG.debug("Tx {}: Find primary for shard {} failed", parent.getIdentifier(), shardName, failure); - transactionContextWrapper.executePriorTransactionOperations(new NoOpTransactionContext(failure, - parent.getIdentifier())); + try { + transactionContextWrapper.executePriorTransactionOperations( + new NoOpTransactionContext(failure, parent.getIdentifier())); + } finally { + onTransactionContextCreated(parent.getIdentifier()); + } } - final TransactionContextWrapper newTransactionContextWrapper(final TransactionProxy parent, final String shardName) { - final TransactionContextWrapper transactionContextWrapper = - new TransactionContextWrapper(parent.getIdentifier(), actorContext); - - Future findPrimaryFuture = findPrimaryShard(shardName); - if(findPrimaryFuture.isCompleted()) { - Try maybe = findPrimaryFuture.value().get(); - if(maybe.isSuccess()) { - onFindPrimaryShardSuccess(maybe.get(), parent, shardName, transactionContextWrapper); + final AbstractTransactionContextWrapper newTransactionContextWrapper(final TransactionProxy parent, + final String shardName) { + final DelayedTransactionContextWrapper contextWrapper = new DelayedTransactionContextWrapper( + parent.getIdentifier(), actorUtils, shardName); + final Future findPrimaryFuture = findPrimaryShard(shardName, parent.getIdentifier()); + if (findPrimaryFuture.isCompleted()) { + final Try maybe = findPrimaryFuture.value().get(); + if (maybe.isSuccess()) { + return maybeCreateDirectTransactionContextWrapper(maybe.get(), parent, shardName, + contextWrapper); } else { - onFindPrimaryShardFailure(maybe.failed().get(), parent, shardName, transactionContextWrapper); + onFindPrimaryShardFailure(maybe.failed().get(), parent, shardName, + contextWrapper); } } else { - findPrimaryFuture.onComplete(new OnComplete() { - @Override - public void onComplete(final Throwable failure, final PrimaryShardInfo primaryShardInfo) { - if (failure == null) { - onFindPrimaryShardSuccess(primaryShardInfo, parent, shardName, transactionContextWrapper); - } else { - onFindPrimaryShardFailure(failure, parent, shardName, transactionContextWrapper); - } + findPrimaryFuture.onComplete((result) -> { + if (result.isSuccess()) { + onFindPrimaryShardSuccess(result.get(), parent, shardName, contextWrapper); + } else { + onFindPrimaryShardFailure(result.failed().get(), parent, shardName, contextWrapper); } - }, actorContext.getClientDispatcher()); + return null; + }, actorUtils.getClientDispatcher()); } - - return transactionContextWrapper; + return contextWrapper; } private void updateShardInfo(final String shardName, final PrimaryShardInfo primaryShardInfo) { - final Optional maybeDataTree = primaryShardInfo.getLocalShardDataTree(); + final Optional maybeDataTree = primaryShardInfo.getLocalShardDataTree(); if (maybeDataTree.isPresent()) { - if(!knownLocal.containsKey(shardName)) { + if (!knownLocal.containsKey(shardName)) { LOG.debug("Shard {} resolved to local data tree - adding local factory", shardName); F factory = factoryForShard(shardName, primaryShardInfo.getPrimaryShardActor(), maybeDataTree.get()); knownLocal.putIfAbsent(shardName, factory); } - } else if(knownLocal.containsKey(shardName)) { + } else if (knownLocal.containsKey(shardName)) { LOG.debug("Shard {} invalidating local data tree", shardName); knownLocal.remove(shardName); } } - protected String getMemberName() { - String memberName = getActorContext().getCurrentMemberName(); - if (memberName == null) { - memberName = "UNKNOWN-MEMBER"; - } - - return memberName; + protected final MemberName getMemberName() { + return historyId.getClientId().getFrontendId().getMemberName(); } /** @@ -146,7 +192,9 @@ abstract class AbstractTransactionContextFactory findPrimaryShard(String shardName); + protected abstract Future findPrimaryShard(@NonNull String shardName, + @NonNull TransactionIdentifier txId); /** * Create local transaction factory for specified shard, backed by specified shard leader * and data tree instance. * - * @param shardName - * @param shardLeader + * @param shardName the shard name + * @param shardLeader the shard leader * @param dataTree Backing data tree instance. The data tree may only be accessed in * read-only manner. * @return Transaction factory for local use. */ - protected abstract F factoryForShard(String shardName, ActorSelection shardLeader, DataTree dataTree); + protected abstract F factoryForShard(String shardName, ActorSelection shardLeader, ReadOnlyDataTree dataTree); /** * Callback invoked from child transactions to push any futures, which need to * be waited for before the next transaction is allocated. * @param cohortFutures Collection of futures */ - protected abstract void onTransactionReady(@Nonnull TransactionIdentifier transaction, @Nonnull Collection> cohortFutures); + protected abstract void onTransactionReady(@NonNull TransactionIdentifier transaction, + @NonNull Collection> cohortFutures); + + /** + * Callback invoked when the internal TransactionContext has been created for a transaction. + * + * @param transactionId the ID of the transaction. + */ + protected abstract void onTransactionContextCreated(@NonNull TransactionIdentifier transactionId); private static TransactionContext createLocalTransactionContext(final LocalTransactionFactory factory, final TransactionProxy parent) { - switch(parent.getType()) { + switch (parent.getType()) { case READ_ONLY: final DOMStoreReadTransaction readOnly = factory.newReadOnlyTransaction(parent.getIdentifier()); - return new LocalTransactionContext(readOnly, parent.getIdentifier()) { + return new LocalTransactionContext(readOnly, parent.getIdentifier(), factory) { @Override protected DOMStoreWriteTransaction getWriteDelegate() { throw new UnsupportedOperationException(); @@ -194,7 +251,7 @@ abstract class AbstractTransactionContextFactory