X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FAbstractTransactionContextFactory.java;h=69c69bb84b395dc5d89db35f74cdd44343987c95;hp=976e613e8ea183b293d666bc56c8fd8cbc358123;hb=ef3b9a8300db1c791f2c4088d39152ccf9f5b97c;hpb=9302c5052c431ae2add87d4e14a68570ef7604ec diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/AbstractTransactionContextFactory.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/AbstractTransactionContextFactory.java index 976e613e8e..69c69bb84b 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/AbstractTransactionContextFactory.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/AbstractTransactionContextFactory.java @@ -9,14 +9,16 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorSelection; import akka.dispatch.OnComplete; -import com.google.common.base.Optional; import com.google.common.base.Preconditions; import java.util.Collection; +import java.util.Optional; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; -import java.util.concurrent.atomic.AtomicLong; +import java.util.concurrent.atomic.AtomicLongFieldUpdater; import javax.annotation.Nonnull; -import org.opendaylight.controller.cluster.datastore.identifiers.TransactionIdentifier; +import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier; +import org.opendaylight.controller.cluster.access.concepts.MemberName; +import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.controller.cluster.datastore.messages.PrimaryShardInfo; import org.opendaylight.controller.cluster.datastore.utils.ActorContext; import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; @@ -34,110 +36,130 @@ import scala.util.Try; */ abstract class AbstractTransactionContextFactory implements AutoCloseable { private static final Logger LOG = LoggerFactory.getLogger(AbstractTransactionContextFactory.class); - - protected static final AtomicLong TX_COUNTER = new AtomicLong(); + @SuppressWarnings("rawtypes") + private static final AtomicLongFieldUpdater TX_COUNTER_UPDATER = + AtomicLongFieldUpdater.newUpdater(AbstractTransactionContextFactory.class, "nextTx"); private final ConcurrentMap knownLocal = new ConcurrentHashMap<>(); + private final LocalHistoryIdentifier historyId; private final ActorContext actorContext; - protected AbstractTransactionContextFactory(final ActorContext actorContext) { + // Used via TX_COUNTER_UPDATER + @SuppressWarnings("unused") + private volatile long nextTx; + + protected AbstractTransactionContextFactory(final ActorContext actorContext, + final LocalHistoryIdentifier historyId) { this.actorContext = Preconditions.checkNotNull(actorContext); + this.historyId = Preconditions.checkNotNull(historyId); } final ActorContext getActorContext() { return actorContext; } - private TransactionContext maybeCreateLocalTransactionContext(final TransactionProxy parent, final String shardName) { + final LocalHistoryIdentifier getHistoryId() { + return historyId; + } + + @SuppressWarnings("checkstyle:IllegalCatch") + private TransactionContext maybeCreateLocalTransactionContext(final TransactionProxy parent, + final String shardName) { final LocalTransactionFactory local = knownLocal.get(shardName); if (local != null) { - if(LOG.isDebugEnabled()) { - LOG.debug("Tx {} - Creating local component for shard {} using factory {}", - parent.getIdentifier(), shardName, local); + LOG.debug("Tx {} - Creating local component for shard {} using factory {}", parent.getIdentifier(), + shardName, local); + + try { + return createLocalTransactionContext(local, parent); + } catch (Exception e) { + return new NoOpTransactionContext(e, parent.getIdentifier()); } - return createLocalTransactionContext(local, parent); } return null; } private void onFindPrimaryShardSuccess(PrimaryShardInfo primaryShardInfo, TransactionProxy parent, - String shardName, TransactionContextWrapper transactionContextAdapter) { - if(LOG.isDebugEnabled()) { - LOG.debug("Tx {}: Found primary {} for shard {}", parent.getIdentifier(), - primaryShardInfo.getPrimaryShardActor(), shardName); - } + String shardName, TransactionContextWrapper transactionContextWrapper) { + LOG.debug("Tx {}: Found primary {} for shard {}", parent.getIdentifier(), + primaryShardInfo.getPrimaryShardActor(), shardName); updateShardInfo(shardName, primaryShardInfo); - TransactionContext localContext = maybeCreateLocalTransactionContext(parent, shardName); - if(localContext != null) { - transactionContextAdapter.executePriorTransactionOperations(localContext); - } else { - RemoteTransactionContextSupport remote = new RemoteTransactionContextSupport(transactionContextAdapter, - parent, shardName); - remote.setPrimaryShard(primaryShardInfo.getPrimaryShardActor(), primaryShardInfo.getPrimaryShardVersion()); + try { + TransactionContext localContext = maybeCreateLocalTransactionContext(parent, shardName); + if (localContext != null) { + transactionContextWrapper.executePriorTransactionOperations(localContext); + } else { + RemoteTransactionContextSupport remote = new RemoteTransactionContextSupport(transactionContextWrapper, + parent, shardName); + remote.setPrimaryShard(primaryShardInfo); + } + } finally { + onTransactionContextCreated(parent.getIdentifier()); } } private void onFindPrimaryShardFailure(Throwable failure, TransactionProxy parent, - String shardName, TransactionContextWrapper transactionContextAdapter) { + String shardName, TransactionContextWrapper transactionContextWrapper) { LOG.debug("Tx {}: Find primary for shard {} failed", parent.getIdentifier(), shardName, failure); - transactionContextAdapter.executePriorTransactionOperations(new NoOpTransactionContext(failure, - parent.getLimiter())); + try { + transactionContextWrapper.executePriorTransactionOperations(new NoOpTransactionContext(failure, + parent.getIdentifier())); + } finally { + onTransactionContextCreated(parent.getIdentifier()); + } } - final TransactionContextWrapper newTransactionAdapter(final TransactionProxy parent, final String shardName) { - final TransactionContextWrapper transactionContextAdapter = new TransactionContextWrapper(parent.getLimiter()); + final TransactionContextWrapper newTransactionContextWrapper(final TransactionProxy parent, + final String shardName) { + final TransactionContextWrapper transactionContextWrapper = + new TransactionContextWrapper(parent.getIdentifier(), actorContext); - Future findPrimaryFuture = findPrimaryShard(shardName); - if(findPrimaryFuture.isCompleted()) { + Future findPrimaryFuture = findPrimaryShard(shardName, parent.getIdentifier()); + if (findPrimaryFuture.isCompleted()) { Try maybe = findPrimaryFuture.value().get(); - if(maybe.isSuccess()) { - onFindPrimaryShardSuccess(maybe.get(), parent, shardName, transactionContextAdapter); + if (maybe.isSuccess()) { + onFindPrimaryShardSuccess(maybe.get(), parent, shardName, transactionContextWrapper); } else { - onFindPrimaryShardFailure(maybe.failed().get(), parent, shardName, transactionContextAdapter); + onFindPrimaryShardFailure(maybe.failed().get(), parent, shardName, transactionContextWrapper); } } else { findPrimaryFuture.onComplete(new OnComplete() { @Override public void onComplete(final Throwable failure, final PrimaryShardInfo primaryShardInfo) { if (failure == null) { - onFindPrimaryShardSuccess(primaryShardInfo, parent, shardName, transactionContextAdapter); + onFindPrimaryShardSuccess(primaryShardInfo, parent, shardName, transactionContextWrapper); } else { - onFindPrimaryShardFailure(failure, parent, shardName, transactionContextAdapter); + onFindPrimaryShardFailure(failure, parent, shardName, transactionContextWrapper); } } }, actorContext.getClientDispatcher()); } - return transactionContextAdapter; + return transactionContextWrapper; } private void updateShardInfo(final String shardName, final PrimaryShardInfo primaryShardInfo) { final Optional maybeDataTree = primaryShardInfo.getLocalShardDataTree(); if (maybeDataTree.isPresent()) { - if(!knownLocal.containsKey(shardName)) { + if (!knownLocal.containsKey(shardName)) { LOG.debug("Shard {} resolved to local data tree - adding local factory", shardName); F factory = factoryForShard(shardName, primaryShardInfo.getPrimaryShardActor(), maybeDataTree.get()); knownLocal.putIfAbsent(shardName, factory); } - } else if(knownLocal.containsKey(shardName)) { + } else if (knownLocal.containsKey(shardName)) { LOG.debug("Shard {} invalidating local data tree", shardName); knownLocal.remove(shardName); } } - protected String getMemberName() { - String memberName = getActorContext().getCurrentMemberName(); - if (memberName == null) { - memberName = "UNKNOWN-MEMBER"; - } - - return memberName; + protected final MemberName getMemberName() { + return historyId.getClientId().getFrontendId().getMemberName(); } /** @@ -145,7 +167,9 @@ abstract class AbstractTransactionContextFactory findPrimaryShard(String shardName); + protected abstract Future findPrimaryShard(@Nonnull String shardName, + @Nonnull TransactionIdentifier txId); /** * Create local transaction factory for specified shard, backed by specified shard leader * and data tree instance. * - * @param shardName - * @param shardLeader + * @param shardName the shard name + * @param shardLeader the shard leader * @param dataTree Backing data tree instance. The data tree may only be accessed in * read-only manner. * @return Transaction factory for local use. @@ -172,13 +197,23 @@ abstract class AbstractTransactionContextFactory void onTransactionReady(@Nonnull TransactionIdentifier transaction, @Nonnull Collection> cohortFutures); + protected abstract void onTransactionReady(@Nonnull TransactionIdentifier transaction, + @Nonnull Collection> cohortFutures); + + /** + * Callback invoked when the internal TransactionContext has been created for a transaction. + * + * @param transactionId the ID of the transaction. + */ + protected abstract void onTransactionContextCreated(@Nonnull TransactionIdentifier transactionId); + + private static TransactionContext createLocalTransactionContext(final LocalTransactionFactory factory, + final TransactionProxy parent) { - private static TransactionContext createLocalTransactionContext(final LocalTransactionFactory factory, final TransactionProxy parent) { - switch(parent.getType()) { + switch (parent.getType()) { case READ_ONLY: final DOMStoreReadTransaction readOnly = factory.newReadOnlyTransaction(parent.getIdentifier()); - return new LocalTransactionContext(readOnly, parent.getLimiter()) { + return new LocalTransactionContext(readOnly, parent.getIdentifier(), factory) { @Override protected DOMStoreWriteTransaction getWriteDelegate() { throw new UnsupportedOperationException(); @@ -191,7 +226,7 @@ abstract class AbstractTransactionContextFactory