X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDataChangeListener.java;h=cee73445778ea473a61c50b66c61bcb92ca0878f;hp=ba09d0402530921667915eae11103302cfcfb2ea;hb=b00bee7547dbba0677347e991a8674f90752f6a2;hpb=0d78fea60c4818145e7bd8479427dfc04f0f8145 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListener.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListener.java index ba09d04025..cee7344577 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListener.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListener.java @@ -9,22 +9,95 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.Props; -import akka.actor.UntypedActor; import akka.japi.Creator; +import com.google.common.base.Preconditions; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import org.opendaylight.controller.cluster.common.actor.AbstractUntypedActor; +import org.opendaylight.controller.cluster.datastore.messages.DataChanged; +import org.opendaylight.controller.cluster.datastore.messages.DataChangedReply; +import org.opendaylight.controller.cluster.datastore.messages.EnableNotification; +import org.opendaylight.controller.md.sal.binding.api.DataTreeChangeListener; +import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeEvent; +import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeListener; +import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; +import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; -public class DataChangeListener extends UntypedActor { - @Override public void onReceive(Object message) throws Exception { - throw new UnsupportedOperationException("onReceive"); +/** + * Actor for a DataChangeListener. + * + * @deprecated Replaced by {@link DataTreeChangeListener} + */ +@Deprecated +public class DataChangeListener extends AbstractUntypedActor { + private final AsyncDataChangeListener> listener; + private boolean notificationsEnabled = false; + + public DataChangeListener(AsyncDataChangeListener> listener) { + this.listener = Preconditions.checkNotNull(listener, "listener should not be null"); + } + + @Override + public void handleReceive(Object message) { + if (message instanceof DataChanged) { + dataChanged(message); + } else if (message instanceof EnableNotification) { + enableNotification((EnableNotification) message); + } else { + unknownMessage(message); + } } - public static Props props() { - return Props.create(new Creator() { - @Override - public DataChangeListener create() throws Exception { - return new DataChangeListener(); - } + private void enableNotification(EnableNotification message) { + notificationsEnabled = message.isEnabled(); + LOG.debug("{} notifications for listener {}", notificationsEnabled ? "Enabled" : "Disabled", + listener); + } + + @SuppressWarnings("checkstyle:IllegalCatch") + private void dataChanged(Object message) { + + // Do nothing if notifications are not enabled + if (!notificationsEnabled) { + LOG.debug("Notifications not enabled for listener {} - dropping change notification", listener); + return; + } + + DataChanged reply = (DataChanged) message; + AsyncDataChangeEvent> change = reply.getChange(); + + LOG.debug("Sending change notification {} to listener {}", change, listener); + + try { + this.listener.onDataChanged(change); + } catch (RuntimeException e) { + LOG.error( String.format( "Error notifying listener %s", this.listener ), e ); + } + + if (isValidSender(getSender())) { + getSender().tell(DataChangedReply.INSTANCE, getSelf()); + } + } + + public static Props props(final AsyncDataChangeListener> listener) { + return Props.create(new DataChangeListenerCreator(listener)); + } + + private static class DataChangeListenerCreator implements Creator { + private static final long serialVersionUID = 1L; + + @SuppressFBWarnings(value = "SE_BAD_FIELD", justification = "This field is not Serializable but we don't " + + "create remote instances of this actor and thus don't need it to be Serializable.") + final AsyncDataChangeListener> listener; - }); + DataChangeListenerCreator( + AsyncDataChangeListener> listener) { + this.listener = listener; + } + @Override + public DataChangeListener create() throws Exception { + return new DataChangeListener(listener); + } } }