X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDataTreeChangeListenerProxy.java;h=f60e676013ae0d2ed3c9b7ed0aab265da112b4d4;hp=4776f2e0438b43cc256286f68a0969ce3f542993;hb=a3cecfd01d0ef8922530924e3ee9684eb03ee5d6;hpb=925cb4a228d0fda99c7bfeb432eb25285a223887 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerProxy.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerProxy.java index 4776f2e043..f60e676013 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerProxy.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeChangeListenerProxy.java @@ -37,15 +37,18 @@ final class DataTreeChangeListenerProxy ext private static final Logger LOG = LoggerFactory.getLogger(DataTreeChangeListenerProxy.class); private final ActorRef dataChangeListenerActor; private final ActorContext actorContext; + private final YangInstanceIdentifier registeredPath; @GuardedBy("this") private ActorSelection listenerRegistrationActor; - DataTreeChangeListenerProxy(final ActorContext actorContext, final T listener) { + DataTreeChangeListenerProxy(final ActorContext actorContext, final T listener, + final YangInstanceIdentifier registeredPath) { super(listener); this.actorContext = Preconditions.checkNotNull(actorContext); + this.registeredPath = Preconditions.checkNotNull(registeredPath); this.dataChangeListenerActor = actorContext.getActorSystem().actorOf( - DataTreeChangeListenerActor.props(getInstance()) + DataTreeChangeListenerActor.props(getInstance(), registeredPath) .withDispatcher(actorContext.getNotificationDispatcherPath())); } @@ -59,19 +62,19 @@ final class DataTreeChangeListenerProxy ext dataChangeListenerActor.tell(PoisonPill.getInstance(), ActorRef.noSender()); } - void init(final String shardName, final YangInstanceIdentifier treeId) { + void init(final String shardName) { Future findFuture = actorContext.findLocalShardAsync(shardName); findFuture.onComplete(new OnComplete() { @Override public void onComplete(final Throwable failure, final ActorRef shard) { if (failure instanceof LocalShardNotFoundException) { LOG.debug("No local shard found for {} - DataTreeChangeListener {} at path {} " - + "cannot be registered", shardName, getInstance(), treeId); + + "cannot be registered", shardName, getInstance(), registeredPath); } else if (failure != null) { LOG.error("Failed to find local shard {} - DataTreeChangeListener {} at path {} " - + "cannot be registered: {}", shardName, getInstance(), treeId, failure); + + "cannot be registered: {}", shardName, getInstance(), registeredPath, failure); } else { - doRegistration(shard, treeId); + doRegistration(shard); } } }, actorContext.getClientDispatcher()); @@ -94,10 +97,10 @@ final class DataTreeChangeListenerProxy ext actor.tell(CloseDataTreeChangeListenerRegistration.getInstance(), null); } - private void doRegistration(final ActorRef shard, final YangInstanceIdentifier path) { + private void doRegistration(final ActorRef shard) { Future future = actorContext.executeOperationAsync(shard, - new RegisterDataTreeChangeListener(path, dataChangeListenerActor, + new RegisterDataTreeChangeListener(registeredPath, dataChangeListenerActor, getInstance() instanceof ClusteredDOMDataTreeChangeListener), actorContext.getDatastoreContext().getShardInitializationTimeout()); @@ -106,7 +109,7 @@ final class DataTreeChangeListenerProxy ext public void onComplete(final Throwable failure, final Object result) { if (failure != null) { LOG.error("Failed to register DataTreeChangeListener {} at path {}", - getInstance(), path.toString(), failure); + getInstance(), registeredPath, failure); } else { RegisterDataTreeChangeListenerReply reply = (RegisterDataTreeChangeListenerReply) result; setListenerRegistrationActor(actorContext.actorSelection( @@ -117,7 +120,7 @@ final class DataTreeChangeListenerProxy ext } @VisibleForTesting - ActorSelection getListenerRegistrationActor() { + synchronized ActorSelection getListenerRegistrationActor() { return listenerRegistrationActor; }