X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDataTreeCohortRegistrationProxy.java;h=45b0f76484931ba093b4156f4cec107ec1434840;hp=cfe12a1bc65e117832887579b50e32ad2f3ccdef;hb=f83b2d36fdd7e953ba72492ffb684cd112aa04a6;hpb=013a6679470bf692753f2e04ab4398c97fd9f5d0 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortRegistrationProxy.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortRegistrationProxy.java index cfe12a1bc6..45b0f76484 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortRegistrationProxy.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataTreeCohortRegistrationProxy.java @@ -5,18 +5,18 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.controller.cluster.datastore; +import static java.util.Objects.requireNonNull; + import akka.actor.ActorRef; import akka.dispatch.OnComplete; import akka.pattern.Patterns; import akka.util.Timeout; -import com.google.common.base.Preconditions; import java.util.concurrent.TimeUnit; import javax.annotation.concurrent.GuardedBy; import org.opendaylight.controller.cluster.datastore.exceptions.LocalShardNotFoundException; -import org.opendaylight.controller.cluster.datastore.utils.ActorContext; +import org.opendaylight.controller.cluster.datastore.utils.ActorUtils; import org.opendaylight.mdsal.dom.api.DOMDataTreeCommitCohort; import org.opendaylight.mdsal.dom.api.DOMDataTreeCommitCohortRegistration; import org.opendaylight.mdsal.dom.api.DOMDataTreeIdentifier; @@ -33,23 +33,22 @@ public class DataTreeCohortRegistrationProxy private static final Timeout TIMEOUT = new Timeout(new FiniteDuration(5, TimeUnit.SECONDS)); private final DOMDataTreeIdentifier subtree; private final ActorRef actor; - private final ActorContext actorContext; + private final ActorUtils actorUtils; @GuardedBy("this") private ActorRef cohortRegistry; - - DataTreeCohortRegistrationProxy(ActorContext actorContext, DOMDataTreeIdentifier subtree, C cohort) { + DataTreeCohortRegistrationProxy(final ActorUtils actorUtils, final DOMDataTreeIdentifier subtree, + final C cohort) { super(cohort); - this.subtree = Preconditions.checkNotNull(subtree); - this.actorContext = Preconditions.checkNotNull(actorContext); - this.actor = actorContext.getActorSystem().actorOf(DataTreeCohortActor.props(getInstance(), - subtree.getRootIdentifier()).withDispatcher(actorContext.getNotificationDispatcherPath())); + this.subtree = requireNonNull(subtree); + this.actorUtils = requireNonNull(actorUtils); + this.actor = actorUtils.getActorSystem().actorOf(DataTreeCohortActor.props(getInstance(), + subtree.getRootIdentifier()).withDispatcher(actorUtils.getNotificationDispatcherPath())); } - - public void init(String shardName) { + public void init(final String shardName) { // FIXME: Add late binding to shard. - Future findFuture = actorContext.findLocalShardAsync(shardName); + Future findFuture = actorUtils.findLocalShardAsync(shardName); findFuture.onComplete(new OnComplete() { @Override public void onComplete(final Throwable failure, final ActorRef shard) { @@ -58,15 +57,15 @@ public class DataTreeCohortRegistrationProxy + "cannot be registered", shardName, getInstance(), subtree); } else if (failure != null) { LOG.error("Failed to find local shard {} - DataTreeChangeListener {} at path {} " - + "cannot be registered: {}", shardName, getInstance(), subtree, failure); + + "cannot be registered", shardName, getInstance(), subtree, failure); } else { performRegistration(shard); } } - }, actorContext.getClientDispatcher()); + }, actorUtils.getClientDispatcher()); } - private synchronized void performRegistration(ActorRef shard) { + private synchronized void performRegistration(final ActorRef shard) { if (isClosed()) { return; } @@ -76,7 +75,7 @@ public class DataTreeCohortRegistrationProxy future.onComplete(new OnComplete() { @Override - public void onComplete(Throwable failure, Object val) { + public void onComplete(final Throwable failure, final Object val) { if (failure != null) { LOG.error("Unable to register {} as commit cohort", getInstance(), failure); } @@ -85,7 +84,7 @@ public class DataTreeCohortRegistrationProxy } } - }, actorContext.getClientDispatcher()); + }, actorUtils.getClientDispatcher()); } @Override