X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDistributedDataStore.java;h=40e045f18e31bdfbcf2eb34c9fa0847a778f94f4;hp=f64c6f1a8669888726f30bfe4099aa628365ccbb;hb=971b179000ef1cc56699de35061cf6f97d4cf36f;hpb=2d16cfa0af7079ff969dcb81da6071ecacb3a5f6 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java index f64c6f1a86..40e045f18e 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java @@ -10,9 +10,14 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorRef; import akka.actor.ActorSystem; +import com.google.common.base.Preconditions; +import com.google.common.util.concurrent.ListeningExecutorService; +import com.google.common.util.concurrent.MoreExecutors; +import org.opendaylight.controller.cluster.datastore.identifiers.ShardManagerIdentifier; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListener; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListenerReply; import org.opendaylight.controller.cluster.datastore.messages.UpdateSchemaContext; +import org.opendaylight.controller.cluster.datastore.shardstrategy.ShardStrategyFactory; import org.opendaylight.controller.cluster.datastore.utils.ActorContext; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeListener; @@ -22,7 +27,9 @@ import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadWriteTransactio import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransactionChain; import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; import org.opendaylight.yangtools.concepts.ListenerRegistration; -import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier; +import org.opendaylight.yangtools.util.PropertyUtils; +import org.opendaylight.yangtools.util.concurrent.SpecialExecutors; +import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.model.api.SchemaContext; import org.opendaylight.yangtools.yang.model.api.SchemaContextListener; @@ -32,64 +39,130 @@ import org.slf4j.LoggerFactory; /** * */ -public class DistributedDataStore implements DOMStore, SchemaContextListener { +public class DistributedDataStore implements DOMStore, SchemaContextListener, AutoCloseable { private static final Logger LOG = LoggerFactory.getLogger(DistributedDataStore.class); + private static final String EXECUTOR_MAX_POOL_SIZE_PROP = + "mdsal.dist-datastore-executor-pool.size"; + private static final int DEFAULT_EXECUTOR_MAX_POOL_SIZE = 10; + + private static final String EXECUTOR_MAX_QUEUE_SIZE_PROP = + "mdsal.dist-datastore-executor-queue.size"; + private static final int DEFAULT_EXECUTOR_MAX_QUEUE_SIZE = 5000; - private final String type; private final ActorContext actorContext; - public DistributedDataStore(ActorSystem actorSystem, String type) { - this(new ActorContext(actorSystem, actorSystem.actorOf(ShardManager.props(type))), type); + private SchemaContext schemaContext; + + /** + * Executor used to run FutureTask's + * + * This is typically used when we need to make a request to an actor and + * wait for it's response and the consumer needs to be provided a Future. + */ + private final ListeningExecutorService executor = + MoreExecutors.listeningDecorator( + SpecialExecutors.newBlockingBoundedFastThreadPool( + PropertyUtils.getIntSystemProperty( + EXECUTOR_MAX_POOL_SIZE_PROP, + DEFAULT_EXECUTOR_MAX_POOL_SIZE), + PropertyUtils.getIntSystemProperty( + EXECUTOR_MAX_QUEUE_SIZE_PROP, + DEFAULT_EXECUTOR_MAX_QUEUE_SIZE), "DistDataStore")); + + public DistributedDataStore(ActorSystem actorSystem, String type, ClusterWrapper cluster, Configuration configuration) { + Preconditions.checkNotNull(actorSystem, "actorSystem should not be null"); + Preconditions.checkNotNull(type, "type should not be null"); + Preconditions.checkNotNull(cluster, "cluster should not be null"); + Preconditions.checkNotNull(configuration, "configuration should not be null"); + + + String shardManagerId = ShardManagerIdentifier.builder().type(type).build().toString(); + + LOG.info("Creating ShardManager : {}", shardManagerId); + + this.actorContext = new ActorContext(actorSystem, actorSystem + .actorOf(ShardManager.props(type, cluster, configuration), + shardManagerId ), cluster, configuration); } - public DistributedDataStore(ActorContext actorContext, String type) { - this.type = type; - this.actorContext = actorContext; + public DistributedDataStore(ActorContext actorContext) { + this.actorContext = Preconditions.checkNotNull(actorContext, "actorContext should not be null"); } @Override - public >> ListenerRegistration registerChangeListener( - InstanceIdentifier path, L listener, + public >> ListenerRegistration registerChangeListener( + YangInstanceIdentifier path, L listener, AsyncDataBroker.DataChangeScope scope) { - ActorRef dataChangeListenerActor = actorContext.getActorSystem().actorOf(DataChangeListener.props()); + Preconditions.checkNotNull(path, "path should not be null"); + Preconditions.checkNotNull(listener, "listener should not be null"); - Object result = actorContext.executeShardOperation(Shard.DEFAULT_NAME, - new RegisterChangeListener(path, dataChangeListenerActor.path(), - AsyncDataBroker.DataChangeScope.BASE), - ActorContext.ASK_DURATION); - RegisterChangeListenerReply reply = (RegisterChangeListenerReply) result; - return new ListenerRegistrationProxy(reply.getListenerRegistrationPath()); + LOG.debug("Registering listener: {} for path: {} scope: {}", listener, path, scope); + + ActorRef dataChangeListenerActor = actorContext.getActorSystem().actorOf( + DataChangeListener.props(schemaContext,listener,path )); + + String shardName = ShardStrategyFactory.getStrategy(path).findShard(path); + + Object result = actorContext.executeLocalShardOperation(shardName, + new RegisterChangeListener(path, dataChangeListenerActor.path(), + scope), + ActorContext.ASK_DURATION + ); + + if (result != null) { + RegisterChangeListenerReply reply = (RegisterChangeListenerReply) result; + return new DataChangeListenerRegistrationProxy(actorContext + .actorSelection(reply.getListenerRegistrationPath()), listener, + dataChangeListenerActor); + } + + LOG.debug( + "No local shard for shardName {} was found so returning a noop registration", + shardName); + return new NoOpDataChangeListenerRegistration(listener); } + + @Override public DOMStoreTransactionChain createTransactionChain() { - return new TransactionChainProxy(actorContext); + return new TransactionChainProxy(actorContext, executor, schemaContext); } @Override public DOMStoreReadTransaction newReadOnlyTransaction() { - return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_ONLY); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_ONLY, + executor, schemaContext); } @Override public DOMStoreWriteTransaction newWriteOnlyTransaction() { - return new TransactionProxy(actorContext, TransactionProxy.TransactionType.WRITE_ONLY); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.WRITE_ONLY, + executor, schemaContext); } @Override public DOMStoreReadWriteTransaction newReadWriteTransaction() { - return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_WRITE); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_WRITE, + executor, schemaContext); } @Override public void onGlobalContextUpdated(SchemaContext schemaContext) { - actorContext.getShardManager().tell(new UpdateSchemaContext(schemaContext), null); + this.schemaContext = schemaContext; + actorContext.getShardManager().tell( + new UpdateSchemaContext(schemaContext), null); + } + + @Override public void close() throws Exception { + actorContext.shutdown(); + } }