X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDistributedDataStore.java;h=bf541d95deadeb3e9ecce59c83cdb988934289a5;hp=2ef8e5f449f8df564ae42943c6597224b832bcb4;hb=9f61e98b036119694dfef0759a7cafc56aae6e86;hpb=6d73d16b194435ea1ea783a37d1b51fc1f558a1f diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java index 2ef8e5f449..bf541d95de 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DistributedDataStore.java @@ -10,9 +10,12 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorRef; import akka.actor.ActorSystem; +import akka.dispatch.OnComplete; +import akka.util.Timeout; +import com.google.common.base.Preconditions; +import org.opendaylight.controller.cluster.datastore.identifiers.ShardManagerIdentifier; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListener; import org.opendaylight.controller.cluster.datastore.messages.RegisterChangeListenerReply; -import org.opendaylight.controller.cluster.datastore.messages.UpdateSchemaContext; import org.opendaylight.controller.cluster.datastore.shardstrategy.ShardStrategyFactory; import org.opendaylight.controller.cluster.datastore.utils.ActorContext; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker; @@ -29,102 +32,117 @@ import org.opendaylight.yangtools.yang.model.api.SchemaContext; import org.opendaylight.yangtools.yang.model.api.SchemaContextListener; import org.slf4j.Logger; import org.slf4j.LoggerFactory; - -import java.util.concurrent.ExecutorService; -import java.util.concurrent.Executors; +import scala.concurrent.Future; /** * */ public class DistributedDataStore implements DOMStore, SchemaContextListener, AutoCloseable { - private static final Logger - LOG = LoggerFactory.getLogger(DistributedDataStore.class); - + private static final Logger LOG = LoggerFactory.getLogger(DistributedDataStore.class); + public static final int REGISTER_DATA_CHANGE_LISTENER_TIMEOUT_FACTOR = 24; // 24 times the usual operation timeout - private final String type; private final ActorContext actorContext; - private SchemaContext schemaContext; + public DistributedDataStore(ActorSystem actorSystem, String type, ClusterWrapper cluster, + Configuration configuration, DatastoreContext datastoreContext) { + Preconditions.checkNotNull(actorSystem, "actorSystem should not be null"); + Preconditions.checkNotNull(type, "type should not be null"); + Preconditions.checkNotNull(cluster, "cluster should not be null"); + Preconditions.checkNotNull(configuration, "configuration should not be null"); + Preconditions.checkNotNull(datastoreContext, "datastoreContext should not be null"); + String shardManagerId = ShardManagerIdentifier.builder().type(type).build().toString(); + LOG.info("Creating ShardManager : {}", shardManagerId); - /** - * Executor used to run FutureTask's - * - * This is typically used when we need to make a request to an actor and - * wait for it's response and the consumer needs to be provided a Future. - * - * FIXME : Make the thread pool configurable - */ - private final ExecutorService executor = - Executors.newFixedThreadPool(10); + actorContext = new ActorContext(actorSystem, actorSystem.actorOf( + ShardManager.props(type, cluster, configuration, datastoreContext) + .withMailbox(ActorContext.MAILBOX), shardManagerId ), cluster, configuration); - public DistributedDataStore(ActorSystem actorSystem, String type, ClusterWrapper cluster, Configuration configuration) { - this(new ActorContext(actorSystem, actorSystem - .actorOf(ShardManager.props(type, cluster, configuration), - "shardmanager-" + type), cluster, configuration), type); + actorContext.setOperationTimeout(datastoreContext.getOperationTimeoutInSeconds()); } - public DistributedDataStore(ActorContext actorContext, String type) { - this.type = type; - this.actorContext = actorContext; + public DistributedDataStore(ActorContext actorContext) { + this.actorContext = Preconditions.checkNotNull(actorContext, "actorContext should not be null"); } - + @SuppressWarnings("unchecked") @Override - public >> ListenerRegistration registerChangeListener( - YangInstanceIdentifier path, L listener, + public >> + ListenerRegistration registerChangeListener( + final YangInstanceIdentifier path, L listener, AsyncDataBroker.DataChangeScope scope) { + Preconditions.checkNotNull(path, "path should not be null"); + Preconditions.checkNotNull(listener, "listener should not be null"); + + LOG.debug("Registering listener: {} for path: {} scope: {}", listener, path, scope); + ActorRef dataChangeListenerActor = actorContext.getActorSystem().actorOf( - DataChangeListener.props(schemaContext,listener,path )); + DataChangeListener.props(listener )); String shardName = ShardStrategyFactory.getStrategy(path).findShard(path); - Object result = actorContext.executeShardOperation(shardName, - new RegisterChangeListener(path, dataChangeListenerActor.path(), - scope).toSerializable(), - ActorContext.ASK_DURATION - ); - - RegisterChangeListenerReply reply = RegisterChangeListenerReply.fromSerializable(actorContext.getActorSystem(),result); - return new DataChangeListenerRegistrationProxy(actorContext.actorSelection(reply.getListenerRegistrationPath()), listener, dataChangeListenerActor); + Future future = actorContext.executeLocalShardOperationAsync(shardName, + new RegisterChangeListener(path, dataChangeListenerActor.path(), scope), + new Timeout(actorContext.getOperationDuration().$times( + REGISTER_DATA_CHANGE_LISTENER_TIMEOUT_FACTOR))); + + if (future != null) { + final DataChangeListenerRegistrationProxy listenerRegistrationProxy = + new DataChangeListenerRegistrationProxy(listener, dataChangeListenerActor); + + future.onComplete(new OnComplete(){ + + @Override public void onComplete(Throwable failure, Object result) + throws Throwable { + if(failure != null){ + LOG.error("Failed to register listener at path " + path.toString(), failure); + return; + } + RegisterChangeListenerReply reply = (RegisterChangeListenerReply) result; + listenerRegistrationProxy.setListenerRegistrationActor(actorContext + .actorSelection(reply.getListenerRegistrationPath())); + } + }, actorContext.getActorSystem().dispatcher()); + return listenerRegistrationProxy; + } + + LOG.debug( + "No local shard for shardName {} was found so returning a noop registration", + shardName); + + return new NoOpDataChangeListenerRegistration(listener); } - - @Override public DOMStoreTransactionChain createTransactionChain() { - return new TransactionChainProxy(actorContext, executor, schemaContext); + return new TransactionChainProxy(actorContext); } @Override public DOMStoreReadTransaction newReadOnlyTransaction() { - return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_ONLY, - executor, schemaContext); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_ONLY); } @Override public DOMStoreWriteTransaction newWriteOnlyTransaction() { - return new TransactionProxy(actorContext, TransactionProxy.TransactionType.WRITE_ONLY, - executor, schemaContext); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.WRITE_ONLY); } @Override public DOMStoreReadWriteTransaction newReadWriteTransaction() { - return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_WRITE, - executor, schemaContext); + return new TransactionProxy(actorContext, TransactionProxy.TransactionType.READ_WRITE); } - @Override public void onGlobalContextUpdated(SchemaContext schemaContext) { - this.schemaContext = schemaContext; - actorContext.getShardManager().tell( - new UpdateSchemaContext(schemaContext), null); + @Override + public void onGlobalContextUpdated(SchemaContext schemaContext) { + actorContext.setSchemaContext(schemaContext); } - @Override public void close() throws Exception { + @Override + public void close() throws Exception { actorContext.shutdown(); - } }