X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FLocalTransactionContext.java;h=5435bb548d5c58e91e2f20d07dc7895f97755df8;hp=9cf5312c1efccb687a87b05c96612e39d8344a39;hb=abaef4a5ae37f27542155457fe7306a4662b1eeb;hpb=461173ce10acbd8597b8f4c6ccb6c98c7a99447c diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java index 9cf5312c1e..5435bb548d 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java @@ -7,18 +7,24 @@ */ package org.opendaylight.controller.cluster.datastore; +import static java.util.Objects.requireNonNull; + import akka.actor.ActorSelection; -import com.google.common.base.Preconditions; import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.MoreExecutors; import com.google.common.util.concurrent.SettableFuture; +import java.util.Optional; +import java.util.SortedSet; +import java.util.function.Consumer; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.controller.cluster.datastore.messages.AbstractRead; -import org.opendaylight.controller.cluster.datastore.modification.AbstractModification; +import org.opendaylight.mdsal.common.api.ReadFailedException; import org.opendaylight.mdsal.dom.spi.store.DOMStoreReadTransaction; import org.opendaylight.mdsal.dom.spi.store.DOMStoreTransaction; import org.opendaylight.mdsal.dom.spi.store.DOMStoreWriteTransaction; +import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; +import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import scala.concurrent.Future; /** @@ -35,7 +41,7 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { LocalTransactionContext(final DOMStoreTransaction txDelegate, final TransactionIdentifier identifier, final LocalTransactionReadySupport readySupport) { super(identifier); - this.txDelegate = Preconditions.checkNotNull(txDelegate); + this.txDelegate = requireNonNull(txDelegate); this.readySupport = readySupport; } @@ -43,19 +49,33 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { protected abstract DOMStoreReadTransaction getReadDelegate(); - @Override @SuppressWarnings("checkstyle:IllegalCatch") - public void executeModification(final AbstractModification modification, final Boolean havePermit) { + private void executeModification(final Consumer consumer) { incrementModificationCount(); if (operationError == null) { try { - modification.apply(getWriteDelegate()); + consumer.accept(getWriteDelegate()); } catch (Exception e) { operationError = e; } } } + @Override + public void executeDelete(final YangInstanceIdentifier path, final Boolean havePermit) { + executeModification(transaction -> transaction.delete(path)); + } + + @Override + public void executeMerge(final YangInstanceIdentifier path, final NormalizedNode data, final Boolean havePermit) { + executeModification(transaction -> transaction.merge(path, data)); + } + + @Override + public void executeWrite(final YangInstanceIdentifier path, final NormalizedNode data, final Boolean havePermit) { + executeModification(transaction -> transaction.write(path, data)); + } + @Override public void executeRead(final AbstractRead readCmd, final SettableFuture proxyFuture, final Boolean havePermit) { @@ -67,7 +87,8 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { @Override public void onFailure(final Throwable failure) { - proxyFuture.setException(failure); + proxyFuture.setException(failure instanceof Exception + ? ReadFailedException.MAPPER.apply((Exception) failure) : failure); } }, MoreExecutors.directExecutor()); } @@ -78,9 +99,10 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { } @Override - public Future readyTransaction(final Boolean havePermit) { + public Future readyTransaction(final Boolean havePermit, + final Optional> participatingShardNames) { final LocalThreePhaseCommitCohort cohort = ready(); - return cohort.initiateCoordinatedCommit(); + return cohort.initiateCoordinatedCommit(participatingShardNames); } @Override