X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FLocalTransactionContext.java;h=8c4dddc565d27aab4943e3ef61d99ce7d166e0f7;hp=276523e680a6389210edf290fff1a32fff252f23;hb=123afd8b015173c459f4937c84eb2e91286f65a8;hpb=340a2d4c979ac6f8d5adff8bd9e1c9f724e7a164 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java index 276523e680..8c4dddc565 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java @@ -8,17 +8,17 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorSelection; -import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.MoreExecutors; import com.google.common.util.concurrent.SettableFuture; -import org.opendaylight.controller.cluster.datastore.identifiers.TransactionIdentifier; +import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; +import org.opendaylight.controller.cluster.datastore.messages.AbstractRead; +import org.opendaylight.controller.cluster.datastore.modification.AbstractModification; import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransaction; import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; -import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; -import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import scala.concurrent.Future; /** @@ -32,8 +32,8 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { private final LocalTransactionReadySupport readySupport; private Exception operationError; - LocalTransactionContext(DOMStoreTransaction txDelegate, TransactionIdentifier identifier, - LocalTransactionReadySupport readySupport) { + LocalTransactionContext(final DOMStoreTransaction txDelegate, final TransactionIdentifier identifier, + final LocalTransactionReadySupport readySupport) { super(identifier); this.txDelegate = Preconditions.checkNotNull(txDelegate); this.readySupport = readySupport; @@ -44,24 +44,12 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { protected abstract DOMStoreReadTransaction getReadDelegate(); @Override - public void writeData(YangInstanceIdentifier path, NormalizedNode data) { + @SuppressWarnings("checkstyle:IllegalCatch") + public void executeModification(final AbstractModification modification, final Boolean havePermit) { incrementModificationCount(); - if(operationError == null) { + if (operationError == null) { try { - getWriteDelegate().write(path, data); - } catch (Exception e) { - operationError = e; - } - } - - } - - @Override - public void mergeData(YangInstanceIdentifier path, NormalizedNode data) { - incrementModificationCount(); - if(operationError == null) { - try { - getWriteDelegate().merge(path, data); + modification.apply(getWriteDelegate()); } catch (Exception e) { operationError = e; } @@ -69,71 +57,38 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { } @Override - public void deleteData(YangInstanceIdentifier path) { - incrementModificationCount(); - if(operationError == null) { - try { - getWriteDelegate().delete(path); - } catch (Exception e) { - operationError = e; - } - } - } - - @Override - public void readData(YangInstanceIdentifier path, final SettableFuture>> proxyFuture) { - Futures.addCallback(getReadDelegate().read(path), new FutureCallback>>() { + public void executeRead(final AbstractRead readCmd, final SettableFuture proxyFuture, + final Boolean havePermit) { + Futures.addCallback(readCmd.apply(getReadDelegate()), new FutureCallback() { @Override - public void onSuccess(final Optional> result) { + public void onSuccess(final T result) { proxyFuture.set(result); } @Override - public void onFailure(final Throwable t) { - proxyFuture.setException(t); + public void onFailure(final Throwable failure) { + proxyFuture.setException(failure); } - }); - } - - @Override - public void dataExists(YangInstanceIdentifier path, final SettableFuture proxyFuture) { - Futures.addCallback(getReadDelegate().exists(path), new FutureCallback() { - @Override - public void onSuccess(final Boolean result) { - proxyFuture.set(result); - } - - @Override - public void onFailure(final Throwable t) { - proxyFuture.setException(t); - } - }); + }, MoreExecutors.directExecutor()); } private LocalThreePhaseCommitCohort ready() { logModificationCount(); - LocalThreePhaseCommitCohort cohort = readySupport.onTransactionReady(getWriteDelegate()); - cohort.setOperationError(operationError); - return cohort; + return readySupport.onTransactionReady(getWriteDelegate(), operationError); } @Override - public Future readyTransaction() { + public Future readyTransaction(final Boolean havePermit) { final LocalThreePhaseCommitCohort cohort = ready(); return cohort.initiateCoordinatedCommit(); } @Override - public Future directCommit() { + public Future directCommit(final Boolean havePermit) { final LocalThreePhaseCommitCohort cohort = ready(); return cohort.initiateDirectCommit(); } - @Override - public boolean supportsDirectCommit() { - return true; - } - @Override public void closeTransaction() { txDelegate.close();