X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FLocalTransactionContext.java;h=b201486fb2267c8bad28e8cd5d0ecbc9bf045bb4;hp=76bafb75d3003a911f1b1207f55a919b0c08e2f0;hb=a70cc70f49501749ca4f6139080b0899b6b6e6f8;hpb=925cb4a228d0fda99c7bfeb432eb25285a223887 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java index 76bafb75d3..b201486fb2 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java @@ -7,17 +7,24 @@ */ package org.opendaylight.controller.cluster.datastore; +import static java.util.Objects.requireNonNull; + import akka.actor.ActorSelection; -import com.google.common.base.Preconditions; import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.MoreExecutors; import com.google.common.util.concurrent.SettableFuture; +import java.util.Optional; +import java.util.SortedSet; +import java.util.function.Consumer; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.controller.cluster.datastore.messages.AbstractRead; -import org.opendaylight.controller.cluster.datastore.modification.AbstractModification; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransaction; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; +import org.opendaylight.mdsal.common.api.ReadFailedException; +import org.opendaylight.mdsal.dom.spi.store.DOMStoreReadTransaction; +import org.opendaylight.mdsal.dom.spi.store.DOMStoreTransaction; +import org.opendaylight.mdsal.dom.spi.store.DOMStoreWriteTransaction; +import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; +import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import scala.concurrent.Future; /** @@ -31,10 +38,10 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { private final LocalTransactionReadySupport readySupport; private Exception operationError; - LocalTransactionContext(DOMStoreTransaction txDelegate, TransactionIdentifier identifier, - LocalTransactionReadySupport readySupport) { + LocalTransactionContext(final DOMStoreTransaction txDelegate, final TransactionIdentifier identifier, + final LocalTransactionReadySupport readySupport) { super(identifier); - this.txDelegate = Preconditions.checkNotNull(txDelegate); + this.txDelegate = requireNonNull(txDelegate); this.readySupport = readySupport; } @@ -42,13 +49,12 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { protected abstract DOMStoreReadTransaction getReadDelegate(); - @Override @SuppressWarnings("checkstyle:IllegalCatch") - public void executeModification(AbstractModification modification) { + private void executeModification(Consumer consumer) { incrementModificationCount(); if (operationError == null) { try { - modification.apply(getWriteDelegate()); + consumer.accept(getWriteDelegate()); } catch (Exception e) { operationError = e; } @@ -56,7 +62,25 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { } @Override - public void executeRead(AbstractRead readCmd, final SettableFuture proxyFuture) { + public void executeDelete(final YangInstanceIdentifier path, final Boolean havePermit) { + executeModification(transaction -> transaction.delete(path)); + } + + @Override + public void executeMerge(final YangInstanceIdentifier path, final NormalizedNode data, + final Boolean havePermit) { + executeModification(transaction -> transaction.merge(path, data)); + } + + @Override + public void executeWrite(final YangInstanceIdentifier path, final NormalizedNode data, + final Boolean havePermit) { + executeModification(transaction -> transaction.write(path, data)); + } + + @Override + public void executeRead(final AbstractRead readCmd, final SettableFuture proxyFuture, + final Boolean havePermit) { Futures.addCallback(readCmd.apply(getReadDelegate()), new FutureCallback() { @Override public void onSuccess(final T result) { @@ -65,9 +89,10 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { @Override public void onFailure(final Throwable failure) { - proxyFuture.setException(failure); + proxyFuture.setException(failure instanceof Exception + ? ReadFailedException.MAPPER.apply((Exception) failure) : failure); } - }); + }, MoreExecutors.directExecutor()); } private LocalThreePhaseCommitCohort ready() { @@ -76,13 +101,14 @@ abstract class LocalTransactionContext extends AbstractTransactionContext { } @Override - public Future readyTransaction() { + public Future readyTransaction(final Boolean havePermit, + final Optional> participatingShardNames) { final LocalThreePhaseCommitCohort cohort = ready(); - return cohort.initiateCoordinatedCommit(); + return cohort.initiateCoordinatedCommit(participatingShardNames); } @Override - public Future directCommit() { + public Future directCommit(final Boolean havePermit) { final LocalThreePhaseCommitCohort cohort = ready(); return cohort.initiateDirectCommit(); }