X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardRecoveryCoordinator.java;h=dae3383a2e10eb78a83798b2a5dd52de7000f891;hp=634121f5e5e669b5038246876ea0228b454edfe5;hb=8e6e0aeb5ca474cb292aab6ca581e921b0a56489;hpb=7ec296abdea94bbdc336276731ee545a2fb13e7c diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardRecoveryCoordinator.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardRecoveryCoordinator.java index 634121f5e5..dae3383a2e 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardRecoveryCoordinator.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardRecoveryCoordinator.java @@ -9,15 +9,9 @@ package org.opendaylight.controller.cluster.datastore; import com.google.common.base.Preconditions; import java.io.IOException; -import java.net.URI; -import java.util.Set; -import org.opendaylight.controller.cluster.datastore.modification.MutableCompositeModification; -import org.opendaylight.controller.cluster.datastore.node.utils.transformer.NormalizedNodePruner; import org.opendaylight.controller.cluster.datastore.utils.PruningDataTreeModification; import org.opendaylight.controller.cluster.datastore.utils.SerializationUtils; import org.opendaylight.controller.cluster.raft.RaftActorRecoveryCohort; -import org.opendaylight.controller.cluster.raft.protobuff.client.messages.CompositeModificationByteStringPayload; -import org.opendaylight.controller.cluster.raft.protobuff.client.messages.CompositeModificationPayload; import org.opendaylight.controller.cluster.raft.protobuff.client.messages.Payload; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; @@ -36,11 +30,10 @@ import org.slf4j.Logger; * @author Thomas Pantelis */ class ShardRecoveryCoordinator implements RaftActorRecoveryCohort { - private static final YangInstanceIdentifier ROOT = YangInstanceIdentifier.builder().build(); private final ShardDataTree store; private final String shardName; private final Logger log; - private final Set validNamespaces; + private final SchemaContext schemaContext; private PruningDataTreeModification transaction; private int size; private final byte[] restoreFromSnapshot; @@ -51,13 +44,13 @@ class ShardRecoveryCoordinator implements RaftActorRecoveryCohort { this.restoreFromSnapshot = restoreFromSnapshot; this.shardName = shardName; this.log = log; - this.validNamespaces = NormalizedNodePruner.namespaces(schemaContext); + this.schemaContext = schemaContext; } @Override public void startLogRecoveryBatch(int maxBatchSize) { log.debug("{}: starting log recovery batch with max size {}", shardName, maxBatchSize); - transaction = new PruningDataTreeModification(store.newModification(), validNamespaces); + transaction = new PruningDataTreeModification(store.newModification(), store.getDataTree(), schemaContext); size = 0; } @@ -69,14 +62,6 @@ class ShardRecoveryCoordinator implements RaftActorRecoveryCohort { if (payload instanceof DataTreeCandidatePayload) { DataTreeCandidates.applyToModification(transaction, ((DataTreeCandidatePayload)payload).getCandidate()); size++; - } else if (payload instanceof CompositeModificationPayload) { - MutableCompositeModification.fromSerializable( - ((CompositeModificationPayload) payload).getModification()).apply(transaction); - size++; - } else if (payload instanceof CompositeModificationByteStringPayload) { - MutableCompositeModification.fromSerializable( - ((CompositeModificationByteStringPayload) payload).getModification()).apply(transaction); - size++; } else { log.error("{}: Unknown payload {} received during recovery", shardName, payload); } @@ -86,7 +71,7 @@ class ShardRecoveryCoordinator implements RaftActorRecoveryCohort { } private void commitTransaction(PruningDataTreeModification tx) throws DataValidationFailedException { - store.commit(tx.getDelegate()); + store.commit(tx.getResultingModification()); } /** @@ -115,8 +100,9 @@ class ShardRecoveryCoordinator implements RaftActorRecoveryCohort { log.debug("{}: Applying recovered snapshot", shardName); final NormalizedNode node = SerializationUtils.deserializeNormalizedNode(snapshotBytes); - final PruningDataTreeModification tx = new PruningDataTreeModification(store.newModification(), validNamespaces); - tx.write(ROOT, node); + final PruningDataTreeModification tx = new PruningDataTreeModification(store.newModification(), + store.getDataTree(), schemaContext); + tx.write(YangInstanceIdentifier.EMPTY, node); try { commitTransaction(tx); } catch (DataValidationFailedException e) {