X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardTransaction.java;h=f5ca6e3c5aa2334eb26c52408dd7279f08e33d3a;hp=e3d1e2d9d42e4968f4b81ca0ea33d40c2b7b07f7;hb=5a15471e74536f8fe6d62747b7b822655a17dd4e;hpb=7e24111a0842d66187c752022aa975c411b42cca diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransaction.java index e3d1e2d9d4..f5ca6e3c5a 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransaction.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardTransaction.java @@ -11,13 +11,20 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorRef; import akka.actor.PoisonPill; import akka.actor.Props; -import akka.event.Logging; -import akka.event.LoggingAdapter; +import akka.actor.ReceiveTimeout; import akka.japi.Creator; + import com.google.common.base.Optional; -import com.google.common.util.concurrent.ListenableFuture; +import com.google.common.util.concurrent.CheckedFuture; +import org.opendaylight.controller.cluster.common.actor.AbstractUntypedActor; + + +import org.opendaylight.controller.cluster.datastore.exceptions.UnknownMessageException; +import org.opendaylight.controller.cluster.datastore.jmx.mbeans.shard.ShardStats; import org.opendaylight.controller.cluster.datastore.messages.CloseTransaction; import org.opendaylight.controller.cluster.datastore.messages.CloseTransactionReply; +import org.opendaylight.controller.cluster.datastore.messages.DataExists; +import org.opendaylight.controller.cluster.datastore.messages.DataExistsReply; import org.opendaylight.controller.cluster.datastore.messages.DeleteData; import org.opendaylight.controller.cluster.datastore.messages.DeleteDataReply; import org.opendaylight.controller.cluster.datastore.messages.MergeData; @@ -34,13 +41,15 @@ import org.opendaylight.controller.cluster.datastore.modification.ImmutableCompo import org.opendaylight.controller.cluster.datastore.modification.MergeModification; import org.opendaylight.controller.cluster.datastore.modification.MutableCompositeModification; import org.opendaylight.controller.cluster.datastore.modification.WriteModification; +import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; +import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadTransaction; import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadWriteTransaction; import org.opendaylight.controller.sal.core.spi.data.DOMStoreThreePhaseCommitCohort; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransactionChain; -import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier; +import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransaction; +import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; +import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; - -import java.util.concurrent.ExecutionException; +import org.opendaylight.yangtools.yang.model.api.SchemaContext; /** * The ShardTransaction Actor represents a remote transaction @@ -64,150 +73,187 @@ import java.util.concurrent.ExecutionException; *
  • {@link org.opendaylight.controller.cluster.datastore.messages.CloseTransaction} *

    */ -public class ShardTransaction extends AbstractUntypedActor { +public abstract class ShardTransaction extends AbstractUntypedActor { private final ActorRef shardActor; + protected final SchemaContext schemaContext; + private final ShardStats shardStats; - // FIXME : see below - // If transactionChain is not null then this transaction is part of a - // transactionChain. Not really clear as to what that buys us - private final DOMStoreTransactionChain transactionChain; - - private final DOMStoreReadWriteTransaction transaction; - - private final MutableCompositeModification modification = - new MutableCompositeModification(); + private final MutableCompositeModification modification = new MutableCompositeModification(); - private final LoggingAdapter log = - Logging.getLogger(getContext().system(), this); - - public ShardTransaction(DOMStoreReadWriteTransaction transaction, - ActorRef shardActor) { - this(null, transaction, shardActor); - } - - public ShardTransaction(DOMStoreTransactionChain transactionChain, DOMStoreReadWriteTransaction transaction, - ActorRef shardActor) { - this.transactionChain = transactionChain; - this.transaction = transaction; + protected ShardTransaction(ActorRef shardActor, SchemaContext schemaContext, + ShardStats shardStats) { this.shardActor = shardActor; + this.schemaContext = schemaContext; + this.shardStats = shardStats; } - - - public static Props props(final DOMStoreReadWriteTransaction transaction, - final ActorRef shardActor) { - return Props.create(new Creator() { - - @Override - public ShardTransaction create() throws Exception { - return new ShardTransaction(transaction, shardActor); - } - }); - } - - public static Props props(final DOMStoreTransactionChain transactionChain, final DOMStoreReadWriteTransaction transaction, - final ActorRef shardActor) { - return Props.create(new Creator() { - - @Override - public ShardTransaction create() throws Exception { - return new ShardTransaction(transactionChain, transaction, shardActor); - } - }); + public static Props props(DOMStoreTransaction transaction, ActorRef shardActor, + SchemaContext schemaContext,DatastoreContext datastoreContext, ShardStats shardStats) { + return Props.create(new ShardTransactionCreator(transaction, shardActor, schemaContext, + datastoreContext, shardStats)); } + protected abstract DOMStoreTransaction getDOMStoreTransaction(); @Override public void handleReceive(Object message) throws Exception { - if (message instanceof ReadData) { - readData((ReadData) message); - } else if (message instanceof WriteData) { - writeData((WriteData) message); - } else if (message instanceof MergeData) { - mergeData((MergeData) message); - } else if (message instanceof DeleteData) { - deleteData((DeleteData) message); - } else if (message instanceof ReadyTransaction) { - readyTransaction((ReadyTransaction) message); - } else if (message instanceof CloseTransaction) { - closeTransaction((CloseTransaction) message); + if (message.getClass().equals(CloseTransaction.SERIALIZABLE_CLASS)) { + closeTransaction(true); } else if (message instanceof GetCompositedModification) { // This is here for testing only getSender().tell(new GetCompositeModificationReply( - new ImmutableCompositeModification(modification)), getSelf()); + new ImmutableCompositeModification(modification)), getSelf()); + } else if (message instanceof ReceiveTimeout) { + if(LOG.isDebugEnabled()) { + LOG.debug("Got ReceiveTimeout for inactivity - closing Tx"); + } + closeTransaction(false); + } else { + throw new UnknownMessageException(message); + } + } + + private void closeTransaction(boolean sendReply) { + getDOMStoreTransaction().close(); + + if(sendReply) { + getSender().tell(new CloseTransactionReply().toSerializable(), getSelf()); } + + getSelf().tell(PoisonPill.getInstance(), getSelf()); } - private void readData(ReadData message) { + protected void readData(DOMStoreReadTransaction transaction,ReadData message) { final ActorRef sender = getSender(); final ActorRef self = getSelf(); - final InstanceIdentifier path = message.getPath(); - final ListenableFuture>> future = - transaction.read(path); + final YangInstanceIdentifier path = message.getPath(); + final CheckedFuture>, ReadFailedException> future = + transaction.read(path); future.addListener(new Runnable() { @Override public void run() { try { - Optional> optional = future.get(); + Optional> optional = future.checkedGet(); if (optional.isPresent()) { - sender.tell(new ReadDataReply(optional.get()), self); + sender.tell(new ReadDataReply(schemaContext,optional.get()).toSerializable(), self); } else { - sender.tell(new ReadDataReply(null), self); + sender.tell(new ReadDataReply(schemaContext,null).toSerializable(), self); } - } catch (InterruptedException | ExecutionException e) { - log.error(e, - "An exception happened when reading data from path : " - + path.toString()); + } catch (Exception e) { + shardStats.incrementFailedReadTransactionsCount(); + sender.tell(new akka.actor.Status.Failure(e), self); } } }, getContext().dispatcher()); } + protected void dataExists(DOMStoreReadTransaction transaction, DataExists message) { + final YangInstanceIdentifier path = message.getPath(); + + try { + Boolean exists = transaction.exists(path).checkedGet(); + getSender().tell(new DataExistsReply(exists).toSerializable(), getSelf()); + } catch (ReadFailedException e) { + getSender().tell(new akka.actor.Status.Failure(e),getSelf()); + } + + } - private void writeData(WriteData message) { + protected void writeData(DOMStoreWriteTransaction transaction, WriteData message) { modification.addModification( - new WriteModification(message.getPath(), message.getData())); - transaction.write(message.getPath(), message.getData()); - getSender().tell(new WriteDataReply(), getSelf()); + new WriteModification(message.getPath(), message.getData(),schemaContext)); + if(LOG.isDebugEnabled()) { + LOG.debug("writeData at path : " + message.getPath().toString()); + } + try { + transaction.write(message.getPath(), message.getData()); + getSender().tell(new WriteDataReply().toSerializable(), getSelf()); + }catch(Exception e){ + getSender().tell(new akka.actor.Status.Failure(e), getSelf()); + } } - private void mergeData(MergeData message) { + protected void mergeData(DOMStoreWriteTransaction transaction, MergeData message) { modification.addModification( - new MergeModification(message.getPath(), message.getData())); - transaction.merge(message.getPath(), message.getData()); - getSender().tell(new MergeDataReply(), getSelf()); + new MergeModification(message.getPath(), message.getData(), schemaContext)); + if(LOG.isDebugEnabled()) { + LOG.debug("mergeData at path : " + message.getPath().toString()); + } + try { + transaction.merge(message.getPath(), message.getData()); + getSender().tell(new MergeDataReply().toSerializable(), getSelf()); + }catch(Exception e){ + getSender().tell(new akka.actor.Status.Failure(e), getSelf()); + } } - private void deleteData(DeleteData message) { + protected void deleteData(DOMStoreWriteTransaction transaction, DeleteData message) { + if(LOG.isDebugEnabled()) { + LOG.debug("deleteData at path : " + message.getPath().toString()); + } modification.addModification(new DeleteModification(message.getPath())); - transaction.delete(message.getPath()); - getSender().tell(new DeleteDataReply(), getSelf()); + try { + transaction.delete(message.getPath()); + getSender().tell(new DeleteDataReply().toSerializable(), getSelf()); + }catch(Exception e){ + getSender().tell(new akka.actor.Status.Failure(e), getSelf()); + } } - private void readyTransaction(ReadyTransaction message) { - DOMStoreThreePhaseCommitCohort cohort = transaction.ready(); + protected void readyTransaction(DOMStoreWriteTransaction transaction, ReadyTransaction message) { + DOMStoreThreePhaseCommitCohort cohort = transaction.ready(); ActorRef cohortActor = getContext().actorOf( - ThreePhaseCommitCohort.props(cohort, shardActor, modification), "cohort"); + ThreePhaseCommitCohort.props(cohort, shardActor, modification, shardStats), "cohort"); getSender() - .tell(new ReadyTransactionReply(cohortActor.path()), getSelf()); + .tell(new ReadyTransactionReply(cohortActor.path()).toSerializable(), getSelf()); } - private void closeTransaction(CloseTransaction message) { - transaction.close(); - getSender().tell(new CloseTransactionReply(), getSelf()); - getSelf().tell(PoisonPill.getInstance(), getSelf()); - } + private static class ShardTransactionCreator implements Creator { + private static final long serialVersionUID = 1L; - // These classes are in here for test purposes only + final DOMStoreTransaction transaction; + final ActorRef shardActor; + final SchemaContext schemaContext; + final DatastoreContext datastoreContext; + final ShardStats shardStats; + ShardTransactionCreator(DOMStoreTransaction transaction, ActorRef shardActor, + SchemaContext schemaContext, DatastoreContext datastoreContext, + ShardStats shardStats) { + this.transaction = transaction; + this.shardActor = shardActor; + this.shardStats = shardStats; + this.schemaContext = schemaContext; + this.datastoreContext = datastoreContext; + } - static class GetCompositedModification { + @Override + public ShardTransaction create() throws Exception { + ShardTransaction tx; + if(transaction instanceof DOMStoreReadWriteTransaction) { + tx = new ShardReadWriteTransaction((DOMStoreReadWriteTransaction)transaction, + shardActor, schemaContext, shardStats); + } else if(transaction instanceof DOMStoreReadTransaction) { + tx = new ShardReadTransaction((DOMStoreReadTransaction)transaction, shardActor, + schemaContext, shardStats); + } else { + tx = new ShardWriteTransaction((DOMStoreWriteTransaction)transaction, + shardActor, schemaContext, shardStats); + } + tx.getContext().setReceiveTimeout(datastoreContext.getShardTransactionIdleTimeout()); + return tx; + } + } + + // These classes are in here for test purposes only + + static class GetCompositedModification { }