X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardWriteTransaction.java;h=4ae54d3e5f727856c93a6f896e7630f21e11c10d;hp=1d5b1d8e1b99bf35f5fabe8ab3723892dd7af193;hb=4062f5241a2a6f58ffb83dd1e9939ee66122d217;hpb=2d62916cb1f4b4045f4fc38fbd313f8339f9ac67 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardWriteTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardWriteTransaction.java index 1d5b1d8e1b..4ae54d3e5f 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardWriteTransaction.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardWriteTransaction.java @@ -1,11 +1,10 @@ /* - * Copyright (c) 2014 Cisco Systems, Inc. and others. All rights reserved. - * Copyright (c) 2015 Brocade Communications Systems, Inc. and others. All rights reserved. - * - * This program and the accompanying materials are made available under the - * terms of the Eclipse Public License v1.0 which accompanies this distribution, - * and is available at http://www.eclipse.org/legal/epl-v10.html + * Copyright (c) 2014 Cisco Systems, Inc. and others. All rights reserved. + * Copyright (c) 2015 Brocade Communications Systems, Inc. and others. All rights reserved. * + * This program and the accompanying materials are made available under the + * terms of the Eclipse Public License v1.0 which accompanies this distribution, + * and is available at http://www.eclipse.org/legal/epl-v10.html */ package org.opendaylight.controller.cluster.datastore; @@ -15,23 +14,10 @@ import akka.actor.PoisonPill; import org.opendaylight.controller.cluster.datastore.jmx.mbeans.shard.ShardStats; import org.opendaylight.controller.cluster.datastore.messages.BatchedModifications; import org.opendaylight.controller.cluster.datastore.messages.BatchedModificationsReply; -import org.opendaylight.controller.cluster.datastore.messages.DeleteData; -import org.opendaylight.controller.cluster.datastore.messages.DeleteDataReply; +import org.opendaylight.controller.cluster.datastore.messages.DataExists; import org.opendaylight.controller.cluster.datastore.messages.ForwardedReadyTransaction; -import org.opendaylight.controller.cluster.datastore.messages.MergeData; -import org.opendaylight.controller.cluster.datastore.messages.MergeDataReply; -import org.opendaylight.controller.cluster.datastore.messages.ReadyTransaction; -import org.opendaylight.controller.cluster.datastore.messages.WriteData; -import org.opendaylight.controller.cluster.datastore.messages.WriteDataReply; -import org.opendaylight.controller.cluster.datastore.modification.CompositeModification; -import org.opendaylight.controller.cluster.datastore.modification.DeleteModification; -import org.opendaylight.controller.cluster.datastore.modification.MergeModification; +import org.opendaylight.controller.cluster.datastore.messages.ReadData; import org.opendaylight.controller.cluster.datastore.modification.Modification; -import org.opendaylight.controller.cluster.datastore.modification.MutableCompositeModification; -import org.opendaylight.controller.cluster.datastore.modification.WriteModification; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreThreePhaseCommitCohort; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransaction; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; /** * @author: syedbahm @@ -39,53 +25,41 @@ import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; */ public class ShardWriteTransaction extends ShardTransaction { - private final MutableCompositeModification compositeModification = new MutableCompositeModification(); private int totalBatchedModificationsReceived; private Exception lastBatchedModificationsException; - private final DOMStoreWriteTransaction transaction; + private final ReadWriteShardDataTreeTransaction transaction; - public ShardWriteTransaction(DOMStoreWriteTransaction transaction, ActorRef shardActor, - ShardStats shardStats, String transactionID, short clientTxVersion) { - super(shardActor, shardStats, transactionID, clientTxVersion); + public ShardWriteTransaction(ReadWriteShardDataTreeTransaction transaction, ActorRef shardActor, + ShardStats shardStats) { + super(shardActor, shardStats, transaction.getId()); this.transaction = transaction; } @Override - protected DOMStoreTransaction getDOMStoreTransaction() { + protected ReadWriteShardDataTreeTransaction getDOMStoreTransaction() { return transaction; } @Override - public void handleReceive(Object message) throws Exception { - + public void handleReceive(Object message) { if (message instanceof BatchedModifications) { batchedModifications((BatchedModifications)message); - } else if (message instanceof ReadyTransaction) { - readyTransaction(transaction, !SERIALIZED_REPLY); - } else if(ReadyTransaction.SERIALIZABLE_CLASS.equals(message.getClass())) { - readyTransaction(transaction, SERIALIZED_REPLY); - } else if(WriteData.isSerializedType(message)) { - writeData(transaction, WriteData.fromSerializable(message), SERIALIZED_REPLY); - - } else if(MergeData.isSerializedType(message)) { - mergeData(transaction, MergeData.fromSerializable(message), SERIALIZED_REPLY); - - } else if(DeleteData.isSerializedType(message)) { - deleteData(transaction, DeleteData.fromSerializable(message), SERIALIZED_REPLY); - - } else if (message instanceof GetCompositedModification) { - // This is here for testing only - getSender().tell(new GetCompositeModificationReply(compositeModification), getSelf()); } else { super.handleReceive(message); } } private void batchedModifications(BatchedModifications batched) { + if (checkClosed()) { + if (batched.isReady()) { + getSelf().tell(PoisonPill.getInstance(), getSelf()); + } + return; + } + try { for(Modification modification: batched.getModifications()) { - compositeModification.addModification(modification); - modification.apply(transaction); + modification.apply(transaction.getSnapshot()); } totalBatchedModificationsReceived++; @@ -100,7 +74,7 @@ public class ShardWriteTransaction extends ShardTransaction { totalBatchedModificationsReceived, batched.getTotalMessagesSent())); } - readyTransaction(transaction, false); + readyTransaction(false, batched.isDoCommitOnReady(), batched.getVersion()); } else { getSender().tell(new BatchedModificationsReply(batched.getModifications().size()), getSelf()); } @@ -114,83 +88,32 @@ public class ShardWriteTransaction extends ShardTransaction { } } - private void writeData(DOMStoreWriteTransaction transaction, WriteData message, - boolean returnSerialized) { - LOG.debug("writeData at path : {}", message.getPath()); - - compositeModification.addModification( - new WriteModification(message.getPath(), message.getData())); - try { - transaction.write(message.getPath(), message.getData()); - WriteDataReply writeDataReply = WriteDataReply.INSTANCE; - getSender().tell(returnSerialized ? writeDataReply.toSerializable(message.getVersion()) : - writeDataReply, getSelf()); - }catch(Exception e){ - getSender().tell(new akka.actor.Status.Failure(e), getSelf()); - } + protected final void dataExists(DataExists message) { + super.dataExists(transaction, message); } - private void mergeData(DOMStoreWriteTransaction transaction, MergeData message, - boolean returnSerialized) { - LOG.debug("mergeData at path : {}", message.getPath()); - - compositeModification.addModification( - new MergeModification(message.getPath(), message.getData())); - - try { - transaction.merge(message.getPath(), message.getData()); - MergeDataReply mergeDataReply = MergeDataReply.INSTANCE; - getSender().tell(returnSerialized ? mergeDataReply.toSerializable(message.getVersion()) : - mergeDataReply, getSelf()); - }catch(Exception e){ - getSender().tell(new akka.actor.Status.Failure(e), getSelf()); - } + protected final void readData(ReadData message) { + super.readData(transaction, message); } - private void deleteData(DOMStoreWriteTransaction transaction, DeleteData message, - boolean returnSerialized) { - LOG.debug("deleteData at path : {}", message.getPath()); - - compositeModification.addModification(new DeleteModification(message.getPath())); - try { - transaction.delete(message.getPath()); - DeleteDataReply deleteDataReply = DeleteDataReply.INSTANCE; - getSender().tell(returnSerialized ? deleteDataReply.toSerializable(message.getVersion()) : - deleteDataReply, getSelf()); - }catch(Exception e){ - getSender().tell(new akka.actor.Status.Failure(e), getSelf()); + private boolean checkClosed() { + if (transaction.isClosed()) { + getSender().tell(new akka.actor.Status.Failure(new IllegalStateException("Transaction is closed, no modifications allowed")), getSelf()); + return true; + } else { + return false; } } - private void readyTransaction(DOMStoreWriteTransaction transaction, boolean returnSerialized) { + private void readyTransaction(boolean returnSerialized, boolean doImmediateCommit, short clientTxVersion) { String transactionID = getTransactionID(); LOG.debug("readyTransaction : {}", transactionID); - DOMStoreThreePhaseCommitCohort cohort = transaction.ready(); - - getShardActor().forward(new ForwardedReadyTransaction(transactionID, getClientTxVersion(), - cohort, compositeModification, returnSerialized), getContext()); + getShardActor().forward(new ForwardedReadyTransaction(transactionID, clientTxVersion, + transaction, doImmediateCommit), getContext()); // The shard will handle the commit from here so we're no longer needed - self-destruct. getSelf().tell(PoisonPill.getInstance(), getSelf()); } - - // These classes are in here for test purposes only - - static class GetCompositedModification { - } - - static class GetCompositeModificationReply { - private final CompositeModification modification; - - - GetCompositeModificationReply(CompositeModification modification) { - this.modification = modification; - } - - public CompositeModification getModification() { - return modification; - } - } }