X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardWriteTransaction.java;h=67f2c684a15743e86c0855010bd72c492baf7fd3;hp=21c210daf252fc4633b12882bb18dfea99779aa5;hb=a213231082af487d8b65ea3d411cd029e48b34fa;hpb=26ead80b71a367f8dac348905d440d7e203e0b4f diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardWriteTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardWriteTransaction.java index 21c210daf2..67f2c684a1 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardWriteTransaction.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardWriteTransaction.java @@ -1,162 +1,121 @@ /* + * Copyright (c) 2014 Cisco Systems, Inc. and others. All rights reserved. + * Copyright (c) 2015 Brocade Communications Systems, Inc. and others. All rights reserved. * - * Copyright (c) 2014 Cisco Systems, Inc. and others. All rights reserved. - * - * This program and the accompanying materials are made available under the - * terms of the Eclipse Public License v1.0 which accompanies this distribution, - * and is available at http://www.eclipse.org/legal/epl-v10.html - * + * This program and the accompanying materials are made available under the + * terms of the Eclipse Public License v1.0 which accompanies this distribution, + * and is available at http://www.eclipse.org/legal/epl-v10.html */ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorRef; -import org.opendaylight.controller.cluster.datastore.jmx.mbeans.shard.ShardStats; -import org.opendaylight.controller.cluster.datastore.messages.DeleteData; -import org.opendaylight.controller.cluster.datastore.messages.DeleteDataReply; +import akka.actor.PoisonPill; +import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; +import org.opendaylight.controller.cluster.datastore.messages.BatchedModifications; +import org.opendaylight.controller.cluster.datastore.messages.BatchedModificationsReply; +import org.opendaylight.controller.cluster.datastore.messages.DataExists; import org.opendaylight.controller.cluster.datastore.messages.ForwardedReadyTransaction; -import org.opendaylight.controller.cluster.datastore.messages.MergeData; -import org.opendaylight.controller.cluster.datastore.messages.MergeDataReply; -import org.opendaylight.controller.cluster.datastore.messages.ReadyTransaction; -import org.opendaylight.controller.cluster.datastore.messages.WriteData; -import org.opendaylight.controller.cluster.datastore.messages.WriteDataReply; -import org.opendaylight.controller.cluster.datastore.modification.CompositeModification; -import org.opendaylight.controller.cluster.datastore.modification.DeleteModification; -import org.opendaylight.controller.cluster.datastore.modification.ImmutableCompositeModification; -import org.opendaylight.controller.cluster.datastore.modification.MergeModification; -import org.opendaylight.controller.cluster.datastore.modification.MutableCompositeModification; -import org.opendaylight.controller.cluster.datastore.modification.WriteModification; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreThreePhaseCommitCohort; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreTransaction; -import org.opendaylight.controller.sal.core.spi.data.DOMStoreWriteTransaction; -import org.opendaylight.yangtools.yang.model.api.SchemaContext; +import org.opendaylight.controller.cluster.datastore.messages.ReadData; +import org.opendaylight.controller.cluster.datastore.modification.Modification; /** - * @author: syedbahm - * Date: 8/6/14 + * Actor for a shard write-only transaction. + * + * @author syedbahm */ public class ShardWriteTransaction extends ShardTransaction { - private final MutableCompositeModification modification = new MutableCompositeModification(); - private final DOMStoreWriteTransaction transaction; + private int totalBatchedModificationsReceived; + private Exception lastBatchedModificationsException; + private final ReadWriteShardDataTreeTransaction transaction; - public ShardWriteTransaction(DOMStoreWriteTransaction transaction, ActorRef shardActor, - SchemaContext schemaContext, ShardStats shardStats, String transactionID) { - super(shardActor, schemaContext, shardStats, transactionID); + public ShardWriteTransaction(final ReadWriteShardDataTreeTransaction transaction, final ActorRef shardActor, + final ShardStats shardStats) { + super(shardActor, shardStats, transaction.getIdentifier()); this.transaction = transaction; } @Override - protected DOMStoreTransaction getDOMStoreTransaction() { + protected ReadWriteShardDataTreeTransaction getDOMStoreTransaction() { return transaction; } @Override - public void handleReceive(Object message) throws Exception { - - if (message instanceof WriteData) { - writeData(transaction, (WriteData) message, !SERIALIZED_REPLY); - - } else if (message instanceof MergeData) { - mergeData(transaction, (MergeData) message, !SERIALIZED_REPLY); - - } else if (message instanceof DeleteData) { - deleteData(transaction, (DeleteData) message, !SERIALIZED_REPLY); - - } else if (message instanceof ReadyTransaction) { - readyTransaction(transaction, new ReadyTransaction(), !SERIALIZED_REPLY); - - } else if(WriteData.SERIALIZABLE_CLASS.equals(message.getClass())) { - writeData(transaction, WriteData.fromSerializable(message, getSchemaContext()), SERIALIZED_REPLY); - - } else if(MergeData.SERIALIZABLE_CLASS.equals(message.getClass())) { - mergeData(transaction, MergeData.fromSerializable(message, getSchemaContext()), SERIALIZED_REPLY); - - } else if(DeleteData.SERIALIZABLE_CLASS.equals(message.getClass())) { - deleteData(transaction, DeleteData.fromSerializable(message), SERIALIZED_REPLY); - - } else if(ReadyTransaction.SERIALIZABLE_CLASS.equals(message.getClass())) { - readyTransaction(transaction, new ReadyTransaction(), SERIALIZED_REPLY); - - } else if (message instanceof GetCompositedModification) { - // This is here for testing only - getSender().tell(new GetCompositeModificationReply( - new ImmutableCompositeModification(modification)), getSelf()); + public void handleReceive(final Object message) { + if (message instanceof BatchedModifications) { + batchedModifications((BatchedModifications)message); } else { super.handleReceive(message); } } - private void writeData(DOMStoreWriteTransaction transaction, WriteData message, boolean returnSerialized) { - modification.addModification( - new WriteModification(message.getPath(), message.getData(), getSchemaContext())); - if(LOG.isDebugEnabled()) { - LOG.debug("writeData at path : " + message.getPath().toString()); + @SuppressWarnings("checkstyle:IllegalCatch") + private void batchedModifications(final BatchedModifications batched) { + if (checkClosed()) { + if (batched.isReady()) { + getSelf().tell(PoisonPill.getInstance(), getSelf()); + } + return; } - try { - transaction.write(message.getPath(), message.getData()); - WriteDataReply writeDataReply = new WriteDataReply(); - getSender().tell(returnSerialized ? writeDataReply.toSerializable() : writeDataReply, - getSelf()); - }catch(Exception e){ - getSender().tell(new akka.actor.Status.Failure(e), getSelf()); - } - } - private void mergeData(DOMStoreWriteTransaction transaction, MergeData message, boolean returnSerialized) { - modification.addModification( - new MergeModification(message.getPath(), message.getData(), getSchemaContext())); - if(LOG.isDebugEnabled()) { - LOG.debug("mergeData at path : " + message.getPath().toString()); - } try { - transaction.merge(message.getPath(), message.getData()); - MergeDataReply mergeDataReply = new MergeDataReply(); - getSender().tell(returnSerialized ? mergeDataReply.toSerializable() : mergeDataReply , - getSelf()); - }catch(Exception e){ + for (Modification modification: batched.getModifications()) { + modification.apply(transaction.getSnapshot()); + } + + totalBatchedModificationsReceived++; + if (batched.isReady()) { + if (lastBatchedModificationsException != null) { + throw lastBatchedModificationsException; + } + + if (totalBatchedModificationsReceived != batched.getTotalMessagesSent()) { + throw new IllegalStateException(String.format( + "The total number of batched messages received %d does not match the number sent %d", + totalBatchedModificationsReceived, batched.getTotalMessagesSent())); + } + + readyTransaction(batched); + } else { + getSender().tell(new BatchedModificationsReply(batched.getModifications().size()), getSelf()); + } + } catch (Exception e) { + lastBatchedModificationsException = e; getSender().tell(new akka.actor.Status.Failure(e), getSelf()); - } - } - private void deleteData(DOMStoreWriteTransaction transaction, DeleteData message, boolean returnSerialized) { - if(LOG.isDebugEnabled()) { - LOG.debug("deleteData at path : " + message.getPath().toString()); - } - modification.addModification(new DeleteModification(message.getPath())); - try { - transaction.delete(message.getPath()); - DeleteDataReply deleteDataReply = new DeleteDataReply(); - getSender().tell(returnSerialized ? deleteDataReply.toSerializable() : deleteDataReply, - getSelf()); - }catch(Exception e){ - getSender().tell(new akka.actor.Status.Failure(e), getSelf()); + if (batched.isReady()) { + getSelf().tell(PoisonPill.getInstance(), getSelf()); + } } } - private void readyTransaction(DOMStoreWriteTransaction transaction, ReadyTransaction message, boolean returnSerialized) { - DOMStoreThreePhaseCommitCohort cohort = transaction.ready(); - - getShardActor().forward(new ForwardedReadyTransaction( - getTransactionID(), cohort, modification, returnSerialized), - getContext()); + protected final void dataExists(final DataExists message) { + super.dataExists(transaction, message); } - // These classes are in here for test purposes only + protected final void readData(final ReadData message) { + super.readData(transaction, message); + } - static class GetCompositedModification { + private boolean checkClosed() { + final boolean ret = transaction.isClosed(); + if (ret) { + getSender().tell(new akka.actor.Status.Failure(new IllegalStateException( + "Transaction is closed, no modifications allowed")), getSelf()); + } + return ret; } - static class GetCompositeModificationReply { - private final CompositeModification modification; + private void readyTransaction(final BatchedModifications batched) { + TransactionIdentifier transactionID = getTransactionId(); + LOG.debug("readyTransaction : {}", transactionID); - GetCompositeModificationReply(CompositeModification modification) { - this.modification = modification; - } + getShardActor().forward(new ForwardedReadyTransaction(transactionID, batched.getVersion(), + transaction, batched.isDoCommitOnReady(), batched.getParticipatingShardNames()), getContext()); - public CompositeModification getModification() { - return modification; - } + // The shard will handle the commit from here so we're no longer needed - self-destruct. + getSelf().tell(PoisonPill.getInstance(), getSelf()); } }