X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Futils%2FDataTreeModificationOutput.java;h=3619c2264e142c9bcc3259846569124bb4341c75;hp=84717e188f9d64ad4e28c7446b668da641a23a96;hb=e84f63ee098fff5b02cbce1281ca0d1208f966fa;hpb=925cb4a228d0fda99c7bfeb432eb25285a223887 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/DataTreeModificationOutput.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/DataTreeModificationOutput.java index 84717e188f..3619c2264e 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/DataTreeModificationOutput.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/utils/DataTreeModificationOutput.java @@ -7,16 +7,16 @@ */ package org.opendaylight.controller.cluster.datastore.utils; -import com.google.common.base.Throwables; import java.io.DataOutputStream; import java.io.File; import java.io.FileOutputStream; import java.io.IOException; +import java.nio.charset.StandardCharsets; import javax.xml.stream.XMLStreamException; import org.opendaylight.controller.cluster.datastore.util.AbstractDataTreeModificationCursor; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; -import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeModification; +import org.opendaylight.yangtools.yang.data.tree.api.DataTreeModification; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -32,10 +32,10 @@ public final class DataTreeModificationOutput { } @SuppressWarnings("checkstyle:IllegalCatch") - public static void toFile(File file, DataTreeModification modification) { + public static void toFile(final File file, final DataTreeModification modification) { try (FileOutputStream outStream = new FileOutputStream(file)) { modification.applyToCursor(new DataTreeModificationOutputCursor(new DataOutputStream(outStream))); - } catch (Exception e) { + } catch (IOException | RuntimeException e) { LOG.error("Error writing DataTreeModification to file {}", file, e); } } @@ -43,42 +43,42 @@ public final class DataTreeModificationOutput { private static class DataTreeModificationOutputCursor extends AbstractDataTreeModificationCursor { private final DataOutputStream output; - DataTreeModificationOutputCursor(DataOutputStream output) { + DataTreeModificationOutputCursor(final DataOutputStream output) { this.output = output; } @Override - public void delete(PathArgument child) { + public void delete(final PathArgument child) { try { - output.write("\nDELETE -> ".getBytes()); - output.write(current().node(child).toString().getBytes()); + output.write("\nDELETE -> ".getBytes(StandardCharsets.UTF_8)); + output.write(current().node(child).toString().getBytes(StandardCharsets.UTF_8)); output.writeByte('\n'); } catch (IOException e) { - Throwables.propagate(e); + throw new RuntimeException(e); } } @Override - public void merge(PathArgument child, NormalizedNode data) { + public void merge(final PathArgument child, final NormalizedNode data) { outputPathAndNode("MERGE", child, data); } @Override - public void write(PathArgument child, NormalizedNode data) { + public void write(final PathArgument child, final NormalizedNode data) { outputPathAndNode("WRITE", child, data); } - private void outputPathAndNode(String name, PathArgument child, NormalizedNode data) { + private void outputPathAndNode(final String name, final PathArgument child, final NormalizedNode data) { try { output.writeByte('\n'); - output.write(name.getBytes()); - output.write(" -> ".getBytes()); - output.write(current().node(child).toString().getBytes()); - output.write(": \n".getBytes()); + output.write(name.getBytes(StandardCharsets.UTF_8)); + output.write(" -> ".getBytes(StandardCharsets.UTF_8)); + output.write(current().node(child).toString().getBytes(StandardCharsets.UTF_8)); + output.write(": \n".getBytes(StandardCharsets.UTF_8)); NormalizedNodeXMLOutput.toStream(output, data); output.writeByte('\n'); } catch (IOException | XMLStreamException e) { - Throwables.propagate(e); + throw new RuntimeException(e); } } }