X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatabroker%2FAbstractDOMBrokerWriteTransactionTest.java;h=e77f6456dedc24a4a46ffb7353b7dc6e2d358b1a;hp=5263ab67fa52f4783b093f52f0886f590c85a2b0;hb=546a419fa18f5d7c5dde9f2289baece60c211a81;hpb=f41c5e6e6f6e10b36b1e4b1992877e38e718c8fb diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/AbstractDOMBrokerWriteTransactionTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/AbstractDOMBrokerWriteTransactionTest.java index 5263ab67fa..e77f6456de 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/AbstractDOMBrokerWriteTransactionTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/AbstractDOMBrokerWriteTransactionTest.java @@ -7,26 +7,27 @@ package org.opendaylight.controller.cluster.databroker; import static org.junit.Assert.assertTrue; -import static org.mockito.Matchers.any; +import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.doThrow; -import com.google.common.util.concurrent.CheckedFuture; +import com.google.common.util.concurrent.FluentFuture; import java.util.Collection; import java.util.Collections; +import java.util.concurrent.ExecutionException; import org.junit.Assert; -import org.junit.Before; import org.junit.Test; +import org.junit.runner.RunWith; import org.mockito.Mock; -import org.mockito.MockitoAnnotations; +import org.mockito.junit.MockitoJUnitRunner; +import org.opendaylight.mdsal.common.api.CommitInfo; import org.opendaylight.mdsal.common.api.LogicalDatastoreType; import org.opendaylight.mdsal.common.api.TransactionCommitFailedException; import org.opendaylight.mdsal.dom.spi.store.DOMStoreWriteTransaction; +@RunWith(MockitoJUnitRunner.StrictStubs.class) public class AbstractDOMBrokerWriteTransactionTest { - @Mock - private AbstractDOMTransactionFactory abstractDOMTransactionFactory; - + private AbstractDOMTransactionFactory abstractDOMTransactionFactory; @Mock private DOMStoreWriteTransaction domStoreWriteTransaction; @@ -38,7 +39,7 @@ public class AbstractDOMBrokerWriteTransactionTest { } @Override - protected DOMStoreWriteTransaction createTransaction(LogicalDatastoreType key) { + protected DOMStoreWriteTransaction createTransaction(final LogicalDatastoreType key) { return null; } @@ -48,43 +49,38 @@ public class AbstractDOMBrokerWriteTransactionTest { } } - @Before - public void setup() { - MockitoAnnotations.initMocks(this); - } - @Test - public void readyRuntimeExceptionAndCancel() { + public void readyRuntimeExceptionAndCancel() throws InterruptedException { RuntimeException thrown = new RuntimeException(); doThrow(thrown).when(domStoreWriteTransaction).ready(); AbstractDOMBrokerWriteTransactionTestImpl abstractDOMBrokerWriteTransactionTestImpl = new AbstractDOMBrokerWriteTransactionTestImpl(); - CheckedFuture submitFuture = - abstractDOMBrokerWriteTransactionTestImpl.submit(); + FluentFuture submitFuture = abstractDOMBrokerWriteTransactionTestImpl.commit(); try { - submitFuture.checkedGet(); + submitFuture.get(); Assert.fail("TransactionCommitFailedException expected"); - } catch (TransactionCommitFailedException e) { - assertTrue(e.getCause() == thrown); + } catch (ExecutionException e) { + assertTrue(e.getCause() instanceof TransactionCommitFailedException); + assertTrue(e.getCause().getCause() == thrown); abstractDOMBrokerWriteTransactionTestImpl.cancel(); } } @Test - public void submitRuntimeExceptionAndCancel() { + public void submitRuntimeExceptionAndCancel() throws InterruptedException { RuntimeException thrown = new RuntimeException(); - doThrow(thrown).when(abstractDOMTransactionFactory).submit(any(), any()); + doThrow(thrown).when(abstractDOMTransactionFactory).commit(any(), any()); AbstractDOMBrokerWriteTransactionTestImpl abstractDOMBrokerWriteTransactionTestImpl = new AbstractDOMBrokerWriteTransactionTestImpl(); - CheckedFuture submitFuture = - abstractDOMBrokerWriteTransactionTestImpl.submit(); + FluentFuture submitFuture = abstractDOMBrokerWriteTransactionTestImpl.commit(); try { - submitFuture.checkedGet(); + submitFuture.get(); Assert.fail("TransactionCommitFailedException expected"); - } catch (TransactionCommitFailedException e) { - assertTrue(e.getCause() == thrown); + } catch (ExecutionException e) { + assertTrue(e.getCause() instanceof TransactionCommitFailedException); + assertTrue(e.getCause().getCause() == thrown); abstractDOMBrokerWriteTransactionTestImpl.cancel(); } }