X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDataChangeListenerTest.java;h=25d47388fe49579fdb66271e4f33ca7effeef314;hp=26ec583b3e058108f9cc18517f5f6909847f5cd6;hb=75495f26e7718da7d6f9e0ad06af1caa2e3ebf08;hpb=b17205ee3cc4800dccbc222ae8b6607bdc814f76 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java index 26ec583b3e..25d47388fe 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java @@ -1,154 +1,130 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorRef; +import akka.actor.DeadLetter; import akka.actor.Props; import akka.testkit.JavaTestKit; +import org.junit.Assert; import org.junit.Test; +import org.mockito.Mockito; import org.opendaylight.controller.cluster.datastore.messages.DataChanged; import org.opendaylight.controller.cluster.datastore.messages.DataChangedReply; import org.opendaylight.controller.cluster.datastore.messages.EnableNotification; import org.opendaylight.controller.md.cluster.datastore.model.CompositeModel; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeEvent; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeListener; -import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; -import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; - -import java.util.HashMap; -import java.util.HashSet; -import java.util.Map; -import java.util.Set; - -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertTrue; +import org.opendaylight.yangtools.yang.model.api.SchemaContext; public class DataChangeListenerTest extends AbstractActorTest { - private static class MockDataChangedEvent implements AsyncDataChangeEvent> { - Map> createdData = new HashMap(); - Map> updatedData = new HashMap(); - Map> originalData = new HashMap(); - - - - @Override - public Map> getCreatedData() { - createdData.put(CompositeModel.FAMILY_PATH, CompositeModel.createFamily()); - return createdData; - } - - @Override - public Map> getUpdatedData() { - updatedData.put(CompositeModel.FAMILY_PATH, CompositeModel.createFamily()); - return updatedData; - - } - - @Override - public Set getRemovedPaths() { - Setids = new HashSet(); - ids.add( CompositeModel.TEST_PATH); - return ids; - } - - @Override - public Map> getOriginalData() { - originalData.put(CompositeModel.FAMILY_PATH, CompositeModel.createFamily()); - return originalData; - } - - @Override public NormalizedNode getOriginalSubtree() { - + @SuppressWarnings({ "rawtypes", "unchecked" }) + @Test + public void testDataChangedWhenNotificationsAreEnabled(){ + new JavaTestKit(getSystem()) {{ + final AsyncDataChangeEvent mockChangeEvent = Mockito.mock(AsyncDataChangeEvent.class); + final AsyncDataChangeListener mockListener = Mockito.mock(AsyncDataChangeListener.class); + final Props props = DataChangeListener.props(mockListener); + final ActorRef subject = getSystem().actorOf(props, "testDataChangedNotificationsEnabled"); - return originalData.put(CompositeModel.FAMILY_PATH, CompositeModel.createFamily()); - } + // Let the DataChangeListener know that notifications should be enabled + subject.tell(new EnableNotification(true), getRef()); - @Override public NormalizedNode getUpdatedSubtree() { + subject.tell(new DataChanged(CompositeModel.createTestContext(), mockChangeEvent), + getRef()); - //fixme: need to have some valid data here - return originalData.put(CompositeModel.FAMILY_PATH, CompositeModel.createFamily()); - } - } + expectMsgClass(DataChangedReply.class); - private class MockDataChangeListener implements AsyncDataChangeListener> { - private boolean gotIt = false; - private AsyncDataChangeEvent> change; - - @Override public void onDataChanged( - AsyncDataChangeEvent> change) { - gotIt = true;this.change=change; - } - - public boolean gotIt() { - return gotIt; - } - public AsyncDataChangeEvent> getChange(){ - return change; - } + Mockito.verify(mockListener).onDataChanged(mockChangeEvent); + }}; } + @SuppressWarnings({ "rawtypes", "unchecked" }) @Test - public void testDataChangedWhenNotificationsAreEnabled(){ + public void testDataChangedWhenNotificationsAreDisabled(){ new JavaTestKit(getSystem()) {{ - final MockDataChangeListener listener = new MockDataChangeListener(); - final Props props = DataChangeListener.props(CompositeModel.createTestContext(),listener,CompositeModel.FAMILY_PATH ); + final AsyncDataChangeEvent mockChangeEvent = Mockito.mock(AsyncDataChangeEvent.class); + final AsyncDataChangeListener mockListener = Mockito.mock(AsyncDataChangeListener.class); + final Props props = DataChangeListener.props(mockListener); final ActorRef subject = - getSystem().actorOf(props, "testDataChangedNotificationsEnabled"); + getSystem().actorOf(props, "testDataChangedNotificationsDisabled"); + + subject.tell(new DataChanged(CompositeModel.createTestContext(), mockChangeEvent), + getRef()); new Within(duration("1 seconds")) { + @Override protected void run() { - - // Let the DataChangeListener know that notifications should - // be enabled - subject.tell(new EnableNotification(true), getRef()); - - subject.tell( - new DataChanged(CompositeModel.createTestContext(),new MockDataChangedEvent()), - getRef()); - - final Boolean out = new ExpectMsg(duration("800 millis"), "dataChanged") { - // do not put code outside this method, will run afterwards - protected Boolean match(Object in) { - if (in != null && in.getClass().equals(DataChangedReply.class)) { - - return true; - } else { - throw noMatch(); - } - } - }.get(); // this extracts the received message - - assertTrue(out); - assertTrue(listener.gotIt()); - assertNotNull(listener.getChange().getCreatedData()); - expectNoMsg(); + + Mockito.verify(mockListener, Mockito.never()).onDataChanged( + Mockito.any(AsyncDataChangeEvent.class)); } + }; + }}; + } + @SuppressWarnings({ "rawtypes", "unchecked" }) + @Test + public void testDataChangedWithNoSender(){ + new JavaTestKit(getSystem()) {{ + final AsyncDataChangeEvent mockChangeEvent = Mockito.mock(AsyncDataChangeEvent.class); + final AsyncDataChangeListener mockListener = Mockito.mock(AsyncDataChangeListener.class); + final Props props = DataChangeListener.props(mockListener); + final ActorRef subject = getSystem().actorOf(props, "testDataChangedWithNoSender"); + + getSystem().eventStream().subscribe(getRef(), DeadLetter.class); + + subject.tell(new DataChanged(CompositeModel.createTestContext(), mockChangeEvent), + ActorRef.noSender()); + + // Make sure no DataChangedReply is sent to DeadLetters. + while(true) { + DeadLetter deadLetter; + try { + deadLetter = expectMsgClass(duration("1 seconds"), DeadLetter.class); + } catch (AssertionError e) { + // Timed out - got no DeadLetter - this is good + break; + } - }; + // We may get DeadLetters for other messages we don't care about. + Assert.assertFalse("Unexpected DataChangedReply", + deadLetter.message() instanceof DataChangedReply); + } }}; } + @SuppressWarnings({ "rawtypes", "unchecked" }) @Test - public void testDataChangedWhenNotificationsAreDisabled(){ + public void testDataChangedWithListenerRuntimeEx(){ new JavaTestKit(getSystem()) {{ - final MockDataChangeListener listener = new MockDataChangeListener(); - final Props props = DataChangeListener.props(CompositeModel.createTestContext(),listener,CompositeModel.FAMILY_PATH ); - final ActorRef subject = - getSystem().actorOf(props, "testDataChangedNotificationsDisabled"); + AsyncDataChangeEvent mockChangeEvent1 = Mockito.mock(AsyncDataChangeEvent.class); + AsyncDataChangeEvent mockChangeEvent2 = Mockito.mock(AsyncDataChangeEvent.class); + AsyncDataChangeEvent mockChangeEvent3 = Mockito.mock(AsyncDataChangeEvent.class); - new Within(duration("1 seconds")) { - protected void run() { + AsyncDataChangeListener mockListener = Mockito.mock(AsyncDataChangeListener.class); + Mockito.doThrow(new RuntimeException("mock")).when(mockListener).onDataChanged(mockChangeEvent2); - subject.tell( - new DataChanged(CompositeModel.createTestContext(),new MockDataChangedEvent()), - getRef()); + Props props = DataChangeListener.props(mockListener); + ActorRef subject = getSystem().actorOf(props, "testDataChangedWithListenerRuntimeEx"); - expectNoMsg(); - } + // Let the DataChangeListener know that notifications should be enabled + subject.tell(new EnableNotification(true), getRef()); + SchemaContext schemaContext = CompositeModel.createTestContext(); - }; + subject.tell(new DataChanged(schemaContext, mockChangeEvent1),getRef()); + expectMsgClass(DataChangedReply.class); + + subject.tell(new DataChanged(schemaContext, mockChangeEvent2),getRef()); + expectMsgClass(DataChangedReply.class); + + subject.tell(new DataChanged(schemaContext, mockChangeEvent3),getRef()); + expectMsgClass(DataChangedReply.class); + + Mockito.verify(mockListener).onDataChanged(mockChangeEvent1); + Mockito.verify(mockListener).onDataChanged(mockChangeEvent2); + Mockito.verify(mockListener).onDataChanged(mockChangeEvent3); }}; } }