X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDataChangeListenerTest.java;h=d5a12c73c57c0deb4fda3be2f11aac435a428bdc;hp=101a73782b498943acb14b0cb03be2dde5df1f87;hb=0dad308556a5e4d6b5623bb3212238aa6bdd3a0c;hpb=3d7c2897555bff941853f29093ba5ab8c811a421 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java index 101a73782b..d5a12c73c5 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java @@ -4,6 +4,7 @@ import akka.actor.ActorRef; import akka.actor.DeadLetter; import akka.actor.Props; import akka.testkit.JavaTestKit; +import org.junit.Assert; import org.junit.Test; import org.mockito.Mockito; import org.opendaylight.controller.cluster.datastore.messages.DataChanged; @@ -70,19 +71,25 @@ public class DataChangeListenerTest extends AbstractActorTest { final Props props = DataChangeListener.props(mockListener); final ActorRef subject = getSystem().actorOf(props, "testDataChangedWithNoSender"); - // Let the DataChangeListener know that notifications should be enabled - subject.tell(new EnableNotification(true), ActorRef.noSender()); + getSystem().eventStream().subscribe(getRef(), DeadLetter.class); subject.tell(new DataChanged(CompositeModel.createTestContext(), mockChangeEvent), ActorRef.noSender()); - getSystem().eventStream().subscribe(getRef(), DeadLetter.class); - new Within(duration("1 seconds")) { - @Override - protected void run() { - expectNoMsg(); + // Make sure no DataChangedReply is sent to DeadLetters. + while(true) { + DeadLetter deadLetter; + try { + deadLetter = expectMsgClass(duration("1 seconds"), DeadLetter.class); + } catch (AssertionError e) { + // Timed out - got no DeadLetter - this is good + break; } - }; + + // We may get DeadLetters for other messages we don't care about. + Assert.assertFalse("Unexpected DataChangedReply", + deadLetter.message() instanceof DataChangedReply); + } }}; } }