X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FDataChangeListenerTest.java;h=f3dcaa2b709810d169ae1ae1cc0b54c716051fe9;hp=6f0816be5c8a19968c0c3811adf68f713497a033;hb=013a6679470bf692753f2e04ab4398c97fd9f5d0;hpb=c1362c86eb19e92e6c64d10099a45deb499c6db1 diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java index 6f0816be5c..f3dcaa2b70 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DataChangeListenerTest.java @@ -1,102 +1,142 @@ +/* + * Copyright (c) 2014, 2015 Cisco Systems, Inc. and others. All rights reserved. + * + * This program and the accompanying materials are made available under the + * terms of the Eclipse Public License v1.0 which accompanies this distribution, + * and is available at http://www.eclipse.org/legal/epl-v10.html + */ + package org.opendaylight.controller.cluster.datastore; +import static org.opendaylight.controller.md.cluster.datastore.model.TestModel.TEST_PATH; + import akka.actor.ActorRef; +import akka.actor.DeadLetter; import akka.actor.Props; import akka.testkit.JavaTestKit; +import org.junit.Assert; import org.junit.Test; +import org.mockito.Mockito; import org.opendaylight.controller.cluster.datastore.messages.DataChanged; import org.opendaylight.controller.cluster.datastore.messages.DataChangedReply; +import org.opendaylight.controller.cluster.datastore.messages.EnableNotification; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeEvent; import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeListener; -import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier; -import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; - -import java.util.Map; -import java.util.Set; - -import static org.junit.Assert.assertTrue; public class DataChangeListenerTest extends AbstractActorTest { - private static class MockDataChangedEvent implements AsyncDataChangeEvent> { + @SuppressWarnings({ "rawtypes", "unchecked" }) + @Test + public void testDataChangedWhenNotificationsAreEnabled() { + new JavaTestKit(getSystem()) { + { + final AsyncDataChangeEvent mockChangeEvent = Mockito.mock(AsyncDataChangeEvent.class); + final AsyncDataChangeListener mockListener = Mockito.mock(AsyncDataChangeListener.class); + final Props props = DataChangeListener.props(mockListener, TEST_PATH); + final ActorRef subject = getSystem().actorOf(props, "testDataChangedNotificationsEnabled"); - @Override - public Map> getCreatedData() { - throw new UnsupportedOperationException("getCreatedData"); - } + // Let the DataChangeListener know that notifications should be + // enabled + subject.tell(new EnableNotification(true), getRef()); - @Override - public Map> getUpdatedData() { - throw new UnsupportedOperationException("getUpdatedData"); - } + subject.tell(new DataChanged(mockChangeEvent), getRef()); - @Override public Set getRemovedPaths() { - throw new UnsupportedOperationException("getRemovedPaths"); - } + expectMsgClass(DataChangedReply.class); - @Override - public Map> getOriginalData() { - throw new UnsupportedOperationException("getOriginalData"); - } + Mockito.verify(mockListener).onDataChanged(mockChangeEvent); + } + }; + } - @Override public NormalizedNode getOriginalSubtree() { - throw new UnsupportedOperationException("getOriginalSubtree"); - } + @SuppressWarnings({ "rawtypes", "unchecked" }) + @Test + public void testDataChangedWhenNotificationsAreDisabled() { + new JavaTestKit(getSystem()) { + { + final AsyncDataChangeEvent mockChangeEvent = Mockito.mock(AsyncDataChangeEvent.class); + final AsyncDataChangeListener mockListener = Mockito.mock(AsyncDataChangeListener.class); + final Props props = DataChangeListener.props(mockListener, TEST_PATH); + final ActorRef subject = getSystem().actorOf(props, "testDataChangedNotificationsDisabled"); + + subject.tell(new DataChanged(mockChangeEvent), getRef()); + + new Within(duration("1 seconds")) { + @Override + protected void run() { + expectNoMsg(); + + Mockito.verify(mockListener, Mockito.never()) + .onDataChanged(Mockito.any(AsyncDataChangeEvent.class)); + } + }; + } + }; + } - @Override public NormalizedNode getUpdatedSubtree() { - throw new UnsupportedOperationException("getUpdatedSubtree"); - } + @SuppressWarnings({ "rawtypes", "unchecked" }) + @Test + public void testDataChangedWithNoSender() { + new JavaTestKit(getSystem()) { + { + final AsyncDataChangeEvent mockChangeEvent = Mockito.mock(AsyncDataChangeEvent.class); + final AsyncDataChangeListener mockListener = Mockito.mock(AsyncDataChangeListener.class); + final Props props = DataChangeListener.props(mockListener, TEST_PATH); + final ActorRef subject = getSystem().actorOf(props, "testDataChangedWithNoSender"); + + getSystem().eventStream().subscribe(getRef(), DeadLetter.class); + + subject.tell(new DataChanged(mockChangeEvent), ActorRef.noSender()); + + // Make sure no DataChangedReply is sent to DeadLetters. + while (true) { + DeadLetter deadLetter; + try { + deadLetter = expectMsgClass(duration("1 seconds"), DeadLetter.class); + } catch (AssertionError e) { + // Timed out - got no DeadLetter - this is good + break; + } + + // We may get DeadLetters for other messages we don't care + // about. + Assert.assertFalse("Unexpected DataChangedReply", deadLetter.message() instanceof DataChangedReply); + } + } + }; } - private class MockDataChangeListener implements AsyncDataChangeListener> { - private boolean gotIt = false; + @SuppressWarnings({ "rawtypes", "unchecked" }) + @Test + public void testDataChangedWithListenerRuntimeEx() { + new JavaTestKit(getSystem()) { + { + final AsyncDataChangeEvent mockChangeEvent1 = Mockito.mock(AsyncDataChangeEvent.class); + final AsyncDataChangeEvent mockChangeEvent2 = Mockito.mock(AsyncDataChangeEvent.class); + final AsyncDataChangeEvent mockChangeEvent3 = Mockito.mock(AsyncDataChangeEvent.class); - @Override public void onDataChanged( - AsyncDataChangeEvent> change) { - gotIt = true; - } + AsyncDataChangeListener mockListener = Mockito.mock(AsyncDataChangeListener.class); + Mockito.doThrow(new RuntimeException("mock")).when(mockListener).onDataChanged(mockChangeEvent2); - public boolean gotIt() { - return gotIt; - } - } + Props props = DataChangeListener.props(mockListener, TEST_PATH); + ActorRef subject = getSystem().actorOf(props, "testDataChangedWithListenerRuntimeEx"); - @Test - public void testDataChanged(){ - new JavaTestKit(getSystem()) {{ - final MockDataChangeListener listener = new MockDataChangeListener(); - final Props props = DataChangeListener.props(listener); - final ActorRef subject = - getSystem().actorOf(props, "testDataChanged"); - - new Within(duration("1 seconds")) { - protected void run() { - - subject.tell( - new DataChanged(new MockDataChangedEvent()), - getRef()); - - final Boolean out = new ExpectMsg("dataChanged") { - // do not put code outside this method, will run afterwards - protected Boolean match(Object in) { - if (in instanceof DataChangedReply) { - DataChangedReply reply = - (DataChangedReply) in; - return true; - } else { - throw noMatch(); - } - } - }.get(); // this extracts the received message - - assertTrue(out); - assertTrue(listener.gotIt()); - // Will wait for the rest of the 3 seconds - expectNoMsg(); - } + // Let the DataChangeListener know that notifications should be + // enabled + subject.tell(new EnableNotification(true), getRef()); + + subject.tell(new DataChanged(mockChangeEvent1), getRef()); + expectMsgClass(DataChangedReply.class); + + subject.tell(new DataChanged(mockChangeEvent2), getRef()); + expectMsgClass(DataChangedReply.class); + subject.tell(new DataChanged(mockChangeEvent3), getRef()); + expectMsgClass(DataChangedReply.class); - }; - }}; + Mockito.verify(mockListener).onDataChanged(mockChangeEvent1); + Mockito.verify(mockListener).onDataChanged(mockChangeEvent2); + Mockito.verify(mockListener).onDataChanged(mockChangeEvent3); + } + }; } }