X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardTestKit.java;h=b22ca277e507479ac86846c912f18e9f5d0615e9;hp=79d5c5116d4617de160f68e7f1952042327715ed;hb=HEAD;hpb=cd81eb73b7abf677571b2366425ccbc8d794f4b6

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTestKit.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTestKit.java
index 79d5c5116d..515c0b5b92 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTestKit.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTestKit.java
@@ -7,66 +7,92 @@
  */
 package org.opendaylight.controller.cluster.datastore;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
 import akka.actor.ActorRef;
 import akka.actor.ActorSystem;
 import akka.pattern.Patterns;
-import akka.testkit.JavaTestKit;
+import akka.testkit.javadsl.EventFilter;
+import akka.testkit.javadsl.TestKit;
 import akka.util.Timeout;
 import com.google.common.util.concurrent.Uninterruptibles;
-import org.junit.Assert;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
 import org.opendaylight.controller.cluster.raft.client.messages.FindLeader;
 import org.opendaylight.controller.cluster.raft.client.messages.FindLeaderReply;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import scala.concurrent.Await;
 import scala.concurrent.Future;
-import scala.concurrent.duration.Duration;
 import scala.concurrent.duration.FiniteDuration;
 
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.TimeoutException;
+public class ShardTestKit extends TestKit {
+    private static final Logger LOG = LoggerFactory.getLogger(ShardTestKit.class);
 
-class ShardTestKit extends JavaTestKit {
-
-    ShardTestKit(ActorSystem actorSystem) {
+    public ShardTestKit(final ActorSystem actorSystem) {
         super(actorSystem);
     }
 
-    protected void waitForLogMessage(final Class logLevel, ActorRef subject, String logMessage){
+    public void waitForLogMessage(final Class<?> logLevel, final ActorRef subject, final String logMessage) {
         // Wait for a specific log message to show up
-        final boolean result =
-            new JavaTestKit.EventFilter<Boolean>(logLevel
-            ) {
-                @Override
-                protected Boolean run() {
-                    return true;
+        final Boolean result = new EventFilter(logLevel, getSystem()).from(subject.path().toString())
+                .message(logMessage).occurrences(1).intercept(() -> Boolean.TRUE);
+        assertEquals(Boolean.TRUE, result);
+    }
+
+    @SuppressWarnings("checkstyle:IllegalCatch")
+    public static String waitUntilLeader(final ActorRef shard) {
+        FiniteDuration duration = FiniteDuration.create(100, TimeUnit.MILLISECONDS);
+        for (int i = 0; i < 20 * 5; i++) {
+            Future<Object> future = Patterns.ask(shard, FindLeader.INSTANCE, new Timeout(duration));
+            try {
+                final var maybeLeader = ((FindLeaderReply) Await.result(future, duration)).getLeaderActor();
+                if (maybeLeader.isPresent()) {
+                    return maybeLeader.orElseThrow();
                 }
-            }.from(subject.path().toString())
-                .message(logMessage)
-                .occurrences(1).exec();
+            } catch (TimeoutException e) {
+                LOG.trace("FindLeader timed out", e);
+            } catch (Exception e) {
+                LOG.error("FindLeader failed", e);
+            }
 
-        Assert.assertEquals(true, result);
+            Uninterruptibles.sleepUninterruptibly(50, TimeUnit.MILLISECONDS);
+        }
 
+        fail("Leader not found for shard " + shard.path());
+        return null;
     }
 
-    protected void waitUntilLeader(ActorRef shard) {
-        FiniteDuration duration = Duration.create(100, TimeUnit.MILLISECONDS);
-        for(int i = 0; i < 20 * 5; i++) {
-            Future<Object> future = Patterns.ask(shard, new FindLeader(), new Timeout(duration));
+    @SuppressWarnings("checkstyle:IllegalCatch")
+    public void waitUntilNoLeader(final ActorRef shard) {
+        FiniteDuration duration = FiniteDuration.create(100, TimeUnit.MILLISECONDS);
+        Object lastResponse = null;
+        for (int i = 0; i < 20 * 5; i++) {
+            Future<Object> future = Patterns.ask(shard, FindLeader.INSTANCE, new Timeout(duration));
             try {
-                FindLeaderReply resp = (FindLeaderReply)Await.result(future, duration);
-                if(resp.getLeaderActor() != null) {
+                final var maybeLeader = ((FindLeaderReply) Await.result(future, duration)).getLeaderActor();
+                if (!maybeLeader.isPresent()) {
                     return;
                 }
-            } catch(TimeoutException e) {
-            } catch(Exception e) {
-                System.err.println("FindLeader threw ex");
-                e.printStackTrace();
-            }
 
+                lastResponse = maybeLeader.orElseThrow();
+            } catch (TimeoutException e) {
+                lastResponse = e;
+            } catch (Exception e) {
+                LOG.error("FindLeader failed", e);
+                lastResponse = e;
+            }
 
             Uninterruptibles.sleepUninterruptibly(50, TimeUnit.MILLISECONDS);
         }
 
-        Assert.fail("Leader not found for shard " + shard.path());
-    }
+        if (lastResponse instanceof Throwable) {
+            throw (AssertionError)new AssertionError(
+                    String.format("Unexpected error occurred from FindLeader for shard %s", shard.path()))
+                            .initCause((Throwable)lastResponse);
+        }
 
-}
\ No newline at end of file
+        fail(String.format("Unexpected leader %s found for shard %s", lastResponse, shard.path()));
+    }
+}