X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardTransactionFailureTest.java;h=869f47578711ea313181e4011444dc82ca35feaa;hp=86016a677b3f6f357e3ad8cf31c86e174a3a2a3b;hb=9f61e98b036119694dfef0759a7cafc56aae6e86;hpb=26d0e25159bf3b73ca38a88e17268cf17f876d8d diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionFailureTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionFailureTest.java index 86016a677b..869f475787 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionFailureTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionFailureTest.java @@ -13,28 +13,34 @@ package org.opendaylight.controller.cluster.datastore; import akka.actor.ActorRef; import akka.actor.Props; import akka.testkit.TestActorRef; + import com.google.common.util.concurrent.ListeningExecutorService; import com.google.common.util.concurrent.MoreExecutors; -import org.junit.Assert; + +import org.junit.BeforeClass; import org.junit.Test; -import org.opendaylight.controller.cluster.datastore.messages.DeleteData; +import org.opendaylight.controller.cluster.datastore.identifiers.ShardIdentifier; +import org.opendaylight.controller.cluster.datastore.jmx.mbeans.shard.ShardStats; +import org.opendaylight.controller.cluster.datastore.node.utils.serialization.NormalizedNodeSerializer; import org.opendaylight.controller.md.cluster.datastore.model.TestModel; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; import org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMDataStore; import org.opendaylight.controller.protobuff.messages.common.NormalizedNodeMessages; import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages; +import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; +import org.opendaylight.yangtools.yang.data.impl.schema.Builders; import org.opendaylight.yangtools.yang.model.api.SchemaContext; + import scala.concurrent.Await; import scala.concurrent.Future; import scala.concurrent.duration.Duration; import java.util.Collections; - -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertTrue; +import java.util.concurrent.TimeUnit; /** * Covers negative test cases + * * @author Basheeruddin Ahmed */ public class ShardTransactionFailureTest extends AbstractActorTest { @@ -48,48 +54,30 @@ public class ShardTransactionFailureTest extends AbstractActorTest { private static final SchemaContext testSchemaContext = TestModel.createTestContext(); - static { + private static final ShardIdentifier SHARD_IDENTIFIER = + ShardIdentifier.builder().memberName("member-1") + .shardName("inventory").type("operational").build(); + + private final DatastoreContext datastoreContext = new DatastoreContext(); + + private final ShardStats shardStats = new ShardStats(SHARD_IDENTIFIER.toString(), "DataStore"); + + @BeforeClass + public static void staticSetup() { store.onGlobalContextUpdated(testSchemaContext); } - - @Test - public void testNegativePerformingWriteOperationOnReadTransaction() - throws Exception { - try { - - final ActorRef - shard = getSystem() - .actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction - .props(store.newReadOnlyTransaction(), shard, TestModel - .createTestContext()); - final TestActorRef subject = TestActorRef.apply(props, getSystem()); - - subject - .receive(new DeleteData(TestModel.TEST_PATH).toSerializable(), - ActorRef.noSender()); - Assert.assertFalse(true); - - - } catch (Exception cs) { - assertEquals(cs.getClass().getSimpleName(), - Exception.class.getSimpleName()); - assertTrue(cs.getMessage().startsWith( - "ShardTransaction:handleRecieve received an unknown message")); - } + private ActorRef createShard(){ + return getSystem().actorOf(Shard.props(SHARD_IDENTIFIER, Collections.EMPTY_MAP, new DatastoreContext(), TestModel.createTestContext())); } @Test(expected = ReadFailedException.class) public void testNegativeReadWithReadOnlyTransactionClosed() throws Throwable { - final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newReadOnlyTransaction(), shard, - TestModel.createTestContext()); + final ActorRef shard = createShard(); + final Props props = ShardTransaction.props(store.newReadOnlyTransaction(), shard, + testSchemaContext, datastoreContext, shardStats); final TestActorRef subject = TestActorRef .create(getSystem(), props, @@ -103,32 +91,26 @@ public class ShardTransactionFailureTest extends AbstractActorTest { ).build(); Future future = akka.pattern.Patterns.ask(subject, readData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); - ((ShardReadTransaction) subject.underlyingActor()) - .forUnitTestOnlyExplicitTransactionClose(); + subject.underlyingActor().getDOMStoreTransaction().close(); future = akka.pattern.Patterns.ask(subject, readData, 3000); - Await.result(future, Duration.Zero()); - - + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); } @Test(expected = ReadFailedException.class) - public void testNegativeReadWithReadWriteOnlyTransactionClosed() + public void testNegativeReadWithReadWriteTransactionClosed() throws Throwable { - final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newReadWriteTransaction(), shard, - TestModel.createTestContext()); + final ActorRef shard = createShard(); + final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, + testSchemaContext, datastoreContext, shardStats); final TestActorRef subject = TestActorRef .create(getSystem(), props, - "testNegativeReadWithReadWriteOnlyTransactionClosed"); + "testNegativeReadWithReadWriteTransactionClosed"); ShardTransactionMessages.ReadData readData = ShardTransactionMessages.ReadData.newBuilder() @@ -136,30 +118,53 @@ public class ShardTransactionFailureTest extends AbstractActorTest { NormalizedNodeMessages.InstanceIdentifier.newBuilder() .build() ).build(); + Future future = akka.pattern.Patterns.ask(subject, readData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); - ((ShardReadWriteTransaction) subject.underlyingActor()) - .forUnitTestOnlyExplicitTransactionClose(); + subject.underlyingActor().getDOMStoreTransaction().close(); future = akka.pattern.Patterns.ask(subject, readData, 3000); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); + } + @Test(expected = ReadFailedException.class) + public void testNegativeExistsWithReadWriteTransactionClosed() + throws Throwable { - } + final ActorRef shard = createShard(); + final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, + testSchemaContext, datastoreContext, shardStats); + final TestActorRef subject = TestActorRef + .create(getSystem(), props, + "testNegativeExistsWithReadWriteTransactionClosed"); + + ShardTransactionMessages.DataExists dataExists = + ShardTransactionMessages.DataExists.newBuilder() + .setInstanceIdentifierPathArguments( + NormalizedNodeMessages.InstanceIdentifier.newBuilder() + .build() + ).build(); + + Future future = + akka.pattern.Patterns.ask(subject, dataExists, 3000); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); + + subject.underlyingActor().getDOMStoreTransaction().close(); + + future = akka.pattern.Patterns.ask(subject, dataExists, 3000); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); + } @Test(expected = IllegalStateException.class) public void testNegativeWriteWithTransactionReady() throws Exception { - final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newWriteOnlyTransaction(), shard, - TestModel.createTestContext()); + final ActorRef shard = createShard(); + final Props props = ShardTransaction.props(store.newWriteOnlyTransaction(), shard, + testSchemaContext, datastoreContext, shardStats); final TestActorRef subject = TestActorRef .create(getSystem(), props, @@ -170,35 +175,28 @@ public class ShardTransactionFailureTest extends AbstractActorTest { Future future = akka.pattern.Patterns.ask(subject, readyTransaction, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); ShardTransactionMessages.WriteData writeData = ShardTransactionMessages.WriteData.newBuilder() .setInstanceIdentifierPathArguments( NormalizedNodeMessages.InstanceIdentifier.newBuilder() .build()).setNormalizedNode( - NormalizedNodeMessages.Node.newBuilder().build() + buildNormalizedNode() ).build(); future = akka.pattern.Patterns.ask(subject, writeData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); - - + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); } - @Test(expected = IllegalStateException.class) public void testNegativeReadWriteWithTransactionReady() throws Exception { - final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newReadWriteTransaction(), shard, - TestModel.createTestContext()); + final ActorRef shard = createShard(); + final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, + testSchemaContext, datastoreContext, shardStats); final TestActorRef subject = TestActorRef .create(getSystem(), props, @@ -209,34 +207,33 @@ public class ShardTransactionFailureTest extends AbstractActorTest { Future future = akka.pattern.Patterns.ask(subject, readyTransaction, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); ShardTransactionMessages.WriteData writeData = ShardTransactionMessages.WriteData.newBuilder() .setInstanceIdentifierPathArguments( NormalizedNodeMessages.InstanceIdentifier.newBuilder() - .build()).setNormalizedNode( - NormalizedNodeMessages.Node.newBuilder().build() - - ).build(); + .build() + ) + .setNormalizedNode(buildNormalizedNode()) + .build(); future = akka.pattern.Patterns.ask(subject, writeData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); - + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); + } + private NormalizedNodeMessages.Node buildNormalizedNode() { + return NormalizedNodeSerializer + .serialize(Builders.containerBuilder().withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)).build()); } @Test(expected = IllegalStateException.class) public void testNegativeMergeTransactionReady() throws Exception { - final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newReadWriteTransaction(), shard, - TestModel.createTestContext()); + final ActorRef shard = createShard(); + final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, + testSchemaContext, datastoreContext, shardStats); final TestActorRef subject = TestActorRef .create(getSystem(), props, "testNegativeMergeTransactionReady"); @@ -246,23 +243,19 @@ public class ShardTransactionFailureTest extends AbstractActorTest { Future future = akka.pattern.Patterns.ask(subject, readyTransaction, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); ShardTransactionMessages.MergeData mergeData = ShardTransactionMessages.MergeData.newBuilder() .setInstanceIdentifierPathArguments( NormalizedNodeMessages.InstanceIdentifier.newBuilder() .build()).setNormalizedNode( - NormalizedNodeMessages.Node.newBuilder().build() + buildNormalizedNode() ).build(); future = akka.pattern.Patterns.ask(subject, mergeData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); - - + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); } @@ -270,11 +263,9 @@ public class ShardTransactionFailureTest extends AbstractActorTest { public void testNegativeDeleteDataWhenTransactionReady() throws Exception { - final ActorRef shard = - getSystem().actorOf(Shard.props("config", Collections.EMPTY_MAP)); - final Props props = - ShardTransaction.props(store.newReadWriteTransaction(), shard, - TestModel.createTestContext()); + final ActorRef shard = createShard(); + final Props props = ShardTransaction.props(store.newReadWriteTransaction(), shard, + testSchemaContext, datastoreContext, shardStats); final TestActorRef subject = TestActorRef .create(getSystem(), props, @@ -285,8 +276,7 @@ public class ShardTransactionFailureTest extends AbstractActorTest { Future future = akka.pattern.Patterns.ask(subject, readyTransaction, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); ShardTransactionMessages.DeleteData deleteData = ShardTransactionMessages.DeleteData.newBuilder() @@ -295,9 +285,6 @@ public class ShardTransactionFailureTest extends AbstractActorTest { .build()).build(); future = akka.pattern.Patterns.ask(subject, deleteData, 3000); - assertTrue(future.isCompleted()); - Await.result(future, Duration.Zero()); - - + Await.result(future, Duration.create(3, TimeUnit.SECONDS)); } }