X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=blobdiff_plain;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FShardTransactionTest.java;h=a59abe7dd0621c4253d9594d1e42a2939dcbbe86;hp=23984ad973933666d41fb60c762e18517181ef1a;hb=ccca30bbb1545643c427fc59c23329c5d49f8d4b;hpb=9fb1df14f2dc885fee1dce821b753cc99af6e54f diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java index 23984ad973..a59abe7dd0 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ShardTransactionTest.java @@ -1,673 +1,368 @@ +/* + * Copyright (c) 2014, 2015 Cisco Systems, Inc. and others. All rights reserved. + * + * This program and the accompanying materials are made available under the + * terms of the Eclipse Public License v1.0 which accompanies this distribution, + * and is available at http://www.eclipse.org/legal/epl-v10.html + */ package org.opendaylight.controller.cluster.datastore; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; import static org.mockito.Mockito.doThrow; +import static org.mockito.Mockito.inOrder; +import static org.mockito.Mockito.mock; + import akka.actor.ActorRef; import akka.actor.Props; import akka.actor.Status.Failure; import akka.actor.Terminated; -import akka.testkit.JavaTestKit; +import akka.dispatch.Dispatchers; import akka.testkit.TestActorRef; -import java.util.Collections; +import akka.testkit.javadsl.TestKit; +import com.google.common.base.Throwables; +import java.time.Duration; import java.util.concurrent.TimeUnit; +import org.junit.Before; import org.junit.Test; import org.mockito.InOrder; -import org.mockito.Mockito; -import org.opendaylight.controller.cluster.datastore.ShardWriteTransaction.GetCompositeModificationReply; -import org.opendaylight.controller.cluster.datastore.TransactionProxy.TransactionType; -import org.opendaylight.controller.cluster.datastore.exceptions.UnknownMessageException; +import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.controller.cluster.datastore.identifiers.ShardIdentifier; -import org.opendaylight.controller.cluster.datastore.jmx.mbeans.shard.ShardStats; import org.opendaylight.controller.cluster.datastore.messages.BatchedModifications; import org.opendaylight.controller.cluster.datastore.messages.BatchedModificationsReply; import org.opendaylight.controller.cluster.datastore.messages.CloseTransaction; import org.opendaylight.controller.cluster.datastore.messages.CloseTransactionReply; import org.opendaylight.controller.cluster.datastore.messages.CommitTransactionReply; -import org.opendaylight.controller.cluster.datastore.messages.CreateSnapshot; import org.opendaylight.controller.cluster.datastore.messages.DataExists; import org.opendaylight.controller.cluster.datastore.messages.DataExistsReply; -import org.opendaylight.controller.cluster.datastore.messages.DeleteData; -import org.opendaylight.controller.cluster.datastore.messages.DeleteDataReply; -import org.opendaylight.controller.cluster.datastore.messages.MergeData; -import org.opendaylight.controller.cluster.datastore.messages.MergeDataReply; import org.opendaylight.controller.cluster.datastore.messages.ReadData; import org.opendaylight.controller.cluster.datastore.messages.ReadDataReply; -import org.opendaylight.controller.cluster.datastore.messages.ReadyTransaction; import org.opendaylight.controller.cluster.datastore.messages.ReadyTransactionReply; -import org.opendaylight.controller.cluster.datastore.messages.WriteData; -import org.opendaylight.controller.cluster.datastore.messages.WriteDataReply; -import org.opendaylight.controller.cluster.datastore.modification.CompositeModification; import org.opendaylight.controller.cluster.datastore.modification.DeleteModification; import org.opendaylight.controller.cluster.datastore.modification.MergeModification; -import org.opendaylight.controller.cluster.datastore.modification.Modification; import org.opendaylight.controller.cluster.datastore.modification.WriteModification; -import org.opendaylight.controller.cluster.datastore.node.NormalizedNodeToNodeCodec; -import org.opendaylight.controller.cluster.datastore.node.NormalizedNodeToNodeCodec.Encoded; -import org.opendaylight.controller.cluster.datastore.utils.SerializationUtils; -import org.opendaylight.controller.cluster.raft.base.messages.CaptureSnapshotReply; +import org.opendaylight.controller.cluster.raft.TestActorFactory; import org.opendaylight.controller.md.cluster.datastore.model.TestModel; -import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeModification; import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes; import org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableContainerNodeBuilder; -import org.opendaylight.yangtools.yang.model.api.SchemaContext; +import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext; public class ShardTransactionTest extends AbstractActorTest { - private static final SchemaContext testSchemaContext = TestModel.createTestContext(); private static final TransactionType RO = TransactionType.READ_ONLY; private static final TransactionType RW = TransactionType.READ_WRITE; private static final TransactionType WO = TransactionType.WRITE_ONLY; private static final ShardIdentifier SHARD_IDENTIFIER = - ShardIdentifier.builder().memberName("member-1") - .shardName("inventory").type("config").build(); - - private DatastoreContext datastoreContext = DatastoreContext.newBuilder().build(); - - private final ShardStats shardStats = new ShardStats(SHARD_IDENTIFIER.toString(), "DataStore"); - - private final ShardDataTree store = new ShardDataTree(testSchemaContext); + ShardIdentifier.create("inventory", MEMBER_NAME, "config"); + private static final EffectiveModelContext TEST_MODEL = TestModel.createTestContext(); - private int txCounter = 0; + private DatastoreContext datastoreContext = DatastoreContext.newBuilder().persistent(false).build(); - private ActorRef createShard() { - return getSystem().actorOf(Shard.props(SHARD_IDENTIFIER, - Collections.emptyMap(), datastoreContext, TestModel.createTestContext())); - } - - private ActorRef newTransactionActor(TransactionType type, AbstractShardDataTreeTransaction transaction, String name) { - return newTransactionActor(type, transaction, name, DataStoreVersions.CURRENT_VERSION); - } + private final TestActorFactory actorFactory = new TestActorFactory(getSystem()); - private ActorRef newTransactionActor(TransactionType type, AbstractShardDataTreeTransaction transaction, String name, short version) { - return newTransactionActor(type, transaction, null, name, version); - } + private TestActorRef shard; + private ShardDataTree store; + private TestKit testKit; - private ActorRef newTransactionActor(TransactionType type, AbstractShardDataTreeTransaction transaction, ActorRef shard, String name) { - return newTransactionActor(type, transaction, null, name, DataStoreVersions.CURRENT_VERSION); + @Before + public void setUp() { + shard = actorFactory.createTestActor(Shard.builder().id(SHARD_IDENTIFIER).datastoreContext(datastoreContext) + .schemaContextProvider(() -> TEST_MODEL).props() + .withDispatcher(Dispatchers.DefaultDispatcherId())); + ShardTestKit.waitUntilLeader(shard); + store = shard.underlyingActor().getDataStore(); + testKit = new TestKit(getSystem()); } - private ActorRef newTransactionActor(TransactionType type, AbstractShardDataTreeTransaction transaction, ActorRef shard, String name, - short version) { - Props props = ShardTransaction.props(type, transaction, shard != null ? shard : createShard(), - datastoreContext, shardStats, "txn", version); - return getSystem().actorOf(props, name); + private ActorRef newTransactionActor(final TransactionType type, + final AbstractShardDataTreeTransaction transaction, final String name) { + Props props = ShardTransaction.props(type, transaction, shard, datastoreContext, + shard.underlyingActor().getShardMBean()); + return actorFactory.createActorNoVerify(props, name); } private ReadOnlyShardDataTreeTransaction readOnlyTransaction() { - return store.newReadOnlyTransaction("test-ro-" + String.valueOf(txCounter++), null); + return store.newReadOnlyTransaction(nextTransactionId()); } private ReadWriteShardDataTreeTransaction readWriteTransaction() { - return store.newReadWriteTransaction("test-rw-" + String.valueOf(txCounter++), null); + return store.newReadWriteTransaction(nextTransactionId()); } @Test - public void testOnReceiveReadData() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - - testOnReceiveReadData(newTransactionActor(RO, readOnlyTransaction(), shard, "testReadDataRO")); - - testOnReceiveReadData(newTransactionActor(RW, readWriteTransaction(), shard, "testReadDataRW")); - } - - private void testOnReceiveReadData(final ActorRef transaction) { - //serialized read - transaction.tell(new ReadData(YangInstanceIdentifier.builder().build()).toSerializable(), - getRef()); - - Object replySerialized = - expectMsgClass(duration("5 seconds"), ReadDataReply.SERIALIZABLE_CLASS); - - assertNotNull(ReadDataReply.fromSerializable(replySerialized).getNormalizedNode()); - - // unserialized read - transaction.tell(new ReadData(YangInstanceIdentifier.builder().build()),getRef()); - - ReadDataReply reply = expectMsgClass(duration("5 seconds"), ReadDataReply.class); - - assertNotNull(reply.getNormalizedNode()); - }}; + public void testOnReceiveReadData() { + testOnReceiveReadData(newTransactionActor(RO, readOnlyTransaction(), "testReadDataRO")); + testOnReceiveReadData(newTransactionActor(RW, readWriteTransaction(), "testReadDataRW")); } - @Test - public void testOnReceiveReadDataWhenDataNotFound() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - - testOnReceiveReadDataWhenDataNotFound(newTransactionActor( - RO, readOnlyTransaction(), shard, "testReadDataWhenDataNotFoundRO")); - - testOnReceiveReadDataWhenDataNotFound(newTransactionActor( - RW, readWriteTransaction(), shard, "testReadDataWhenDataNotFoundRW")); - } - - private void testOnReceiveReadDataWhenDataNotFound(final ActorRef transaction) { - // serialized read - transaction.tell(new ReadData(TestModel.TEST_PATH).toSerializable(), getRef()); - - Object replySerialized = - expectMsgClass(duration("5 seconds"), ReadDataReply.SERIALIZABLE_CLASS); - - assertTrue(ReadDataReply.fromSerializable(replySerialized).getNormalizedNode() == null); + private void testOnReceiveReadData(final ActorRef transaction) { + transaction.tell(new ReadData(YangInstanceIdentifier.empty(), DataStoreVersions.CURRENT_VERSION), + testKit.getRef()); - // unserialized read - transaction.tell(new ReadData(TestModel.TEST_PATH),getRef()); + ReadDataReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), ReadDataReply.class); - ReadDataReply reply = expectMsgClass(duration("5 seconds"), ReadDataReply.class); - - assertTrue(reply.getNormalizedNode() == null); - }}; + assertNotNull(reply.getNormalizedNode()); } @Test - public void testOnReceiveReadDataHeliumR1() throws Exception { - new JavaTestKit(getSystem()) {{ - ActorRef transaction = newTransactionActor(RO, readOnlyTransaction(), - "testOnReceiveReadDataHeliumR1", DataStoreVersions.HELIUM_1_VERSION); - - transaction.tell(new ReadData(YangInstanceIdentifier.builder().build()).toSerializable(), - getRef()); - - ShardTransactionMessages.ReadDataReply replySerialized = - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.ReadDataReply.class); - - assertNotNull(ReadDataReply.fromSerializable(replySerialized).getNormalizedNode()); - }}; + public void testOnReceiveReadDataWhenDataNotFound() { + testOnReceiveReadDataWhenDataNotFound(newTransactionActor(RO, readOnlyTransaction(), + "testReadDataWhenDataNotFoundRO")); + testOnReceiveReadDataWhenDataNotFound(newTransactionActor(RW, readWriteTransaction(), + "testReadDataWhenDataNotFoundRW")); } - @Test - public void testOnReceiveDataExistsPositive() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - - testOnReceiveDataExistsPositive(newTransactionActor(RO, readOnlyTransaction(), shard, - "testDataExistsPositiveRO")); - - testOnReceiveDataExistsPositive(newTransactionActor(RW, readWriteTransaction(), shard, - "testDataExistsPositiveRW")); - } - - private void testOnReceiveDataExistsPositive(final ActorRef transaction) { - transaction.tell(new DataExists(YangInstanceIdentifier.builder().build()).toSerializable(), - getRef()); - - ShardTransactionMessages.DataExistsReply replySerialized = - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.DataExistsReply.class); - - assertTrue(DataExistsReply.fromSerializable(replySerialized).exists()); - - // unserialized read - transaction.tell(new DataExists(YangInstanceIdentifier.builder().build()),getRef()); + private void testOnReceiveReadDataWhenDataNotFound(final ActorRef transaction) { + transaction.tell(new ReadData(TestModel.TEST_PATH, DataStoreVersions.CURRENT_VERSION), testKit.getRef()); - DataExistsReply reply = expectMsgClass(duration("5 seconds"), DataExistsReply.class); + ReadDataReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), ReadDataReply.class); - assertTrue(reply.exists()); - }}; + assertNull(reply.getNormalizedNode()); } @Test - public void testOnReceiveDataExistsNegative() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef shard = createShard(); - - testOnReceiveDataExistsNegative(newTransactionActor(RO, readOnlyTransaction(), shard, - "testDataExistsNegativeRO")); - - testOnReceiveDataExistsNegative(newTransactionActor(RW, readWriteTransaction(), shard, - "testDataExistsNegativeRW")); - } - - private void testOnReceiveDataExistsNegative(final ActorRef transaction) { - transaction.tell(new DataExists(TestModel.TEST_PATH).toSerializable(), getRef()); - - ShardTransactionMessages.DataExistsReply replySerialized = - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.DataExistsReply.class); - - assertFalse(DataExistsReply.fromSerializable(replySerialized).exists()); - - // unserialized read - transaction.tell(new DataExists(TestModel.TEST_PATH),getRef()); - - DataExistsReply reply = expectMsgClass(duration("5 seconds"), DataExistsReply.class); - - assertFalse(reply.exists()); - }}; + public void testOnReceiveDataExistsPositive() { + testOnReceiveDataExistsPositive(newTransactionActor(RO, readOnlyTransaction(), "testDataExistsPositiveRO")); + testOnReceiveDataExistsPositive(newTransactionActor(RW, readWriteTransaction(), "testDataExistsPositiveRW")); } - private void assertModification(final ActorRef subject, - final Class modificationType) { - new JavaTestKit(getSystem()) {{ - subject.tell(new ShardWriteTransaction.GetCompositedModification(), getRef()); + private void testOnReceiveDataExistsPositive(final ActorRef transaction) { + transaction.tell(new DataExists(YangInstanceIdentifier.empty(), DataStoreVersions.CURRENT_VERSION), + testKit.getRef()); - CompositeModification compositeModification = expectMsgClass(duration("3 seconds"), - GetCompositeModificationReply.class).getModification(); + DataExistsReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), DataExistsReply.class); - assertTrue(compositeModification.getModifications().size() == 1); - assertEquals(modificationType, compositeModification.getModifications().get(0).getClass()); - }}; + assertTrue(reply.exists()); } @Test - public void testOnReceiveWriteData() { - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), - "testOnReceiveWriteData"); - - transaction.tell(new WriteData(TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME), DataStoreVersions.HELIUM_2_VERSION). - toSerializable(), getRef()); - - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.WriteDataReply.class); - - assertModification(transaction, WriteModification.class); - - // unserialized write - transaction.tell(new WriteData(TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME), DataStoreVersions.CURRENT_VERSION), - getRef()); - - expectMsgClass(duration("5 seconds"), WriteDataReply.class); - }}; + public void testOnReceiveDataExistsNegative() { + testOnReceiveDataExistsNegative(newTransactionActor(RO, readOnlyTransaction(), "testDataExistsNegativeRO")); + testOnReceiveDataExistsNegative(newTransactionActor(RW, readWriteTransaction(), "testDataExistsNegativeRW")); } - @Test - public void testOnReceiveHeliumR1WriteData() { - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), - "testOnReceiveHeliumR1WriteData", DataStoreVersions.HELIUM_1_VERSION); - - Encoded encoded = new NormalizedNodeToNodeCodec(null).encode(TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME)); - ShardTransactionMessages.WriteData serialized = ShardTransactionMessages.WriteData.newBuilder() - .setInstanceIdentifierPathArguments(encoded.getEncodedPath()) - .setNormalizedNode(encoded.getEncodedNode().getNormalizedNode()).build(); + private void testOnReceiveDataExistsNegative(final ActorRef transaction) { + transaction.tell(new DataExists(TestModel.TEST_PATH, DataStoreVersions.CURRENT_VERSION), testKit.getRef()); - transaction.tell(serialized, getRef()); + DataExistsReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), DataExistsReply.class); - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.WriteDataReply.class); - - assertModification(transaction, WriteModification.class); - }}; + assertFalse(reply.exists()); } @Test - public void testOnReceiveMergeData() { - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(RW, readWriteTransaction(), - "testMergeData"); - - transaction.tell(new MergeData(TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME), DataStoreVersions.HELIUM_2_VERSION). - toSerializable(), getRef()); - - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.MergeDataReply.class); - - assertModification(transaction, MergeModification.class); - - //unserialized merge - transaction.tell(new MergeData(TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME), DataStoreVersions.CURRENT_VERSION), - getRef()); - - expectMsgClass(duration("5 seconds"), MergeDataReply.class); - }}; + public void testOnReceiveBatchedModifications() { + ShardDataTreeTransactionParent parent = mock(ShardDataTreeTransactionParent.class); + DataTreeModification mockModification = mock(DataTreeModification.class); + ReadWriteShardDataTreeTransaction mockWriteTx = new ReadWriteShardDataTreeTransaction(parent, + nextTransactionId(), mockModification); + final ActorRef transaction = newTransactionActor(RW, mockWriteTx, "testOnReceiveBatchedModifications"); + + YangInstanceIdentifier writePath = TestModel.TEST_PATH; + NormalizedNode writeData = ImmutableContainerNodeBuilder.create() + .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)) + .withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); + + YangInstanceIdentifier mergePath = TestModel.OUTER_LIST_PATH; + NormalizedNode mergeData = ImmutableContainerNodeBuilder.create() + .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.OUTER_LIST_QNAME)) + .build(); + + YangInstanceIdentifier deletePath = TestModel.TEST_PATH; + + BatchedModifications batched = new BatchedModifications(nextTransactionId(), + DataStoreVersions.CURRENT_VERSION); + batched.addModification(new WriteModification(writePath, writeData)); + batched.addModification(new MergeModification(mergePath, mergeData)); + batched.addModification(new DeleteModification(deletePath)); + + transaction.tell(batched, testKit.getRef()); + + BatchedModificationsReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), + BatchedModificationsReply.class); + assertEquals("getNumBatched", 3, reply.getNumBatched()); + + InOrder inOrder = inOrder(mockModification); + inOrder.verify(mockModification).write(writePath, writeData); + inOrder.verify(mockModification).merge(mergePath, mergeData); + inOrder.verify(mockModification).delete(deletePath); } @Test - public void testOnReceiveHeliumR1MergeData() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), - "testOnReceiveHeliumR1MergeData", DataStoreVersions.HELIUM_1_VERSION); - - Encoded encoded = new NormalizedNodeToNodeCodec(null).encode(TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME)); - ShardTransactionMessages.MergeData serialized = ShardTransactionMessages.MergeData.newBuilder() - .setInstanceIdentifierPathArguments(encoded.getEncodedPath()) - .setNormalizedNode(encoded.getEncodedNode().getNormalizedNode()).build(); - - transaction.tell(serialized, getRef()); - - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.MergeDataReply.class); - - assertModification(transaction, MergeModification.class); - }}; + public void testOnReceiveBatchedModificationsReadyWithoutImmediateCommit() { + final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), + "testOnReceiveBatchedModificationsReadyWithoutImmediateCommit"); + + TestKit watcher = new TestKit(getSystem()); + watcher.watch(transaction); + + YangInstanceIdentifier writePath = TestModel.TEST_PATH; + NormalizedNode writeData = ImmutableContainerNodeBuilder.create() + .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)) + .withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); + + final TransactionIdentifier tx1 = nextTransactionId(); + BatchedModifications batched = new BatchedModifications(tx1, DataStoreVersions.CURRENT_VERSION); + batched.addModification(new WriteModification(writePath, writeData)); + + transaction.tell(batched, testKit.getRef()); + BatchedModificationsReply reply = testKit.expectMsgClass(Duration.ofSeconds(5), + BatchedModificationsReply.class); + assertEquals("getNumBatched", 1, reply.getNumBatched()); + + batched = new BatchedModifications(tx1, DataStoreVersions.CURRENT_VERSION); + batched.setReady(); + batched.setTotalMessagesSent(2); + + transaction.tell(batched, testKit.getRef()); + testKit.expectMsgClass(Duration.ofSeconds(5), ReadyTransactionReply.class); + watcher.expectMsgClass(Duration.ofSeconds(5), Terminated.class); } @Test - public void testOnReceiveDeleteData() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), - "testDeleteData"); - - transaction.tell(new DeleteData(TestModel.TEST_PATH, DataStoreVersions.HELIUM_2_VERSION). - toSerializable(), getRef()); - - expectMsgClass(duration("5 seconds"), ShardTransactionMessages.DeleteDataReply.class); - - assertModification(transaction, DeleteModification.class); - - //unserialized - transaction.tell(new DeleteData(TestModel.TEST_PATH, DataStoreVersions.CURRENT_VERSION), getRef()); - - expectMsgClass(duration("5 seconds"), DeleteDataReply.class); - }}; - } - - @Test - public void testOnReceiveBatchedModifications() throws Exception { - new JavaTestKit(getSystem()) {{ - - ShardDataTreeTransactionParent parent = Mockito.mock(ShardDataTreeTransactionParent.class); - DataTreeModification mockModification = Mockito.mock(DataTreeModification.class); - ReadWriteShardDataTreeTransaction mockWriteTx = new ReadWriteShardDataTreeTransaction(parent, "id", mockModification); - final ActorRef transaction = newTransactionActor(RW, mockWriteTx, "testOnReceiveBatchedModifications"); - - YangInstanceIdentifier writePath = TestModel.TEST_PATH; - NormalizedNode writeData = ImmutableContainerNodeBuilder.create().withNodeIdentifier( - new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)). - withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); - - YangInstanceIdentifier mergePath = TestModel.OUTER_LIST_PATH; - NormalizedNode mergeData = ImmutableContainerNodeBuilder.create().withNodeIdentifier( - new YangInstanceIdentifier.NodeIdentifier(TestModel.OUTER_LIST_QNAME)).build(); - - YangInstanceIdentifier deletePath = TestModel.TEST_PATH; - - BatchedModifications batched = new BatchedModifications("tx1", DataStoreVersions.CURRENT_VERSION, null); - batched.addModification(new WriteModification(writePath, writeData)); - batched.addModification(new MergeModification(mergePath, mergeData)); - batched.addModification(new DeleteModification(deletePath)); - - transaction.tell(batched, getRef()); - - BatchedModificationsReply reply = expectMsgClass(duration("5 seconds"), BatchedModificationsReply.class); - assertEquals("getNumBatched", 3, reply.getNumBatched()); - - JavaTestKit verification = new JavaTestKit(getSystem()); - transaction.tell(new ShardWriteTransaction.GetCompositedModification(), verification.getRef()); - - CompositeModification compositeModification = verification.expectMsgClass(duration("5 seconds"), - GetCompositeModificationReply.class).getModification(); - - assertEquals("CompositeModification size", 3, compositeModification.getModifications().size()); - - WriteModification write = (WriteModification)compositeModification.getModifications().get(0); - assertEquals("getPath", writePath, write.getPath()); - assertEquals("getData", writeData, write.getData()); - - MergeModification merge = (MergeModification)compositeModification.getModifications().get(1); - assertEquals("getPath", mergePath, merge.getPath()); - assertEquals("getData", mergeData, merge.getData()); - - DeleteModification delete = (DeleteModification)compositeModification.getModifications().get(2); - assertEquals("getPath", deletePath, delete.getPath()); - - InOrder inOrder = Mockito.inOrder(mockModification); - inOrder.verify(mockModification).write(writePath, writeData); - inOrder.verify(mockModification).merge(mergePath, mergeData); - inOrder.verify(mockModification).delete(deletePath); - }}; - } - - @Test - public void testOnReceiveBatchedModificationsReadyWithoutImmediateCommit() throws Exception { - new JavaTestKit(getSystem()) {{ - - final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), - "testOnReceiveBatchedModificationsReadyWithoutImmediateCommit"); - - JavaTestKit watcher = new JavaTestKit(getSystem()); - watcher.watch(transaction); - - YangInstanceIdentifier writePath = TestModel.TEST_PATH; - NormalizedNode writeData = ImmutableContainerNodeBuilder.create().withNodeIdentifier( - new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)). - withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); - - BatchedModifications batched = new BatchedModifications("tx1", DataStoreVersions.CURRENT_VERSION, null); - batched.addModification(new WriteModification(writePath, writeData)); - - transaction.tell(batched, getRef()); - BatchedModificationsReply reply = expectMsgClass(duration("5 seconds"), BatchedModificationsReply.class); - assertEquals("getNumBatched", 1, reply.getNumBatched()); - - batched = new BatchedModifications("tx1", DataStoreVersions.CURRENT_VERSION, null); - batched.setReady(true); - batched.setTotalMessagesSent(2); - - transaction.tell(batched, getRef()); - expectMsgClass(duration("5 seconds"), ReadyTransactionReply.class); - watcher.expectMsgClass(duration("5 seconds"), Terminated.class); - }}; + public void testOnReceiveBatchedModificationsReadyWithImmediateCommit() { + final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), + "testOnReceiveBatchedModificationsReadyWithImmediateCommit"); + + TestKit watcher = new TestKit(getSystem()); + watcher.watch(transaction); + + YangInstanceIdentifier writePath = TestModel.TEST_PATH; + NormalizedNode writeData = ImmutableContainerNodeBuilder.create() + .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)) + .withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); + + BatchedModifications batched = new BatchedModifications(nextTransactionId(), + DataStoreVersions.CURRENT_VERSION); + batched.addModification(new WriteModification(writePath, writeData)); + batched.setReady(); + batched.setDoCommitOnReady(true); + batched.setTotalMessagesSent(1); + + transaction.tell(batched, testKit.getRef()); + testKit.expectMsgClass(Duration.ofSeconds(5), CommitTransactionReply.class); + watcher.expectMsgClass(Duration.ofSeconds(5), Terminated.class); } - @Test - public void testOnReceiveBatchedModificationsReadyWithImmediateCommit() throws Exception { - new JavaTestKit(getSystem()) {{ - - final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), - "testOnReceiveBatchedModificationsReadyWithImmediateCommit"); - - JavaTestKit watcher = new JavaTestKit(getSystem()); - watcher.watch(transaction); - - YangInstanceIdentifier writePath = TestModel.TEST_PATH; - NormalizedNode writeData = ImmutableContainerNodeBuilder.create().withNodeIdentifier( - new YangInstanceIdentifier.NodeIdentifier(TestModel.TEST_QNAME)). - withChild(ImmutableNodes.leafNode(TestModel.DESC_QNAME, "foo")).build(); - - BatchedModifications batched = new BatchedModifications("tx1", DataStoreVersions.CURRENT_VERSION, null); - batched.addModification(new WriteModification(writePath, writeData)); - batched.setReady(true); - batched.setDoCommitOnReady(true); - batched.setTotalMessagesSent(1); - - transaction.tell(batched, getRef()); - expectMsgClass(duration("5 seconds"), CommitTransactionReply.SERIALIZABLE_CLASS); - watcher.expectMsgClass(duration("5 seconds"), Terminated.class); - }}; - } + @Test(expected = TestException.class) + public void testOnReceiveBatchedModificationsFailure() throws Exception { + ShardDataTreeTransactionParent parent = mock(ShardDataTreeTransactionParent.class); + DataTreeModification mockModification = mock(DataTreeModification.class); + ReadWriteShardDataTreeTransaction mockWriteTx = new ReadWriteShardDataTreeTransaction(parent, + nextTransactionId(), mockModification); + final ActorRef transaction = newTransactionActor(RW, mockWriteTx, + "testOnReceiveBatchedModificationsFailure"); - @Test(expected=TestException.class) - public void testOnReceiveBatchedModificationsFailure() throws Throwable { - new JavaTestKit(getSystem()) {{ + TestKit watcher = new TestKit(getSystem()); + watcher.watch(transaction); - ShardDataTreeTransactionParent parent = Mockito.mock(ShardDataTreeTransactionParent.class); - DataTreeModification mockModification = Mockito.mock(DataTreeModification.class); - ReadWriteShardDataTreeTransaction mockWriteTx = new ReadWriteShardDataTreeTransaction(parent, "id", mockModification); - final ActorRef transaction = newTransactionActor(RW, mockWriteTx, - "testOnReceiveBatchedModificationsFailure"); + YangInstanceIdentifier path = TestModel.TEST_PATH; + ContainerNode node = ImmutableNodes.containerNode(TestModel.TEST_QNAME); - JavaTestKit watcher = new JavaTestKit(getSystem()); - watcher.watch(transaction); + doThrow(new TestException()).when(mockModification).write(path, node); - YangInstanceIdentifier path = TestModel.TEST_PATH; - ContainerNode node = ImmutableNodes.containerNode(TestModel.TEST_QNAME); + final TransactionIdentifier tx1 = nextTransactionId(); + BatchedModifications batched = new BatchedModifications(tx1, DataStoreVersions.CURRENT_VERSION); + batched.addModification(new WriteModification(path, node)); - doThrow(new TestException()).when(mockModification).write(path, node); + transaction.tell(batched, testKit.getRef()); + testKit.expectMsgClass(Duration.ofSeconds(5), akka.actor.Status.Failure.class); - BatchedModifications batched = new BatchedModifications("tx1", DataStoreVersions.CURRENT_VERSION, null); - batched.addModification(new WriteModification(path, node)); + batched = new BatchedModifications(tx1, DataStoreVersions.CURRENT_VERSION); + batched.setReady(); + batched.setTotalMessagesSent(2); - transaction.tell(batched, getRef()); - expectMsgClass(duration("5 seconds"), akka.actor.Status.Failure.class); + transaction.tell(batched, testKit.getRef()); + Failure failure = testKit.expectMsgClass(Duration.ofSeconds(5), akka.actor.Status.Failure.class); + watcher.expectMsgClass(Duration.ofSeconds(5), Terminated.class); - batched = new BatchedModifications("tx1", DataStoreVersions.CURRENT_VERSION, null); - batched.setReady(true); - batched.setTotalMessagesSent(2); - - transaction.tell(batched, getRef()); - Failure failure = expectMsgClass(duration("5 seconds"), akka.actor.Status.Failure.class); - watcher.expectMsgClass(duration("5 seconds"), Terminated.class); - - if(failure != null) { - throw failure.cause(); - } - }}; - } - - @Test(expected=IllegalStateException.class) - public void testOnReceiveBatchedModificationsReadyWithIncorrectTotalMessageCount() throws Throwable { - new JavaTestKit(getSystem()) {{ - - final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), - "testOnReceiveBatchedModificationsReadyWithIncorrectTotalMessageCount"); - - JavaTestKit watcher = new JavaTestKit(getSystem()); - watcher.watch(transaction); - - BatchedModifications batched = new BatchedModifications("tx1", DataStoreVersions.CURRENT_VERSION, null); - batched.setReady(true); - batched.setTotalMessagesSent(2); - - transaction.tell(batched, getRef()); - - Failure failure = expectMsgClass(duration("5 seconds"), akka.actor.Status.Failure.class); - watcher.expectMsgClass(duration("5 seconds"), Terminated.class); - - if(failure != null) { - throw failure.cause(); - } - }}; - } - - @Test - public void testOnReceivePreLithiumReadyTransaction() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(RW, readWriteTransaction(), - "testReadyTransaction", DataStoreVersions.HELIUM_2_VERSION); - - JavaTestKit watcher = new JavaTestKit(getSystem()); - watcher.watch(transaction); - - transaction.tell(new ReadyTransaction().toSerializable(), getRef()); - - expectMsgClass(duration("5 seconds"), ReadyTransactionReply.SERIALIZABLE_CLASS); - watcher.expectMsgClass(duration("5 seconds"), Terminated.class); - }}; - - // test - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(RW, readWriteTransaction(), - "testReadyTransaction2", DataStoreVersions.HELIUM_2_VERSION); - - JavaTestKit watcher = new JavaTestKit(getSystem()); - watcher.watch(transaction); - - transaction.tell(new ReadyTransaction(), getRef()); - - expectMsgClass(duration("5 seconds"), ReadyTransactionReply.class); - watcher.expectMsgClass(duration("5 seconds"), Terminated.class); - }}; + if (failure != null) { + Throwables.propagateIfPossible(failure.cause(), Exception.class); + throw new RuntimeException(failure.cause()); + } } - @Test - public void testOnReceiveCreateSnapshot() throws Exception { - new JavaTestKit(getSystem()) {{ - ShardTest.writeToStore(store.getDataTree(), TestModel.TEST_PATH, - ImmutableNodes.containerNode(TestModel.TEST_QNAME)); - - NormalizedNode expectedRoot = ShardTest.readStore(store.getDataTree(), - YangInstanceIdentifier.builder().build()); - - final ActorRef transaction = newTransactionActor(TransactionType.READ_ONLY, readOnlyTransaction(), - "testOnReceiveCreateSnapshot"); + @Test(expected = IllegalStateException.class) + public void testOnReceiveBatchedModificationsReadyWithIncorrectTotalMessageCount() throws Exception { + final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), + "testOnReceiveBatchedModificationsReadyWithIncorrectTotalMessageCount"); - watch(transaction); + TestKit watcher = new TestKit(getSystem()); + watcher.watch(transaction); - transaction.tell(CreateSnapshot.INSTANCE, getRef()); + BatchedModifications batched = new BatchedModifications(nextTransactionId(), + DataStoreVersions.CURRENT_VERSION); + batched.setReady(); + batched.setTotalMessagesSent(2); - CaptureSnapshotReply reply = expectMsgClass(duration("3 seconds"), CaptureSnapshotReply.class); + transaction.tell(batched, testKit.getRef()); - assertNotNull("getSnapshot is null", reply.getSnapshot()); + Failure failure = testKit.expectMsgClass(Duration.ofSeconds(5), akka.actor.Status.Failure.class); + watcher.expectMsgClass(Duration.ofSeconds(5), Terminated.class); - NormalizedNode actualRoot = SerializationUtils.deserializeNormalizedNode( - reply.getSnapshot()); - - assertEquals("Root node", expectedRoot, actualRoot); - - expectTerminated(duration("3 seconds"), transaction); - }}; + if (failure != null) { + Throwables.throwIfInstanceOf(failure.cause(), Exception.class); + Throwables.throwIfUnchecked(failure.cause()); + throw new RuntimeException(failure.cause()); + } } @Test - public void testReadWriteTxOnReceiveCloseTransaction() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(RW, readWriteTransaction(), - "testReadWriteTxOnReceiveCloseTransaction"); + public void testReadWriteTxOnReceiveCloseTransaction() { + final ActorRef transaction = newTransactionActor(RW, readWriteTransaction(), + "testReadWriteTxOnReceiveCloseTransaction"); - watch(transaction); + testKit.watch(transaction); - transaction.tell(new CloseTransaction().toSerializable(), getRef()); + transaction.tell(new CloseTransaction().toSerializable(), testKit.getRef()); - expectMsgClass(duration("3 seconds"), CloseTransactionReply.SERIALIZABLE_CLASS); - expectTerminated(duration("3 seconds"), transaction); - }}; + testKit.expectMsgClass(Duration.ofSeconds(3), CloseTransactionReply.class); + testKit.expectTerminated(Duration.ofSeconds(3), transaction); } @Test - public void testWriteOnlyTxOnReceiveCloseTransaction() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), - "testWriteTxOnReceiveCloseTransaction"); + public void testWriteOnlyTxOnReceiveCloseTransaction() { + final ActorRef transaction = newTransactionActor(WO, readWriteTransaction(), + "testWriteTxOnReceiveCloseTransaction"); - watch(transaction); + testKit.watch(transaction); - transaction.tell(new CloseTransaction().toSerializable(), getRef()); + transaction.tell(new CloseTransaction().toSerializable(), testKit.getRef()); - expectMsgClass(duration("3 seconds"), CloseTransactionReply.SERIALIZABLE_CLASS); - expectTerminated(duration("3 seconds"), transaction); - }}; + testKit.expectMsgClass(Duration.ofSeconds(3), CloseTransactionReply.class); + testKit.expectTerminated(Duration.ofSeconds(3), transaction); } @Test - public void testReadOnlyTxOnReceiveCloseTransaction() throws Exception { - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(TransactionType.READ_ONLY, readOnlyTransaction(), - "testReadOnlyTxOnReceiveCloseTransaction"); + public void testReadOnlyTxOnReceiveCloseTransaction() { + final ActorRef transaction = newTransactionActor(TransactionType.READ_ONLY, readOnlyTransaction(), + "testReadOnlyTxOnReceiveCloseTransaction"); - watch(transaction); + testKit.watch(transaction); - transaction.tell(new CloseTransaction().toSerializable(), getRef()); + transaction.tell(new CloseTransaction().toSerializable(), testKit.getRef()); - expectMsgClass(duration("3 seconds"), Terminated.class); - }}; - } - - @Test(expected=UnknownMessageException.class) - public void testNegativePerformingWriteOperationOnReadTransaction() throws Exception { - final ActorRef shard = createShard(); - final Props props = ShardTransaction.props(TransactionType.READ_ONLY, readOnlyTransaction(), shard, - datastoreContext, shardStats, "txn", DataStoreVersions.CURRENT_VERSION); - final TestActorRef transaction = TestActorRef.apply(props,getSystem()); - - transaction.receive(new DeleteData(TestModel.TEST_PATH, DataStoreVersions.CURRENT_VERSION). - toSerializable(), ActorRef.noSender()); + testKit.expectMsgClass(Duration.ofSeconds(3), Terminated.class); } @Test public void testShardTransactionInactivity() { - datastoreContext = DatastoreContext.newBuilder().shardTransactionIdleTimeout( 500, TimeUnit.MILLISECONDS).build(); - new JavaTestKit(getSystem()) {{ - final ActorRef transaction = newTransactionActor(RW, readWriteTransaction(), - "testShardTransactionInactivity"); + final ActorRef transaction = newTransactionActor(RW, readWriteTransaction(), + "testShardTransactionInactivity"); - watch(transaction); + testKit.watch(transaction); - expectMsgClass(duration("3 seconds"), Terminated.class); - }}; + testKit.expectMsgClass(Duration.ofSeconds(3), Terminated.class); } public static class TestException extends RuntimeException {